[meta-qt5 PATCH] qmake5_paths.bbclass: Fix fonts installation path

[meta-qt5 PATCH] qmake5_paths.bbclass: Fix fonts installation path

[Otavio Salvador]

As Qt internal fonts (qtbase-fonts) are not included anymore, we need
to rely on system fonts to work.

All major distributions, as well as all recipes on OE-Core and
Meta-OE, use ${datadir}/fonts as path so we adapt the value for use
for Qt use as well.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 classes/qmake5_paths.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/qmake5_paths.bbclass b/classes/qmake5_paths.bbclass
index e1101a9..ef3ff8f 100644
--- a/classes/qmake5_paths.bbclass
+++ b/classes/qmake5_paths.bbclass
@@ -49,4 +49,4 @@ OE_QMAKE_PATH_QT_SETTINGS = "${sysconfdir}${QT_DIR_NAME}"
 OE_QMAKE_PATH_QT_EXAMPLES = "${datadir}${QT_DIR_NAME}/examples"
 OE_QMAKE_PATH_QT_TESTS = "${datadir}${QT_DIR_NAME}/tests"
 
-OE_QMAKE_PATH_QT_FONTS = "${OE_QMAKE_PATH_LIBS}/fonts"
+OE_QMAKE_PATH_QT_FONTS = "${OE_QMAKE_PATH_DATA}/fonts"
-- 
2.10.0

Re: [meta-qt5 PATCH] qmake5_paths.bbclass: Fix fonts installation path

[Otavio Salvador]

Hello folks,

On Thu, Oct 20, 2016 at 2:46 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> As Qt internal fonts (qtbase-fonts) are not included anymore, we need
> to rely on system fonts to work.
>
> All major distributions, as well as all recipes on OE-Core and
> Meta-OE, use ${datadir}/fonts as path so we adapt the value for use
> for Qt use as well.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Please take a look at this. This fixes a customer which were trying to
use morty with Qt Virtual Keyboard.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-qt5 PATCH] qmake5_paths.bbclass: Fix fonts installation path

[Samuli Piippo]

That looks like the correct path to use, but how does this fix the problem?
OE_QMAKE_PATH_QT_FONTS doesn't seem to used anywhere in meta-qt5 any 
more and probably should have been removed together with the font 
packaging bits.

-samuli

On 20.10.2016 19:53, Otavio Salvador wrote:
> Hello folks,
>
> On Thu, Oct 20, 2016 at 2:46 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> As Qt internal fonts (qtbase-fonts) are not included anymore, we need
>> to rely on system fonts to work.
>>
>> All major distributions, as well as all recipes on OE-Core and
>> Meta-OE, use ${datadir}/fonts as path so we adapt the value for use
>> for Qt use as well.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Please take a look at this. This fixes a customer which were trying to
> use morty with Qt Virtual Keyboard.
>

Re: [meta-qt5 PATCH] qmake5_paths.bbclass: Fix fonts installation path

[Otavio Salvador]

On Fri, Oct 21, 2016 at 4:47 AM, Samuli Piippo <samuli.piippo@qt.io> wrote:
> That looks like the correct path to use, but how does this fix the problem?
> OE_QMAKE_PATH_QT_FONTS doesn't seem to used anywhere in meta-qt5 any more
> and probably should have been removed together with the font packaging bits.

It did not fix it, indeed. We had a left over from a test so it hided
the issue. We are checking it now.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-qt5 PATCH] qmake5_paths.bbclass: Fix fonts installation path

[Otavio Salvador]

On Fri, Oct 21, 2016 at 9:58 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, Oct 21, 2016 at 4:47 AM, Samuli Piippo <samuli.piippo@qt.io> wrote:
>> That looks like the correct path to use, but how does this fix the problem?
>> OE_QMAKE_PATH_QT_FONTS doesn't seem to used anywhere in meta-qt5 any more
>> and probably should have been removed together with the font packaging bits.
>
> It did not fix it, indeed. We had a left over from a test so it hided
> the issue. We are checking it now.

This change ought to be ignored; the Qt QPA has a hardcoded path which
can be overridden using an environment var and this seems to be the
standard practice for people not using fontconfig support.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750