[U-Boot] [PATCH] Add README for the "Falcon" mode

[U-Boot] [PATCH] Add README for the "Falcon" mode

[Stefano Babic]

Simple howto to add support to a board
for booting the kernel from SPL ("Falcon" mode).

Signed-off-by: Stefano Babic <sbabic@denx.de>
CC: Marek Vasut <marex@denx.de>
CC: Otavio Salvador <otavio@ossystems.com.br>
CC: Tom Rini <trini@ti.com>
---
 doc/README.falcon |  124 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 doc/README.falcon

diff --git a/doc/README.falcon b/doc/README.falcon
new file mode 100644
index 0000000..d50b8c3
--- /dev/null
+++ b/doc/README.falcon
@@ -0,0 +1,124 @@
+U-Boot "Falcon" Mode
+====================
+
+Introduction
+------------
+
+This documents provides an overview how to add support for "Falcon" mode
+to a board.
+Falcon mode is introduced to speed up the booting process, allowing
+to boot a Linux kernel (or whatever image) without a full blown U-Boot.
+
+Falcon mode relies on the SPL framework. In fact, to make booting faster,
+U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
+image. In mostly implementations, SPL is used to start U-Boot when booting from
+a mass storage, such as NAND or SD-Card. SPL has now support for other media,
+and can be generalized seen as a way to start an image performing the minimum
+required initialization. SPL initializes mainly the RAM controller, and after
+that copies U-Boot image into the memory. The "Falcon" mode extends this way
+allowing to start any kind of image, an in particular a Linux kernel, preparing
+a snapshot of the parameters (ATAG or DT) required by the kernel to boot.
+
+Falcon adds a command under U-Boot to reuse all code responsible to prepare
+the interface with the kernel. In usual U-boot systems, these parameters are
+generated each time before loading the kernel, passing to Linux the address
+in memory where the parameters can be read.
+With falcon, this snapshot can be saved into persistent storage and SPL is
+informed to load it before running the kernel.
+
+To boot the kernel, these steps under a Falcon-aware U-Boot are required:
+
+1. Boot the board into U-Boot.
+Use the "spl export" command to generate the kernel parameters area or the DT.
+U-boot runs as when it boots the kernel, but stops before passing the control
+to the kernel.
+
+2. Saves the prepared snapshot into persistent media.
+The address where to save it must be configured into board configuration
+file (CONFIG_CMD_SPL_NAND_OFS for NAND).
+
+3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
+the parameters area to the address required address.
+
+It is required to implement a custom mechanism to select if SPL loads U-Boot
+or another image.
+The value of a GPIO is a simple way to operate the selection, as well as
+reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
+
+Falcon mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
+SPL that U-Boot is not the only available image that SPL is able to start.
+
+Configuration
+----------------------------
+CONFIG_CMD_SPL		Enable the "spl export" command.
+			The command "spl export" is then available in U-Boot
+			mode
+CONFIG_SPL_OS_BOOT	Activate Falcon mode.
+			A board should implement the following functions:
+
+CONFIG_SPL_OS_BOOT_KEY	Common name for GPIO used to select between U-Boot
+			and kernel image. Optional.
+
+CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
+				copied by SPL.
+				In most cases, it is <start_of_ram> + 0x100
+
+CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
+
+CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
+
+CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
+
+Function that a board must implement
+------------------------------------
+
+void spl_board_prepare_for_linux(void) : optional
+	Called from SPL before starting the kernel
+
+spl_start_uboot() : required
+		Returns "0" if SPL starts the kernel, "1" if U-Boot
+		must be started.
+
+
+Using spl command
+-----------------
+
+twister => spl
+spl - SPL configuration
+
+Usage:
+spl export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr if <img> = fdt] - export a kernel parameter image
+	 initrd_img can be set to "-" if fdt_addr without initrd img isused
+
+img 		: "atags" or "fdt"
+kernel_addr 	: kernel is loaded as part of the boot process, but it is not started.
+		  This is the address where a kernel image is stored.
+init_addr	: optional for atags - the address where the parameters area is generated into RAM
+fdt_addr	: in case of fdt, the address of the device tree.
+
+Example (for the twister board):
+
+twister => spl export atags 0x82000000
+## Booting kernel from Legacy Image at 82000000 ...
+   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
+   Image Type:   ARM Linux Kernel Image (uncompressed)
+   Data Size:    3654808 Bytes = 3.5 MiB
+   Load Address: 80008000
+   Entry Point:  80008000
+   Verifying Checksum ... OK
+   Loading Kernel Image ... OK
+OK
+cmdline subcommand not supported
+bdt subcommand not supported
+Argument image is now in RAM at: 0x80000100
+
+The parameters generated with this step can be saved into NAND at the offset
+0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
+
+Next time, the board can be started into "Falcon mode" moving the
+CONFIG_SPL_OS_BOOT_KEY GPIO.
+The kernel is loaded directly by the SPL without passing through U-Boot.
+
+Falcon mode was presented at the RMLL 2011. Slides are available at:
+
+http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf
-- 
1.7.9.5

[U-Boot] [PATCH] Add README for the "Falcon" mode

[Andreas Bießmann]

Dear Stefano Babic,

On 12.11.2012 11:59, Stefano Babic wrote:
> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Marek Vasut <marex@denx.de>
> CC: Otavio Salvador <otavio@ossystems.com.br>
> CC: Tom Rini <trini@ti.com>
> ---
>  doc/README.falcon |  124 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 124 insertions(+)
>  create mode 100644 doc/README.falcon
> 
> diff --git a/doc/README.falcon b/doc/README.falcon
> new file mode 100644
> index 0000000..d50b8c3
> --- /dev/null
> +++ b/doc/README.falcon
> @@ -0,0 +1,124 @@
> +U-Boot "Falcon" Mode
> +====================
> +
> +Introduction
> +------------
> +
> +This documents provides an overview how to add support for "Falcon" mode
> +to a board.
> +Falcon mode is introduced to speed up the booting process, allowing
> +to boot a Linux kernel (or whatever image) without a full blown U-Boot.
> +
> +Falcon mode relies on the SPL framework. In fact, to make booting faster,
> +U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
> +image. In mostly implementations, SPL is used to start U-Boot when booting from
-----------------^
In most implementations?

> +a mass storage, such as NAND or SD-Card. SPL has now support for other media,
> +and can be generalized seen as a way to start an image performing the minimum
> +required initialization. SPL initializes mainly the RAM controller, and after
> +that copies U-Boot image into the memory. The "Falcon" mode extends this way
> +allowing to start any kind of image, an in particular a Linux kernel, preparing
------------------------------------------^
and in particular?
------------------------------------------------------------------------^
to achieve that, to be able to boot linux, ... ?
The 'preparing a snapshot...' part of this sentence sounds weird to me.

> +a snapshot of the parameters (ATAG or DT) required by the kernel to boot.
> +
> +Falcon adds a command under U-Boot to reuse all code responsible to prepare
> +the interface with the kernel. In usual U-boot systems, these parameters are
> +generated each time before loading the kernel, passing to Linux the address
> +in memory where the parameters can be read.
> +With falcon, this snapshot can be saved into persistent storage and SPL is
> +informed to load it before running the kernel.
> +
> +To boot the kernel, these steps under a Falcon-aware U-Boot are required:
> +
> +1. Boot the board into U-Boot.
> +Use the "spl export" command to generate the kernel parameters area or the DT.
> +U-boot runs as when it boots the kernel, but stops before passing the control
> +to the kernel.
> +
> +2. Saves the prepared snapshot into persistent media.
> +The address where to save it must be configured into board configuration
> +file (CONFIG_CMD_SPL_NAND_OFS for NAND).
> +
> +3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
> +the parameters area to the address required address.
--------------------------------^
first address is not necessary here

> +
> +It is required to implement a custom mechanism to select if SPL loads U-Boot
> +or another image.
> +The value of a GPIO is a simple way to operate the selection, as well as
> +reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
> +
> +Falcon mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
> +SPL that U-Boot is not the only available image that SPL is able to start.
> +
> +Configuration
> +----------------------------
> +CONFIG_CMD_SPL		Enable the "spl export" command.
> +			The command "spl export" is then available in U-Boot
> +			mode
> +CONFIG_SPL_OS_BOOT	Activate Falcon mode.
> +			A board should implement the following functions:
> +
> +CONFIG_SPL_OS_BOOT_KEY	Common name for GPIO used to select between U-Boot
> +			and kernel image. Optional.
> +
> +CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
> +				copied by SPL.
> +				In most cases, it is <start_of_ram> + 0x100
> +
> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
> +
> +CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
> +
> +CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
> +
> +Function that a board must implement
> +------------------------------------
> +
> +void spl_board_prepare_for_linux(void) : optional
> +	Called from SPL before starting the kernel
> +
> +spl_start_uboot() : required
> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
> +		must be started.

In which way interact the CONFIG_SPL_OS_BOOT_KEY with the
spl_start_uboot()? Is both required, can one use one or the other?

> +
> +
> +Using spl command
> +-----------------
> +
> +twister => spl
> +spl - SPL configuration
> +
> +Usage:
> +spl export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr if <img> = fdt] - export a kernel parameter image
> +	 initrd_img can be set to "-" if fdt_addr without initrd img isused
> +
> +img 		: "atags" or "fdt"
> +kernel_addr 	: kernel is loaded as part of the boot process, but it is not started.
> +		  This is the address where a kernel image is stored.
-------------------------------------------------------------^
persistently?
This is the place in mass storage, right?

> +init_addr	: optional for atags - the address where the parameters area is generated into RAM
how about the initrd_addr mentioned above?

> +fdt_addr	: in case of fdt, the address of the device tree.
> +
> +Example (for the twister board):
> +
> +twister => spl export atags 0x82000000
> +## Booting kernel from Legacy Image at 82000000 ...
> +   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
> +   Image Type:   ARM Linux Kernel Image (uncompressed)
> +   Data Size:    3654808 Bytes = 3.5 MiB
> +   Load Address: 80008000
> +   Entry Point:  80008000
> +   Verifying Checksum ... OK
> +   Loading Kernel Image ... OK
> +OK
> +cmdline subcommand not supported
> +bdt subcommand not supported
> +Argument image is now in RAM at: 0x80000100
> +
> +The parameters generated with this step can be saved into NAND at the offset
> +0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
> +
> +Next time, the board can be started into "Falcon mode" moving the
> +CONFIG_SPL_OS_BOOT_KEY GPIO.
> +The kernel is loaded directly by the SPL without passing through U-Boot.
> +
> +Falcon mode was presented at the RMLL 2011. Slides are available at:
> +
> +http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf
> 

Best regards

Andreas Bie?mann

[U-Boot] [PATCH] Add README for the "Falcon" mode

[Stefano Babic]

On 12/11/2012 12:35, Andreas Bie?mann wrote:

Hi Andreas,

>> +Falcon mode relies on the SPL framework. In fact, to make booting faster,
>> +U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
>> +image. In mostly implementations, SPL is used to start U-Boot when booting from
> -----------------^
> In most implementations?

Thanks, I fix it.

> 
>> +a mass storage, such as NAND or SD-Card. SPL has now support for other media,
>> +and can be generalized seen as a way to start an image performing the minimum
>> +required initialization. SPL initializes mainly the RAM controller, and after
>> +that copies U-Boot image into the memory. The "Falcon" mode extends this way
>> +allowing to start any kind of image, an in particular a Linux kernel, preparing
> ------------------------------------------^
> and in particular?
> ------------------------------------------------------------------------^
> to achieve that, to be able to boot linux, ... ?
> The 'preparing a snapshot...' part of this sentence sounds weird to me.

I am a specialist to write weird sentences. I rewrite this part for V2,
hoping to clarify what I like to explain.

>> +3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
>> +the parameters area to the address required address.
> --------------------------------^
> first address is not necessary here

Right

>> +Function that a board must implement
>> +------------------------------------
>> +
>> +void spl_board_prepare_for_linux(void) : optional
>> +	Called from SPL before starting the kernel
>> +
>> +spl_start_uboot() : required
>> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
>> +		must be started.
> 
> In which way interact the CONFIG_SPL_OS_BOOT_KEY with the
> spl_start_uboot()? Is both required, can one use one or the other?

Really checking the implementation, it should be better to remove
CONFIG_SPL_OS_BOOT_KEY. There is not a weak function for
spl_start_uboot(), and I think it is better so. But
CONFIG_SPL_OS_BOOT_KEY is used only inside spl_start_uboot() in the
board's implementation. IMHO it will be better to use a local define for
the GPIOs inside board files, and drop CONFIG_SPL_OS_BOOT_KEY (in
another patch, I mean).

>> +img 		: "atags" or "fdt"
>> +kernel_addr 	: kernel is loaded as part of the boot process, but it is not started.
>> +		  This is the address where a kernel image is stored.
> -------------------------------------------------------------^
> persistently?
> This is the place in mass storage, right?

No, but it could be (for NOR flash, for example). It is the address
where a uImage can be found. It could be in RAM after loading it with
tftp, or in a NOR flash.

In any case, the spl command does not call itself utilities to copy the
kernel from mass storage - such as "nand read" or "fatload", for example.

> 
>> +init_addr	: optional for atags - the address where the parameters area is generated into RAM
> how about the initrd_addr mentioned above?

What is not clear ? init_addr is the destination address, where spl puts
its result. Is it not clear from the description ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH] Add README for the "Falcon" mode

[Andreas Bießmann]

Hi Stefano,

On 12.11.2012 14:02, Stefano Babic wrote:
> On 12/11/2012 12:35, Andreas Bie?mann wrote:

<snip>

>>> +Function that a board must implement
>>> +------------------------------------
>>> +
>>> +void spl_board_prepare_for_linux(void) : optional
>>> +	Called from SPL before starting the kernel
>>> +
>>> +spl_start_uboot() : required
>>> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
>>> +		must be started.
>>
>> In which way interact the CONFIG_SPL_OS_BOOT_KEY with the
>> spl_start_uboot()? Is both required, can one use one or the other?
> 
> Really checking the implementation, it should be better to remove
> CONFIG_SPL_OS_BOOT_KEY. There is not a weak function for
> spl_start_uboot(), and I think it is better so. But
> CONFIG_SPL_OS_BOOT_KEY is used only inside spl_start_uboot() in the
> board's implementation. IMHO it will be better to use a local define for
> the GPIOs inside board files, and drop CONFIG_SPL_OS_BOOT_KEY (in
> another patch, I mean).

sounds good to me.

>>> +img 		: "atags" or "fdt"
>>> +kernel_addr 	: kernel is loaded as part of the boot process, but it is not started.
>>> +		  This is the address where a kernel image is stored.
>> -------------------------------------------------------------^
>> persistently?
>> This is the place in mass storage, right?
> 
> No, but it could be (for NOR flash, for example). It is the address
> where a uImage can be found. It could be in RAM after loading it with
> tftp, or in a NOR flash.
> 
> In any case, the spl command does not call itself utilities to copy the
> kernel from mass storage - such as "nand read" or "fatload", for example.

Ok, thats what I thought. But on first read of this README it was not
clear to me which address I should write there. The step by step example
should have some 'nand read' in it to clarify.

>>> +init_addr	: optional for atags - the address where the parameters area is generated into RAM
>> how about the initrd_addr mentioned above?
> 
> What is not clear ? init_addr is the destination address, where spl puts
> its result. Is it not clear from the description ?

Well, the usage() for spl does not have a 'init_addr' but an
'initrd_addr'. Also your example line states:

---8<---
Usage:
spl export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr if
<img> = fdt] - export a kernel parameter image
	 initrd_img can be set to "-" if fdt_addr without initrd img isused
--->8---

So for me it is not clear where the 'init_addr' come from.
BTW: I find your detailed description way better than current usage() of
spl command. Would IMHO be useful to add it there in another patch.
another BTW: is there a typo in usage() for spl cmd? One line states
'initrd_addr' but some later it says 'initrd_img'.

And last: the spl puts its result at a self gained position. The
position is defined at compile time or when generating the uImage but
not at command line for 'spl export' (see spl_export():
gd->bd->bi_boot_params vs. images.ft_addr).

Best regards

Andreas Bie?mann

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Stefano Babic]

Simple howto to add support to a board
for booting the kernel from SPL ("Falcon" mode).

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
Changes in v2:
- spelling, language fixes (Andreas Biessman)
- rewrite some unclear sentences
- drop CONFIG_SPL_OS_BOOT_KEY
- make example with twister more exhaustive

 doc/README.falcon |  163 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 163 insertions(+)
 create mode 100644 doc/README.falcon

diff --git a/doc/README.falcon b/doc/README.falcon
new file mode 100644
index 0000000..94126fd
--- /dev/null
+++ b/doc/README.falcon
@@ -0,0 +1,163 @@
+U-Boot "Falcon" Mode
+====================
+
+Introduction
+------------
+
+This documents provides an overview how to add support for "Falcon" mode
+to a board.
+Falcon mode is introduced to speed up the booting process, allowing
+to boot a Linux kernel (or whatever image) without a full blown U-Boot.
+
+Falcon mode relies on the SPL framework. In fact, to make booting faster,
+U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
+image. In most implementations, SPL is used to start U-Boot when booting from
+a mass storage, such as NAND or SD-Card. SPL has now support for other media,
+and can be generalized seen as a way to start an image performing the minimum
+required initialization. SPL initializes mainly the RAM controller, and after
+that copies U-Boot image into the memory. The "Falcon" mode extends this way
+allowing to start the Linux kernel directly from SPL. A new command is added
+to U-Boot to prepare the parameters that SPL must pass to the kernel, using
+ATAGS or Device Tree.
+
+Falcon adds a command under U-Boot to reuse all code responsible to prepare
+the interface with the kernel. In usual U-boot systems, these parameters are
+generated each time before loading the kernel, passing to Linux the address
+in memory where the parameters can be read.
+With falcon, this snapshot can be saved into persistent storage and SPL is
+informed to load it before running the kernel.
+
+To boot the kernel, these steps under a Falcon-aware U-Boot are required:
+
+1. Boot the board into U-Boot.
+Use the "spl export" command to generate the kernel parameters area or the DT.
+U-boot runs as when it boots the kernel, but stops before passing the control
+to the kernel.
+
+2. Saves the prepared snapshot into persistent media.
+The address where to save it must be configured into board configuration
+file (CONFIG_CMD_SPL_NAND_OFS for NAND).
+
+3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
+the parameters area to the required address.
+
+It is required to implement a custom mechanism to select if SPL loads U-Boot
+or another image.
+The value of a GPIO is a simple way to operate the selection, as well as
+reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
+
+Falcon mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
+SPL that U-Boot is not the only available image that SPL is able to start.
+
+Configuration
+----------------------------
+CONFIG_CMD_SPL		Enable the "spl export" command.
+			The command "spl export" is then available in U-Boot
+			mode
+CONFIG_SPL_OS_BOOT	Activate Falcon mode.
+			A board should implement the following functions:
+
+CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
+				copied by SPL.
+				In most cases, it is <start_of_ram> + 0x100
+
+CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
+
+CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
+
+CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
+
+Function that a board must implement
+------------------------------------
+
+void spl_board_prepare_for_linux(void) : optional
+	Called from SPL before starting the kernel
+
+spl_start_uboot() : required
+		Returns "0" if SPL starts the kernel, "1" if U-Boot
+		must be started.
+
+
+Using spl command
+-----------------
+
+spl - SPL configuration
+
+Usage:
+
+spl export <img=atags|fdt> [kernel_addr] [fdt_addr if <img> = fdt] - export a kernel parameter image
+
+img		: "atags" or "fdt"
+kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
+		  This is the address where a kernel image is stored.
+fdt_addr	: in case of fdt, the address of the device tree.
+
+
+The spl puts its result at a self gained position. The position is defined at compile
+time or when generating the uImage but not at command line for 'spl export'
+(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
+
+Example (for the twister board):
+--------------------------------
+
+Using mtd names and with the following (default) configuration
+for mtdparts:
+
+device nand0 <omap2-nand.0>, # parts = 9
+ #: name		size		offset		mask_flags
+ 0: MLO                 0x00080000      0x00000000      0
+ 1: u-boot              0x00100000      0x00080000      0
+ 2: env1                0x00040000      0x00180000      0
+ 3: env2                0x00040000      0x001c0000      0
+ 4: kernel              0x00600000      0x00200000      0
+ 5: bootparms           0x00040000      0x00800000      0
+ 6: splashimg           0x00200000      0x00840000      0
+ 7: mini                0x02800000      0x00a40000      0
+ 8: rootfs              0x1cdc0000      0x03240000      0
+
+
+twister => nand read 82000000 kernel
+
+NAND read: device 0 offset 0x200000, size 0x600000
+ 6291456 bytes read: OK
+
+Now the kernel is in RAM at address 0x82000000
+
+twister => spl export atags 0x82000000
+## Booting kernel from Legacy Image at 82000000 ...
+   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
+   Image Type:   ARM Linux Kernel Image (uncompressed)
+   Data Size:    3654808 Bytes = 3.5 MiB
+   Load Address: 80008000
+   Entry Point:  80008000
+   Verifying Checksum ... OK
+   Loading Kernel Image ... OK
+OK
+cmdline subcommand not supported
+bdt subcommand not supported
+Argument image is now in RAM at: 0x80000100
+
+The result can be checked at address 0x80000100:
+
+twister => md 0x80000100
+80000100: 00000005 54410001 00000000 00000000    ......AT........
+80000110: 00000000 00000067 54410009 746f6f72    ....g.....ATroot
+80000120: 65642f3d 666e2f76 77722073 73666e20    =/dev/nfs rw nfs
+
+The parameters generated with this step can be saved into NAND at the offset
+0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
+
+nand erase.part bootparms
+nand write 0x80000100 bootparms 0x4000
+
+Now the parameters are stored into the NAND flash at the address
+CONFIG_CMD_SPL_NAND_OFS (=0x800000).
+
+Next time, the board can be started into "Falcon mode" moving the
+setting the gpio (on twister gpio 55 is used) to kernel mode.
+
+The kernel is loaded directly by the SPL without passing through U-Boot.
+
+Falcon mode was presented at the RMLL 2011. Slides are available at:
+
+http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf
-- 
1.7.9.5

[U-Boot] [PATCH v2 2/2] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define

[Stefano Babic]

CONFIG_SPL_OS_BOOT_KEY is used only in board files. It is
not required to have a general CONFIG_ option. Rename it and
define it in board directory.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

 board/technexion/twister/twister.c  |    8 ++++----
 board/technexion/twister/twister.h  |    2 ++
 board/timll/devkit8000/devkit8000.c |    8 ++++----
 board/timll/devkit8000/devkit8000.h |    3 +++
 include/configs/devkit8000.h        |    1 -
 include/configs/twister.h           |    1 -
 6 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/board/technexion/twister/twister.c b/board/technexion/twister/twister.c
index 1471559..bbc29b7 100644
--- a/board/technexion/twister/twister.c
+++ b/board/technexion/twister/twister.c
@@ -161,10 +161,10 @@ void spl_board_prepare_for_linux(void)
 int spl_start_uboot(void)
 {
 	int val = 0;
-	if (!gpio_request(CONFIG_SPL_OS_BOOT_KEY, "U-Boot key")) {
-		gpio_direction_input(CONFIG_SPL_OS_BOOT_KEY);
-		val = gpio_get_value(CONFIG_SPL_OS_BOOT_KEY);
-		gpio_free(CONFIG_SPL_OS_BOOT_KEY);
+	if (!gpio_request(SPL_OS_BOOT_KEY, "U-Boot key")) {
+		gpio_direction_input(SPL_OS_BOOT_KEY);
+		val = gpio_get_value(SPL_OS_BOOT_KEY);
+		gpio_free(SPL_OS_BOOT_KEY);
 	}
 	return val;
 }
diff --git a/board/technexion/twister/twister.h b/board/technexion/twister/twister.h
index a2051c0..cff479c 100644
--- a/board/technexion/twister/twister.h
+++ b/board/technexion/twister/twister.h
@@ -38,6 +38,8 @@ const omap3_sysinfo sysinfo = {
 #define XR16L2751_UART1_BASE	0x21000000
 #define XR16L2751_UART2_BASE	0x23000000
 
+/* GPIO used to select between U-Boot and kernel */
+#define SPL_OS_BOOT_KEY	55
 
 /*
  * IEN  - Input Enable
diff --git a/board/timll/devkit8000/devkit8000.c b/board/timll/devkit8000/devkit8000.c
index 35f5e15..d8e7ebe 100644
--- a/board/timll/devkit8000/devkit8000.c
+++ b/board/timll/devkit8000/devkit8000.c
@@ -172,10 +172,10 @@ void spl_board_prepare_for_linux(void)
 int spl_start_uboot(void)
 {
 	int val = 0;
-	if (!gpio_request(CONFIG_SPL_OS_BOOT_KEY, "U-Boot key")) {
-		gpio_direction_input(CONFIG_SPL_OS_BOOT_KEY);
-		val = gpio_get_value(CONFIG_SPL_OS_BOOT_KEY);
-		gpio_free(CONFIG_SPL_OS_BOOT_KEY);
+	if (!gpio_request(SPL_OS_BOOT_KEY, "U-Boot key")) {
+		gpio_direction_input(SPL_OS_BOOT_KEY);
+		val = gpio_get_value(SPL_OS_BOOT_KEY);
+		gpio_free(SPL_OS_BOOT_KEY);
 	}
 	return !val;
 }
diff --git a/board/timll/devkit8000/devkit8000.h b/board/timll/devkit8000/devkit8000.h
index aa69e6c..c1965e2 100644
--- a/board/timll/devkit8000/devkit8000.h
+++ b/board/timll/devkit8000/devkit8000.h
@@ -32,6 +32,9 @@ const omap3_sysinfo sysinfo = {
 	"NAND",
 };
 
+/* GPIO used to select between U-Boot and kernel */
+#define SPL_OS_BOOT_KEY	26
+
 /*
  * IEN  - Input Enable
  * IDIS - Input Disable
diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index da3263f..54b5eeb 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -353,7 +353,6 @@
 
 /* SPL OS boot options */
 #define CONFIG_SPL_OS_BOOT
-#define CONFIG_SPL_OS_BOOT_KEY	26
 
 #define CONFIG_CMD_SPL
 #define CONFIG_CMD_SPL_WRITE_SIZE       0x400 /* 1024 byte */
diff --git a/include/configs/twister.h b/include/configs/twister.h
index a852481..4205a11 100644
--- a/include/configs/twister.h
+++ b/include/configs/twister.h
@@ -58,7 +58,6 @@
 #define CONFIG_CMD_SPL_NAND_OFS	(CONFIG_SYS_NAND_SPL_KERNEL_OFFS+\
 						0x600000)
 #define CONFIG_SPL_OS_BOOT
-#define CONFIG_SPL_OS_BOOT_KEY	55
 
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
-- 
1.7.9.5

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Thomas Weber]

Hello Stefano,

there are some inconsistency for the writing of the Falcon mode:
"Falcon" mode, Falcon mode, Falcon, falcon, "Falcon mode"

On 11/13/2012 12:11 PM, Stefano Babic wrote:
> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> Changes in v2:
> - spelling, language fixes (Andreas Biessman)
> - rewrite some unclear sentences
> - drop CONFIG_SPL_OS_BOOT_KEY
> - make example with twister more exhaustive
>
>  doc/README.falcon |  163 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 163 insertions(+)
>  create mode 100644 doc/README.falcon
>
> diff --git a/doc/README.falcon b/doc/README.falcon
> new file mode 100644
> index 0000000..94126fd
> --- /dev/null
> +++ b/doc/README.falcon
> @@ -0,0 +1,163 @@
> +U-Boot "Falcon" Mode
> +====================
> +
> +Introduction
> +------------
> +
> +This documents provides an overview how to add support for "Falcon" mode
This document provides ...
> +to a board.
> +Falcon mode is introduced to speed up the booting process, allowing
> +to boot a Linux kernel (or whatever image) without a full blown U-Boot.
> +
> +Falcon mode relies on the SPL framework. In fact, to make booting faster,
> +U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
> +image. In most implementations, SPL is used to start U-Boot when booting from
> +a mass storage, such as NAND or SD-Card. SPL has now support for other media,
> +and can be generalized seen as a way to start an image performing the minimum
> +required initialization. SPL initializes mainly the RAM controller, and after
> +that copies U-Boot image into the memory. The "Falcon" mode extends this way
> +allowing to start the Linux kernel directly from SPL. A new command is added
> +to U-Boot to prepare the parameters that SPL must pass to the kernel, using
> +ATAGS or Device Tree.
> +
> +Falcon adds a command under U-Boot to reuse all code responsible to prepare
> +the interface with the kernel. In usual U-boot systems, these parameters are
U-boot => U-Boot
> +generated each time before loading the kernel, passing to Linux the address
> +in memory where the parameters can be read.
> +With falcon, this snapshot can be saved into persistent storage and SPL is
> +informed to load it before running the kernel.
> +
> +To boot the kernel, these steps under a Falcon-aware U-Boot are required:
> +
> +1. Boot the board into U-Boot.
> +Use the "spl export" command to generate the kernel parameters area or the DT.
> +U-boot runs as when it boots the kernel, but stops before passing the control
> +to the kernel.
> +
> +2. Saves the prepared snapshot into persistent media.
Saves => Save
> +The address where to save it must be configured into board configuration
> +file (CONFIG_CMD_SPL_NAND_OFS for NAND).
> +
> +3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
> +the parameters area to the required address.
> +
> +It is required to implement a custom mechanism to select if SPL loads U-Boot
> +or another image.
> +The value of a GPIO is a simple way to operate the selection, as well as
> +reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
> +
> +Falcon mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
> +SPL that U-Boot is not the only available image that SPL is able to start.
> +
> +Configuration
> +----------------------------
> +CONFIG_CMD_SPL		Enable the "spl export" command.
> +			The command "spl export" is then available in U-Boot
> +			mode
> +CONFIG_SPL_OS_BOOT	Activate Falcon mode.
> +			A board should implement the following functions:
> +
> +CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
> +				copied by SPL.
> +				In most cases, it is <start_of_ram> + 0x100
> +
> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
> +
> +CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
> +
> +CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
> +
> +Function that a board must implement
> +------------------------------------
> +
> +void spl_board_prepare_for_linux(void) : optional
> +	Called from SPL before starting the kernel
> +
> +spl_start_uboot() : required
> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
> +		must be started.
> +
> +
> +Using spl command
> +-----------------
> +
> +spl - SPL configuration
> +
> +Usage:
> +
> +spl export <img=atags|fdt> [kernel_addr] [fdt_addr if <img> = fdt] - export a kernel parameter image
> +
> +img		: "atags" or "fdt"
> +kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
> +		  This is the address where a kernel image is stored.
> +fdt_addr	: in case of fdt, the address of the device tree.
> +
> +
> +The spl puts its result at a self gained position. The position is defined at compile
> +time or when generating the uImage but not at command line for 'spl export'
> +(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
> +
> +Example (for the twister board):
> +--------------------------------
> +
> +Using mtd names and with the following (default) configuration
> +for mtdparts:
> +
> +device nand0 <omap2-nand.0>, # parts = 9
> + #: name		size		offset		mask_flags
> + 0: MLO                 0x00080000      0x00000000      0
> + 1: u-boot              0x00100000      0x00080000      0
> + 2: env1                0x00040000      0x00180000      0
> + 3: env2                0x00040000      0x001c0000      0
> + 4: kernel              0x00600000      0x00200000      0
> + 5: bootparms           0x00040000      0x00800000      0
> + 6: splashimg           0x00200000      0x00840000      0
> + 7: mini                0x02800000      0x00a40000      0
> + 8: rootfs              0x1cdc0000      0x03240000      0
> +
> +
> +twister => nand read 82000000 kernel
> +
> +NAND read: device 0 offset 0x200000, size 0x600000
> + 6291456 bytes read: OK
> +
> +Now the kernel is in RAM at address 0x82000000
> +
> +twister => spl export atags 0x82000000
> +## Booting kernel from Legacy Image at 82000000 ...
> +   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
> +   Image Type:   ARM Linux Kernel Image (uncompressed)
> +   Data Size:    3654808 Bytes = 3.5 MiB
> +   Load Address: 80008000
> +   Entry Point:  80008000
> +   Verifying Checksum ... OK
> +   Loading Kernel Image ... OK
> +OK
> +cmdline subcommand not supported
> +bdt subcommand not supported
> +Argument image is now in RAM at: 0x80000100
> +
> +The result can be checked at address 0x80000100:
> +
> +twister => md 0x80000100
> +80000100: 00000005 54410001 00000000 00000000    ......AT........
> +80000110: 00000000 00000067 54410009 746f6f72    ....g.....ATroot
> +80000120: 65642f3d 666e2f76 77722073 73666e20    =/dev/nfs rw nfs
> +
> +The parameters generated with this step can be saved into NAND at the offset
> +0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
> +
> +nand erase.part bootparms
> +nand write 0x80000100 bootparms 0x4000
> +
> +Now the parameters are stored into the NAND flash at the address
> +CONFIG_CMD_SPL_NAND_OFS (=0x800000).
> +
> +Next time, the board can be started into "Falcon mode" moving the
> +setting the gpio (on twister gpio 55 is used) to kernel mode.
> +
> +The kernel is loaded directly by the SPL without passing through U-Boot.
> +
> +Falcon mode was presented at the RMLL 2011. Slides are available at:
I think it was in 2012.
> +
> +http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf

Regards,
Thomas

[U-Boot] [PATCH v2 2/2] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define

[Thomas Weber]

On 11/13/2012 12:11 PM, Stefano Babic wrote:
> CONFIG_SPL_OS_BOOT_KEY is used only in board files. It is
> not required to have a general CONFIG_ option. Rename it and
> define it in board directory.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
>
Tested on Devkit8000.

Tested-by: Thomas Weber <thomas.weber@corscience.de>
Acked-by: Thomas Weber <thomas.weber@corscience.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thomas_weber.vcf
Type: text/x-vcard
Size: 260 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121113/57bcf9bd/attachment.vcf>

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Andreas Bießmann]

Dear Stefano Babic,

On 13.11.2012 12:11, Stefano Babic wrote:
> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> Changes in v2:
> - spelling, language fixes (Andreas Biessman)
> - rewrite some unclear sentences
> - drop CONFIG_SPL_OS_BOOT_KEY
> - make example with twister more exhaustive
> 
>  doc/README.falcon |  163 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 163 insertions(+)
>  create mode 100644 doc/README.falcon
> 

<snip>

> +Configuration
> +----------------------------
> +CONFIG_CMD_SPL		Enable the "spl export" command.
> +			The command "spl export" is then available in U-Boot
> +			mode
> +CONFIG_SPL_OS_BOOT	Activate Falcon mode.
> +			A board should implement the following functions:

I think reordering this list to have the required functions directly
after the colon would be helpful. Alternatively add a pointer to the
list of functions after the list of defines.

> +
> +CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
> +				copied by SPL.
> +				In most cases, it is <start_of_ram> + 0x100
> +
> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
> +
> +CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
> +
> +CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
> +
> +Function that a board must implement
> +------------------------------------
> +
> +void spl_board_prepare_for_linux(void) : optional
> +	Called from SPL before starting the kernel
> +
> +spl_start_uboot() : required
> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
> +		must be started.
> +
> +
> +Using spl command
> +-----------------
> +
> +spl - SPL configuration
> +
> +Usage:
> +
> +spl export <img=atags|fdt> [kernel_addr] [fdt_addr if <img> = fdt] - export a kernel parameter image
> +
> +img		: "atags" or "fdt"
> +kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
> +		  This is the address where a kernel image is stored.
> +fdt_addr	: in case of fdt, the address of the device tree.
> +
> +
> +The spl puts its result at a self gained position. The position is defined at compile
> +time or when generating the uImage but not at command line for 'spl export'
> +(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).

I think you got me wrong by my last remarks about the usage() of 'spl
export'.


First of all there is presumably a typo in the descriptive text.

The current code has this usage():
---8<---
	"export <img=atags|fdt> [kernel_addr] [initrd_addr] "
	"[fdt_addr if <img> = fdt] - export a kernel parameter image\n"
	"\t initrd_img can be set to \"-\" if fdt_addr without initrd img is"
	"used")
--->8---
The arguments say something about 'initrd_addr' but the descriptive text
has 'initrd_img'. I think (but do not know since I have not used the spl
command so often) that the 'initrd_img' should be written 'initrd_addr'
(cc Simon Schwarz for that).

The second thing in my last review of your patch was maybe shortly
described. You did write there the correct usage() of 'spl export' but
later on add a more descriptive text about the parameters of 'spl
export'. In these descriptive text you did write 'init_addr' instead of
'initrd_addr' - that was my comment about.
Additionally I thought your descriptive text is way better than the
current descriptive text of 'spl export', so I asked to add your
description to the command.

Now the main reason for my writing here ;)
Your usage() of 'spl export' some lines above is wrong cause it is
missing the 'initrd_addr' parameter.

<snip example>

Best regards

Andreas Bie?mann

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Stefano Babic]

On 13/11/2012 16:55, Andreas Bie?mann wrote:

>> +CONFIG_SPL_OS_BOOT	Activate Falcon mode.
>> +			A board should implement the following functions:
> 
> I think reordering this list to have the required functions directly
> after the colon would be helpful. Alternatively add a pointer to the
> list of functions after the list of defines.

Yes, it is what I wanted to do. In fact, the phrase now before the colon
seems incomplete, because the functions are missing. I will this entry
at the end of the define, so that the functions will follow after it.

> 
>> +spl - SPL configuration
>> +
>> +Usage:
>> +
>> +spl export <img=atags|fdt> [kernel_addr] [fdt_addr if <img> = fdt] - export a kernel parameter image
>> +
>> +img		: "atags" or "fdt"
>> +kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
>> +		  This is the address where a kernel image is stored.
>> +fdt_addr	: in case of fdt, the address of the device tree.
>> +
>> +
>> +The spl puts its result at a self gained position. The position is defined at compile
>> +time or when generating the uImage but not at command line for 'spl export'
>> +(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
> 
> I think you got me wrong by my last remarks about the usage() of 'spl
> export'.

Probably...

> 
> 
> First of all there is presumably a typo in the descriptive text.
> 
> The current code has this usage():
> ---8<---
> 	"export <img=atags|fdt> [kernel_addr] [initrd_addr] "
> 	"[fdt_addr if <img> = fdt] - export a kernel parameter image\n"
> 	"\t initrd_img can be set to \"-\" if fdt_addr without initrd img is"
> 	"used")
> --->8---
> The arguments say something about 'initrd_addr' but the descriptive text
> has 'initrd_img'. I think (but do not know since I have not used the spl
> command so often) that the 'initrd_img' should be written 'initrd_addr'
> (cc Simon Schwarz for that).

Ok, I cannot avoid to fix this typo the command with a separate patch.
Else documentation and code remain inconsistent.

> 
> The second thing in my last review of your patch was maybe shortly
> described. You did write there the correct usage() of 'spl export' but
> later on add a more descriptive text about the parameters of 'spl
> export'. In these descriptive text you did write 'init_addr' instead of
> 'initrd_addr' - that was my comment about.

Ok, it seems I misunderstood. But I think your comment about where spl
stores the result is helpful, even if the address is printed by the
command itself.

> Additionally I thought your descriptive text is way better than the
> current descriptive text of 'spl export', so I asked to add your
> description to the command.

Ok - I will put it into the spl help as well.

> 
> Now the main reason for my writing here ;)
> Your usage() of 'spl export' some lines above is wrong cause it is
> missing the 'initrd_addr' parameter.


Correct - to be fixed ;-)

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Otavio Salvador]

On Tue, Nov 13, 2012 at 9:11 AM, Stefano Babic <sbabic@denx.de> wrote:

> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> Changes in v2:
> - spelling, language fixes (Andreas Biessman)
> - rewrite some unclear sentences
> - drop CONFIG_SPL_OS_BOOT_KEY
> - make example with twister more exhaustive
>
>  doc/README.falcon |  163
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 163 insertions(+)
>  create mode 100644 doc/README.falcon
>
> diff --git a/doc/README.falcon b/doc/README.falcon
> new file mode 100644
> index 0000000..94126fd
> --- /dev/null
> +++ b/doc/README.falcon
> @@ -0,0 +1,163 @@
> +U-Boot "Falcon" Mode
> +====================
> +
> +Introduction
> +------------
> +
> +This documents provides an overview how to add support for "Falcon" mode
> +to a board.
> +Falcon mode is introduced to speed up the booting process, allowing
> +to boot a Linux kernel (or whatever image) without a full blown U-Boot.
> +
> +Falcon mode relies on the SPL framework. In fact, to make booting faster,
> +U-Boot is split into two parts: the SPL (Secondary Program Loader) and
> U-Boot
> +image. In most implementations, SPL is used to start U-Boot when booting
> from
> +a mass storage, such as NAND or SD-Card. SPL has now support for other
> media,
>

In the text you have the offset to save the image onto a NAND offset so I
fail to see how it'd be used for SD-Card.

Can you elaborate it a bit?


> +and can be generalized seen as a way to start an image performing the
> minimum
> +required initialization. SPL initializes mainly the RAM controller, and
> after
> +that copies U-Boot image into the memory. The "Falcon" mode extends this
> way
> +allowing to start the Linux kernel directly from SPL. A new command is
> added
> +to U-Boot to prepare the parameters that SPL must pass to the kernel,
> using
> +ATAGS or Device Tree.
> +
> +Falcon adds a command under U-Boot to reuse all code responsible to
> prepare
> +the interface with the kernel. In usual U-boot systems, these parameters
> are
> +generated each time before loading the kernel, passing to Linux the
> address
> +in memory where the parameters can be read.
> +With falcon, this snapshot can be saved into persistent storage and SPL is
> +informed to load it before running the kernel.
>

You mix Falcon and falcon. I'd say you always use Falcon as it is the name
of the feature so it ought to be in upper case. Another thing, 'With
falcon, ' ought to be move to the previous line or have an empty line
before it.


> +To boot the kernel, these steps under a Falcon-aware U-Boot are required:
> +
> +1. Boot the board into U-Boot.
> +Use the "spl export" command to generate the kernel parameters area or
> the DT.
> +U-boot runs as when it boots the kernel, but stops before passing the
> control
> +to the kernel.
> +
> +2. Saves the prepared snapshot into persistent media.
> +The address where to save it must be configured into board configuration
> +file (CONFIG_CMD_SPL_NAND_OFS for NAND).
>

And for others?


> +3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
> +the parameters area to the required address.
> +
> +It is required to implement a custom mechanism to select if SPL loads
> U-Boot
> +or another image.
> +The value of a GPIO is a simple way to operate the selection, as well as
> +reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
>

An empty line before "The value"?


> +Falcon mode is generally activated by setting CONFIG_SPL_OS_BOOT. This
> tells
> +SPL that U-Boot is not the only available image that SPL is able to start.
> +
> +Configuration
> +----------------------------
> +CONFIG_CMD_SPL         Enable the "spl export" command.
> +                       The command "spl export" is then available in
> U-Boot
> +                       mode
> +CONFIG_SPL_OS_BOOT     Activate Falcon mode.
> +                       A board should implement the following functions:
> +
> +CONFIG_SYS_SPL_ARGS_ADDR       Address in RAM where the parameters must be
> +                               copied by SPL.
> +                               In most cases, it is <start_of_ram> + 0x100
> +
> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS        Offset in NAND where the kernel is
> stored
>

And other media?


> +CONFIG_CMD_SPL_NAND_OFS        Offset in NAND where the parameters area
> was saved.
> +
> +CONFIG_CMD_SPL_WRITE_SIZE      Size of the parameters area to be copied
> +
> +Function that a board must implement
> +------------------------------------
>

Is there others optional? Otherwise you could call it as:

Adding Falcon mode support for a board

+void spl_board_prepare_for_linux(void) : optional
> +       Called from SPL before starting the kernel
> +
> +spl_start_uboot() : required
> +               Returns "0" if SPL starts the kernel, "1" if U-Boot
> +               must be started.
> +
> +
> +Using spl command
> +-----------------
> +
> +spl - SPL configuration
> +
> +Usage:
> +
> +spl export <img=atags|fdt> [kernel_addr] [fdt_addr if <img> = fdt] -
> export a kernel parameter image
> +
> +img            : "atags" or "fdt"
> +kernel_addr    : kernel is loaded as part of the boot process, but it is
> not started.
> +                 This is the address where a kernel image is stored.
> +fdt_addr       : in case of fdt, the address of the device tree.
> +
> +
> +The spl puts its result at a self gained position. The position is
> defined at compile
> +time or when generating the uImage but not at command line for 'spl
> export'
> +(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
> +
> +Example (for the twister board):
> +--------------------------------
> +
> +Using mtd names and with the following (default) configuration
> +for mtdparts:
> +
> +device nand0 <omap2-nand.0>, # parts = 9
> + #: name               size            offset          mask_flags
> + 0: MLO                 0x00080000      0x00000000      0
> + 1: u-boot              0x00100000      0x00080000      0
> + 2: env1                0x00040000      0x00180000      0
> + 3: env2                0x00040000      0x001c0000      0
> + 4: kernel              0x00600000      0x00200000      0
> + 5: bootparms           0x00040000      0x00800000      0
> + 6: splashimg           0x00200000      0x00840000      0
> + 7: mini                0x02800000      0x00a40000      0
> + 8: rootfs              0x1cdc0000      0x03240000      0
> +
> +
> +twister => nand read 82000000 kernel
> +
> +NAND read: device 0 offset 0x200000, size 0x600000
> + 6291456 bytes read: OK
> +
> +Now the kernel is in RAM at address 0x82000000
> +
> +twister => spl export atags 0x82000000
> +## Booting kernel from Legacy Image at 82000000 ...
> +   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
> +   Image Type:   ARM Linux Kernel Image (uncompressed)
> +   Data Size:    3654808 Bytes = 3.5 MiB
> +   Load Address: 80008000
> +   Entry Point:  80008000
> +   Verifying Checksum ... OK
> +   Loading Kernel Image ... OK
> +OK
> +cmdline subcommand not supported
> +bdt subcommand not supported
> +Argument image is now in RAM at: 0x80000100
> +
> +The result can be checked at address 0x80000100:
> +
> +twister => md 0x80000100
> +80000100: 00000005 54410001 00000000 00000000    ......AT........
> +80000110: 00000000 00000067 54410009 746f6f72    ....g.....ATroot
> +80000120: 65642f3d 666e2f76 77722073 73666e20    =/dev/nfs rw nfs
> +
> +The parameters generated with this step can be saved into NAND at the
> offset
> +0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
> +
> +nand erase.part bootparms
> +nand write 0x80000100 bootparms 0x4000
> +
> +Now the parameters are stored into the NAND flash at the address
> +CONFIG_CMD_SPL_NAND_OFS (=0x800000).
> +
> +Next time, the board can be started into "Falcon mode" moving the
> +setting the gpio (on twister gpio 55 is used) to kernel mode.
> +
> +The kernel is loaded directly by the SPL without passing through U-Boot.
> +
> +Falcon mode was presented at the RMLL 2011. Slides are available at:
> +
> +http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf
> --
> 1.7.9.5
>
>
Regards,

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Stefano Babic]

On 14/11/2012 11:29, Otavio Salvador wrote:
> 
> 

Hi Otavio,

> 
> In the text you have the offset to save the image onto a NAND offset so
> I fail to see how it'd be used for SD-Card.
> 
> Can you elaborate it a bit?

No, I can't without introducing errors. Current code supports Falcon
only booting from NAND - I do not think that it is a big thing to use
another media, but it is not yet done. This document must

>     +and can be generalized seen as a way to start an image performing
>     the minimum
>     +required initialization. SPL initializes mainly the RAM controller,
>     and after
>     +that copies U-Boot image into the memory. The "Falcon" mode extends
>     this way
>     +allowing to start the Linux kernel directly from SPL. A new command
>     is added
>     +to U-Boot to prepare the parameters that SPL must pass to the
>     kernel, using
>     +ATAGS or Device Tree.
>     +
>     +Falcon adds a command under U-Boot to reuse all code responsible to
>     prepare
>     +the interface with the kernel. In usual U-boot systems, these
>     parameters are
>     +generated each time before loading the kernel, passing to Linux the
>     address
>     +in memory where the parameters can be read.
>     +With falcon, this snapshot can be saved into persistent storage and
>     SPL is
>     +informed to load it before running the kernel.
> 
> 
> You mix Falcon and falcon.

You're right, there are already comments about this. This will be fixed
globally in V3 (I will use Falcon Mode consistently).

> I'd say you always use Falcon as it is the
> name of the feature so it ought to be in upper case. Another thing,
> 'With falcon, ' ought to be move to the previous line or have an empty
> line before it.

Ok

>  
> 
>     +To boot the kernel, these steps under a Falcon-aware U-Boot are
>     required:
>     +
>     +1. Boot the board into U-Boot.
>     +Use the "spl export" command to generate the kernel parameters area
>     or the DT.
>     +U-boot runs as when it boots the kernel, but stops before passing
>     the control
>     +to the kernel.
>     +
>     +2. Saves the prepared snapshot into persistent media.
>     +The address where to save it must be configured into board
>     configuration
>     +file (CONFIG_CMD_SPL_NAND_OFS for NAND).
> 
> 
> And for others?

Not yet implemented, patches welcome ! But you are right, there is
already a patch to use a NOR flash that should flow soon into mainline.
I will check and add documentation for it. For the orher media, the
document must be updated together when they will be full supported.


>  
> 
>     +3. Boot the board into "Falcon" mode. SPL will load the kernel and copy
>     +the parameters area to the required address.
>     +
>     +It is required to implement a custom mechanism to select if SPL
>     loads U-Boot
>     +or another image.
>     +The value of a GPIO is a simple way to operate the selection, as
>     well as
>     +reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
> 
> 
> An empty line before "The value"?

Ok

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode

[Otavio Salvador]

On Wed, Nov 14, 2012 at 10:19 AM, Stefano Babic <sbabic@denx.de> wrote:

> On 14/11/2012 11:29, Otavio Salvador wrote:
> >
>
> Hi Otavio,
>
> >
> > In the text you have the offset to save the image onto a NAND offset so
> > I fail to see how it'd be used for SD-Card.
> >
> > Can you elaborate it a bit?
>
> No, I can't without introducing errors. Current code supports Falcon
> only booting from NAND - I do not think that it is a big thing to use
> another media, but it is not yet done. This document must


So I'd say to drop the SD-Card from the document.


> >     +and can be generalized seen as a way to start an image performing
> >     the minimum
> >     +required initialization. SPL initializes mainly the RAM controller,
> >     and after
> >     +that copies U-Boot image into the memory. The "Falcon" mode extends
> >     this way
> >     +allowing to start the Linux kernel directly from SPL. A new command
> >     is added
> >     +to U-Boot to prepare the parameters that SPL must pass to the
> >     kernel, using
> >     +ATAGS or Device Tree.
> >     +
> >     +Falcon adds a command under U-Boot to reuse all code responsible to
> >     prepare
> >     +the interface with the kernel. In usual U-boot systems, these
> >     parameters are
> >     +generated each time before loading the kernel, passing to Linux the
> >     address
> >     +in memory where the parameters can be read.
> >     +With falcon, this snapshot can be saved into persistent storage and
> >     SPL is
> >     +informed to load it before running the kernel.
> >
> >
> > You mix Falcon and falcon.
>
> You're right, there are already comments about this. This will be fixed
> globally in V3 (I will use Falcon Mode consistently).
>
> > I'd say you always use Falcon as it is the
> > name of the feature so it ought to be in upper case. Another thing,
> > 'With falcon, ' ought to be move to the previous line or have an empty
> > line before it.
>
> Ok
>
> >
> >
> >     +To boot the kernel, these steps under a Falcon-aware U-Boot are
> >     required:
> >     +
> >     +1. Boot the board into U-Boot.
> >     +Use the "spl export" command to generate the kernel parameters area
> >     or the DT.
> >     +U-boot runs as when it boots the kernel, but stops before passing
> >     the control
> >     +to the kernel.
> >     +
> >     +2. Saves the prepared snapshot into persistent media.
> >     +The address where to save it must be configured into board
> >     configuration
> >     +file (CONFIG_CMD_SPL_NAND_OFS for NAND).
> >
> >
> > And for others?
>
> Not yet implemented, patches welcome ! But you are right, there is
> already a patch to use a NOR flash that should flow soon into mainline.
> I will check and add documentation for it. For the orher media, the
> document must be updated together when they will be full supported.
>
>
> >
> >
> >     +3. Boot the board into "Falcon" mode. SPL will load the kernel and
> copy
> >     +the parameters area to the required address.
> >     +
> >     +It is required to implement a custom mechanism to select if SPL
> >     loads U-Boot
> >     +or another image.
> >     +The value of a GPIO is a simple way to operate the selection, as
> >     well as
> >     +reading a character from the SPL console if CONFIG_SPL_CONSOLE is
> set.
> >
> >
> > An empty line before "The value"?
>
> Ok
>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
> =====================================================================
>



-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[U-Boot] [PATCH v3 1/3] Add README for the "Falcon" mode

[Stefano Babic]

Simple howto to add support to a board
for booting the kernel from SPL ("Falcon" mode).

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
Changes in v3:
- parameter initrd_addr was removed in V2 (Andreas Biessmann)
- added patch to fix help usage for spl export (Andreas Biessmann)
- Added empty lines (Otavio Salvador)
- add a more exhaustive description explaining that
  spl export does not save into media (Lukasz Majewski).

Changes in v2:
- spelling, language fixes (Andreas Biessman)
- rewrite some unclear sentences
- drop CONFIG_SPL_OS_BOOT_KEY
- make example with twister more exhaustive

 doc/README.falcon |  173 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 173 insertions(+)
 create mode 100644 doc/README.falcon

diff --git a/doc/README.falcon b/doc/README.falcon
new file mode 100644
index 0000000..87279e4
--- /dev/null
+++ b/doc/README.falcon
@@ -0,0 +1,173 @@
+U-Boot Falcon Mode
+====================
+
+Introduction
+------------
+
+This document provides an overview how to add support for Falcon Mode
+to a board.
+Falcon Mode is introduced to speed up the booting process, allowing
+to boot a Linux kernel (or whatever image) without a full blown U-Boot.
+
+Falcon Mode relies on the SPL framework. In fact, to make booting faster,
+U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
+image. In most implementations, SPL is used to start U-Boot when booting from
+a mass storage, such as NAND or SD-Card. SPL has now support for other media,
+and can be generalized seen as a way to start an image performing the minimum
+required initialization. SPL initializes mainly the RAM controller, and after
+that copies U-Boot image into the memory. The Falcon Mode extends this way
+allowing to start the Linux kernel directly from SPL. A new command is added
+to U-Boot to prepare the parameters that SPL must pass to the kernel, using
+ATAGS or Device Tree.
+
+Falcon Mode adds a command under U-Boot to reuse all code responsible to prepare
+the interface with the kernel. In usual U-Boot systems, these parameters are
+generated each time before loading the kernel, passing to Linux the address
+in memory where the parameters can be read.
+With Falcon Mode, this snapshot can be saved into persistent storage and SPL is
+informed to load it before running the kernel.
+
+To boot the kernel, these steps under a Falcon-aware U-Boot are required:
+
+1. Boot the board into U-Boot.
+Use the "spl export" command to generate the kernel parameters area or the DT.
+U-Boot runs as when it boots the kernel, but stops before passing the control
+to the kernel.
+
+2. Save the prepared snapshot into persistent media.
+The address where to save it must be configured into board configuration
+file (CONFIG_CMD_SPL_NAND_OFS for NAND).
+
+3. Boot the board into Falcon Mode. SPL will load the kernel and copy
+the parameters area to the required address.
+
+It is required to implement a custom mechanism to select if SPL loads U-Boot
+or another image.
+
+The value of a GPIO is a simple way to operate the selection, as well as
+reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
+
+Falcon Mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
+SPL that U-Boot is not the only available image that SPL is able to start.
+
+Configuration
+----------------------------
+CONFIG_CMD_SPL		Enable the "spl export" command.
+			The command "spl export" is then available in U-Boot
+			mode
+CONFIG_SPL_OS_BOOT	Activate Falcon Mode.
+			A board should implement the following functions:
+
+CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
+				copied by SPL.
+				In most cases, it is <start_of_ram> + 0x100
+
+CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
+
+CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
+
+CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
+
+Function that a board must implement
+------------------------------------
+
+void spl_board_prepare_for_linux(void) : optional
+	Called from SPL before starting the kernel
+
+spl_start_uboot() : required
+		Returns "0" if SPL starts the kernel, "1" if U-Boot
+		must be started.
+
+
+Using spl command
+-----------------
+
+spl - SPL configuration
+
+Usage:
+
+spl export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr ]
+
+img		: "atags" or "fdt"
+kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
+		  This is the address where a kernel image is stored.
+initrd_addr	: Address of initial ramdisk
+		  can be set to "-" if fdt_addr without initrd img is used
+fdt_addr	: in case of fdt, the address of the device tree.
+
+The spl puts its result at a self gained position. The position is defined at compile
+time or when generating the uImage but not at command line for 'spl export'
+(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
+
+spl export' does not write directly to a storage media. This command is intended to save
+the prepared information in RAM.  This information must then be transferred to a final destination
+where the SPL will load it, that is defined at compile time
+(CONFIG_CMD_SPL_NAND_OFS in case of NAND).
+
+The user is responsible to save the data into the required media, as described
+on the following example.
+
+Usage on the twister board:
+--------------------------------
+
+Using mtd names with the following (default) configuration
+for mtdparts:
+
+device nand0 <omap2-nand.0>, # parts = 9
+ #: name		size		offset		mask_flags
+ 0: MLO                 0x00080000      0x00000000      0
+ 1: u-boot              0x00100000      0x00080000      0
+ 2: env1                0x00040000      0x00180000      0
+ 3: env2                0x00040000      0x001c0000      0
+ 4: kernel              0x00600000      0x00200000      0
+ 5: bootparms           0x00040000      0x00800000      0
+ 6: splashimg           0x00200000      0x00840000      0
+ 7: mini                0x02800000      0x00a40000      0
+ 8: rootfs              0x1cdc0000      0x03240000      0
+
+
+twister => nand read 82000000 kernel
+
+NAND read: device 0 offset 0x200000, size 0x600000
+ 6291456 bytes read: OK
+
+Now the kernel is in RAM at address 0x82000000
+
+twister => spl export atags 0x82000000
+## Booting kernel from Legacy Image at 82000000 ...
+   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
+   Image Type:   ARM Linux Kernel Image (uncompressed)
+   Data Size:    3654808 Bytes = 3.5 MiB
+   Load Address: 80008000
+   Entry Point:  80008000
+   Verifying Checksum ... OK
+   Loading Kernel Image ... OK
+OK
+cmdline subcommand not supported
+bdt subcommand not supported
+Argument image is now in RAM at: 0x80000100
+
+The result can be checked at address 0x80000100:
+
+twister => md 0x80000100
+80000100: 00000005 54410001 00000000 00000000    ......AT........
+80000110: 00000000 00000067 54410009 746f6f72    ....g.....ATroot
+80000120: 65642f3d 666e2f76 77722073 73666e20    =/dev/nfs rw nfs
+
+The parameters generated with this step can be saved into NAND at the offset
+0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
+
+nand erase.part bootparms
+nand write 0x80000100 bootparms 0x4000
+
+Now the parameters are stored into the NAND flash at the address
+CONFIG_CMD_SPL_NAND_OFS (=0x800000).
+
+Next time, the board can be started into Falcon Mode moving the
+setting the gpio (on twister gpio 55 is used) to kernel mode.
+
+The kernel is loaded directly by the SPL without passing through U-Boot.
+
+Falcon Mode was presented at the RMLL 2012. Slides are available at:
+
+http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf
-- 
1.7.9.5

[U-Boot] [PATCH v3 2/3] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define

[Stefano Babic]

CONFIG_SPL_OS_BOOT_KEY is used only in board files. It is
not required to have a general CONFIG_ option. Rename it and
define it in board directory.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

 board/technexion/twister/twister.c  |    8 ++++----
 board/technexion/twister/twister.h  |    2 ++
 board/timll/devkit8000/devkit8000.c |    8 ++++----
 board/timll/devkit8000/devkit8000.h |    3 +++
 include/configs/devkit8000.h        |    1 -
 include/configs/twister.h           |    1 -
 6 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/board/technexion/twister/twister.c b/board/technexion/twister/twister.c
index 1471559..bbc29b7 100644
--- a/board/technexion/twister/twister.c
+++ b/board/technexion/twister/twister.c
@@ -161,10 +161,10 @@ void spl_board_prepare_for_linux(void)
 int spl_start_uboot(void)
 {
 	int val = 0;
-	if (!gpio_request(CONFIG_SPL_OS_BOOT_KEY, "U-Boot key")) {
-		gpio_direction_input(CONFIG_SPL_OS_BOOT_KEY);
-		val = gpio_get_value(CONFIG_SPL_OS_BOOT_KEY);
-		gpio_free(CONFIG_SPL_OS_BOOT_KEY);
+	if (!gpio_request(SPL_OS_BOOT_KEY, "U-Boot key")) {
+		gpio_direction_input(SPL_OS_BOOT_KEY);
+		val = gpio_get_value(SPL_OS_BOOT_KEY);
+		gpio_free(SPL_OS_BOOT_KEY);
 	}
 	return val;
 }
diff --git a/board/technexion/twister/twister.h b/board/technexion/twister/twister.h
index a2051c0..cff479c 100644
--- a/board/technexion/twister/twister.h
+++ b/board/technexion/twister/twister.h
@@ -38,6 +38,8 @@ const omap3_sysinfo sysinfo = {
 #define XR16L2751_UART1_BASE	0x21000000
 #define XR16L2751_UART2_BASE	0x23000000
 
+/* GPIO used to select between U-Boot and kernel */
+#define SPL_OS_BOOT_KEY	55
 
 /*
  * IEN  - Input Enable
diff --git a/board/timll/devkit8000/devkit8000.c b/board/timll/devkit8000/devkit8000.c
index 35f5e15..d8e7ebe 100644
--- a/board/timll/devkit8000/devkit8000.c
+++ b/board/timll/devkit8000/devkit8000.c
@@ -172,10 +172,10 @@ void spl_board_prepare_for_linux(void)
 int spl_start_uboot(void)
 {
 	int val = 0;
-	if (!gpio_request(CONFIG_SPL_OS_BOOT_KEY, "U-Boot key")) {
-		gpio_direction_input(CONFIG_SPL_OS_BOOT_KEY);
-		val = gpio_get_value(CONFIG_SPL_OS_BOOT_KEY);
-		gpio_free(CONFIG_SPL_OS_BOOT_KEY);
+	if (!gpio_request(SPL_OS_BOOT_KEY, "U-Boot key")) {
+		gpio_direction_input(SPL_OS_BOOT_KEY);
+		val = gpio_get_value(SPL_OS_BOOT_KEY);
+		gpio_free(SPL_OS_BOOT_KEY);
 	}
 	return !val;
 }
diff --git a/board/timll/devkit8000/devkit8000.h b/board/timll/devkit8000/devkit8000.h
index aa69e6c..c1965e2 100644
--- a/board/timll/devkit8000/devkit8000.h
+++ b/board/timll/devkit8000/devkit8000.h
@@ -32,6 +32,9 @@ const omap3_sysinfo sysinfo = {
 	"NAND",
 };
 
+/* GPIO used to select between U-Boot and kernel */
+#define SPL_OS_BOOT_KEY	26
+
 /*
  * IEN  - Input Enable
  * IDIS - Input Disable
diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index da3263f..54b5eeb 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -353,7 +353,6 @@
 
 /* SPL OS boot options */
 #define CONFIG_SPL_OS_BOOT
-#define CONFIG_SPL_OS_BOOT_KEY	26
 
 #define CONFIG_CMD_SPL
 #define CONFIG_CMD_SPL_WRITE_SIZE       0x400 /* 1024 byte */
diff --git a/include/configs/twister.h b/include/configs/twister.h
index a852481..4205a11 100644
--- a/include/configs/twister.h
+++ b/include/configs/twister.h
@@ -58,7 +58,6 @@
 #define CONFIG_CMD_SPL_NAND_OFS	(CONFIG_SYS_NAND_SPL_KERNEL_OFFS+\
 						0x600000)
 #define CONFIG_SPL_OS_BOOT
-#define CONFIG_SPL_OS_BOOT_KEY	55
 
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
-- 
1.7.9.5

[U-Boot] [PATCH v3 3/3] SPL: Change description for spl command

[Stefano Babic]

Add a more descriptive text to the help of the spl
command.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

 common/cmd_spl.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/common/cmd_spl.c b/common/cmd_spl.c
index 9ec054a..b21d41d 100644
--- a/common/cmd_spl.c
+++ b/common/cmd_spl.c
@@ -182,7 +182,11 @@ static int do_spl(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 U_BOOT_CMD(
 	spl, 6 , 1, do_spl, "SPL configuration",
-	"export <img=atags|fdt> [kernel_addr] [initrd_addr] "
-	"[fdt_addr if <img> = fdt] - export a kernel parameter image\n"
-	"\t initrd_img can be set to \"-\" if fdt_addr without initrd img is"
-	"used");
+	"export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr ]\n"
+	"\timg\t\t\"atags\" or \"fdt\"\n"
+	"\tkernel_addr\taddress where a kernel image is stored.\n"
+	"\t\t\tkernel is loaded as part of the boot process, but it is not started.\n"
+	"\tinitrd_addr\tAddress of initial ramdisk\n"
+	"\t\t\tcan be set to \"-\" if fdt_addr without initrd img is used\n"
+	"\tfdt_addr\tin case of fdt, the address of the device tree.\n"
+	);
-- 
1.7.9.5

[U-Boot] [PATCH v3 1/3] Add README for the "Falcon" mode

[Otavio Salvador]

On Mon, Nov 19, 2012 at 7:11 AM, Stefano Babic <sbabic@denx.de> wrote:

> ...
>
+Falcon Mode relies on the SPL framework. In fact, to make booting faster,
> +U-Boot is split into two parts: the SPL (Secondary Program Loader) and
> U-Boot
> +image. In most implementations, SPL is used to start U-Boot when booting
> from
> +a mass storage, such as NAND or SD-Card. SPL has now support for other
> media,
> +and can be generalized seen as a way to start an image performing the
> minimum
> +required initialization. SPL initializes mainly the RAM controller, and
> after
> +that copies U-Boot image into the memory. The Falcon Mode extends this way
> +allowing to start the Linux kernel directly from SPL. A new command is
> added
> +to U-Boot to prepare the parameters that SPL must pass to the kernel,
> using
> +ATAGS or Device Tree.
>

[U-Boot] [PATCH v3 3/3] SPL: Change description for spl command

[Andreas Bießmann]

Dear Stefano Babic,

On 19.11.2012 10:11, Stefano Babic wrote:
> Add a more descriptive text to the help of the spl
> command.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> 
>  common/cmd_spl.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/common/cmd_spl.c b/common/cmd_spl.c
> index 9ec054a..b21d41d 100644
> --- a/common/cmd_spl.c
> +++ b/common/cmd_spl.c
> @@ -182,7 +182,11 @@ static int do_spl(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  
>  U_BOOT_CMD(
>  	spl, 6 , 1, do_spl, "SPL configuration",
> -	"export <img=atags|fdt> [kernel_addr] [initrd_addr] "
> -	"[fdt_addr if <img> = fdt] - export a kernel parameter image\n"
> -	"\t initrd_img can be set to \"-\" if fdt_addr without initrd img is"
> -	"used");
> +	"export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr ]\n"
---------------------------------------------------------------------^
unnecessary blank

> +	"\timg\t\t\"atags\" or \"fdt\"\n"
> +	"\tkernel_addr\taddress where a kernel image is stored.\n"
> +	"\t\t\tkernel is loaded as part of the boot process, but it is not started.\n"
> +	"\tinitrd_addr\tAddress of initial ramdisk\n"
------------------------^
Capitalization should be uniform. Either change all other places to
capital beginning or start here with small letters.

> +	"\t\t\tcan be set to \"-\" if fdt_addr without initrd img is used\n"
--------------------------------------------------------------^
I think we should write here either 'initrd image'/'initial ramdisk
image' or 'initrd_addr'. I know img is a well known abbreviation for
image, but in a descriptive text we should IMHO not abbreviate.
Additionally the sentence should stop with a full stop like the others do.

> +	"\tfdt_addr\tin case of fdt, the address of the device tree.\n"
> +	);
> 

Best regards

Andreas Bie?mann

[U-Boot] [PATCH v3 1/3] Add README for the "Falcon" mode

[Andreas Bießmann]

Dear Stefano Babic,

On 19.11.2012 10:11, Stefano Babic wrote:
> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>

despite a small change

Acked-by: Andreas Bie?mann <andreas.devel@googlemail.com>

> ---
> Changes in v3:
> - parameter initrd_addr was removed in V2 (Andreas Biessmann)
> - added patch to fix help usage for spl export (Andreas Biessmann)
> - Added empty lines (Otavio Salvador)
> - add a more exhaustive description explaining that
>   spl export does not save into media (Lukasz Majewski).
> 
> Changes in v2:
> - spelling, language fixes (Andreas Biessman)
> - rewrite some unclear sentences
> - drop CONFIG_SPL_OS_BOOT_KEY
> - make example with twister more exhaustive
> 

<snip>

> +Configuration
> +----------------------------
> +CONFIG_CMD_SPL		Enable the "spl export" command.
> +			The command "spl export" is then available in U-Boot
> +			mode
> +CONFIG_SPL_OS_BOOT	Activate Falcon Mode.
> +			A board should implement the following functions:
> +
> +CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
> +				copied by SPL.
> +				In most cases, it is <start_of_ram> + 0x100
> +
> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
> +
> +CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
> +
> +CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
> +
> +Function that a board must implement
> +------------------------------------
> +
> +void spl_board_prepare_for_linux(void) : optional
> +	Called from SPL before starting the kernel
> +
> +spl_start_uboot() : required
> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
> +		must be started.
> +
> +

shouldn't we reorder that thing here (move CONFIG_SPL_OS_BOOT down to
the functions)?

Best regards

Andreas Bie?mann

[U-Boot] [PATCH v3 1/3] Add README for the "Falcon" mode

[Stefano Babic]

On 19/11/2012 11:14, Otavio Salvador wrote:
> On Mon, Nov 19, 2012 at 7:11 AM, Stefano Babic <sbabic@denx.de
> <mailto:sbabic@denx.de>> wrote:
> 
>     ... 
> 
>     +Falcon Mode relies on the SPL framework. In fact, to make booting
>     faster,
>     +U-Boot is split into two parts: the SPL (Secondary Program Loader)
>     and U-Boot
>     +image. In most implementations, SPL is used to start U-Boot when
>     booting from
>     +a mass storage, such as NAND or SD-Card. SPL has now support for
>     other media,
>     +and can be generalized seen as a way to start an image performing
>     the minimum
>     +required initialization. SPL initializes mainly the RAM controller,
>     and after
>     +that copies U-Boot image into the memory. The Falcon Mode extends
>     this way
>     +allowing to start the Linux kernel directly from SPL. A new command
>     is added
>     +to U-Boot to prepare the parameters that SPL must pass to the
>     kernel, using
>     +ATAGS or Device Tree.
> 
> 
> From the above text it seems the Falcon Mode is already available in
> SD-Card however this is not truth. Please rework this so it is clear
> what is already working and what needs to be done.

I reread the sentence, and I am really describing what SPL alone does,
not Falcon mode. SPL is already available for different storage and
there are some boards booting from SD. Check for CONFIG_SPL_MMC_SUPPORT
in include/configs, there are plenty of boards using it.

On the other side, Falcon Mode (SPL + CONFIG_SPL_OS_BOOT) is set only
for two boards, twister and devkit8000, bpth booting from NAND.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH v3 1/3] Add README for the "Falcon" mode

[Stefano Babic]

On 19/11/2012 11:21, Andreas Bie?mann wrote:
> Dear Stefano Babic,
> 
> On 19.11.2012 10:11, Stefano Babic wrote:
>> Simple howto to add support to a board
>> for booting the kernel from SPL ("Falcon" mode).
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
> 
> despite a small change
> 
> Acked-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> 
>> ---
>> Changes in v3:
>> - parameter initrd_addr was removed in V2 (Andreas Biessmann)
>> - added patch to fix help usage for spl export (Andreas Biessmann)
>> - Added empty lines (Otavio Salvador)
>> - add a more exhaustive description explaining that
>>   spl export does not save into media (Lukasz Majewski).
>>
>> Changes in v2:
>> - spelling, language fixes (Andreas Biessman)
>> - rewrite some unclear sentences
>> - drop CONFIG_SPL_OS_BOOT_KEY
>> - make example with twister more exhaustive
>>
> 
> <snip>
> 
>> +Configuration
>> +----------------------------
>> +CONFIG_CMD_SPL		Enable the "spl export" command.
>> +			The command "spl export" is then available in U-Boot
>> +			mode
>> +CONFIG_SPL_OS_BOOT	Activate Falcon Mode.
>> +			A board should implement the following functions:
>> +
>> +CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
>> +				copied by SPL.
>> +				In most cases, it is <start_of_ram> + 0x100
>> +
>> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
>> +
>> +CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
>> +
>> +CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
>> +
>> +Function that a board must implement
>> +------------------------------------
>> +
>> +void spl_board_prepare_for_linux(void) : optional
>> +	Called from SPL before starting the kernel
>> +
>> +spl_start_uboot() : required
>> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
>> +		must be started.
>> +
>> +
> 
> shouldn't we reorder that thing here (move CONFIG_SPL_OS_BOOT down to
> the functions)?
> 

arghh..right, I missed this change - I will do in V4.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH v4 1/3] Add README for the "Falcon" mode

[Stefano Babic]

Simple howto to add support to a board
for booting the kernel from SPL ("Falcon" mode).

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
Changes in v4:
- fix capitalization, styling, in spl help (Andreas Biessmann)
- move CONFIG_SPL_OS_BOOT before function in doc (Andreas Biessmann)

Changes in v3:
- parameter initrd_addr was removed in V2 (Andreas Biessmann)
- added patch to fix help usage for spl export (Andreas Biessmann)
- Added empty lines (Otavio Salvador)
- add a more exhaustive description explaining that
  spl export does not save into media (Lukasz Majewski).

Changes in v2:
- spelling, language fixes (Andreas Biessman)
- rewrite some unclear sentences
- drop CONFIG_SPL_OS_BOOT_KEY
- make example with twister more exhaustive

 doc/README.falcon |  173 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 173 insertions(+)
 create mode 100644 doc/README.falcon

diff --git a/doc/README.falcon b/doc/README.falcon
new file mode 100644
index 0000000..1c041ea
--- /dev/null
+++ b/doc/README.falcon
@@ -0,0 +1,173 @@
+U-Boot Falcon Mode
+====================
+
+Introduction
+------------
+
+This document provides an overview how to add support for Falcon Mode
+to a board.
+Falcon Mode is introduced to speed up the booting process, allowing
+to boot a Linux kernel (or whatever image) without a full blown U-Boot.
+
+Falcon Mode relies on the SPL framework. In fact, to make booting faster,
+U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
+image. In most implementations, SPL is used to start U-Boot when booting from
+a mass storage, such as NAND or SD-Card. SPL has now support for other media,
+and can be generalized seen as a way to start an image performing the minimum
+required initialization. SPL initializes mainly the RAM controller, and after
+that copies U-Boot image into the memory. The Falcon Mode extends this way
+allowing to start the Linux kernel directly from SPL. A new command is added
+to U-Boot to prepare the parameters that SPL must pass to the kernel, using
+ATAGS or Device Tree.
+
+Falcon Mode adds a command under U-Boot to reuse all code responsible to prepare
+the interface with the kernel. In usual U-Boot systems, these parameters are
+generated each time before loading the kernel, passing to Linux the address
+in memory where the parameters can be read.
+With Falcon Mode, this snapshot can be saved into persistent storage and SPL is
+informed to load it before running the kernel.
+
+To boot the kernel, these steps under a Falcon-aware U-Boot are required:
+
+1. Boot the board into U-Boot.
+Use the "spl export" command to generate the kernel parameters area or the DT.
+U-Boot runs as when it boots the kernel, but stops before passing the control
+to the kernel.
+
+2. Save the prepared snapshot into persistent media.
+The address where to save it must be configured into board configuration
+file (CONFIG_CMD_SPL_NAND_OFS for NAND).
+
+3. Boot the board into Falcon Mode. SPL will load the kernel and copy
+the parameters area to the required address.
+
+It is required to implement a custom mechanism to select if SPL loads U-Boot
+or another image.
+
+The value of a GPIO is a simple way to operate the selection, as well as
+reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
+
+Falcon Mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
+SPL that U-Boot is not the only available image that SPL is able to start.
+
+Configuration
+----------------------------
+CONFIG_CMD_SPL		Enable the "spl export" command.
+			The command "spl export" is then available in U-Boot
+			mode
+CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
+				copied by SPL.
+				In most cases, it is <start_of_ram> + 0x100
+
+CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
+
+CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.
+
+CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
+
+CONFIG_SPL_OS_BOOT	Activate Falcon Mode.
+			A board should implement the following functions:
+
+Function that a board must implement
+------------------------------------
+
+void spl_board_prepare_for_linux(void) : optional
+	Called from SPL before starting the kernel
+
+spl_start_uboot() : required
+		Returns "0" if SPL starts the kernel, "1" if U-Boot
+		must be started.
+
+
+Using spl command
+-----------------
+
+spl - SPL configuration
+
+Usage:
+
+spl export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr ]
+
+img		: "atags" or "fdt"
+kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
+		  This is the address where a kernel image is stored.
+initrd_addr	: Address of initial ramdisk
+		  can be set to "-" if fdt_addr without initrd img is used
+fdt_addr	: in case of fdt, the address of the device tree.
+
+The spl puts its result at a self gained position. The position is defined at compile
+time or when generating the uImage but not at command line for 'spl export'
+(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
+
+spl export' does not write directly to a storage media. This command is intended to save
+the prepared information in RAM.  This information must then be transferred to a final destination
+where the SPL will load it, that is defined at compile time
+(CONFIG_CMD_SPL_NAND_OFS in case of NAND).
+
+The user is responsible to save the data into the required media, as described
+on the following example.
+
+Usage on the twister board:
+--------------------------------
+
+Using mtd names with the following (default) configuration
+for mtdparts:
+
+device nand0 <omap2-nand.0>, # parts = 9
+ #: name		size		offset		mask_flags
+ 0: MLO                 0x00080000      0x00000000      0
+ 1: u-boot              0x00100000      0x00080000      0
+ 2: env1                0x00040000      0x00180000      0
+ 3: env2                0x00040000      0x001c0000      0
+ 4: kernel              0x00600000      0x00200000      0
+ 5: bootparms           0x00040000      0x00800000      0
+ 6: splashimg           0x00200000      0x00840000      0
+ 7: mini                0x02800000      0x00a40000      0
+ 8: rootfs              0x1cdc0000      0x03240000      0
+
+
+twister => nand read 82000000 kernel
+
+NAND read: device 0 offset 0x200000, size 0x600000
+ 6291456 bytes read: OK
+
+Now the kernel is in RAM at address 0x82000000
+
+twister => spl export atags 0x82000000
+## Booting kernel from Legacy Image at 82000000 ...
+   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
+   Image Type:   ARM Linux Kernel Image (uncompressed)
+   Data Size:    3654808 Bytes = 3.5 MiB
+   Load Address: 80008000
+   Entry Point:  80008000
+   Verifying Checksum ... OK
+   Loading Kernel Image ... OK
+OK
+cmdline subcommand not supported
+bdt subcommand not supported
+Argument image is now in RAM at: 0x80000100
+
+The result can be checked at address 0x80000100:
+
+twister => md 0x80000100
+80000100: 00000005 54410001 00000000 00000000    ......AT........
+80000110: 00000000 00000067 54410009 746f6f72    ....g.....ATroot
+80000120: 65642f3d 666e2f76 77722073 73666e20    =/dev/nfs rw nfs
+
+The parameters generated with this step can be saved into NAND at the offset
+0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
+
+nand erase.part bootparms
+nand write 0x80000100 bootparms 0x4000
+
+Now the parameters are stored into the NAND flash at the address
+CONFIG_CMD_SPL_NAND_OFS (=0x800000).
+
+Next time, the board can be started into Falcon Mode moving the
+setting the gpio (on twister gpio 55 is used) to kernel mode.
+
+The kernel is loaded directly by the SPL without passing through U-Boot.
+
+Falcon Mode was presented at the RMLL 2012. Slides are available at:
+
+http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf
-- 
1.7.9.5

[U-Boot] [PATCH v4 2/3] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define

[Stefano Babic]

CONFIG_SPL_OS_BOOT_KEY is used only in board files. It is
not required to have a general CONFIG_ option. Rename it and
define it in board directory.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

 board/technexion/twister/twister.c  |    8 ++++----
 board/technexion/twister/twister.h  |    2 ++
 board/timll/devkit8000/devkit8000.c |    8 ++++----
 board/timll/devkit8000/devkit8000.h |    3 +++
 include/configs/devkit8000.h        |    1 -
 include/configs/twister.h           |    1 -
 6 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/board/technexion/twister/twister.c b/board/technexion/twister/twister.c
index 1471559..bbc29b7 100644
--- a/board/technexion/twister/twister.c
+++ b/board/technexion/twister/twister.c
@@ -161,10 +161,10 @@ void spl_board_prepare_for_linux(void)
 int spl_start_uboot(void)
 {
 	int val = 0;
-	if (!gpio_request(CONFIG_SPL_OS_BOOT_KEY, "U-Boot key")) {
-		gpio_direction_input(CONFIG_SPL_OS_BOOT_KEY);
-		val = gpio_get_value(CONFIG_SPL_OS_BOOT_KEY);
-		gpio_free(CONFIG_SPL_OS_BOOT_KEY);
+	if (!gpio_request(SPL_OS_BOOT_KEY, "U-Boot key")) {
+		gpio_direction_input(SPL_OS_BOOT_KEY);
+		val = gpio_get_value(SPL_OS_BOOT_KEY);
+		gpio_free(SPL_OS_BOOT_KEY);
 	}
 	return val;
 }
diff --git a/board/technexion/twister/twister.h b/board/technexion/twister/twister.h
index a2051c0..cff479c 100644
--- a/board/technexion/twister/twister.h
+++ b/board/technexion/twister/twister.h
@@ -38,6 +38,8 @@ const omap3_sysinfo sysinfo = {
 #define XR16L2751_UART1_BASE	0x21000000
 #define XR16L2751_UART2_BASE	0x23000000
 
+/* GPIO used to select between U-Boot and kernel */
+#define SPL_OS_BOOT_KEY	55
 
 /*
  * IEN  - Input Enable
diff --git a/board/timll/devkit8000/devkit8000.c b/board/timll/devkit8000/devkit8000.c
index 35f5e15..d8e7ebe 100644
--- a/board/timll/devkit8000/devkit8000.c
+++ b/board/timll/devkit8000/devkit8000.c
@@ -172,10 +172,10 @@ void spl_board_prepare_for_linux(void)
 int spl_start_uboot(void)
 {
 	int val = 0;
-	if (!gpio_request(CONFIG_SPL_OS_BOOT_KEY, "U-Boot key")) {
-		gpio_direction_input(CONFIG_SPL_OS_BOOT_KEY);
-		val = gpio_get_value(CONFIG_SPL_OS_BOOT_KEY);
-		gpio_free(CONFIG_SPL_OS_BOOT_KEY);
+	if (!gpio_request(SPL_OS_BOOT_KEY, "U-Boot key")) {
+		gpio_direction_input(SPL_OS_BOOT_KEY);
+		val = gpio_get_value(SPL_OS_BOOT_KEY);
+		gpio_free(SPL_OS_BOOT_KEY);
 	}
 	return !val;
 }
diff --git a/board/timll/devkit8000/devkit8000.h b/board/timll/devkit8000/devkit8000.h
index aa69e6c..c1965e2 100644
--- a/board/timll/devkit8000/devkit8000.h
+++ b/board/timll/devkit8000/devkit8000.h
@@ -32,6 +32,9 @@ const omap3_sysinfo sysinfo = {
 	"NAND",
 };
 
+/* GPIO used to select between U-Boot and kernel */
+#define SPL_OS_BOOT_KEY	26
+
 /*
  * IEN  - Input Enable
  * IDIS - Input Disable
diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index da3263f..54b5eeb 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -353,7 +353,6 @@
 
 /* SPL OS boot options */
 #define CONFIG_SPL_OS_BOOT
-#define CONFIG_SPL_OS_BOOT_KEY	26
 
 #define CONFIG_CMD_SPL
 #define CONFIG_CMD_SPL_WRITE_SIZE       0x400 /* 1024 byte */
diff --git a/include/configs/twister.h b/include/configs/twister.h
index a852481..4205a11 100644
--- a/include/configs/twister.h
+++ b/include/configs/twister.h
@@ -58,7 +58,6 @@
 #define CONFIG_CMD_SPL_NAND_OFS	(CONFIG_SYS_NAND_SPL_KERNEL_OFFS+\
 						0x600000)
 #define CONFIG_SPL_OS_BOOT
-#define CONFIG_SPL_OS_BOOT_KEY	55
 
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
-- 
1.7.9.5

[U-Boot] [PATCH v4 3/3] SPL: Change description for spl command

[Stefano Babic]

Add a more descriptive text to the help of the spl
command.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

 common/cmd_spl.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/common/cmd_spl.c b/common/cmd_spl.c
index 9ec054a..b3d9834 100644
--- a/common/cmd_spl.c
+++ b/common/cmd_spl.c
@@ -182,7 +182,11 @@ static int do_spl(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 U_BOOT_CMD(
 	spl, 6 , 1, do_spl, "SPL configuration",
-	"export <img=atags|fdt> [kernel_addr] [initrd_addr] "
-	"[fdt_addr if <img> = fdt] - export a kernel parameter image\n"
-	"\t initrd_img can be set to \"-\" if fdt_addr without initrd img is"
-	"used");
+	"export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr]\n"
+	"\timg\t\t\"atags\" or \"fdt\"\n"
+	"\tkernel_addr\taddress where a kernel image is stored.\n"
+	"\t\t\tkernel is loaded as part of the boot process, but it is not started.\n"
+	"\tinitrd_addr\taddress of initial ramdisk\n"
+	"\t\t\tcan be set to \"-\" if fdt_addr without initrd_addr is used.\n"
+	"\tfdt_addr\tin case of fdt, the address of the device tree.\n"
+	);
-- 
1.7.9.5

[U-Boot] [PATCH v4 1/3] Add README for the "Falcon" mode

[Vikram Narayanan]

Hi Stefano,

Sorry for bumping in at v4. Below are some of my comments.

On 11/23/2012 9:01 PM, Stefano Babic wrote:
> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
>
> Signed-off-by: Stefano Babic<sbabic@denx.de>
> ---
> Changes in v4:
> - fix capitalization, styling, in spl help (Andreas Biessmann)
> - move CONFIG_SPL_OS_BOOT before function in doc (Andreas Biessmann)
>
<snip>
> diff --git a/doc/README.falcon b/doc/README.falcon
> new file mode 100644
> index 0000000..1c041ea
> --- /dev/null
> +++ b/doc/README.falcon
> @@ -0,0 +1,173 @@
> +U-Boot Falcon Mode
> +====================
> +
> +Introduction
> +------------
> +
> +This document provides an overview how to add support for Falcon Mode

s/an overview/an overview of/

> +to a board.
> +Falcon Mode is introduced to speed up the booting process, allowing
> +to boot a Linux kernel (or whatever image) without a full blown U-Boot.
> +
> +Falcon Mode relies on the SPL framework. In fact, to make booting faster,
> +U-Boot is split into two parts: the SPL (Secondary Program Loader) and U-Boot
> +image. In most implementations, SPL is used to start U-Boot when booting from
> +a mass storage, such as NAND or SD-Card. SPL has now support for other media,
> +and can be generalized seen as a way to start an image performing the minimum

Rephrase the above line as,
and can generally be seen ....

> +required initialization. SPL initializes mainly the RAM controller, and after
> +that copies U-Boot image into the memory. The Falcon Mode extends this way

Rephrase ..

SPL mainly initializes the RAM controller, and then copies U-boot image 
to the main memory.

> +allowing to start the Linux kernel directly from SPL. A new command is added
> +to U-Boot to prepare the parameters that SPL must pass to the kernel, using
> +ATAGS or Device Tree.
> +
> +Falcon Mode adds a command under U-Boot to reuse all code responsible to prepare

Already it is mentioned that 'a new command is added'. The above line is 
redundant then. Please rephrase it.

> +the interface with the kernel. In usual U-Boot systems, these parameters are
> +generated each time before loading the kernel, passing to Linux the address
> +in memory where the parameters can be read.
> +With Falcon Mode, this snapshot can be saved into persistent storage and SPL is
> +informed to load it before running the kernel.
> +
> +To boot the kernel, these steps under a Falcon-aware U-Boot are required:
> +
> +1. Boot the board into U-Boot.
> +Use the "spl export" command to generate the kernel parameters area or the DT.
> +U-Boot runs as when it boots the kernel, but stops before passing the control
> +to the kernel.
> +
> +2. Save the prepared snapshot into persistent media.
> +The address where to save it must be configured into board configuration
> +file (CONFIG_CMD_SPL_NAND_OFS for NAND).
> +
> +3. Boot the board into Falcon Mode. SPL will load the kernel and copy
> +the parameters area to the required address.

copy the parameters which is saved in the persistent media to the ....

> +
> +It is required to implement a custom mechanism to select if SPL loads U-Boot
> +or another image.
> +
> +The value of a GPIO is a simple way to operate the selection, as well as
> +reading a character from the SPL console if CONFIG_SPL_CONSOLE is set.
> +
> +Falcon Mode is generally activated by setting CONFIG_SPL_OS_BOOT. This tells
> +SPL that U-Boot is not the only available image that SPL is able to start.
> +
> +Configuration
> +----------------------------
> +CONFIG_CMD_SPL		Enable the "spl export" command.
> +			The command "spl export" is then available in U-Boot
> +			mode
> +CONFIG_SYS_SPL_ARGS_ADDR	Address in RAM where the parameters must be
> +				copied by SPL.
> +				In most cases, it is<start_of_ram>  + 0x100

A space in between is and '<'

> +
> +CONFIG_SYS_NAND_SPL_KERNEL_OFFS	Offset in NAND where the kernel is stored
> +
> +CONFIG_CMD_SPL_NAND_OFS	Offset in NAND where the parameters area was saved.

Can the above be renamed to include the word 'PARAMS'? But becomes 
lengthy. Any suggestions?

> +
> +CONFIG_CMD_SPL_WRITE_SIZE 	Size of the parameters area to be copied
> +
> +CONFIG_SPL_OS_BOOT	Activate Falcon Mode.
> +			A board should implement the following functions:

Is there a big difference between the line above and the one below?

> +Function that a board must implement
> +------------------------------------
> +
> +void spl_board_prepare_for_linux(void) : optional
> +	Called from SPL before starting the kernel
> +
> +spl_start_uboot() : required
> +		Returns "0" if SPL starts the kernel, "1" if U-Boot
> +		must be started.
> +
> +
> +Using spl command
> +-----------------
> +
> +spl - SPL configuration
> +
> +Usage:
> +
> +spl export<img=atags|fdt>  [kernel_addr] [initrd_addr] [fdt_addr ]
> +
> +img		: "atags" or "fdt"
> +kernel_addr	: kernel is loaded as part of the boot process, but it is not started.
> +		  This is the address where a kernel image is stored.
> +initrd_addr	: Address of initial ramdisk
> +		  can be set to "-" if fdt_addr without initrd img is used
> +fdt_addr	: in case of fdt, the address of the device tree.
> +
> +The spl puts its result at a self gained position. The position is defined at compile
> +time or when generating the uImage but not at command line for 'spl export'
> +(see spl_export(): gd->bd->bi_boot_params vs. images.ft_addr).
> +
> +spl export' does not write directly to a storage media. This command is intended to save
> +the prepared information in RAM.  This information must then be transferred to a final destination

^ [1]
Final destination? How is it getting transferred?
Shall lines/content [1] and [2] merged?

> +where the SPL will load it, that is defined at compile time
> +(CONFIG_CMD_SPL_NAND_OFS in case of NAND).
> +
> +The user is responsible to save the data into the required media, as described
> +on the following example.

^ [2]

> +Usage on the twister board:
> +--------------------------------
> +
> +Using mtd names with the following (default) configuration
> +for mtdparts:
> +
> +device nand0<omap2-nand.0>, # parts = 9
> + #: name		size		offset		mask_flags
> + 0: MLO                 0x00080000      0x00000000      0
> + 1: u-boot              0x00100000      0x00080000      0
> + 2: env1                0x00040000      0x00180000      0
> + 3: env2                0x00040000      0x001c0000      0
> + 4: kernel              0x00600000      0x00200000      0
> + 5: bootparms           0x00040000      0x00800000      0
> + 6: splashimg           0x00200000      0x00840000      0
> + 7: mini                0x02800000      0x00a40000      0
> + 8: rootfs              0x1cdc0000      0x03240000      0
> +
> +
> +twister =>  nand read 82000000 kernel
> +
> +NAND read: device 0 offset 0x200000, size 0x600000
> + 6291456 bytes read: OK
> +
> +Now the kernel is in RAM at address 0x82000000
> +
> +twister =>  spl export atags 0x82000000
> +## Booting kernel from Legacy Image at 82000000 ...
> +   Image Name:   Linux-3.5.0-rc4-14089-gda0b7f4
> +   Image Type:   ARM Linux Kernel Image (uncompressed)
> +   Data Size:    3654808 Bytes = 3.5 MiB
> +   Load Address: 80008000
> +   Entry Point:  80008000
> +   Verifying Checksum ... OK
> +   Loading Kernel Image ... OK
> +OK
> +cmdline subcommand not supported
> +bdt subcommand not supported
> +Argument image is now in RAM at: 0x80000100
> +
> +The result can be checked at address 0x80000100:
> +
> +twister =>  md 0x80000100
> +80000100: 00000005 54410001 00000000 00000000    ......AT........
> +80000110: 00000000 00000067 54410009 746f6f72    ....g.....ATroot
> +80000120: 65642f3d 666e2f76 77722073 73666e20    =/dev/nfs rw nfs
> +
> +The parameters generated with this step can be saved into NAND at the offset
> +0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
> +
> +nand erase.part bootparms
> +nand write 0x80000100 bootparms 0x4000

If the offset is known at compile time, why should the end user use the 
above commands to write it? Can't it be automated? Just an idea.

> +Now the parameters are stored into the NAND flash at the address
> +CONFIG_CMD_SPL_NAND_OFS (=0x800000).
> +
> +Next time, the board can be started into Falcon Mode moving the
> +setting the gpio (on twister gpio 55 is used) to kernel mode.
> +
> +The kernel is loaded directly by the SPL without passing through U-Boot.
> +
> +Falcon Mode was presented at the RMLL 2012. Slides are available at:
> +
> +http://schedule2012.rmll.info/IMG/pdf/LSM2012_UbootFalconMode_Babic.pdf

Regards,
Vikram

[U-Boot] [PATCH v4 1/3] Add README for the "Falcon" mode

[Andreas Bießmann]

Dear Vikram Narayanan,

On 23.11.12 19:10, Vikram Narayanan wrote:

<snip>

>> +The parameters generated with this step can be saved into NAND at the
>> offset
>> +0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
>> +
>> +nand erase.part bootparms
>> +nand write 0x80000100 bootparms 0x4000
> 
> If the offset is known at compile time, why should the end user use the
> above commands to write it? Can't it be automated? Just an idea.

No, please read
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/102326
or
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/147205

Best regards

Andreas Bie?mann

[U-Boot] [PATCH v4 1/3] Add README for the "Falcon" mode

[Stefano Babic]

On 23/11/2012 19:10, Vikram Narayanan wrote:
> Hi Stefano,
> 
> Sorry for bumping in at v4. Below are some of my comments.
> 

No problems, all reviews are welcome ! I fix your comments in V5.

> 
> If the offset is known at compile time, why should the end user use the
> above commands to write it? Can't it be automated? Just an idea.

No, it's not - Andreas have already given links to previous threads
where this issue was discussed.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH v4 1/3] Add README for the "Falcon" mode

[Vikram Narayanan]

Hello Andreas,

On 11/24/2012 3:29 AM, Andreas Bie?mann wrote:
> Dear Vikram Narayanan,
>
> On 23.11.12 19:10, Vikram Narayanan wrote:
>
> <snip>
>
>>> +The parameters generated with this step can be saved into NAND at the
>>> offset
>>> +0x800000 (value for twister for CONFIG_CMD_SPL_NAND_OFS)
>>> +
>>> +nand erase.part bootparms
>>> +nand write 0x80000100 bootparms 0x4000
>>
>> If the offset is known at compile time, why should the end user use the
>> above commands to write it? Can't it be automated? Just an idea.
>
> No, please read
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/102326
> or
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/147205
>

Thanks. Clarified.

Regards,
Vikram

[U-Boot] [PATCH] Add README for the "Falcon" mode

[Otavio Salvador]

On Mon, Nov 12, 2012 at 8:59 AM, Stefano Babic <sbabic@denx.de> wrote:
> Simple howto to add support to a board
> for booting the kernel from SPL ("Falcon" mode).
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>

Could this be updated and resend? This is an interesting feature which
lacks documentation currently.

Regards,

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[U-Boot] [PATCH] Add README for the "Falcon" mode

[Stefano Babic]

On 11/02/2013 22:12, Otavio Salvador wrote:
> On Mon, Nov 12, 2012 at 8:59 AM, Stefano Babic <sbabic@denx.de> wrote:
>> Simple howto to add support to a board
>> for booting the kernel from SPL ("Falcon" mode).
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
> 
> Could this be updated and resend? This is an interesting feature which
> lacks documentation currently.

Hi Otavio,

you are right, and thanks to point out that the documentation is not yet
merged. I will push a V5 as I promised with fixes for the last comments.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================