[meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[ting.liu]

From: Ting Liu <ting.liu@freescale.com>

If both udev-extraconf and udev-rules-qoriq installed, file clashes
will happen. move fsl specific rules back to udev-extraconf

Signed-off-by: Ting Liu <ting.liu@freescale.com>
---
 conf/machine/include/qoriq-base.inc                              | 2 +-
 .../qoriq-ppc/automount.rules                                    | 1 +
 recipes-core/udev/udev-extraconf_%.bbappend                      | 9 +++++++++
 recipes-core/udev/udev-rules-qoriq.bb                            | 5 -----
 4 files changed, 11 insertions(+), 6 deletions(-)
 rename recipes-core/udev/{udev-rules-qoriq => udev-extraconf}/qoriq-ppc/automount.rules (89%)
 create mode 100644 recipes-core/udev/udev-extraconf_%.bbappend

diff --git a/conf/machine/include/qoriq-base.inc b/conf/machine/include/qoriq-base.inc
index 35ca79c..acb4e83 100644
--- a/conf/machine/include/qoriq-base.inc
+++ b/conf/machine/include/qoriq-base.inc
@@ -11,7 +11,7 @@ PREFERRED_VERSION_openssl = "1.0.1i"
 
 # settings
 MACHINE_FEATURES = "keyboard pci ext2 ext3 serial"
-MACHINE_EXTRA_RRECOMMENDS += "udev-rules-qoriq kernel-modules"
+MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf udev-rules-qoriq kernel-modules"
 MACHINEOVERRIDES .= ":qoriq-ppc"
 
 IMAGE_CLASSES += "image_types_uboot"
diff --git a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
similarity index 89%
rename from recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
rename to recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
index a47efda..e1d75d7 100644
--- a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
+++ b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
@@ -18,6 +18,7 @@ SUBSYSTEM=="block", ENV{DEVTYPE}=="partition", GOTO="automount_end"
 # Media automounting
 SUBSYSTEM=="block", ACTION=="add"    RUN+="/etc/udev/scripts/mount.sh"
 SUBSYSTEM=="block", ACTION=="remove" RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1" RUN+="/etc/udev/scripts/mount.sh"
 
 LABEL="automount_end"
 
diff --git a/recipes-core/udev/udev-extraconf_%.bbappend b/recipes-core/udev/udev-extraconf_%.bbappend
new file mode 100644
index 0000000..2b09465
--- /dev/null
+++ b/recipes-core/udev/udev-extraconf_%.bbappend
@@ -0,0 +1,9 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${BPN}:"
+
+do_install_append_qoriq-ppc () {
+    # skip mmc rpmb partitions
+    echo "/dev/mmcblk.*rpmb" >>${D}${sysconfdir}/udev/mount.blacklist
+    # skip nbd (network block device)
+    echo "/dev/nbd*" >>${D}${sysconfdir}/udev/mount.blacklist
+}
+
diff --git a/recipes-core/udev/udev-rules-qoriq.bb b/recipes-core/udev/udev-rules-qoriq.bb
index 546f9e8..6f06c02 100644
--- a/recipes-core/udev/udev-rules-qoriq.bb
+++ b/recipes-core/udev/udev-rules-qoriq.bb
@@ -14,10 +14,5 @@ RULE_t1024 = "72-fsl-dpaa-persistent-networking.rules"
 do_install () {
     install -d ${D}${sysconfdir}/udev/rules.d/
     install -m 0644 ${WORKDIR}/${RULE} ${D}${sysconfdir}/udev/rules.d/
-
-    # skip mmc rpmb partitions
-    echo "/dev/mmcblk.*rpmb" >>${D}${sysconfdir}/udev/mount.blacklist
-    # skip nbd (network block device)
-    echo "/dev/nbd*" >>${D}${sysconfdir}/udev/mount.blacklist
 }
 
-- 
1.9.1

[meta-fsl-ppc][PATCH 2/2] u-boot: use TARGET_VENDOR to compose multilib sys

[ting.liu]

From: Ting Liu <ting.liu@freescale.com>

This aligns with the default setting in Poky.

Signed-off-by: Ting Liu <ting.liu@freescale.com>
---
 recipes-bsp/u-boot/u-boot-qoriq_2014.07.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-bsp/u-boot/u-boot-qoriq_2014.07.bb b/recipes-bsp/u-boot/u-boot-qoriq_2014.07.bb
index 43af42d..b780658 100644
--- a/recipes-bsp/u-boot/u-boot-qoriq_2014.07.bb
+++ b/recipes-bsp/u-boot/u-boot-qoriq_2014.07.bb
@@ -30,7 +30,7 @@ python () {
     if "e5500-64b:" in arch or "e6500-64b:" in arch:
         if not "lib32" in ml:
             raise bb.parse.SkipPackage("Building the u-boot for this arch requires multilib to be enabled")
-        sys_multilib = 'powerpc-' + d.getVar('DISTRO') + 'mllib32-' + d.getVar('HOST_OS')
+        sys_multilib = 'powerpc' + d.getVar('TARGET_VENDOR') + 'mllib32-' + d.getVar('HOST_OS')
         d.setVar('DEPENDS_append', ' lib32-gcc-cross-powerpc lib32-libgcc')
         d.setVar('PATH_append', ':' + d.getVar('STAGING_BINDIR_NATIVE') + '/' + sys_multilib)
         d.setVar('TOOLCHAIN_OPTIONS_append', '/../lib32-' + d.getVar("MACHINE"))
-- 
1.9.1

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[Otavio Salvador]

Hello,

On Fri, Jan 16, 2015 at 8:22 AM,  <ting.liu@freescale.com> wrote:
> From: Ting Liu <ting.liu@freescale.com>
>
> If both udev-extraconf and udev-rules-qoriq installed, file clashes
> will happen. move fsl specific rules back to udev-extraconf
>
> Signed-off-by: Ting Liu <ting.liu@freescale.com>
> ---
>  conf/machine/include/qoriq-base.inc                              | 2 +-
>  .../qoriq-ppc/automount.rules                                    | 1 +
>  recipes-core/udev/udev-extraconf_%.bbappend                      | 9 +++++++++
>  recipes-core/udev/udev-rules-qoriq.bb                            | 5 -----
>  4 files changed, 11 insertions(+), 6 deletions(-)
>  rename recipes-core/udev/{udev-rules-qoriq => udev-extraconf}/qoriq-ppc/automount.rules (89%)
>  create mode 100644 recipes-core/udev/udev-extraconf_%.bbappend
>
> diff --git a/conf/machine/include/qoriq-base.inc b/conf/machine/include/qoriq-base.inc
> index 35ca79c..acb4e83 100644
> --- a/conf/machine/include/qoriq-base.inc
> +++ b/conf/machine/include/qoriq-base.inc
> @@ -11,7 +11,7 @@ PREFERRED_VERSION_openssl = "1.0.1i"
>
>  # settings
>  MACHINE_FEATURES = "keyboard pci ext2 ext3 serial"
> -MACHINE_EXTRA_RRECOMMENDS += "udev-rules-qoriq kernel-modules"
> +MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf udev-rules-qoriq kernel-modules"
>  MACHINEOVERRIDES .= ":qoriq-ppc"
>
>  IMAGE_CLASSES += "image_types_uboot"
> diff --git a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
> similarity index 89%
> rename from recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
> rename to recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
> index a47efda..e1d75d7 100644
> --- a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
> +++ b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
> @@ -18,6 +18,7 @@ SUBSYSTEM=="block", ENV{DEVTYPE}=="partition", GOTO="automount_end"
>  # Media automounting
>  SUBSYSTEM=="block", ACTION=="add"    RUN+="/etc/udev/scripts/mount.sh"
>  SUBSYSTEM=="block", ACTION=="remove" RUN+="/etc/udev/scripts/mount.sh"
> +SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1" RUN+="/etc/udev/scripts/mount.sh"

You can avoid this and add a new 'automount-qoriq.rules' file with this.

But could you explain what DISK_MEDIA_CHANGE will handle?

>  LABEL="automount_end"
>
> diff --git a/recipes-core/udev/udev-extraconf_%.bbappend b/recipes-core/udev/udev-extraconf_%.bbappend
> new file mode 100644
> index 0000000..2b09465
> --- /dev/null
> +++ b/recipes-core/udev/udev-extraconf_%.bbappend
> @@ -0,0 +1,9 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${BPN}:"
> +
> +do_install_append_qoriq-ppc () {
> +    # skip mmc rpmb partitions
> +    echo "/dev/mmcblk.*rpmb" >>${D}${sysconfdir}/udev/mount.blacklist

Shouldn't rpmb partitions to be blacklisted in OE-Core?

> +    # skip nbd (network block device)
> +    echo "/dev/nbd*" >>${D}${sysconfdir}/udev/mount.blacklist
> +}

Same here.

> diff --git a/recipes-core/udev/udev-rules-qoriq.bb b/recipes-core/udev/udev-rules-qoriq.bb
> index 546f9e8..6f06c02 100644
> --- a/recipes-core/udev/udev-rules-qoriq.bb
> +++ b/recipes-core/udev/udev-rules-qoriq.bb
> @@ -14,10 +14,5 @@ RULE_t1024 = "72-fsl-dpaa-persistent-networking.rules"
>  do_install () {
>      install -d ${D}${sysconfdir}/udev/rules.d/
>      install -m 0644 ${WORKDIR}/${RULE} ${D}${sysconfdir}/udev/rules.d/
> -
> -    # skip mmc rpmb partitions
> -    echo "/dev/mmcblk.*rpmb" >>${D}${sysconfdir}/udev/mount.blacklist
> -    # skip nbd (network block device)
> -    echo "/dev/nbd*" >>${D}${sysconfdir}/udev/mount.blacklist
>  }
>
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[ting.liu]

> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf
> Of Otavio Salvador
> Sent: Friday, January 16, 2015 7:41 PM
> To: Liu Ting-B28495
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add
> fsl specific rules back
> 
> Hello,
> 
> On Fri, Jan 16, 2015 at 8:22 AM,  <ting.liu@freescale.com> wrote:
> > From: Ting Liu <ting.liu@freescale.com>
> >
> > If both udev-extraconf and udev-rules-qoriq installed, file clashes
> > will happen. move fsl specific rules back to udev-extraconf
> >
> > Signed-off-by: Ting Liu <ting.liu@freescale.com>
> > ---
> >  conf/machine/include/qoriq-base.inc                              | 2 +-
> >  .../qoriq-ppc/automount.rules                                    | 1 +
> >  recipes-core/udev/udev-extraconf_%.bbappend                      | 9
> +++++++++
> >  recipes-core/udev/udev-rules-qoriq.bb                            | 5 -----
> >  4 files changed, 11 insertions(+), 6 deletions(-)  rename
> > recipes-core/udev/{udev-rules-qoriq =>
> > udev-extraconf}/qoriq-ppc/automount.rules (89%)  create mode 100644
> > recipes-core/udev/udev-extraconf_%.bbappend
> >
> > diff --git a/conf/machine/include/qoriq-base.inc
> > b/conf/machine/include/qoriq-base.inc
> > index 35ca79c..acb4e83 100644
> > --- a/conf/machine/include/qoriq-base.inc
> > +++ b/conf/machine/include/qoriq-base.inc
> > @@ -11,7 +11,7 @@ PREFERRED_VERSION_openssl = "1.0.1i"
> >
> >  # settings
> >  MACHINE_FEATURES = "keyboard pci ext2 ext3 serial"
> > -MACHINE_EXTRA_RRECOMMENDS += "udev-rules-qoriq kernel-modules"
> > +MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf udev-rules-qoriq kernel-
> modules"
> >  MACHINEOVERRIDES .= ":qoriq-ppc"
> >
> >  IMAGE_CLASSES += "image_types_uboot"
> > diff --git
> > a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
> > b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
> > similarity index 89%
> > rename from
> > recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
> > rename to recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
> > index a47efda..e1d75d7 100644
> > --- a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
> > +++ b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
> > @@ -18,6 +18,7 @@ SUBSYSTEM=="block", ENV{DEVTYPE}=="partition",
> GOTO="automount_end"
> >  # Media automounting
> >  SUBSYSTEM=="block", ACTION=="add"    RUN+="/etc/udev/scripts/mount.sh"
> >  SUBSYSTEM=="block", ACTION=="remove" RUN+="/etc/udev/scripts/mount.sh"
> > +SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1"
> RUN+="/etc/udev/scripts/mount.sh"
> 
> You can avoid this and add a new 'automount-qoriq.rules' file with this.
[Liu Ting-B28495] will this file override automount.rules completely?

> 
> But could you explain what DISK_MEDIA_CHANGE will handle?
[Liu Ting-B28495] just sync with oe-core updates.

> 
> >  LABEL="automount_end"
> >
> > diff --git a/recipes-core/udev/udev-extraconf_%.bbappend
> > b/recipes-core/udev/udev-extraconf_%.bbappend
> > new file mode 100644
> > index 0000000..2b09465
> > --- /dev/null
> > +++ b/recipes-core/udev/udev-extraconf_%.bbappend
> > @@ -0,0 +1,9 @@
> > +FILESEXTRAPATHS_prepend := "${THISDIR}/${BPN}:"
> > +
> > +do_install_append_qoriq-ppc () {
> > +    # skip mmc rpmb partitions
> > +    echo "/dev/mmcblk.*rpmb" >>${D}${sysconfdir}/udev/mount.blacklist
> 
> Shouldn't rpmb partitions to be blacklisted in OE-Core?
[Liu Ting-B28495] will send the patch to oe-core.

> 
> > +    # skip nbd (network block device)
> > +    echo "/dev/nbd*" >>${D}${sysconfdir}/udev/mount.blacklist
> > +}
> 
> Same here.
> 
> > diff --git a/recipes-core/udev/udev-rules-qoriq.bb
> > b/recipes-core/udev/udev-rules-qoriq.bb
> > index 546f9e8..6f06c02 100644
> > --- a/recipes-core/udev/udev-rules-qoriq.bb
> > +++ b/recipes-core/udev/udev-rules-qoriq.bb
> > @@ -14,10 +14,5 @@ RULE_t1024 = "72-fsl-dpaa-persistent-networking.rules"
> >  do_install () {
> >      install -d ${D}${sysconfdir}/udev/rules.d/
> >      install -m 0644 ${WORKDIR}/${RULE}
> > ${D}${sysconfdir}/udev/rules.d/
> > -
> > -    # skip mmc rpmb partitions
> > -    echo "/dev/mmcblk.*rpmb" >>${D}${sysconfdir}/udev/mount.blacklist
> > -    # skip nbd (network block device)
> > -    echo "/dev/nbd*" >>${D}${sysconfdir}/udev/mount.blacklist
> >  }
> >
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale
> 
> 
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[Otavio Salvador]

Hello,

On Mon, Jan 19, 2015 at 7:44 AM, ting.liu@freescale.com
<ting.liu@freescale.com> wrote:
>> -----Original Message-----
>> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf
>> Of Otavio Salvador
>> Sent: Friday, January 16, 2015 7:41 PM
>> To: Liu Ting-B28495
>> Cc: meta-freescale@yoctoproject.org
>> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add
>> fsl specific rules back
>>
>> Hello,
>>
>> On Fri, Jan 16, 2015 at 8:22 AM,  <ting.liu@freescale.com> wrote:
>> > From: Ting Liu <ting.liu@freescale.com>
>> >
>> > If both udev-extraconf and udev-rules-qoriq installed, file clashes
>> > will happen. move fsl specific rules back to udev-extraconf
>> >
>> > Signed-off-by: Ting Liu <ting.liu@freescale.com>
>> > ---
>> >  conf/machine/include/qoriq-base.inc                              | 2 +-
>> >  .../qoriq-ppc/automount.rules                                    | 1 +
>> >  recipes-core/udev/udev-extraconf_%.bbappend                      | 9
>> +++++++++
>> >  recipes-core/udev/udev-rules-qoriq.bb                            | 5 -----
>> >  4 files changed, 11 insertions(+), 6 deletions(-)  rename
>> > recipes-core/udev/{udev-rules-qoriq =>
>> > udev-extraconf}/qoriq-ppc/automount.rules (89%)  create mode 100644
>> > recipes-core/udev/udev-extraconf_%.bbappend
>> >
>> > diff --git a/conf/machine/include/qoriq-base.inc
>> > b/conf/machine/include/qoriq-base.inc
>> > index 35ca79c..acb4e83 100644
>> > --- a/conf/machine/include/qoriq-base.inc
>> > +++ b/conf/machine/include/qoriq-base.inc
>> > @@ -11,7 +11,7 @@ PREFERRED_VERSION_openssl = "1.0.1i"
>> >
>> >  # settings
>> >  MACHINE_FEATURES = "keyboard pci ext2 ext3 serial"
>> > -MACHINE_EXTRA_RRECOMMENDS += "udev-rules-qoriq kernel-modules"
>> > +MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf udev-rules-qoriq kernel-
>> modules"
>> >  MACHINEOVERRIDES .= ":qoriq-ppc"
>> >
>> >  IMAGE_CLASSES += "image_types_uboot"
>> > diff --git
>> > a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
>> > b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
>> > similarity index 89%
>> > rename from
>> > recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
>> > rename to recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
>> > index a47efda..e1d75d7 100644
>> > --- a/recipes-core/udev/udev-rules-qoriq/qoriq-ppc/automount.rules
>> > +++ b/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules
>> > @@ -18,6 +18,7 @@ SUBSYSTEM=="block", ENV{DEVTYPE}=="partition",
>> GOTO="automount_end"
>> >  # Media automounting
>> >  SUBSYSTEM=="block", ACTION=="add"    RUN+="/etc/udev/scripts/mount.sh"
>> >  SUBSYSTEM=="block", ACTION=="remove" RUN+="/etc/udev/scripts/mount.sh"
>> > +SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1"
>> RUN+="/etc/udev/scripts/mount.sh"
>>
>> You can avoid this and add a new 'automount-qoriq.rules' file with this.
> [Liu Ting-B28495] will this file override automount.rules completely?
>
>>
>> But could you explain what DISK_MEDIA_CHANGE will handle?
> [Liu Ting-B28495] just sync with oe-core updates.

So I am not getting what the package is adding. Is it just the rpmd partitions?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[zhenhua.luo]

Hi Otavio, 

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Monday, January 19, 2015 6:53 PM
> 
> >> >  # Media automounting
> >> >  SUBSYSTEM=="block", ACTION=="add"
> RUN+="/etc/udev/scripts/mount.sh"
> >> >  SUBSYSTEM=="block", ACTION=="remove"
> RUN+="/etc/udev/scripts/mount.sh"
> >> > +SUBSYSTEM=="block", ACTION=="change",
> ENV{DISK_MEDIA_CHANGE}=="1"
> >> RUN+="/etc/udev/scripts/mount.sh"
> >>
> >> You can avoid this and add a new 'automount-qoriq.rules' file with this.
> > [Liu Ting-B28495] will this file override automount.rules completely?
> >
> >>
> >> But could you explain what DISK_MEDIA_CHANGE will handle?
> > [Liu Ting-B28495] just sync with oe-core updates.
[Luo Zhenhua-B19537] DISK_MEDIA_CHANGE environment variable controls if the antomount udev rule will be executed, if it is set to 1, the script will be executed when the change event is triggered for block device. 


Best Regards,

Zhenhua

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[Otavio Salvador]

On Wed, Jan 21, 2015 at 1:59 AM, zhenhua.luo@freescale.com
<zhenhua.luo@freescale.com> wrote:
>> >> But could you explain what DISK_MEDIA_CHANGE will handle?
>> > [Liu Ting-B28495] just sync with oe-core updates.
> [Luo Zhenhua-B19537] DISK_MEDIA_CHANGE environment variable controls if the antomount udev rule will be executed, if it is set to 1, the script will be executed when the change event is triggered for block device.

Great; I am failing to see why it is qoriq specific. It could easily
go to OE-Core. Don't it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[zhenhua.luo]

The line is already in oe-core, the meta-fsl-ppc layer includes a customized automount.sh that is based on oe-core version, the change is just sync the following change from oe-core. 

http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-core/udev/udev-extraconf/automount.rules?id=140d188b3665f914396834168feeff6ffcb64d76


Best Regards,

Zhenhua

> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Wednesday, January 21, 2015 8:31 PM
> To: Luo Zhenhua-B19537
> Cc: Liu Ting-B28495; meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add
> fsl specific rules back
> 
> On Wed, Jan 21, 2015 at 1:59 AM, zhenhua.luo@freescale.com
> <zhenhua.luo@freescale.com> wrote:
> >> >> But could you explain what DISK_MEDIA_CHANGE will handle?
> >> > [Liu Ting-B28495] just sync with oe-core updates.
> > [Luo Zhenhua-B19537] DISK_MEDIA_CHANGE environment variable controls
> if the antomount udev rule will be executed, if it is set to 1, the script will be
> executed when the change event is triggered for block device.
> 
> Great; I am failing to see why it is qoriq specific. It could easily go to OE-Core.
> Don't it?
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-ppc][PATCH 1/2] udev-extraconf: add fsl specific rules back

[Otavio Salvador]

On Wed, Jan 21, 2015 at 11:56 AM, zhenhua.luo@freescale.com
<zhenhua.luo@freescale.com> wrote:
> The line is already in oe-core, the meta-fsl-ppc layer includes a customized automount.sh that is based on oe-core version, the change is just sync the following change from oe-core.
>
> http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-core/udev/udev-extraconf/automount.rules?id=140d188b3665f914396834168feeff6ffcb64d76

We shouldn't duplicate the file in this case. Going deeper in the root
cause why this has been included in meta-fsl-ppc got a nice hint[1]

1. http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-ppc/commit/recipes-core/udev/udev-extraconf/qoriq-ppc/automount.rules?id=06c140cb72406b6d88140ca1085c20352ba193d4

and I think it has been dealt at OE-Core already:

commit 6a7aa9cac2fc128ffc9ea4416426335e06db345a
Author: Otavio Salvador <otavio@ossystems.com.br>
Date:   Mon Apr 22 08:52:29 2013 -0300

    udev-extraconf: Avoid mounting unknown filesystems

    Depending on kernel version used, the system can hung when trying to
    mount the extended partition (not the logical one) as it is a holder
    for other partitions and does not have a filesystem in it.

    To avoid this to happen we just mount partitions when these are using
    known filesystems so it does not try to mount a partition for an
    unsupported filesystem.

    Reported-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>
    Reported-by: Leonardo Sandoval Gonzalez <b42214@freescale.com>
    (From OE-Core rev: 895c9685a7f95dc84786213f945895a504a16254)

    Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
    Tested-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>
    Signed-off-by: Saul Wold <sgw@linux.intel.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Am I missing anything?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750