* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
@ 2014-07-09 19:27 Eric Nelson
2014-07-09 19:40 ` Otavio Salvador
0 siblings, 1 reply; 7+ messages in thread
From: Eric Nelson @ 2014-07-09 19:27 UTC (permalink / raw)
To: u-boot
The pad settings for DISP0_DATA02 and DISP0_DAT10 were not
set in the same way as DISP0_DAT00-23, causing much flicker
in parallel RGB displays on Dual-Lite and Solo processors.
These settings now match the i.MX6 Dual and Quad core versions.
Note that this fixes a regression in commit b47abc3 and that
this is the second time we've had a regression on these two
pads (See commit e654ddf).
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
arch/arm/include/asm/arch-mx6/mx6dl_pins.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h
index 2e414ad..1a9604e 100644
--- a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h
+++ b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h
@@ -158,7 +158,7 @@ MX6_PAD_DECL(DISP0_DAT1__IPU1_DISP0_DATA01, 0x03C8, 0x00B4, 0, 0x0000, 0, PAD_CT
MX6_PAD_DECL(DISP0_DAT1__LCD_DATA01, 0x03C8, 0x00B4, 1, 0x0000, 0, 0)
MX6_PAD_DECL(DISP0_DAT1__ECSPI3_MOSI, 0x03C8, 0x00B4, 2, 0x0000, 0, 0)
MX6_PAD_DECL(DISP0_DAT1__GPIO4_IO22, 0x03C8, 0x00B4, 5, 0x0000, 0, 0)
-MX6_PAD_DECL(DISP0_DAT10__IPU1_DISP0_DATA10, 0x03CC, 0x00B8, 0, 0x0000, 0, 0)
+MX6_PAD_DECL(DISP0_DAT10__IPU1_DISP0_DATA10, 0x03CC, 0x00B8, 0, 0x0000, 0, PAD_CTL_DSE_120ohm)
MX6_PAD_DECL(DISP0_DAT10__LCD_DATA10, 0x03CC, 0x00B8, 1, 0x0000, 0, PAD_CTL_DSE_120ohm)
MX6_PAD_DECL(DISP0_DAT10__GPIO4_IO31, 0x03CC, 0x00B8, 5, 0x0000, 0, 0)
MX6_PAD_DECL(DISP0_DAT11__IPU1_DISP0_DATA11, 0x03D0, 0x00BC, 0, 0x0000, 0, PAD_CTL_DSE_120ohm)
@@ -206,7 +206,7 @@ MX6_PAD_DECL(DISP0_DAT19__AUD5_RXD, 0x03F0, 0x00DC, 3, 0x07B0, 0, 0)
MX6_PAD_DECL(DISP0_DAT19__AUD4_RXC, 0x03F0, 0x00DC, 4, 0x07A0, 0, 0)
MX6_PAD_DECL(DISP0_DAT19__GPIO5_IO13, 0x03F0, 0x00DC, 5, 0x0000, 0, 0)
MX6_PAD_DECL(DISP0_DAT19__EIM_CS3_B, 0x03F0, 0x00DC, 7, 0x0000, 0, 0)
-MX6_PAD_DECL(DISP0_DAT2__IPU1_DISP0_DATA02, 0x03F4, 0x00E0, 0, 0x0000, 0, 0)
+MX6_PAD_DECL(DISP0_DAT2__IPU1_DISP0_DATA02, 0x03F4, 0x00E0, 0, 0x0000, 0, PAD_CTL_DSE_120ohm)
MX6_PAD_DECL(DISP0_DAT2__LCD_DATA02, 0x03F4, 0x00E0, 1, 0x0000, 0, 0)
MX6_PAD_DECL(DISP0_DAT2__ECSPI3_MISO, 0x03F4, 0x00E0, 2, 0x0000, 0, 0)
MX6_PAD_DECL(DISP0_DAT2__GPIO4_IO23, 0x03F4, 0x00E0, 5, 0x0000, 0, 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
2014-07-09 19:27 [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10 Eric Nelson
@ 2014-07-09 19:40 ` Otavio Salvador
2014-07-10 13:20 ` Stefano Babic
0 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2014-07-09 19:40 UTC (permalink / raw)
To: u-boot
On Wed, Jul 9, 2014 at 4:27 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> The pad settings for DISP0_DATA02 and DISP0_DAT10 were not
> set in the same way as DISP0_DAT00-23, causing much flicker
> in parallel RGB displays on Dual-Lite and Solo processors.
>
> These settings now match the i.MX6 Dual and Quad core versions.
>
> Note that this fixes a regression in commit b47abc3 and that
> this is the second time we've had a regression on these two
> pads (See commit e654ddf).
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
Stephano, can it be included in the upcoming release?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
2014-07-09 19:40 ` Otavio Salvador
@ 2014-07-10 13:20 ` Stefano Babic
2014-07-10 13:31 ` Eric Nelson
0 siblings, 1 reply; 7+ messages in thread
From: Stefano Babic @ 2014-07-10 13:20 UTC (permalink / raw)
To: u-boot
Hi Eric, hi Otavio,
On 09/07/2014 21:40, Otavio Salvador wrote:
> On Wed, Jul 9, 2014 at 4:27 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> The pad settings for DISP0_DATA02 and DISP0_DAT10 were not
>> set in the same way as DISP0_DAT00-23, causing much flicker
>> in parallel RGB displays on Dual-Lite and Solo processors.
>>
>> These settings now match the i.MX6 Dual and Quad core versions.
>>
>> Note that this fixes a regression in commit b47abc3 and that
>> this is the second time we've had a regression on these two
>> pads (See commit e654ddf).
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Stephano, can it be included in the upcoming release?
I will try: I merge it and I send a PR to Tom, as I did yesterday.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
2014-07-10 13:20 ` Stefano Babic
@ 2014-07-10 13:31 ` Eric Nelson
0 siblings, 0 replies; 7+ messages in thread
From: Eric Nelson @ 2014-07-10 13:31 UTC (permalink / raw)
To: u-boot
On 07/10/2014 06:20 AM, Stefano Babic wrote:
> Hi Eric, hi Otavio,
>
> On 09/07/2014 21:40, Otavio Salvador wrote:
>> On Wed, Jul 9, 2014 at 4:27 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>> The pad settings for DISP0_DATA02 and DISP0_DAT10 were not
>>> set in the same way as DISP0_DAT00-23, causing much flicker
>>> in parallel RGB displays on Dual-Lite and Solo processors.
>>>
>>
>> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>>
>> Stephano, can it be included in the upcoming release?
>
> I will try: I merge it and I send a PR to Tom, as I did yesterday.
>
Thanks Stefano
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
2013-09-13 16:19 Eric Nelson
2013-09-13 20:41 ` Otavio Salvador
@ 2013-09-20 16:09 ` Stefano Babic
1 sibling, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2013-09-20 16:09 UTC (permalink / raw)
To: u-boot
On 13/09/2013 18:19, Eric Nelson wrote:
> This patch fixes a regression introduced by commit 87d720e0.
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
Applied to u-boot-imx, thanks!
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
2013-09-13 16:19 Eric Nelson
@ 2013-09-13 20:41 ` Otavio Salvador
2013-09-20 16:09 ` Stefano Babic
1 sibling, 0 replies; 7+ messages in thread
From: Otavio Salvador @ 2013-09-13 20:41 UTC (permalink / raw)
To: u-boot
On Fri, Sep 13, 2013 at 1:19 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> This patch fixes a regression introduced by commit 87d720e0.
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10
@ 2013-09-13 16:19 Eric Nelson
2013-09-13 20:41 ` Otavio Salvador
2013-09-20 16:09 ` Stefano Babic
0 siblings, 2 replies; 7+ messages in thread
From: Eric Nelson @ 2013-09-13 16:19 UTC (permalink / raw)
To: u-boot
This patch fixes a regression introduced by commit 87d720e0.
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
arch/arm/include/asm/arch-mx6/mx6dl_pins.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h
index c3d0b70..ad537b4 100644
--- a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h
+++ b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h
@@ -235,7 +235,7 @@ enum {
MX6_PAD_DISP0_DAT1__GPIO_4_22 = IOMUX_PAD(0x03C8, 0x00B4, 5, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT1__MMDC_MMDC_DEBUG_6 = IOMUX_PAD(0x03C8, 0x00B4, 6, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT1__PL301_SIM_MX6DL_PER1_HADDR_12 = IOMUX_PAD(0x03C8, 0x00B4, 7, 0x0000, 0, 0),
- MX6_PAD_DISP0_DAT10__IPU1_DISP0_DAT_10 = IOMUX_PAD(0x03CC, 0x00B8, 0, 0x0000, 0, 0),
+ MX6_PAD_DISP0_DAT10__IPU1_DISP0_DAT_10 = IOMUX_PAD(0x03CC, 0x00B8, 0, 0x0000, 0, PAD_CTL_DSE_120ohm),
MX6_PAD_DISP0_DAT10__LCDIF_DAT_10 = IOMUX_PAD(0x03CC, 0x00B8, 1, 0x0000, 0, PAD_CTL_DSE_120ohm),
MX6_PAD_DISP0_DAT10__USDHC1_USDHC_DEBUG_6 = IOMUX_PAD(0x03CC, 0x00B8, 3, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT10__SDMA_DEBUG_EVENT_CHANNEL_3 = IOMUX_PAD(0x03CC, 0x00B8, 4, 0x0000, 0, 0),
@@ -309,7 +309,7 @@ enum {
MX6_PAD_DISP0_DAT19__GPIO_5_13 = IOMUX_PAD(0x03F0, 0x00DC, 5, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT19__MMDC_MMDC_DEBUG_24 = IOMUX_PAD(0x03F0, 0x00DC, 6, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT19__WEIM_WEIM_CS_3 = IOMUX_PAD(0x03F0, 0x00DC, 7, 0x0000, 0, 0),
- MX6_PAD_DISP0_DAT2__IPU1_DISP0_DAT_2 = IOMUX_PAD(0x03F4, 0x00E0, 0, 0x0000, 0, 0),
+ MX6_PAD_DISP0_DAT2__IPU1_DISP0_DAT_2 = IOMUX_PAD(0x03F4, 0x00E0, 0, 0x0000, 0, PAD_CTL_DSE_120ohm),
MX6_PAD_DISP0_DAT2__LCDIF_DAT_2 = IOMUX_PAD(0x03F4, 0x00E0, 1, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT2__ECSPI3_MISO = IOMUX_PAD(0x03F4, 0x00E0, 2, 0x0000, 0, 0),
MX6_PAD_DISP0_DAT2__USDHC1_USDHC_DEBUG_2 = IOMUX_PAD(0x03F4, 0x00E0, 3, 0x0000, 0, 0),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-07-10 13:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-09 19:27 [U-Boot] [PATCH] i.MX6DL/S: add drive-strength back to pads DISP0_DAT2/DAT10 Eric Nelson
2014-07-09 19:40 ` Otavio Salvador
2014-07-10 13:20 ` Stefano Babic
2014-07-10 13:31 ` Eric Nelson
-- strict thread matches above, loose matches on Subject: below --
2013-09-13 16:19 Eric Nelson
2013-09-13 20:41 ` Otavio Salvador
2013-09-20 16:09 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.