* [U-Boot] [PATCH] mxs: Boost the memory power supply
@ 2013-01-21 22:51 Marek Vasut
2013-01-22 0:44 ` Otavio Salvador
2013-01-22 0:57 ` [U-Boot] [PATCH V2] " Marek Vasut
0 siblings, 2 replies; 8+ messages in thread
From: Marek Vasut @ 2013-01-21 22:51 UTC (permalink / raw)
To: u-boot
The memory power supply on MX23 didn't pump out enough juice into
the DRAM chip, thus caused occasional memory corruption. Fix this.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Stefano Babic <sbabic@denx.de>
---
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ++--
board/olimex/mx23_olinuxino/spl_boot.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
index 5944dd2..836e636 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
@@ -230,7 +230,7 @@ static void mx23_mem_setup_vddmem(void)
struct mxs_power_regs *power_regs =
(struct mxs_power_regs *)MXS_POWER_BASE;
- writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+ writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
POWER_VDDMEMCTRL_ENABLE_ILIMIT |
POWER_VDDMEMCTRL_ENABLE_LINREG |
POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,
@@ -238,7 +238,7 @@ static void mx23_mem_setup_vddmem(void)
early_delay(10000);
- writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+ writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
POWER_VDDMEMCTRL_ENABLE_LINREG,
&power_regs->hw_power_vddmemctrl);
}
diff --git a/board/olimex/mx23_olinuxino/spl_boot.c b/board/olimex/mx23_olinuxino/spl_boot.c
index 3cc40cd..d42bb14 100644
--- a/board/olimex/mx23_olinuxino/spl_boot.c
+++ b/board/olimex/mx23_olinuxino/spl_boot.c
@@ -29,7 +29,7 @@
#include <asm/arch/imx-regs.h>
#include <asm/arch/sys_proto.h>
-#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
+#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_16MA | MXS_PAD_PULLUP)
#define MUX_CONFIG_SSP (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
const iomux_cfg_t iomux_setup[] = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] mxs: Boost the memory power supply
2013-01-21 22:51 [U-Boot] [PATCH] mxs: Boost the memory power supply Marek Vasut
@ 2013-01-22 0:44 ` Otavio Salvador
2013-01-22 0:58 ` Marek Vasut
2013-01-22 0:59 ` Fabio Estevam
2013-01-22 0:57 ` [U-Boot] [PATCH V2] " Marek Vasut
1 sibling, 2 replies; 8+ messages in thread
From: Otavio Salvador @ 2013-01-22 0:44 UTC (permalink / raw)
To: u-boot
On Mon, Jan 21, 2013 at 8:51 PM, Marek Vasut <marex@denx.de> wrote:
> The memory power supply on MX23 didn't pump out enough juice into
> the DRAM chip, thus caused occasional memory corruption. Fix this.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
I did try it in mx23evk and mtest works fine there. However this patch
needs to wait for other MMC changes as it does not apply in current
form.
I will post them soon.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] mxs: Boost the memory power supply
2013-01-22 0:44 ` Otavio Salvador
@ 2013-01-22 0:58 ` Marek Vasut
2013-01-22 0:59 ` Fabio Estevam
1 sibling, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2013-01-22 0:58 UTC (permalink / raw)
To: u-boot
Dear Otavio Salvador,
> On Mon, Jan 21, 2013 at 8:51 PM, Marek Vasut <marex@denx.de> wrote:
> > The memory power supply on MX23 didn't pump out enough juice into
> > the DRAM chip, thus caused occasional memory corruption. Fix this.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Otavio Salvador <otavio@ossystems.com.br>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Stefano Babic <sbabic@denx.de>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> I did try it in mx23evk and mtest works fine there. However this patch
> needs to wait for other MMC changes as it does not apply in current
> form.
Ah right, I rebased it on top of -imx/master. V2 out. Obviously you can not
stall important fixes because of other less important patchset, that makes no
sense. Thus, V2.
Good catch, thanks.
> I will post them soon.
>
> --
> Otavio Salvador O.S. Systems
> E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] mxs: Boost the memory power supply
2013-01-22 0:44 ` Otavio Salvador
2013-01-22 0:58 ` Marek Vasut
@ 2013-01-22 0:59 ` Fabio Estevam
2013-01-22 1:00 ` Otavio Salvador
1 sibling, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2013-01-22 0:59 UTC (permalink / raw)
To: u-boot
Hi Otavio,
On Mon, Jan 21, 2013 at 10:44 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> I did try it in mx23evk and mtest works fine there. However this patch
That's good news. Do you plan to submit mx23evk support?
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH V2] mxs: Boost the memory power supply
2013-01-21 22:51 [U-Boot] [PATCH] mxs: Boost the memory power supply Marek Vasut
2013-01-22 0:44 ` Otavio Salvador
@ 2013-01-22 0:57 ` Marek Vasut
2013-01-22 1:01 ` Otavio Salvador
2013-01-28 5:41 ` Stefano Babic
1 sibling, 2 replies; 8+ messages in thread
From: Marek Vasut @ 2013-01-22 0:57 UTC (permalink / raw)
To: u-boot
The memory power supply on MX23 didn't pump out enough juice into
the DRAM chip, thus caused occasional memory corruption. Fix this.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Stefano Babic <sbabic@denx.de>
---
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ++--
board/olimex/mx23_olinuxino/spl_boot.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
V2: Base this on top of u-boot-imx/master
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
index 5944dd2..836e636 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
@@ -230,7 +230,7 @@ static void mx23_mem_setup_vddmem(void)
struct mxs_power_regs *power_regs =
(struct mxs_power_regs *)MXS_POWER_BASE;
- writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+ writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
POWER_VDDMEMCTRL_ENABLE_ILIMIT |
POWER_VDDMEMCTRL_ENABLE_LINREG |
POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,
@@ -238,7 +238,7 @@ static void mx23_mem_setup_vddmem(void)
early_delay(10000);
- writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+ writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
POWER_VDDMEMCTRL_ENABLE_LINREG,
&power_regs->hw_power_vddmemctrl);
}
diff --git a/board/olimex/mx23_olinuxino/spl_boot.c b/board/olimex/mx23_olinuxino/spl_boot.c
index aaebe6c..6cf669f 100644
--- a/board/olimex/mx23_olinuxino/spl_boot.c
+++ b/board/olimex/mx23_olinuxino/spl_boot.c
@@ -29,7 +29,7 @@
#include <asm/arch/imx-regs.h>
#include <asm/arch/sys_proto.h>
-#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
+#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_16MA | MXS_PAD_PULLUP)
const iomux_cfg_t iomux_setup[] = {
/* DUART */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH V2] mxs: Boost the memory power supply
2013-01-22 0:57 ` [U-Boot] [PATCH V2] " Marek Vasut
@ 2013-01-22 1:01 ` Otavio Salvador
2013-01-28 5:41 ` Stefano Babic
1 sibling, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2013-01-22 1:01 UTC (permalink / raw)
To: u-boot
On Mon, Jan 21, 2013 at 10:57 PM, Marek Vasut <marex@denx.de> wrote:
> The memory power supply on MX23 didn't pump out enough juice into
> the DRAM chip, thus caused occasional memory corruption. Fix this.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH V2] mxs: Boost the memory power supply
2013-01-22 0:57 ` [U-Boot] [PATCH V2] " Marek Vasut
2013-01-22 1:01 ` Otavio Salvador
@ 2013-01-28 5:41 ` Stefano Babic
1 sibling, 0 replies; 8+ messages in thread
From: Stefano Babic @ 2013-01-28 5:41 UTC (permalink / raw)
To: u-boot
On 22/01/2013 01:57, Marek Vasut wrote:
> The memory power supply on MX23 didn't pump out enough juice into
> the DRAM chip, thus caused occasional memory corruption. Fix this.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ++--
> board/olimex/mx23_olinuxino/spl_boot.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> V2: Base this on top of u-boot-imx/master
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-01-28 5:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-21 22:51 [U-Boot] [PATCH] mxs: Boost the memory power supply Marek Vasut
2013-01-22 0:44 ` Otavio Salvador
2013-01-22 0:58 ` Marek Vasut
2013-01-22 0:59 ` Fabio Estevam
2013-01-22 1:00 ` Otavio Salvador
2013-01-22 0:57 ` [U-Boot] [PATCH V2] " Marek Vasut
2013-01-22 1:01 ` Otavio Salvador
2013-01-28 5:41 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.