* perf_3.4 do_compile error
@ 2013-04-10 13:21 Lewis, Nick
2013-04-10 13:35 ` Otavio Salvador
0 siblings, 1 reply; 5+ messages in thread
From: Lewis, Nick @ 2013-04-10 13:21 UTC (permalink / raw)
To: 'meta-freescale@yoctoproject.org'
[-- Attachment #1: Type: text/plain, Size: 3856 bytes --]
The problem is experienced for bitbake fsl-image-test with MACHINE?="imx6qsabrelite"
The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross tools which I mention having read that some host system includes get used during perf arm cross
http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34214
Best Regards
Nick
________________________________
OtavioSalvador<https://community.freescale.com/people/OtavioSalvador> 10-Apr-2013 04:44<https://community.freescale.com/docs/DOC-93844#comment-3877> (in response to Nick Lewis<https://community.freescale.com/docs/DOC-93844#comment-3886>)
Nick Lewis<https://community.freescale.com/people/nicklewis> and Henrik Jacobsen<https://community.freescale.com/people/HenrikJacobsen>, these issues are better discussed and handled if you post them in the mailing list. So we can ask what and how to reproduce the issue and fix it.
Please subscribe there and send an e-mail with the description of the issue, the machine you're building for and how to reproduce it.
________________________________
Nick Lewis<https://community.freescale.com/people/nicklewis> 10-Apr-2013 04:03<https://community.freescale.com/docs/DOC-93844#comment-3886> (in response to Henrik Jacobsen<https://community.freescale.com/docs/DOC-93844#comment-3885>)
Ok I will try adding meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch and meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend with the content from Chunrong Guo and see if this resolves it
________________________________
Henrik Jacobsen<https://community.freescale.com/people/HenrikJacobsen> 10-Apr-2013 03:51<https://community.freescale.com/docs/DOC-93844#comment-3885> (in response to Nick Lewis<https://community.freescale.com/docs/DOC-93844#comment-3883>)
I see the same compile problem with perf. Decided to silently await that someone fixes it
________________________________
Nick Lewis<https://community.freescale.com/people/nicklewis> 10-Apr-2013 03:25<https://community.freescale.com/docs/DOC-93844#comment-3883>
I am experiencing an error during do_compile of perf_3.4
util/include/linux/compiler.h:8:0: error: "__attribute_const__" redefined
There appears to be a patch available to resolve this problem at https://lists.yoctoproject.org/pipermail/yocto/2012-October/012625.html but it does not seem to have been applied to meta-fsl-arm. Can someone explain to me a possible reason why I am seeing this problem (when I assume others are not). Should I apply the patch or may there be a different cause of the problem
________________________________
Nick Lewis
nick.lewis@usa.g4s.com<mailto:nick.lewis@usa.g4s.com>
+44 1684 277137<tel:+441684277137>
www.g4stechnology.com<http://www.g4stechnology.com/>
New Challenge House, International Drive, Tewkesbury, Gloucestershire, GL20 8UQ, UK
P Please consider the environment before printing this email
________________________________
The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.
This communication may contain information which is confidential, personal and/or privileged.
It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.
Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.
Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.
This e-mail has been scanned for all viruses by MessageLabs.
[-- Attachment #2: Type: text/html, Size: 8756 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf_3.4 do_compile error
2013-04-10 13:21 perf_3.4 do_compile error Lewis, Nick
@ 2013-04-10 13:35 ` Otavio Salvador
2013-04-10 22:28 ` Sandoval Gonzalez Leonardo-B42214
[not found] ` <AAE0766F5AF36B46BAB7E0EFB927320630E4A54092@GBTWK10E001.Technology.local>
0 siblings, 2 replies; 5+ messages in thread
From: Otavio Salvador @ 2013-04-10 13:35 UTC (permalink / raw)
To: Lewis, Nick; +Cc: meta-freescale
On Wed, Apr 10, 2013 at 10:21 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
> The problem is experienced for bitbake fsl-image-test with
> MACHINE?=”imx6qsabrelite”
>
> The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross tools
> which I mention having read that some host system includes get used during
> perf arm cross
>
> http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34214
I see; which branch are you using? danny or master?
...
> ________________________________
> The details of this company are as follows:
> G4S Technology Limited, Registered Office: Challenge House, International
> Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No.
> 2382338.
>
> This communication may contain information which is confidential, personal
> and/or privileged.
>
> It is for the exclusive use of the intended recipient(s).
> If you are not the intended recipient(s), please note that any distribution,
> forwarding, copying or use of this communication or the information in it is
> strictly prohibited.
>
> Any personal views expressed in this e-mail are those of the individual
> sender and the company does not endorse or accept responsibility for them.
>
> Prior to taking any action based upon this e-mail message, you should seek
> appropriate confirmation of its authenticity.
>
> This e-mail has been scanned for all viruses by MessageLabs.
Please drop this signature as all information here in the mailing list
is public and not confidential.
Regards,
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf_3.4 do_compile error
2013-04-10 13:35 ` Otavio Salvador
@ 2013-04-10 22:28 ` Sandoval Gonzalez Leonardo-B42214
[not found] ` <AAE0766F5AF36B46BAB7E0EFB927320630E4A54092@GBTWK10E001.Technology.local>
1 sibling, 0 replies; 5+ messages in thread
From: Sandoval Gonzalez Leonardo-B42214 @ 2013-04-10 22:28 UTC (permalink / raw)
To: Otavio Salvador, Lewis, Nick; +Cc: meta-freescale
[-- Attachment #1: Type: text/plain, Size: 3272 bytes --]
This fixes the issue
diff --git a/recipes-kernel/linux/linux-imx-3.0.35/imx6qsabrelite/sync-boundary-changes.patch b/recipes-kernel/linux/linux-imx-3.0.35/imx6qsabrelite/sync-boundary-changes.patch
index 48cf7a7..ac4fcd0 100644
--- a/recipes-kernel/linux/linux-imx-3.0.35/imx6qsabrelite/sync-boundary-changes.patch
+++ b/recipes-kernel/linux/linux-imx-3.0.35/imx6qsabrelite/sync-boundary-changes.patch
@@ -7309,17 +7309,4 @@ index fd05514..45191d1 100644
snd_soc_write(codec, SGTL5000_CHIP_DAC_VOL, 0x6060);
snd_soc_write(codec, SGTL5000_CHIP_ANA_ADC_CTRL,
-diff --git a/tools/perf/util/include/linux/compiler.h b/tools/perf/util/include/linux/compiler.h
-index 547628e..791f9dd 100644
---- a/tools/perf/util/include/linux/compiler.h
-+++ b/tools/perf/util/include/linux/compiler.h
-@@ -5,9 +5,7 @@
- #define __always_inline inline
- #endif
- #define __user
--#ifndef __attribute_const__
- #define __attribute_const__
--#endif
-
- #define __used __attribute__((__unused__))
I will prepare a patch and send it soon.
Leo
________________________________________
From: meta-freescale-bounces@yoctoproject.org [meta-freescale-bounces@yoctoproject.org] on behalf of Otavio Salvador [otavio@ossystems.com.br]
Sent: Wednesday, April 10, 2013 8:35 AM
To: Lewis, Nick
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] perf_3.4 do_compile error
On Wed, Apr 10, 2013 at 10:21 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
> The problem is experienced for bitbake fsl-image-test with
> MACHINE?=”imx6qsabrelite”
>
> The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross tools
> which I mention having read that some host system includes get used during
> perf arm cross
>
> http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34214
I see; which branch are you using? danny or master?
...
> ________________________________
> The details of this company are as follows:
> G4S Technology Limited, Registered Office: Challenge House, International
> Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No.
> 2382338.
>
> This communication may contain information which is confidential, personal
> and/or privileged.
>
> It is for the exclusive use of the intended recipient(s).
> If you are not the intended recipient(s), please note that any distribution,
> forwarding, copying or use of this communication or the information in it is
> strictly prohibited.
>
> Any personal views expressed in this e-mail are those of the individual
> sender and the company does not endorse or accept responsibility for them.
>
> Prior to taking any action based upon this e-mail message, you should seek
> appropriate confirmation of its authenticity.
>
> This e-mail has been scanned for all viruses by MessageLabs.
Please drop this signature as all information here in the mailing list
is public and not confidential.
Regards,
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
_______________________________________________
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale
[-- Attachment #2: Type: text/html, Size: 4025 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: perf_3.4 do_compile error
[not found] ` <CAP9ODKqMzuTz9nRZ49MaMv2rsrnEHGPQay9aga+07qgcYbxcDA@mail.gmail.com>
@ 2013-04-11 7:55 ` Lewis, Nick
2013-04-11 11:34 ` Otavio Salvador
0 siblings, 1 reply; 5+ messages in thread
From: Lewis, Nick @ 2013-04-11 7:55 UTC (permalink / raw)
To: 'Otavio Salvador'; +Cc: 'meta-freescale@yoctoproject.org'
>>>> The problem is experienced for bitbake fsl-image-test with
>>>> MACHINE?="imx6qsabrelite"
>>>>
>>>> The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross
>>>> tools which I mention having read that some host system includes get
>>>> used during perf arm cross
>>>>
>>>> http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34
>>>> 21
>>>> 4
>>>
>>>I see; which branch are you using? danny or master?
>>
>> Are you able to reproduce this or is the problem limited to specific host systems?
>>
>> A variation of the patch by Chunrong Guo resolves the problem for me
>
>I've been working in master but please send your patch and we can review it. Before merging it I will try to reproduce the issue.
Please find patch below
diff -urN a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch
--- a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch 1969-12-31 16:00:00.000000000 -0800
+++ b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch 2013-04-10 07:18:57.314214319 -0700
@@ -0,0 +1,12 @@
+--- a/tools/perf/util/include/linux/compiler.h 2013-04-04 17:55:08.000000000 -0700
++++ b/tools/perf/util/include/linux/compiler.h 2013-04-10 07:16:36.711981928 -0700
+@@ -5,7 +5,9 @@
+ #define __always_inline inline
+ #endif
+ #define __user
++#ifndef __attribute_const__
+ #define __attribute_const__
++#endif
+
+ #define __used __attribute__((__unused__))
+
diff -urN a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend
--- a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend 1969-12-31 16:00:00.000000000 -0800
+++ b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend 2013-04-11 00:40:13.615799995 -0700
@@ -0,0 +1,3 @@
+PRINC := "${@int(PRINC) + 1}"
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
+SRC_URI_append = "file://define-attribute-const.patch "
--
Nick
The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.
This communication may contain information which is confidential, personal and/or privileged.
It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.
Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.
Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.
This e-mail has been scanned for all viruses by MessageLabs.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf_3.4 do_compile error
2013-04-11 7:55 ` Lewis, Nick
@ 2013-04-11 11:34 ` Otavio Salvador
0 siblings, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2013-04-11 11:34 UTC (permalink / raw)
To: Lewis, Nick; +Cc: meta-freescale
On Thu, Apr 11, 2013 at 4:55 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
>>>>> The problem is experienced for bitbake fsl-image-test with
>>>>> MACHINE?="imx6qsabrelite"
>>>>>
>>>>> The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross
>>>>> tools which I mention having read that some host system includes get
>>>>> used during perf arm cross
>>>>>
>>>>> http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34
>>>>> 21
>>>>> 4
>>>>
>>>>I see; which branch are you using? danny or master?
>>>
>>> Are you able to reproduce this or is the problem limited to specific host systems?
>>>
>>> A variation of the patch by Chunrong Guo resolves the problem for me
>>
>>I've been working in master but please send your patch and we can review it. Before merging it I will try to reproduce the issue.
>
> Please find patch below
>
>
>
>
> diff -urN a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch
> --- a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch 1969-12-31 16:00:00.000000000 -0800
> +++ b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch 2013-04-10 07:18:57.314214319 -0700
> @@ -0,0 +1,12 @@
> +--- a/tools/perf/util/include/linux/compiler.h 2013-04-04 17:55:08.000000000 -0700
> ++++ b/tools/perf/util/include/linux/compiler.h 2013-04-10 07:16:36.711981928 -0700
> +@@ -5,7 +5,9 @@
> + #define __always_inline inline
> + #endif
> + #define __user
> ++#ifndef __attribute_const__
> + #define __attribute_const__
> ++#endif
> +
> + #define __used __attribute__((__unused__))
> +
> diff -urN a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend
> --- a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend 1969-12-31 16:00:00.000000000 -0800
> +++ b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend 2013-04-11 00:40:13.615799995 -0700
> @@ -0,0 +1,3 @@
> +PRINC := "${@int(PRINC) + 1}"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> +SRC_URI_append = "file://define-attribute-const.patch "
Leonardo has sent a patch which fixes this issue. The root cause of it
is the sync patch we did with Boundary Devices and which hadn't
include this fix. Leonardo has removed this patch hunk and it should
fix the issue. The change comes from linux-imx source as the perf is
build using same kernel source so these match.
I hope it is clear but please ask if you missed something.
Regards,
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-11 11:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-10 13:21 perf_3.4 do_compile error Lewis, Nick
2013-04-10 13:35 ` Otavio Salvador
2013-04-10 22:28 ` Sandoval Gonzalez Leonardo-B42214
[not found] ` <AAE0766F5AF36B46BAB7E0EFB927320630E4A54092@GBTWK10E001.Technology.local>
[not found] ` <CAP9ODKqMzuTz9nRZ49MaMv2rsrnEHGPQay9aga+07qgcYbxcDA@mail.gmail.com>
2013-04-11 7:55 ` Lewis, Nick
2013-04-11 11:34 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.