* [PATCH] mesa: link mesautil with pthreads
@ 2018-01-22 16:56 Randy MacLeod
2018-01-22 17:05 ` ✗ patchtest: failure for mesa: link mesautil with pthreads (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Randy MacLeod @ 2018-01-22 16:56 UTC (permalink / raw)
To: openembedded-core
Cherry-pick fix from mesa upstream:
23ce168048 link mesautil with pthreads
link mesautil with pthreads to avoid:
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid'
collect2: error: ld returned 1 exit status
Upstream-Status: backport
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
.../files/0001-link-mesautil-with-pthreads.patch | 51 ++++++++++++++++++++++
meta/recipes-graphics/mesa/mesa_17.3.3.bb | 1 +
2 files changed, 52 insertions(+)
create mode 100644 meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
diff --git a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
new file mode 100644
index 0000000000..193c54661b
--- /dev/null
+++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
@@ -0,0 +1,51 @@
+From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
+From: Igor Gnatenko <ignatenko@redhat.com>
+Date: Mon, 1 Jan 2018 22:49:00 +0100
+Subject: [PATCH] link mesautil with pthreads
+
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid'
+collect2: error: ld returned 1 exit status
+
+Reviewed-by: Adam Jackson <ajax@redhat.com>
+Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
+---
+ src/util/Makefile.am | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/util/Makefile.am b/src/util/Makefile.am
+index a5241ad27b..633907b9fd 100644
+--- a/src/util/Makefile.am
++++ b/src/util/Makefile.am
+@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
+ libxmlconfig.la
+
+ AM_CPPFLAGS = \
++ $(PTHREAD_CFLAGS) \
+ -I$(top_srcdir)/include
+
+ libmesautil_la_CPPFLAGS = \
+@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
+ $(MESA_UTIL_GENERATED_FILES)
+
+ libmesautil_la_LIBADD = \
++ $(PTHREAD_LIBS) \
+ $(CLOCK_LIB) \
+ $(ZLIB_LIBS) \
+ $(LIBATOMIC_LIBS)
+--
+2.14.3
+
diff --git a/meta/recipes-graphics/mesa/mesa_17.3.3.bb b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
index 6e3f29a2c4..623046e116 100644
--- a/meta/recipes-graphics/mesa/mesa_17.3.3.bb
+++ b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
@@ -10,6 +10,7 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
file://0001-winsys-svga-drm-Include-sys-types.h.patch \
file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
file://0001-anv_icd.py-improve-reproducible-builds.patch \
+ file://0001-link-mesautil-with-pthreads.patch \
"
SRC_URI[md5sum] = "139b5f608b371c0d4395596162f88791"
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ patchtest: failure for mesa: link mesautil with pthreads (rev2)
2018-01-22 16:56 [PATCH] mesa: link mesautil with pthreads Randy MacLeod
@ 2018-01-22 17:05 ` Patchwork
2018-01-22 17:16 ` [PATCH] mesa: link mesautil with pthreads Burton, Ross
2018-01-23 1:37 ` Otavio Salvador
2 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-01-22 17:05 UTC (permalink / raw)
To: Randy MacLeod; +Cc: openembedded-core
== Series Details ==
Series: mesa: link mesautil with pthreads (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/10634/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence_format]
Suggested fix Add Upstream-Status: <Valid status> to the header of meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
Standard format Upstream-Status: <Valid status>
Valid status Pending, Accepted, Backport, Denied, Inappropriate [reason], Submitted [where]
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mesa: link mesautil with pthreads
2018-01-22 16:56 [PATCH] mesa: link mesautil with pthreads Randy MacLeod
2018-01-22 17:05 ` ✗ patchtest: failure for mesa: link mesautil with pthreads (rev2) Patchwork
@ 2018-01-22 17:16 ` Burton, Ross
2018-01-22 19:19 ` Randy MacLeod
2018-01-23 1:37 ` Otavio Salvador
2 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2018-01-22 17:16 UTC (permalink / raw)
To: Randy MacLeod; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 6466 bytes --]
Upstream-Status tag needs to be in the patch you add, not the commit
message.
Ross
On 22 January 2018 at 16:56, Randy MacLeod <Randy.MacLeod@windriver.com>
wrote:
> Cherry-pick fix from mesa upstream:
> 23ce168048 link mesautil with pthreads
>
> link mesautil with pthreads to avoid:
>
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_setname':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `thrd_join':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `thrd_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `call_once':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_get_time_nano':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> collect2: error: ld returned 1 exit status
>
> Upstream-Status: backport
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
> .../files/0001-link-mesautil-with-pthreads.patch | 51
> ++++++++++++++++++++++
> meta/recipes-graphics/mesa/mesa_17.3.3.bb | 1 +
> 2 files changed, 52 insertions(+)
> create mode 100644 meta/recipes-graphics/mesa/
> files/0001-link-mesautil-with-pthreads.patch
>
> diff --git a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 0000000000..193c54661b
> --- /dev/null
> +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-
> pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko <ignatenko@redhat.com>
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson <ajax@redhat.com>
> +Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
> ++++ b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> + libxmlconfig.la
> +
> + AM_CPPFLAGS = \
> ++ $(PTHREAD_CFLAGS) \
> + -I$(top_srcdir)/include
> +
> + libmesautil_la_CPPFLAGS = \
> +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> + $(MESA_UTIL_GENERATED_FILES)
> +
> + libmesautil_la_LIBADD = \
> ++ $(PTHREAD_LIBS) \
> + $(CLOCK_LIB) \
> + $(ZLIB_LIBS) \
> + $(LIBATOMIC_LIBS)
> +--
> +2.14.3
> +
> diff --git a/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> index 6e3f29a2c4..623046e116 100644
> --- a/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> +++ b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> @@ -10,6 +10,7 @@ SRC_URI = "https://mesa.freedesktop.org/
> archive/mesa-${PV}.tar.xz \
> file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch
> \
> file://0001-anv_icd.py-improve-reproducible-builds.patch \
> + file://0001-link-mesautil-with-pthreads.patch \
> "
>
> SRC_URI[md5sum] = "139b5f608b371c0d4395596162f88791"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 8760 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mesa: link mesautil with pthreads
2018-01-22 17:16 ` [PATCH] mesa: link mesautil with pthreads Burton, Ross
@ 2018-01-22 19:19 ` Randy MacLeod
0 siblings, 0 replies; 9+ messages in thread
From: Randy MacLeod @ 2018-01-22 19:19 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2018-01-22 12:16 PM, Burton, Ross wrote:
> Upstream-Status tag needs to be in the patch you add, not the commit
> message.
>
> Ross
Picky, picky! :)
Done.
Next patch, I'll see if local patchtest check works now.
Last time I tried using it, it was busted.
../Randy
>
> On 22 January 2018 at 16:56, Randy MacLeod <Randy.MacLeod@windriver.com
> <mailto:Randy.MacLeod@windriver.com>> wrote:
>
> Cherry-pick fix from mesa upstream:
> 23ce168048 link mesautil with pthreads
>
> link mesautil with pthreads to avoid:
>
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> collect2: error: ld returned 1 exit status
>
> Upstream-Status: backport
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com
> <mailto:Randy.MacLeod@windriver.com>>
> ---
> .../files/0001-link-mesautil-with-pthreads.patch | 51
> ++++++++++++++++++++++
> meta/recipes-graphics/mesa/mesa_17.3.3.bb <http://mesa_17.3.3.bb>
> | 1 +
> 2 files changed, 52 insertions(+)
> create mode 100644
> meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
>
> diff --git
> a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 0000000000..193c54661b
> --- /dev/null
> +++
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko <ignatenko@redhat.com
> <mailto:ignatenko@redhat.com>>
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson <ajax@redhat.com <mailto:ajax@redhat.com>>
> +Signed-off-by: Igor Gnatenko <ignatenko@redhat.com
> <mailto:ignatenko@redhat.com>>
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
> ++++ b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> + libxmlconfig.la <http://libxmlconfig.la>
> +
> + AM_CPPFLAGS = \
> ++ $(PTHREAD_CFLAGS) \
> + -I$(top_srcdir)/include
> +
> + libmesautil_la_CPPFLAGS = \
> +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> + $(MESA_UTIL_GENERATED_FILES)
> +
> + libmesautil_la_LIBADD = \
> ++ $(PTHREAD_LIBS) \
> + $(CLOCK_LIB) \
> + $(ZLIB_LIBS) \
> + $(LIBATOMIC_LIBS)
> +--
> +2.14.3
> +
> diff --git a/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> <http://mesa_17.3.3.bb> b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> <http://mesa_17.3.3.bb>
> index 6e3f29a2c4..623046e116 100644
> --- a/meta/recipes-graphics/mesa/mesa_17.3.3.bb <http://mesa_17.3.3.bb>
> +++ b/meta/recipes-graphics/mesa/mesa_17.3.3.bb <http://mesa_17.3.3.bb>
> @@ -10,6 +10,7 @@ SRC_URI =
> "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
> <https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz> \
> file://0001-winsys-svga-drm-Include-sys-types.h.patch \
>
> file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
> file://0001-anv_icd.py-improve-reproducible-builds.patch \
> + file://0001-link-mesautil-with-pthreads.patch \
> "
>
> SRC_URI[md5sum] = "139b5f608b371c0d4395596162f88791"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>
--
# Randy MacLeod. WR Linux
# Wind River an Intel Company
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mesa: link mesautil with pthreads
2018-01-22 16:56 [PATCH] mesa: link mesautil with pthreads Randy MacLeod
2018-01-22 17:05 ` ✗ patchtest: failure for mesa: link mesautil with pthreads (rev2) Patchwork
2018-01-22 17:16 ` [PATCH] mesa: link mesautil with pthreads Burton, Ross
@ 2018-01-23 1:37 ` Otavio Salvador
2 siblings, 0 replies; 9+ messages in thread
From: Otavio Salvador @ 2018-01-23 1:37 UTC (permalink / raw)
To: Randy MacLeod; +Cc: Patches and discussions about the oe-core layer
On Mon, Jan 22, 2018 at 2:56 PM, Randy MacLeod
<Randy.MacLeod@windriver.com> wrote:
> Cherry-pick fix from mesa upstream:
> 23ce168048 link mesautil with pthreads
>
> link mesautil with pthreads to avoid:
>
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid'
> collect2: error: ld returned 1 exit status
>
> Upstream-Status: backport
This goes in the patch file.
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
> .../files/0001-link-mesautil-with-pthreads.patch | 51 ++++++++++++++++++++++
> meta/recipes-graphics/mesa/mesa_17.3.3.bb | 1 +
> 2 files changed, 52 insertions(+)
> create mode 100644 meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
>
> diff --git a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 0000000000..193c54661b
> --- /dev/null
> +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko <ignatenko@redhat.com>
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson <ajax@redhat.com>
> +Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
> ++++ b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> + libxmlconfig.la
> +
> + AM_CPPFLAGS = \
> ++ $(PTHREAD_CFLAGS) \
> + -I$(top_srcdir)/include
> +
> + libmesautil_la_CPPFLAGS = \
> +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> + $(MESA_UTIL_GENERATED_FILES)
> +
> + libmesautil_la_LIBADD = \
> ++ $(PTHREAD_LIBS) \
> + $(CLOCK_LIB) \
> + $(ZLIB_LIBS) \
> + $(LIBATOMIC_LIBS)
> +--
> +2.14.3
> +
> diff --git a/meta/recipes-graphics/mesa/mesa_17.3.3.bb b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> index 6e3f29a2c4..623046e116 100644
> --- a/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> +++ b/meta/recipes-graphics/mesa/mesa_17.3.3.bb
> @@ -10,6 +10,7 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
> file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
> file://0001-anv_icd.py-improve-reproducible-builds.patch \
> + file://0001-link-mesautil-with-pthreads.patch \
> "
>
> SRC_URI[md5sum] = "139b5f608b371c0d4395596162f88791"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mesa: link mesautil with pthreads
2018-01-22 11:05 ` Burton, Ross
@ 2018-01-22 14:36 ` Randy MacLeod
0 siblings, 0 replies; 9+ messages in thread
From: Randy MacLeod @ 2018-01-22 14:36 UTC (permalink / raw)
To: Burton, Ross, Otavio Salvador
Cc: Patches and discussions about the oe-core layer
On 2018-01-22 06:05 AM, Burton, Ross wrote:
> Yes 17.3.3 is in master now, so can you rebase Randy?
Sure.
../Randy
>
> Ross
>
> On 21 January 2018 at 21:34, Otavio Salvador
> <otavio.salvador@ossystems.com.br
> <mailto:otavio.salvador@ossystems.com.br>> wrote:
>
> On Sun, Jan 21, 2018 at 4:18 AM, Randy MacLeod
> <Randy.MacLeod@windriver.com <mailto:Randy.MacLeod@windriver.com>>
> wrote:
> > Cherry-pick fix from mesa upstream:
> > 23ce168048 link mesautil with pthreads
> >
> > Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com <mailto:Randy.MacLeod@windriver.com>>
>
> Missing Upstream-Status. Also, base it on 17.3.3 recipe so we avoid
> another patch revision.
>
> > ---
> > .../files/0001-link-mesautil-with-pthreads.patch | 51
> ++++++++++++++++++++++
> > meta/recipes-graphics/mesa/mesa_17.3.2.bb
> <http://mesa_17.3.2.bb> | 1 +
> > 2 files changed, 52 insertions(+)
> > create mode 100644
> meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> >
> > diff --git
> a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> > new file mode 100644
> > index 0000000000..193c54661b
> > --- /dev/null
> > +++
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> > @@ -0,0 +1,51 @@
> > +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17
> 00:00:00 2001
> > +From: Igor Gnatenko <ignatenko@redhat.com
> <mailto:ignatenko@redhat.com>>
> > +Date: Mon, 1 Jan 2018 22:49:00 +0100
> > +Subject: [PATCH] link mesautil with pthreads
> > +
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> >
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> > +collect2: error: ld returned 1 exit status
> > +
> > +Reviewed-by: Adam Jackson <ajax@redhat.com <mailto:ajax@redhat.com>>
> > +Signed-off-by: Igor Gnatenko <ignatenko@redhat.com
> <mailto:ignatenko@redhat.com>>
> > +---
> > + src/util/Makefile.am | 2 ++
> > + 1 file changed, 2 insertions(+)
> > +
> > +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> > +index a5241ad27b..633907b9fd 100644
> > +--- a/src/util/Makefile.am
> > ++++ b/src/util/Makefile.am
> > +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> > + libxmlconfig.la <http://libxmlconfig.la>
> > +
> > + AM_CPPFLAGS = \
> > ++ $(PTHREAD_CFLAGS) \
> > + -I$(top_srcdir)/include
> > +
> > + libmesautil_la_CPPFLAGS = \
> > +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> > + $(MESA_UTIL_GENERATED_FILES)
> > +
> > + libmesautil_la_LIBADD = \
> > ++ $(PTHREAD_LIBS) \
> > + $(CLOCK_LIB) \
> > + $(ZLIB_LIBS) \
> > + $(LIBATOMIC_LIBS)
> > +--
> > +2.14.3
> > +
> > diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> <http://mesa_17.3.2.bb> b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> <http://mesa_17.3.2.bb>
> > index 9e9b23322a..8cdcf6c84f 100644
> > --- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> <http://mesa_17.3.2.bb>
> > +++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> <http://mesa_17.3.2.bb>
> > @@ -9,6 +9,7 @@ SRC_URI =
> "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
> <https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz> \
> > file://llvm-config-version.patch \
> > file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> >
> file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
> > + file://0001-link-mesautil-with-pthreads.patch \
> > "
> >
> > SRC_URI[md5sum] = "5c59b779925f504ffd0f13c7dcd29ac6"
> > --
> > 2.11.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854 <tel:%2B55%20%2853%29%209981-7854>
> Mobile: +1 (347) 903-9750 <tel:%2B1%20%28347%29%20903-9750>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>
--
# Randy MacLeod. WR Linux
# Wind River an Intel Company
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mesa: link mesautil with pthreads
2018-01-21 21:34 ` Otavio Salvador
@ 2018-01-22 11:05 ` Burton, Ross
2018-01-22 14:36 ` Randy MacLeod
0 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2018-01-22 11:05 UTC (permalink / raw)
To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 5405 bytes --]
Yes 17.3.3 is in master now, so can you rebase Randy?
Ross
On 21 January 2018 at 21:34, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:
> On Sun, Jan 21, 2018 at 4:18 AM, Randy MacLeod
> <Randy.MacLeod@windriver.com> wrote:
> > Cherry-pick fix from mesa upstream:
> > 23ce168048 link mesautil with pthreads
> >
> > Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>
> Missing Upstream-Status. Also, base it on 17.3.3 recipe so we avoid
> another patch revision.
>
> > ---
> > .../files/0001-link-mesautil-with-pthreads.patch | 51
> ++++++++++++++++++++++
> > meta/recipes-graphics/mesa/mesa_17.3.2.bb | 1 +
> > 2 files changed, 52 insertions(+)
> > create mode 100644 meta/recipes-graphics/mesa/
> files/0001-link-mesautil-with-pthreads.patch
> >
> > diff --git a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> > new file mode 100644
> > index 0000000000..193c54661b
> > --- /dev/null
> > +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-
> pthreads.patch
> > @@ -0,0 +1,51 @@
> > +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> > +From: Igor Gnatenko <ignatenko@redhat.com>
> > +Date: Mon, 1 Jan 2018 22:49:00 +0100
> > +Subject: [PATCH] link mesautil with pthreads
> > +
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> > +collect2: error: ld returned 1 exit status
> > +
> > +Reviewed-by: Adam Jackson <ajax@redhat.com>
> > +Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
> > +---
> > + src/util/Makefile.am | 2 ++
> > + 1 file changed, 2 insertions(+)
> > +
> > +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> > +index a5241ad27b..633907b9fd 100644
> > +--- a/src/util/Makefile.am
> > ++++ b/src/util/Makefile.am
> > +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> > + libxmlconfig.la
> > +
> > + AM_CPPFLAGS = \
> > ++ $(PTHREAD_CFLAGS) \
> > + -I$(top_srcdir)/include
> > +
> > + libmesautil_la_CPPFLAGS = \
> > +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> > + $(MESA_UTIL_GENERATED_FILES)
> > +
> > + libmesautil_la_LIBADD = \
> > ++ $(PTHREAD_LIBS) \
> > + $(CLOCK_LIB) \
> > + $(ZLIB_LIBS) \
> > + $(LIBATOMIC_LIBS)
> > +--
> > +2.14.3
> > +
> > diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> > index 9e9b23322a..8cdcf6c84f 100644
> > --- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> > +++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> > @@ -9,6 +9,7 @@ SRC_URI = "https://mesa.freedesktop.org/
> archive/mesa-${PV}.tar.xz \
> > file://llvm-config-version.patch \
> > file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> > file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch
> \
> > + file://0001-link-mesautil-with-pthreads.patch \
> > "
> >
> > SRC_URI[md5sum] = "5c59b779925f504ffd0f13c7dcd29ac6"
> > --
> > 2.11.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 8197 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mesa: link mesautil with pthreads
2018-01-21 6:18 Randy MacLeod
@ 2018-01-21 21:34 ` Otavio Salvador
2018-01-22 11:05 ` Burton, Ross
0 siblings, 1 reply; 9+ messages in thread
From: Otavio Salvador @ 2018-01-21 21:34 UTC (permalink / raw)
To: Randy MacLeod; +Cc: Patches and discussions about the oe-core layer
On Sun, Jan 21, 2018 at 4:18 AM, Randy MacLeod
<Randy.MacLeod@windriver.com> wrote:
> Cherry-pick fix from mesa upstream:
> 23ce168048 link mesautil with pthreads
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Missing Upstream-Status. Also, base it on 17.3.3 recipe so we avoid
another patch revision.
> ---
> .../files/0001-link-mesautil-with-pthreads.patch | 51 ++++++++++++++++++++++
> meta/recipes-graphics/mesa/mesa_17.3.2.bb | 1 +
> 2 files changed, 52 insertions(+)
> create mode 100644 meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
>
> diff --git a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 0000000000..193c54661b
> --- /dev/null
> +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko <ignatenko@redhat.com>
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson <ajax@redhat.com>
> +Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
> ++++ b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> + libxmlconfig.la
> +
> + AM_CPPFLAGS = \
> ++ $(PTHREAD_CFLAGS) \
> + -I$(top_srcdir)/include
> +
> + libmesautil_la_CPPFLAGS = \
> +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> + $(MESA_UTIL_GENERATED_FILES)
> +
> + libmesautil_la_LIBADD = \
> ++ $(PTHREAD_LIBS) \
> + $(CLOCK_LIB) \
> + $(ZLIB_LIBS) \
> + $(LIBATOMIC_LIBS)
> +--
> +2.14.3
> +
> diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> index 9e9b23322a..8cdcf6c84f 100644
> --- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> +++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> @@ -9,6 +9,7 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
> file://llvm-config-version.patch \
> file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
> + file://0001-link-mesautil-with-pthreads.patch \
> "
>
> SRC_URI[md5sum] = "5c59b779925f504ffd0f13c7dcd29ac6"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] mesa: link mesautil with pthreads
@ 2018-01-21 6:18 Randy MacLeod
2018-01-21 21:34 ` Otavio Salvador
0 siblings, 1 reply; 9+ messages in thread
From: Randy MacLeod @ 2018-01-21 6:18 UTC (permalink / raw)
To: openembedded-core
Cherry-pick fix from mesa upstream:
23ce168048 link mesautil with pthreads
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
.../files/0001-link-mesautil-with-pthreads.patch | 51 ++++++++++++++++++++++
meta/recipes-graphics/mesa/mesa_17.3.2.bb | 1 +
2 files changed, 52 insertions(+)
create mode 100644 meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
diff --git a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
new file mode 100644
index 0000000000..193c54661b
--- /dev/null
+++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
@@ -0,0 +1,51 @@
+From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
+From: Igor Gnatenko <ignatenko@redhat.com>
+Date: Mon, 1 Jan 2018 22:49:00 +0100
+Subject: [PATCH] link mesautil with pthreads
+
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_setname':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: undefined reference to `pthread_setname_np'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_join':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336: undefined reference to `pthread_join'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `thrd_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296: undefined reference to `pthread_create'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: undefined reference to `pthread_sigmask'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `call_once':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function `u_thread_get_time_nano':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: undefined reference to `pthread_getcpuclockid'
+collect2: error: ld returned 1 exit status
+
+Reviewed-by: Adam Jackson <ajax@redhat.com>
+Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
+---
+ src/util/Makefile.am | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/util/Makefile.am b/src/util/Makefile.am
+index a5241ad27b..633907b9fd 100644
+--- a/src/util/Makefile.am
++++ b/src/util/Makefile.am
+@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
+ libxmlconfig.la
+
+ AM_CPPFLAGS = \
++ $(PTHREAD_CFLAGS) \
+ -I$(top_srcdir)/include
+
+ libmesautil_la_CPPFLAGS = \
+@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
+ $(MESA_UTIL_GENERATED_FILES)
+
+ libmesautil_la_LIBADD = \
++ $(PTHREAD_LIBS) \
+ $(CLOCK_LIB) \
+ $(ZLIB_LIBS) \
+ $(LIBATOMIC_LIBS)
+--
+2.14.3
+
diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
index 9e9b23322a..8cdcf6c84f 100644
--- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
+++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
@@ -9,6 +9,7 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
file://llvm-config-version.patch \
file://0001-winsys-svga-drm-Include-sys-types.h.patch \
file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
+ file://0001-link-mesautil-with-pthreads.patch \
"
SRC_URI[md5sum] = "5c59b779925f504ffd0f13c7dcd29ac6"
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-23 1:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 16:56 [PATCH] mesa: link mesautil with pthreads Randy MacLeod
2018-01-22 17:05 ` ✗ patchtest: failure for mesa: link mesautil with pthreads (rev2) Patchwork
2018-01-22 17:16 ` [PATCH] mesa: link mesautil with pthreads Burton, Ross
2018-01-22 19:19 ` Randy MacLeod
2018-01-23 1:37 ` Otavio Salvador
-- strict thread matches above, loose matches on Subject: below --
2018-01-21 6:18 Randy MacLeod
2018-01-21 21:34 ` Otavio Salvador
2018-01-22 11:05 ` Burton, Ross
2018-01-22 14:36 ` Randy MacLeod
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.