* [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency
@ 2020-05-04 14:10 Jens Rehsack
2020-05-04 14:21 ` Otavio Salvador
0 siblings, 1 reply; 5+ messages in thread
From: Jens Rehsack @ 2020-05-04 14:10 UTC (permalink / raw)
To: openembedded-core; +Cc: Anuj Mittal, Jens Rehsack
With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
Author: Yue Tao <Yue.Tao@windriver.com>
Date: Fri May 25 10:48:08 2018 +0800
initscripts: Avoid starting rpcbind daemon twice
Check the status before start it to avoid duplicates.
the use of a script {/usr/sbin/}service is introduced - maybe earlier
provided by systemd, nowadays mostly by init-system-helpers from
debian project.
For the very first shot, maybe discussions and improvements based
on that script collection, use just the init-system-helpers-service
in initscripts/mountnfs.sh to avoid problems mounting NFS in later
boot stage.
Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
meta/conf/distro/include/maintainers.inc | 1 +
.../initscripts/init-system-helpers_1.57.bb | 51 +++++++++++++++++++
.../initscripts/initscripts_1.0.bb | 1 +
3 files changed, 53 insertions(+)
create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb
diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 340cda3300..9afc676031 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -266,6 +266,7 @@ RECIPE_MAINTAINER_pn-icu = "Alexander Kanavin <alex.kanavin@gmail.com>"
RECIPE_MAINTAINER_pn-ifupdown = "Anuj Mittal <anuj.mittal@intel.com>"
RECIPE_MAINTAINER_pn-inetutils = "Tom Rini <trini@konsulko.com>"
RECIPE_MAINTAINER_pn-init-ifupdown = "Anuj Mittal <anuj.mittal@intel.com>"
+RECIPE_MAINTAINER_pn-init-system-helpers = "Anuj Mittal <anuj.mittal@intel.com>"
RECIPE_MAINTAINER_pn-initramfs-boot = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
RECIPE_MAINTAINER_pn-initramfs-framework = "Otavio Salvador <otavio.salvador@ossystems.com.br>"
RECIPE_MAINTAINER_pn-initramfs-live-boot = "Anuj Mittal <anuj.mittal@intel.com>"
diff --git a/meta/recipes-core/initscripts/init-system-helpers_1.57.bb b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
new file mode 100644
index 0000000000..2f7df87e1e
--- /dev/null
+++ b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
@@ -0,0 +1,51 @@
+SUMMARY = "helper tools for all init systems"
+DESCRIPTION = "This package contains helper tools that are necessary for switching between \
+the various init systems that Debian contains (e. g. sysvinit or \
+systemd). An example is deb-systemd-helper, a script that enables systemd unit \
+files without depending on a running systemd. \
+\
+It also includes the \"service\", \"invoke-rc.d\", and \"update-rc.d\" scripts which \
+provide an abstraction for enabling, disabling, starting, and stopping \
+services for all supported Debian init systems as specified by the policy. \
+\
+While this package is maintained by pkg-systemd-maintainers, it is NOT \
+specific to systemd at all. Maintainers of other init systems are welcome to \
+include their helpers in this package."
+HOMEPAGE = "https://salsa.debian.org/debian/init-system-helpers"
+SECTION = "base"
+LICENSE = "BSD-3-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://debian/copyright;md5=ee2b1830fcfead84d07bc060ec43e072"
+
+DEPENDS = "perl"
+
+SRCREV = "760c625ec0e1ffebec2e391d891d389da0f65726"
+SRC_URI = "git://salsa.debian.org/debian/init-system-helpers.git"
+
+S = "${WORKDIR}/git"
+
+do_configure() {
+ :
+}
+
+do_compile() {
+ :
+}
+
+do_install() {
+ install -d -m 0755 ${D}${sbindir}
+ install -m 0755 ${S}/script/invoke-rc.d ${D}${sbindir}
+ install -m 0755 ${S}/script/service ${D}${sbindir}
+ install -m 0755 ${S}/script/update-rc.d ${D}${sbindir}
+}
+
+PACKAGES += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
+
+FILES_${PN} = ""
+FILES_${PN}-invoke-rc.d = "${sbindir}/invoke-rc.d"
+FILES_${PN}-service = "${sbindir}/service"
+FILES_${PN}-update-rc.d = "${sbindir}/update-rc.d"
+
+ALLOW_EMPTY_${PN} = "1"
+
+RDEPENDS_${PN}-update-rc.d = "perl"
+RRECOMMENDS_${PN} += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index 1a59b82fbf..4080c4a495 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','
PACKAGES =+ "${PN}-functions ${PN}-sushell"
RDEPENDS_${PN} = "initd-functions \
${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \
+ init-system-helpers-service \
"
# Recommend pn-functions so that it will be a preferred default provider for initd-functions
RRECOMMENDS_${PN} = "${PN}-functions"
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency
2020-05-04 14:10 [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency Jens Rehsack
@ 2020-05-04 14:21 ` Otavio Salvador
2020-05-05 13:43 ` Jens Rehsack
0 siblings, 1 reply; 5+ messages in thread
From: Otavio Salvador @ 2020-05-04 14:21 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Anuj Mittal, Jens Rehsack
On Mon, May 4, 2020 at 11:10 AM Jens Rehsack <rehsack@gmail.com> wrote:
>
> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
> Author: Yue Tao <Yue.Tao@windriver.com>
> Date: Fri May 25 10:48:08 2018 +0800
>
> initscripts: Avoid starting rpcbind daemon twice
>
> Check the status before start it to avoid duplicates.
>
> the use of a script {/usr/sbin/}service is introduced - maybe earlier
> provided by systemd, nowadays mostly by init-system-helpers from
> debian project.
>
> For the very first shot, maybe discussions and improvements based
> on that script collection, use just the init-system-helpers-service
> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
> boot stage.
>
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
...
> +RDEPENDS_${PN}-update-rc.d = "perl"
Can't it be replaced? using perl here is not nice.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency
2020-05-04 14:21 ` Otavio Salvador
@ 2020-05-05 13:43 ` Jens Rehsack
2020-05-05 14:56 ` Otavio Salvador
0 siblings, 1 reply; 5+ messages in thread
From: Jens Rehsack @ 2020-05-05 13:43 UTC (permalink / raw)
To: Otavio Salvador
Cc: Patches and discussions about the oe-core layer, Anuj Mittal, Khem Raj
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
> Am 04.05.2020 um 16:21 schrieb Otavio Salvador <otavio.salvador@ossystems.com.br>:
>
> On Mon, May 4, 2020 at 11:10 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>
>> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
>> Author: Yue Tao <Yue.Tao@windriver.com>
>> Date: Fri May 25 10:48:08 2018 +0800
>>
>> initscripts: Avoid starting rpcbind daemon twice
>>
>> Check the status before start it to avoid duplicates.
>>
>> the use of a script {/usr/sbin/}service is introduced - maybe earlier
>> provided by systemd, nowadays mostly by init-system-helpers from
>> debian project.
>>
>> For the very first shot, maybe discussions and improvements based
>> on that script collection, use just the init-system-helpers-service
>> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
>> boot stage.
>>
>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ...
>> +RDEPENDS_${PN}-update-rc.d = "perl"
>
> Can't it be replaced? using perl here is not nice.
Be careful :P
Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off
to give community a chance to discuss it). Generally - especially with the
runit, s6, openrc ... in mind - we have to grow from there anyway and I like
our current update-rc.d implementation anyway.
But I would like then to have a 2nd commit (for documentation purposes) to
kill it or we just provide it and let people choose to use this one over
meta/recipes-core/update-rc.d
Cheers
--
Jens Rehsack - rehsack@gmail.com
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency
2020-05-05 13:43 ` Jens Rehsack
@ 2020-05-05 14:56 ` Otavio Salvador
2020-05-05 17:20 ` Jens Rehsack
0 siblings, 1 reply; 5+ messages in thread
From: Otavio Salvador @ 2020-05-05 14:56 UTC (permalink / raw)
To: Jens Rehsack
Cc: Patches and discussions about the oe-core layer, Anuj Mittal, Khem Raj
On Tue, May 5, 2020 at 10:43 AM Jens Rehsack <rehsack@gmail.com> wrote:
> > Am 04.05.2020 um 16:21 schrieb Otavio Salvador <otavio.salvador@ossystems.com.br>:
> >
> > On Mon, May 4, 2020 at 11:10 AM Jens Rehsack <rehsack@gmail.com> wrote:
> >>
> >> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
> >> Author: Yue Tao <Yue.Tao@windriver.com>
> >> Date: Fri May 25 10:48:08 2018 +0800
> >>
> >> initscripts: Avoid starting rpcbind daemon twice
> >>
> >> Check the status before start it to avoid duplicates.
> >>
> >> the use of a script {/usr/sbin/}service is introduced - maybe earlier
> >> provided by systemd, nowadays mostly by init-system-helpers from
> >> debian project.
> >>
> >> For the very first shot, maybe discussions and improvements based
> >> on that script collection, use just the init-system-helpers-service
> >> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
> >> boot stage.
> >>
> >> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> > ...
> >> +RDEPENDS_${PN}-update-rc.d = "perl"
> >
> > Can't it be replaced? using perl here is not nice.
>
> Be careful :P
Everyone has the right to do bad choices in life ;-P
> Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off
> to give community a chance to discuss it). Generally - especially with the
> runit, s6, openrc ... in mind - we have to grow from there anyway and I like
> our current update-rc.d implementation anyway.
>
> But I would like then to have a 2nd commit (for documentation purposes) to
> kill it or we just provide it and let people choose to use this one over
> meta/recipes-core/update-rc.d
Generally, I'd prefer to not give the option as it causes more
troubles for supporting it in future. I am totally fine with it being
dropped on a second commit for sure.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency
2020-05-05 14:56 ` Otavio Salvador
@ 2020-05-05 17:20 ` Jens Rehsack
0 siblings, 0 replies; 5+ messages in thread
From: Jens Rehsack @ 2020-05-05 17:20 UTC (permalink / raw)
To: Otavio Salvador
Cc: Patches and discussions about the oe-core layer, Anuj Mittal, Khem Raj
[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]
> Am 05.05.2020 um 16:56 schrieb Otavio Salvador <otavio.salvador@ossystems.com.br>:
>
> On Tue, May 5, 2020 at 10:43 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>> Am 04.05.2020 um 16:21 schrieb Otavio Salvador <otavio.salvador@ossystems.com.br>:
>>>
>>> On Mon, May 4, 2020 at 11:10 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>>>
>>>> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
>>>> Author: Yue Tao <Yue.Tao@windriver.com>
>>>> Date: Fri May 25 10:48:08 2018 +0800
>>>>
>>>> initscripts: Avoid starting rpcbind daemon twice
>>>>
>>>> Check the status before start it to avoid duplicates.
>>>>
>>>> the use of a script {/usr/sbin/}service is introduced - maybe earlier
>>>> provided by systemd, nowadays mostly by init-system-helpers from
>>>> debian project.
>>>>
>>>> For the very first shot, maybe discussions and improvements based
>>>> on that script collection, use just the init-system-helpers-service
>>>> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
>>>> boot stage.
>>>>
>>>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
>>> ...
>>>> +RDEPENDS_${PN}-update-rc.d = "perl"
>>>
>>> Can't it be replaced? using perl here is not nice.
>>
>> Be careful :P
>
> Everyone has the right to do bad choices in life ;-P
/me nods
But comparing to up-river alternatives, there isn't much better :)
>> Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off
>> to give community a chance to discuss it). Generally - especially with the
>> runit, s6, openrc ... in mind - we have to grow from there anyway and I like
>> our current update-rc.d implementation anyway.
>>
>> But I would like then to have a 2nd commit (for documentation purposes) to
>> kill it or we just provide it and let people choose to use this one over
>> meta/recipes-core/update-rc.d
>
> Generally, I'd prefer to not give the option as it causes more
> troubles for supporting it in future. I am totally fine with it being
> dropped on a second commit for sure.
What do others (Richard, Anuj, Khem) say?
And - making a patch series from that or let someone else kicking it?
Cheers
--
Jens Rehsack - rehsack@gmail.com
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-05 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 14:10 [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency Jens Rehsack
2020-05-04 14:21 ` Otavio Salvador
2020-05-05 13:43 ` Jens Rehsack
2020-05-05 14:56 ` Otavio Salvador
2020-05-05 17:20 ` Jens Rehsack
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.