* [RFC][PATCH] package.bbclass: fix strip and split logic
@ 2014-01-21 9:47 Koen Kooi
2014-01-21 13:57 ` Richard Purdie
0 siblings, 1 reply; 15+ messages in thread
From: Koen Kooi @ 2014-01-21 9:47 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
Original behaviour:
INHIBIT_PACKAGE_STRIP: no strip, no debug split
INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
Behaviour after this patch:
INHIBIT_PACKAGE_STRIP: no strip, no debug split
INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
---
meta/classes/package.bbclass | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 768047c..fa0b7eb 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -781,8 +781,7 @@ python split_and_strip_files () {
kernmods = []
libdir = os.path.abspath(dvar + os.sep + d.getVar("libdir", True))
baselibdir = os.path.abspath(dvar + os.sep + d.getVar("base_libdir", True))
- if (d.getVar('INHIBIT_PACKAGE_DEBUG_SPLIT', True) != '1') and \
- (d.getVar('INHIBIT_PACKAGE_STRIP', True) != '1'):
+ if (d.getVar('INHIBIT_PACKAGE_STRIP', True) != '1'):
for root, dirs, files in cpath.walk(dvar):
for f in files:
file = os.path.join(root, f)
--
1.8.4.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-21 9:47 [RFC][PATCH] package.bbclass: fix strip and split logic Koen Kooi
@ 2014-01-21 13:57 ` Richard Purdie
2014-01-21 14:03 ` Koen Kooi
0 siblings, 1 reply; 15+ messages in thread
From: Richard Purdie @ 2014-01-21 13:57 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>
> Original behaviour:
>
> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>
> Behaviour after this patch:
>
> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
>
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
> meta/classes/package.bbclass | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
FWIW this resulted in a failure on minnow:
http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
So we may have some fixing up to do before this change can be merged...
Cheers,
Richard
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-21 13:57 ` Richard Purdie
@ 2014-01-21 14:03 ` Koen Kooi
2014-01-21 15:04 ` Mark Hatle
2014-01-21 15:09 ` Richard Purdie
0 siblings, 2 replies; 15+ messages in thread
From: Koen Kooi @ 2014-01-21 14:03 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 01/21/2014 02:57 PM, Richard Purdie wrote:
> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>>
>> Original behaviour:
>>
>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>>
>> Behaviour after this patch:
>>
>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
>>
>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>> ---
>> meta/classes/package.bbclass | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> FWIW this resulted in a failure on minnow:
>
> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
>
> So we may have some fixing up to do before this change can be merged...
I have that QA issue as warning not as error. I guess that's why my
builds kept working :)
Aside from that, what are your thoughts on this patch?
regards,
Koen
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-21 14:03 ` Koen Kooi
@ 2014-01-21 15:04 ` Mark Hatle
2014-01-21 15:09 ` Richard Purdie
1 sibling, 0 replies; 15+ messages in thread
From: Mark Hatle @ 2014-01-21 15:04 UTC (permalink / raw)
To: openembedded-core
On 1/21/14, 8:03 AM, Koen Kooi wrote:
> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>>>
>>> Original behaviour:
>>>
>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>>>
>>> Behaviour after this patch:
>>>
>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
My memory of the original theory was that there would be three different uses:
1 - I want no debug (stripped) software on the target and debug binaries (split)
2 - I want debug (not-stripped/not-split) software on the target
3 - I want no debug (stripped) software on the target, and I don't want debug
binaries
So based on that, it looks like your change fixes things. As the original
implementation didn't allow for #3.
--Mark
>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>> ---
>>> meta/classes/package.bbclass | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> FWIW this resulted in a failure on minnow:
>>
>> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
>>
>> So we may have some fixing up to do before this change can be merged...
>
> I have that QA issue as warning not as error. I guess that's why my
> builds kept working :)
>
> Aside from that, what are your thoughts on this patch?
>
> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-21 14:03 ` Koen Kooi
2014-01-21 15:04 ` Mark Hatle
@ 2014-01-21 15:09 ` Richard Purdie
2014-01-23 9:34 ` Koen Kooi
2014-02-04 8:58 ` Koen Kooi
1 sibling, 2 replies; 15+ messages in thread
From: Richard Purdie @ 2014-01-21 15:09 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
> On 01/21/2014 02:57 PM, Richard Purdie wrote:
> > On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
> >> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
> >>
> >> Original behaviour:
> >>
> >> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> >> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
> >>
> >> Behaviour after this patch:
> >>
> >> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> >> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
> >>
> >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> >> ---
> >> meta/classes/package.bbclass | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > FWIW this resulted in a failure on minnow:
> >
> > http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
> >
> > So we may have some fixing up to do before this change can be merged...
>
> I have that QA issue as warning not as error. I guess that's why my
> builds kept working :)
>
> Aside from that, what are your thoughts on this patch?
I'm ok with it in principle but I'd like to see known build issues fixed
before it goes in since red autobuilders cause me enough grief
already ;-).
Cheers,
Richard
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-21 15:09 ` Richard Purdie
@ 2014-01-23 9:34 ` Koen Kooi
2014-01-23 11:33 ` Otavio Salvador
2014-01-23 12:41 ` Martin Jansa
2014-02-04 8:58 ` Koen Kooi
1 sibling, 2 replies; 15+ messages in thread
From: Koen Kooi @ 2014-01-23 9:34 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 01/21/2014 04:09 PM, Richard Purdie wrote:
> On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
>> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>>>>
>>>> Original behaviour:
>>>>
>>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>>>>
>>>> Behaviour after this patch:
>>>>
>>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
>>>>
>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>> ---
>>>> meta/classes/package.bbclass | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> FWIW this resulted in a failure on minnow:
>>>
>>> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
>>>
>>> So we may have some fixing up to do before this change can be merged...
>>
>> I have that QA issue as warning not as error. I guess that's why my
>> builds kept working :)
>>
>> Aside from that, what are your thoughts on this patch?
>
> I'm ok with it in principle but I'd like to see known build issues fixed
> before it goes in since red autobuilders cause me enough grief
> already ;-).
I've changed all occurrences of INHIBIT_PACKAGE_DEBUG_SPLIT to have
INHIBIT_PACKAGE_STRIP as well in all the layers angstrom has configured.
I've sent patches to:
meta-intel
meta-initramfs
meta-oe
meta-fsl-arm
meta-android
meta-aurora
meta-linaro-toolchain
Which brings me to my next point:
If you list a mailinglist in your README where you want to have patches
sent, don't make it automatically reject them. I'm looking at you,
shr-devel!
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-23 9:34 ` Koen Kooi
@ 2014-01-23 11:33 ` Otavio Salvador
2014-01-23 12:41 ` Martin Jansa
1 sibling, 0 replies; 15+ messages in thread
From: Otavio Salvador @ 2014-01-23 11:33 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
Hello,
On Thu, Jan 23, 2014 at 7:34 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> meta-fsl-arm
...
I got this patch and I will merge it next time I merge things there.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-23 9:34 ` Koen Kooi
2014-01-23 11:33 ` Otavio Salvador
@ 2014-01-23 12:41 ` Martin Jansa
1 sibling, 0 replies; 15+ messages in thread
From: Martin Jansa @ 2014-01-23 12:41 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2254 bytes --]
On Thu, Jan 23, 2014 at 10:34:48AM +0100, Koen Kooi wrote:
> On 01/21/2014 04:09 PM, Richard Purdie wrote:
> > On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
> >> On 01/21/2014 02:57 PM, Richard Purdie wrote:
> >>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
> >>>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
> >>>>
> >>>> Original behaviour:
> >>>>
> >>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> >>>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
> >>>>
> >>>> Behaviour after this patch:
> >>>>
> >>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> >>>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
> >>>>
> >>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> >>>> ---
> >>>> meta/classes/package.bbclass | 3 +--
> >>>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>>
> >>> FWIW this resulted in a failure on minnow:
> >>>
> >>> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
> >>>
> >>> So we may have some fixing up to do before this change can be merged...
> >>
> >> I have that QA issue as warning not as error. I guess that's why my
> >> builds kept working :)
> >>
> >> Aside from that, what are your thoughts on this patch?
> >
> > I'm ok with it in principle but I'd like to see known build issues fixed
> > before it goes in since red autobuilders cause me enough grief
> > already ;-).
>
> I've changed all occurrences of INHIBIT_PACKAGE_DEBUG_SPLIT to have
> INHIBIT_PACKAGE_STRIP as well in all the layers angstrom has configured.
> I've sent patches to:
>
> meta-intel
> meta-initramfs
> meta-oe
> meta-fsl-arm
> meta-android
> meta-aurora
> meta-linaro-toolchain
>
> Which brings me to my next point:
>
> If you list a mailinglist in your README where you want to have patches
> sent, don't make it automatically reject them. I'm looking at you,
> shr-devel!
/me hides behind shr-devel owner, which is nobody knows who.
but I'll check
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-01-21 15:09 ` Richard Purdie
2014-01-23 9:34 ` Koen Kooi
@ 2014-02-04 8:58 ` Koen Kooi
2014-02-04 9:32 ` Richard Purdie
2014-02-04 10:10 ` Paul Eggleton
1 sibling, 2 replies; 15+ messages in thread
From: Koen Kooi @ 2014-02-04 8:58 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 01/21/2014 04:09 PM, Richard Purdie wrote:
> On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
>> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>>>>
>>>> Original behaviour:
>>>>
>>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>>>>
>>>> Behaviour after this patch:
>>>>
>>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
>>>>
>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>> ---
>>>> meta/classes/package.bbclass | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> FWIW this resulted in a failure on minnow:
>>>
>>> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
>>>
>>> So we may have some fixing up to do before this change can be merged...
>>
>> I have that QA issue as warning not as error. I guess that's why my
>> builds kept working :)
>>
>> Aside from that, what are your thoughts on this patch?
>
> I'm ok with it in principle but I'd like to see known build issues fixed
> before it goes in since red autobuilders cause me enough grief
> already ;-).
What's the status on this? I know a fix went into meta-intel (albeit it
in a legally questionable way, but that's their problem) and the other
affected layers have received patches for it.
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-02-04 8:58 ` Koen Kooi
@ 2014-02-04 9:32 ` Richard Purdie
2014-02-04 11:20 ` Otavio Salvador
2014-02-04 10:10 ` Paul Eggleton
1 sibling, 1 reply; 15+ messages in thread
From: Richard Purdie @ 2014-02-04 9:32 UTC (permalink / raw)
To: Koen Kooi; +Cc: Otavio Salvador, openembedded-core
On Tue, 2014-02-04 at 09:58 +0100, Koen Kooi wrote:
> On 01/21/2014 04:09 PM, Richard Purdie wrote:
> > On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
> >> On 01/21/2014 02:57 PM, Richard Purdie wrote:
> >>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
> > I'm ok with it in principle but I'd like to see known build issues fixed
> > before it goes in since red autobuilders cause me enough grief
> > already ;-).
>
> What's the status on this? I know a fix went into meta-intel (albeit it
> in a legally questionable way, but that's their problem) and the other
> affected layers have received patches for it.
The last test build I ran:
http://autobuilder.yoctoproject.org/main/builders/nightly-fsl-arm/builds/10/steps/BuildImages_1/logs/stdio
still shows an error in the fsl-arm layer which I suspect is from this.
I was hoping that could get fixed before it merges, its very much still
in the queue though.
I won't wait forever, equally, maintaining the green builds is proving
to consume a lot of my time and if I can avoid adding more failures, I'd
prefer to do so.
Cheers,
Richard
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-02-04 8:58 ` Koen Kooi
2014-02-04 9:32 ` Richard Purdie
@ 2014-02-04 10:10 ` Paul Eggleton
2014-02-04 11:01 ` Koen Kooi
1 sibling, 1 reply; 15+ messages in thread
From: Paul Eggleton @ 2014-02-04 10:10 UTC (permalink / raw)
To: Koen Kooi; +Cc: openembedded-core
On Tuesday 04 February 2014 09:58:47 Koen Kooi wrote:
> What's the status on this? I know a fix went into meta-intel (albeit it
> in a legally questionable way, but that's their problem) and the other
> affected layers have received patches for it.
Legally questionable in what way? If you refer to your name being removed from
the patch, that was rectified before the patch was merged.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-02-04 10:10 ` Paul Eggleton
@ 2014-02-04 11:01 ` Koen Kooi
0 siblings, 0 replies; 15+ messages in thread
From: Koen Kooi @ 2014-02-04 11:01 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On 02/04/2014 11:10 AM, Paul Eggleton wrote:
> On Tuesday 04 February 2014 09:58:47 Koen Kooi wrote:
>> What's the status on this? I know a fix went into meta-intel (albeit it
>> in a legally questionable way, but that's their problem) and the other
>> affected layers have received patches for it.
>
> Legally questionable in what way? If you refer to your name being removed from
> the patch, that was rectified before the patch was merged.
Good, the last I heard was that Tom merged the patches where authorship
was removed due to "git workflow issues". I just checked meta-intel git
and it seems to be OK now.
I still don't get how someone can (accidentally or not) add
--reset-author their git patch workflow, but that's a different discussion.
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-02-04 9:32 ` Richard Purdie
@ 2014-02-04 11:20 ` Otavio Salvador
2014-02-04 11:27 ` Koen Kooi
0 siblings, 1 reply; 15+ messages in thread
From: Otavio Salvador @ 2014-02-04 11:20 UTC (permalink / raw)
To: Richard Purdie; +Cc: Koen Kooi, Patches and discussions about the oe-core layer
Hello Richard,
On Tue, Feb 4, 2014 at 7:32 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2014-02-04 at 09:58 +0100, Koen Kooi wrote:
>> On 01/21/2014 04:09 PM, Richard Purdie wrote:
>> > On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
>> >> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>> >>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>> > I'm ok with it in principle but I'd like to see known build issues fixed
>> > before it goes in since red autobuilders cause me enough grief
>> > already ;-).
>>
>> What's the status on this? I know a fix went into meta-intel (albeit it
>> in a legally questionable way, but that's their problem) and the other
>> affected layers have received patches for it.
>
> The last test build I ran:
>
> http://autobuilder.yoctoproject.org/main/builders/nightly-fsl-arm/builds/10/steps/BuildImages_1/logs/stdio
>
> still shows an error in the fsl-arm layer which I suspect is from this.
> I was hoping that could get fixed before it merges, its very much still
> in the queue though.
>
> I won't wait forever, equally, maintaining the green builds is proving
> to consume a lot of my time and if I can avoid adding more failures, I'd
> prefer to do so.
I asked two fixes for Koen in the patch and I am awaiting this to
apply his patches.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-02-04 11:20 ` Otavio Salvador
@ 2014-02-04 11:27 ` Koen Kooi
2014-02-04 12:12 ` Otavio Salvador
0 siblings, 1 reply; 15+ messages in thread
From: Koen Kooi @ 2014-02-04 11:27 UTC (permalink / raw)
To: Otavio Salvador, Richard Purdie
Cc: Patches and discussions about the oe-core layer
On 02/04/2014 12:20 PM, Otavio Salvador wrote:
> Hello Richard,
>
> On Tue, Feb 4, 2014 at 7:32 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> On Tue, 2014-02-04 at 09:58 +0100, Koen Kooi wrote:
>>> On 01/21/2014 04:09 PM, Richard Purdie wrote:
>>>> On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
>>>>> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>>>>>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>>> I'm ok with it in principle but I'd like to see known build issues fixed
>>>> before it goes in since red autobuilders cause me enough grief
>>>> already ;-).
>>>
>>> What's the status on this? I know a fix went into meta-intel (albeit it
>>> in a legally questionable way, but that's their problem) and the other
>>> affected layers have received patches for it.
>>
>> The last test build I ran:
>>
>> http://autobuilder.yoctoproject.org/main/builders/nightly-fsl-arm/builds/10/steps/BuildImages_1/logs/stdio
>>
>> still shows an error in the fsl-arm layer which I suspect is from this.
>> I was hoping that could get fixed before it merges, its very much still
>> in the queue though.
>>
>> I won't wait forever, equally, maintaining the green builds is proving
>> to consume a lot of my time and if I can avoid adding more failures, I'd
>> prefer to do so.
>
> I asked two fixes for Koen in the patch and I am awaiting this to
> apply his patches.
And I already said I'm not planning to jump through more hoops just to
get this patch into OE-core.
--
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [RFC][PATCH] package.bbclass: fix strip and split logic
2014-02-04 11:27 ` Koen Kooi
@ 2014-02-04 12:12 ` Otavio Salvador
0 siblings, 0 replies; 15+ messages in thread
From: Otavio Salvador @ 2014-02-04 12:12 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On Tue, Feb 4, 2014 at 9:27 AM, Koen Kooi <koen.kooi@linaro.org> wrote:
> On 02/04/2014 12:20 PM, Otavio Salvador wrote:
>>
>> Hello Richard,
>>
>> On Tue, Feb 4, 2014 at 7:32 AM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>>>
>>> On Tue, 2014-02-04 at 09:58 +0100, Koen Kooi wrote:
>>>>
>>>> On 01/21/2014 04:09 PM, Richard Purdie wrote:
>>>>>
>>>>> On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
>>>>>>
>>>>>> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>>>>>>>
>>>>>>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>>>>
>>>>> I'm ok with it in principle but I'd like to see known build issues
>>>>> fixed
>>>>> before it goes in since red autobuilders cause me enough grief
>>>>> already ;-).
>>>>
>>>>
>>>> What's the status on this? I know a fix went into meta-intel (albeit it
>>>> in a legally questionable way, but that's their problem) and the other
>>>> affected layers have received patches for it.
>>>
>>>
>>> The last test build I ran:
>>>
>>>
>>> http://autobuilder.yoctoproject.org/main/builders/nightly-fsl-arm/builds/10/steps/BuildImages_1/logs/stdio
>>>
>>> still shows an error in the fsl-arm layer which I suspect is from this.
>>> I was hoping that could get fixed before it merges, its very much still
>>> in the queue though.
>>>
>>> I won't wait forever, equally, maintaining the green builds is proving
>>> to consume a lot of my time and if I can avoid adding more failures, I'd
>>> prefer to do so.
>>
>> I asked two fixes for Koen in the patch and I am awaiting this to
>> apply his patches.
>
> And I already said I'm not planning to jump through more hoops just to get
> this patch into OE-core.
Sorry Koen but I think as you send the patch you should send the reviewed one.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2014-02-04 12:12 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-21 9:47 [RFC][PATCH] package.bbclass: fix strip and split logic Koen Kooi
2014-01-21 13:57 ` Richard Purdie
2014-01-21 14:03 ` Koen Kooi
2014-01-21 15:04 ` Mark Hatle
2014-01-21 15:09 ` Richard Purdie
2014-01-23 9:34 ` Koen Kooi
2014-01-23 11:33 ` Otavio Salvador
2014-01-23 12:41 ` Martin Jansa
2014-02-04 8:58 ` Koen Kooi
2014-02-04 9:32 ` Richard Purdie
2014-02-04 11:20 ` Otavio Salvador
2014-02-04 11:27 ` Koen Kooi
2014-02-04 12:12 ` Otavio Salvador
2014-02-04 10:10 ` Paul Eggleton
2014-02-04 11:01 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.