[PATCH] go-mod.bbclass: use append to add `modcacherw`

[PATCH] go-mod.bbclass: use append to add `modcacherw`

[Peter A. Bigot]

This class provided default build flags but includes the base go class
which also provides default flags.  Use a different mechanism to
extend the default flags without discarding `-trimpath` from the base
class.

Signed-off-by: Peter A. Bigot <pab@pabigot.com>
---
 meta/classes/go-mod.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/go-mod.bbclass b/meta/classes/go-mod.bbclass
index 5871d025067..cabb04d0ec0 100644
--- a/meta/classes/go-mod.bbclass
+++ b/meta/classes/go-mod.bbclass
@@ -12,7 +12,7 @@
 
 # The '-modcacherw' option ensures we have write access to the cached objects so
 # we avoid errors during clean task as well as when removing the TMPDIR.
-export GOBUILDFLAGS ?= "-v ${GO_LDFLAGS} -modcacherw"
+GOBUILDFLAGS_append = " -modcacherw"
 
 inherit go
 
-- 
2.25.1

Re: [OE-core] [PATCH] go-mod.bbclass: use append to add `modcacherw`

[Otavio Salvador]

Em sáb., 26 de set. de 2020 às 07:53, Peter A. Bigot <pab@pabigot.com> escreveu:
>
> This class provided default build flags but includes the base go class
> which also provides default flags.  Use a different mechanism to
> extend the default flags without discarding `-trimpath` from the base
> class.
>
> Signed-off-by: Peter A. Bigot <pab@pabigot.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750