[meta-java][PATCH] openjdk-8-cross.inc: Fix QA error caused by missing hash

[meta-java][PATCH] openjdk-8-cross.inc: Fix QA error caused by missing hash

[Erkka Kääriä]

Some openjdk makefiles (e.g. vm.make) only use CFLAGS as their linker
flags. This means that the oe-specific linker flags are lost. This in
particular causes issues with the recent oe-core commit a98a81808, which
intentionally poisons the linker hash style, so that any recipes that do
not use the oe LDFLAGS fail to build.

Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
---
 recipes-core/openjdk/openjdk-8-cross.inc | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/recipes-core/openjdk/openjdk-8-cross.inc b/recipes-core/openjdk/openjdk-8-cross.inc
index 11e94ce..6097afc 100644
--- a/recipes-core/openjdk/openjdk-8-cross.inc
+++ b/recipes-core/openjdk/openjdk-8-cross.inc
@@ -39,21 +39,23 @@ SRC_URI_append = "\
     file://jvm.cfg \
 "
 
+# Some makefiles pick the linker flags from the CFLAGS variable, so add
+# the LDFLAGS to CFLAGS
+CFLAGS_append = " \
+  ${LDFLAGS} \
+"
+
 EXTRA_OECONF_append = "\
     --with-jobs=${@get_jdk8_native_jobs(d)} \
-    \
     --with-sys-root=${STAGING_DIR} \
     --with-tools-dir=${STAGING_DIR_NATIVE} \
     --with-boot-jdk=${STAGING_LIBDIR_NATIVE}/jvm/openjdk-8-native \
     --with-cacerts-file=${STAGING_LIBDIR_NATIVE}/jvm/openjdk-8-native/jre/lib/security/cacerts \
-    \
     --disable-precompiled-headers \
     --disable-zip-debug-info \
-    \
     --with-extra-cflags='${CFLAGS}' \
     --with-extra-cxxflags='${CXXFLAGS}' \
     --with-extra-ldflags='${LDFLAGS}' \
-    \
     ${@jdk_configure_options(d)} \
 "
 
-- 
2.7.4

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [meta-java][PATCH] openjdk-8-cross.inc: Fix QA error caused by missing hash

[Otavio Salvador]

On Fri, Aug 19, 2016 at 10:24 AM, Erkka Kääriä <erkka.kaaria@intel.com> wrote:
> Some openjdk makefiles (e.g. vm.make) only use CFLAGS as their linker
> flags. This means that the oe-specific linker flags are lost. This in
> particular causes issues with the recent oe-core commit a98a81808, which
> intentionally poisons the linker hash style, so that any recipes that do
> not use the oe LDFLAGS fail to build.
>
> Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
> ---
>  recipes-core/openjdk/openjdk-8-cross.inc | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-core/openjdk/openjdk-8-cross.inc b/recipes-core/openjdk/openjdk-8-cross.inc
> index 11e94ce..6097afc 100644
> --- a/recipes-core/openjdk/openjdk-8-cross.inc
> +++ b/recipes-core/openjdk/openjdk-8-cross.inc
> @@ -39,21 +39,23 @@ SRC_URI_append = "\
>      file://jvm.cfg \
>  "
>
> +# Some makefiles pick the linker flags from the CFLAGS variable, so add
> +# the LDFLAGS to CFLAGS
> +CFLAGS_append = " \
> +  ${LDFLAGS} \
> +"
> +

Fine.

>  EXTRA_OECONF_append = "\
>      --with-jobs=${@get_jdk8_native_jobs(d)} \
> -    \
>      --with-sys-root=${STAGING_DIR} \
>      --with-tools-dir=${STAGING_DIR_NATIVE} \
>      --with-boot-jdk=${STAGING_LIBDIR_NATIVE}/jvm/openjdk-8-native \
>      --with-cacerts-file=${STAGING_LIBDIR_NATIVE}/jvm/openjdk-8-native/jre/lib/security/cacerts \
> -    \
>      --disable-precompiled-headers \
>      --disable-zip-debug-info \
> -    \
>      --with-extra-cflags='${CFLAGS}' \
>      --with-extra-cxxflags='${CXXFLAGS}' \
>      --with-extra-ldflags='${LDFLAGS}' \
> -    \
>      ${@jdk_configure_options(d)} \
>  "

Not related, please drop this change.

> --
> 2.7.4
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-java][PATCH] openjdk-8-cross.inc: Fix QA error caused by missing hash

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2762 bytes --]


> On Aug 19, 2016, at 6:24 AM, Erkka Kääriä <erkka.kaaria@intel.com> wrote:
> 
> Some openjdk makefiles (e.g. vm.make) only use CFLAGS as their linker
> flags. This means that the oe-specific linker flags are lost. This in
> particular causes issues with the recent oe-core commit a98a81808, which
> intentionally poisons the linker hash style, so that any recipes that do
> not use the oe LDFLAGS fail to build.
> 
> Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
> ---
> recipes-core/openjdk/openjdk-8-cross.inc | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-core/openjdk/openjdk-8-cross.inc b/recipes-core/openjdk/openjdk-8-cross.inc
> index 11e94ce..6097afc 100644
> --- a/recipes-core/openjdk/openjdk-8-cross.inc
> +++ b/recipes-core/openjdk/openjdk-8-cross.inc
> @@ -39,21 +39,23 @@ SRC_URI_append = "\
>     file://jvm.cfg \
> "
> 
> +# Some makefiles pick the linker flags from the CFLAGS variable, so add
> +# the LDFLAGS to CFLAGS
> +CFLAGS_append = " \
> +  ${LDFLAGS} \
> +”

This could break non, gcc compilers, where they will warn about linker options being unused
during compile step etc. and if we use -Werror this may fail to build too. The change belongs
to openjdk build system, if its not that invasive and complex, I would suggest to patch openjdk
and upstream the change, since that will be upstream worthy

> +
> EXTRA_OECONF_append = "\
>     --with-jobs=${@get_jdk8_native_jobs(d)} \
> -    \
>     --with-sys-root=${STAGING_DIR} \
>     --with-tools-dir=${STAGING_DIR_NATIVE} \
>     --with-boot-jdk=${STAGING_LIBDIR_NATIVE}/jvm/openjdk-8-native \
>     --with-cacerts-file=${STAGING_LIBDIR_NATIVE}/jvm/openjdk-8-native/jre/lib/security/cacerts \
> -    \
>     --disable-precompiled-headers \
>     --disable-zip-debug-info \
> -    \
>     --with-extra-cflags='${CFLAGS}' \
>     --with-extra-cxxflags='${CXXFLAGS}' \
>     --with-extra-ldflags='${LDFLAGS}' \
> -    \
>     ${@jdk_configure_options(d)} \
> "
> 
> --
> 2.7.4
> 
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]