All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bash: fix warning about bashbug reference /usr/bin when installed in /bin
@ 2012-07-19 15:16 Otavio Salvador
  2012-07-19 15:20 ` Burton, Ross
  0 siblings, 1 reply; 3+ messages in thread
From: Otavio Salvador @ 2012-07-19 15:16 UTC (permalink / raw)
  To: openembedded-core

We change the installation process so we have bashbug in ${bindir} and
bash at ${base_bindir}; we also build tested it many times in a 8 CPU
machine and had no problem building it in parallel so we dropped
PARALLEL_MAKE override.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-extended/bash/bash.inc    |   13 ++++++++-----
 meta/recipes-extended/bash/bash_4.2.bb |    2 +-
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
index ff9b0ce..a7f5f8f 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -9,11 +9,6 @@ DEPENDS = "ncurses bison-native"
 
 inherit autotools gettext update-alternatives
 
-PARALLEL_MAKE = ""
-
-bindir = "/bin"
-sbindir = "/sbin"
-
 EXTRA_OECONF = "--enable-job-control"
 export CC_FOR_BUILD = "${BUILD_CC}"
 
@@ -30,6 +25,14 @@ do_configure_prepend () {
 	fi
 }
 
+do_install_append () {
+	# Move /usr/bin/bash to /bin/bash, if need
+	if [ "${base_bindir}" != "${bindir}" ]; then
+		mkdir -p ${D}${base_bindir}
+		mv ${D}${bindir}/bash ${D}${base_bindir}
+	fi
+}
+
 pkg_postinst_${PN} () {
 	touch $D${sysconfdir}/shells
 	grep -q "bin/bash" $D${sysconfdir}/shells || echo /bin/bash >> $D${sysconfdir}/shells
diff --git a/meta/recipes-extended/bash/bash_4.2.bb b/meta/recipes-extended/bash/bash_4.2.bb
index e96709a..a28279e 100644
--- a/meta/recipes-extended/bash/bash_4.2.bb
+++ b/meta/recipes-extended/bash/bash_4.2.bb
@@ -1,6 +1,6 @@
 require bash.inc
 
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "${GNU_MIRROR}/bash/${BPN}-${PV}.tar.gz;name=tarball \
            ${GNU_MIRROR}/bash/bash-4.2-patches/bash42-001;apply=yes;striplevel=0;name=patch001 \
-- 
1.7.2.5




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] bash: fix warning about bashbug reference /usr/bin when installed in /bin
  2012-07-19 15:16 [PATCH] bash: fix warning about bashbug reference /usr/bin when installed in /bin Otavio Salvador
@ 2012-07-19 15:20 ` Burton, Ross
  2012-07-19 16:56   ` Otavio Salvador
  0 siblings, 1 reply; 3+ messages in thread
From: Burton, Ross @ 2012-07-19 15:20 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On 19 July 2012 16:16, Otavio Salvador <otavio@ossystems.com.br> wrote:
> We change the installation process so we have bashbug in ${bindir} and
> bash at ${base_bindir}; we also build tested it many times in a 8 CPU
> machine and had no problem building it in parallel so we dropped
> PARALLEL_MAKE override.

I'd really like to see those split out as separate commits...

Ross



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bash: fix warning about bashbug reference /usr/bin when installed in /bin
  2012-07-19 15:20 ` Burton, Ross
@ 2012-07-19 16:56   ` Otavio Salvador
  0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2012-07-19 16:56 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Thu, Jul 19, 2012 at 12:20 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 19 July 2012 16:16, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> We change the installation process so we have bashbug in ${bindir} and
>> bash at ${base_bindir}; we also build tested it many times in a 8 CPU
>> machine and had no problem building it in parallel so we dropped
>> PARALLEL_MAKE override.
>
> I'd really like to see those split out as separate commits...

Ok; I will rework it and send it once again.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-19 17:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 15:16 [PATCH] bash: fix warning about bashbug reference /usr/bin when installed in /bin Otavio Salvador
2012-07-19 15:20 ` Burton, Ross
2012-07-19 16:56   ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.