[meta-fsl-arm-extra PATCH] linux-toradex (3.14.28): Restrict recipe parsing for compatible machines

[meta-fsl-arm-extra PATCH] linux-toradex (3.14.28): Restrict recipe parsing for compatible machines

[Otavio Salvador]

While it is good, as design, allow for easier reuse of the recipe by
custom designs (specially SoM-based ones) it requires that we provide
common 'defconfig' files.

The Toradex kernel does not provide a i.MX6 generic defconfig file
thus triggering a warning when building for other boards, as:

,----
| WARNING: Unable to get checksum for linux-toradex SRC_URI entry
|     defconfig: file could not be found.
`----

To avoid this warning, the compatible machine is now set for the
compatible ones (apalis-imx6 and colibri-imx6).

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

 recipes-kernel/linux/linux-toradex_3.14.28.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-kernel/linux/linux-toradex_3.14.28.bb b/recipes-kernel/linux/linux-toradex_3.14.28.bb
index e7d8718..abd4278 100644
--- a/recipes-kernel/linux/linux-toradex_3.14.28.bb
+++ b/recipes-kernel/linux/linux-toradex_3.14.28.bb
@@ -10,4 +10,4 @@ LOCALVERSION = "-v2.5b2"
 SRCBRANCH = "toradex_imx_3.14.28_1.0.0_ga"
 SRCREV = "8f237ebe42f2cb911245369276a6b3043c2815f2"
 DEPENDS += "lzop-native bc-native"
-COMPATIBLE_MACHINE = "(mx6)"
+COMPATIBLE_MACHINE = "(apalis-imx6|colibri-imx6)"
-- 
2.7.0

Re: [meta-fsl-arm-extra PATCH] linux-toradex (3.14.28): Restrict recipe parsing for compatible machines

[Max Krummenacher]

Hi Otavio

Am Montag, den 18.01.2016, 15:51 -0200 schrieb Otavio Salvador:
> While it is good, as design, allow for easier reuse of the recipe by
> custom designs (specially SoM-based ones) it requires that we provide
> common 'defconfig' files.
> 

Wouldn't it then be better to provide such a common defconfig
additionally? 
If yes I could prepare an alternative patch which adds 
recipes-kernel/linux/linux-toradex-3.14.28/defconfig 
instead of restricting compatible machine. 
I would probably take the current linux-fslc one to cover a greater
range of drivers and options than what we use for our machines.

Regards
Max

> The Toradex kernel does not provide a i.MX6 generic defconfig file
> thus triggering a warning when building for other boards, as:
> 
> ,----
> > WARNING: Unable to get checksum for linux-toradex SRC_URI entry
> >     defconfig: file could not be found.
> `----
> 
> To avoid this warning, the compatible machine is now set for the
> compatible ones (apalis-imx6 and colibri-imx6).
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
>  recipes-kernel/linux/linux-toradex_3.14.28.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-kernel/linux/linux-toradex_3.14.28.bb b/recipes
> -kernel/linux/linux-toradex_3.14.28.bb
> index e7d8718..abd4278 100644
> --- a/recipes-kernel/linux/linux-toradex_3.14.28.bb
> +++ b/recipes-kernel/linux/linux-toradex_3.14.28.bb
> @@ -10,4 +10,4 @@ LOCALVERSION = "-v2.5b2"
>  SRCBRANCH = "toradex_imx_3.14.28_1.0.0_ga"
>  SRCREV = "8f237ebe42f2cb911245369276a6b3043c2815f2"
>  DEPENDS += "lzop-native bc-native"
> -COMPATIBLE_MACHINE = "(mx6)"
> +COMPATIBLE_MACHINE = "(apalis-imx6|colibri-imx6)"

Re: [meta-fsl-arm-extra PATCH] linux-toradex (3.14.28): Restrict recipe parsing for compatible machines

[Otavio Salvador]

On Mon, Jan 18, 2016 at 9:52 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> Am Montag, den 18.01.2016, 15:51 -0200 schrieb Otavio Salvador:
>> While it is good, as design, allow for easier reuse of the recipe by
>> custom designs (specially SoM-based ones) it requires that we provide
>> common 'defconfig' files.
>>
>
> Wouldn't it then be better to provide such a common defconfig
> additionally?
> If yes I could prepare an alternative patch which adds
> recipes-kernel/linux/linux-toradex-3.14.28/defconfig
> instead of restricting compatible machine.
> I would probably take the current linux-fslc one to cover a greater
> range of drivers and options than what we use for our machines.

This is indeed an option and I would appreciate it. One even better
one, in my POV, would be if both machines could use a single
defconfig. Would this be possible?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm-extra PATCH] linux-toradex (3.14.28): Restrict recipe parsing for compatible machines

[Max Krummenacher]

Hi Otavio

2016-01-19 15:15 GMT+01:00 Otavio Salvador <otavio.salvador@ossystems.com.br>:
> On Mon, Jan 18, 2016 at 9:52 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
>> Am Montag, den 18.01.2016, 15:51 -0200 schrieb Otavio Salvador:
>>> While it is good, as design, allow for easier reuse of the recipe by
>>> custom designs (specially SoM-based ones) it requires that we provide
>>> common 'defconfig' files.
>>>
>>
>> Wouldn't it then be better to provide such a common defconfig
>> additionally?
>> If yes I could prepare an alternative patch which adds
>> recipes-kernel/linux/linux-toradex-3.14.28/defconfig
>> instead of restricting compatible machine.
>> I would probably take the current linux-fslc one to cover a greater
>> range of drivers and options than what we use for our machines.
>
> This is indeed an option and I would appreciate it. One even better
> one, in my POV, would be if both machines could use a single
> defconfig. Would this be possible?
>
Yes this is possible, one is a subset of the other.
I'm still not happy though about size etc. as I outlined in the
discussion for the initial commit:
https://lists.yoctoproject.org/pipermail/meta-freescale/2015-December/016795.html
If you have strong feelings towards the 'one size fits all' solution I
might get persuaded (or pressed)
to go for it.

Max

> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm-extra PATCH] linux-toradex (3.14.28): Restrict recipe parsing for compatible machines

[Otavio Salvador]

On Tue, Jan 19, 2016 at 1:15 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> 2016-01-19 15:15 GMT+01:00 Otavio Salvador <otavio.salvador@ossystems.com.br>:
>> On Mon, Jan 18, 2016 at 9:52 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
>>> Am Montag, den 18.01.2016, 15:51 -0200 schrieb Otavio Salvador:
>>>> While it is good, as design, allow for easier reuse of the recipe by
>>>> custom designs (specially SoM-based ones) it requires that we provide
>>>> common 'defconfig' files.
>>>>
>>>
>>> Wouldn't it then be better to provide such a common defconfig
>>> additionally?
>>> If yes I could prepare an alternative patch which adds
>>> recipes-kernel/linux/linux-toradex-3.14.28/defconfig
>>> instead of restricting compatible machine.
>>> I would probably take the current linux-fslc one to cover a greater
>>> range of drivers and options than what we use for our machines.
>>
>> This is indeed an option and I would appreciate it. One even better
>> one, in my POV, would be if both machines could use a single
>> defconfig. Would this be possible?
>>
> Yes this is possible, one is a subset of the other.
> I'm still not happy though about size etc. as I outlined in the
> discussion for the initial commit:
> https://lists.yoctoproject.org/pipermail/meta-freescale/2015-December/016795.html
> If you have strong feelings towards the 'one size fits all' solution I
> might get persuaded (or pressed)
> to go for it.

Personally I expect anyone using Toradex SoM will make their custom
defconfig so the default one is just a reference. The size difference
is minimal specially if you use kernel modules which will not be
loaded if the peripheral is not used/enabled.

It is your call but I don't see a big gain in two different defconfig
files for such small difference.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750