[meta-fsl-ppc][PATCH] udev-rules-qoriq: make variable and function specific to qoriq-ppc targets

[meta-fsl-ppc][PATCH] udev-rules-qoriq: make variable and function specific to qoriq-ppc targets

[Zhenhua Luo]

Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com>
---
 recipes-core/udev/udev-rules-qoriq.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/recipes-core/udev/udev-rules-qoriq.bb b/recipes-core/udev/udev-rules-qoriq.bb
index 1f34b8d..197bc0e 100644
--- a/recipes-core/udev/udev-rules-qoriq.bb
+++ b/recipes-core/udev/udev-rules-qoriq.bb
@@ -2,17 +2,17 @@ DESCRIPTION = "udev rules for Freescale QorIQ SOCs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
 
-SRC_URI = "\
+SRC_URI_qoriq-ppc = "\
     file://71-fsl-dpaa-persistent-networking.rules \
     file://72-fsl-dpaa-persistent-networking.rules \
 "
-RULE ?= "71-fsl-dpaa-persistent-networking.rules"
+RULE_qoriq-ppc ?= "71-fsl-dpaa-persistent-networking.rules"
 RULE_e6500 = "72-fsl-dpaa-persistent-networking.rules"
 RULE_e6500-64b = "72-fsl-dpaa-persistent-networking.rules"
 RULE_t1024 = "72-fsl-dpaa-persistent-networking.rules"
 RULE_t1023 = "72-fsl-dpaa-persistent-networking.rules"
 
-do_install () {
+do_install_qoriq-ppc () {
     install -d ${D}${sysconfdir}/udev/rules.d/
     install -m 0644 ${WORKDIR}/${RULE} ${D}${sysconfdir}/udev/rules.d/
 }
-- 
2.4.3

Re: [meta-fsl-ppc][PATCH] udev-rules-qoriq: make variable and function specific to qoriq-ppc targets

[Otavio Salvador]

On Fri, Jan 8, 2016 at 8:07 AM, Zhenhua Luo <zhenhua.luo@nxp.com> wrote:
> Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com>
> ---
>  recipes-core/udev/udev-rules-qoriq.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-core/udev/udev-rules-qoriq.bb b/recipes-core/udev/udev-rules-qoriq.bb
> index 1f34b8d..197bc0e 100644
> --- a/recipes-core/udev/udev-rules-qoriq.bb
> +++ b/recipes-core/udev/udev-rules-qoriq.bb
> @@ -2,17 +2,17 @@ DESCRIPTION = "udev rules for Freescale QorIQ SOCs"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
>
> -SRC_URI = "\
> +SRC_URI_qoriq-ppc = "\
>      file://71-fsl-dpaa-persistent-networking.rules \
>      file://72-fsl-dpaa-persistent-networking.rules \
>  "
> -RULE ?= "71-fsl-dpaa-persistent-networking.rules"
> +RULE_qoriq-ppc ?= "71-fsl-dpaa-persistent-networking.rules"
>  RULE_e6500 = "72-fsl-dpaa-persistent-networking.rules"
>  RULE_e6500-64b = "72-fsl-dpaa-persistent-networking.rules"
>  RULE_t1024 = "72-fsl-dpaa-persistent-networking.rules"
>  RULE_t1023 = "72-fsl-dpaa-persistent-networking.rules"
>
> -do_install () {
> +do_install_qoriq-ppc () {
>      install -d ${D}${sysconfdir}/udev/rules.d/
>      install -m 0644 ${WORKDIR}/${RULE} ${D}${sysconfdir}/udev/rules.d/
>  }

The compatible machine should be used here, instead. Why are you doing this?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-ppc][PATCH] udev-rules-qoriq: make variable and function specific to qoriq-ppc targets

[Zhenhua Luo]

It intention is to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=8802, the bug of fsl-ppc has been fixed by another patch,  ignore the patch. 


Best Regards,

Zhenhua

> -----Original Message-----
> From: Otavio Salvador [mailto:otavio.salvador@ossystems.com.br]
> Sent: Tuesday, January 12, 2016 12:15 AM
> To: Zhenhua Luo <zhenhua.luo@nxp.com>
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH] udev-rules-qoriq: make
> variable and function specific to qoriq-ppc targets
> 
> On Fri, Jan 8, 2016 at 8:07 AM, Zhenhua Luo <zhenhua.luo@nxp.com> wrote:
> > Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com>
> > ---
> >  recipes-core/udev/udev-rules-qoriq.bb | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/recipes-core/udev/udev-rules-qoriq.bb
> > b/recipes-core/udev/udev-rules-qoriq.bb
> > index 1f34b8d..197bc0e 100644
> > --- a/recipes-core/udev/udev-rules-qoriq.bb
> > +++ b/recipes-core/udev/udev-rules-qoriq.bb
> > @@ -2,17 +2,17 @@ DESCRIPTION = "udev rules for Freescale QorIQ SOCs"
> >  LICENSE = "MIT"
> >  LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
> >
> > -SRC_URI = "\
> > +SRC_URI_qoriq-ppc = "\
> >      file://71-fsl-dpaa-persistent-networking.rules \
> >      file://72-fsl-dpaa-persistent-networking.rules \  "
> > -RULE ?= "71-fsl-dpaa-persistent-networking.rules"
> > +RULE_qoriq-ppc ?= "71-fsl-dpaa-persistent-networking.rules"
> >  RULE_e6500 = "72-fsl-dpaa-persistent-networking.rules"
> >  RULE_e6500-64b = "72-fsl-dpaa-persistent-networking.rules"
> >  RULE_t1024 = "72-fsl-dpaa-persistent-networking.rules"
> >  RULE_t1023 = "72-fsl-dpaa-persistent-networking.rules"
> >
> > -do_install () {
> > +do_install_qoriq-ppc () {
> >      install -d ${D}${sysconfdir}/udev/rules.d/
> >      install -m 0644 ${WORKDIR}/${RULE}
> > ${D}${sysconfdir}/udev/rules.d/  }
> 
> The compatible machine should be used here, instead. Why are you doing this?
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750