From: Paul Gortmaker <paul.gortmaker@windriver.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: LKML <linux-kernel@vger.kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Kukjin Kim <kgene@kernel.org>, Linux PM list <linux-pm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 4/7] drivers/cpufreq: Convert non-modular drivers to use builtin_driver_register Date: Tue, 12 May 2015 23:17:30 -0400 [thread overview] Message-ID: <CAP=VYLqNnn1w8ss9to+NGOhwmq8O8wYY9scMg1vQ1+mQmf=Gyw@mail.gmail.com> (raw) In-Reply-To: <20150512070444.GE32300@linux> On Tue, May 12, 2015 at 3:04 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 10-05-15, 15:49, Paul Gortmaker wrote: >> These files depend on Kconfig options all of which are a bool, so >> we use the appropriate registration function, which avoids us >> relying on an implicit inclusion of <module.h> which we are >> doing currently. >> >> While this currently works, we really don't want to be including >> the module.h header in non-modular code, which we'd be forced >> to do, pending some upcoming code relocation from init.h into >> module.h. So we fix it now by using the non-modular equivalent. >> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Cc: Kukjin Kim <kgene@kernel.org> >> Cc: linux-pm@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> --- >> drivers/cpufreq/exynos-cpufreq.c | 2 +- > > Exynos can be compiled as a module: > > drivers/cpufreq/Kconfig.arm: > > config ARM_EXYNOS_CPUFREQ > tristate "SAMSUNG EXYNOS CPUfreq Driver" > depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 Sounds like things have changed since I did the original compile testing ; thanks for the heads-up and I will follow up with the details, once I can re-test. Thanks, Paul. -- > > -- > viresh > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: paul.gortmaker@windriver.com (Paul Gortmaker) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/7] drivers/cpufreq: Convert non-modular drivers to use builtin_driver_register Date: Tue, 12 May 2015 23:17:30 -0400 [thread overview] Message-ID: <CAP=VYLqNnn1w8ss9to+NGOhwmq8O8wYY9scMg1vQ1+mQmf=Gyw@mail.gmail.com> (raw) In-Reply-To: <20150512070444.GE32300@linux> On Tue, May 12, 2015 at 3:04 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 10-05-15, 15:49, Paul Gortmaker wrote: >> These files depend on Kconfig options all of which are a bool, so >> we use the appropriate registration function, which avoids us >> relying on an implicit inclusion of <module.h> which we are >> doing currently. >> >> While this currently works, we really don't want to be including >> the module.h header in non-modular code, which we'd be forced >> to do, pending some upcoming code relocation from init.h into >> module.h. So we fix it now by using the non-modular equivalent. >> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Cc: Kukjin Kim <kgene@kernel.org> >> Cc: linux-pm at vger.kernel.org >> Cc: linux-arm-kernel at lists.infradead.org >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> --- >> drivers/cpufreq/exynos-cpufreq.c | 2 +- > > Exynos can be compiled as a module: > > drivers/cpufreq/Kconfig.arm: > > config ARM_EXYNOS_CPUFREQ > tristate "SAMSUNG EXYNOS CPUfreq Driver" > depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 Sounds like things have changed since I did the original compile testing ; thanks for the heads-up and I will follow up with the details, once I can re-test. Thanks, Paul. -- > > -- > viresh > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-05-13 3:18 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-10 19:49 [PATCH 0/7] Introduce builtin_driver and use it for non-modular code Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-10 19:49 ` [PATCH 1/7] platform_device: better support builtin boilerplate avoidance Paul Gortmaker 2015-05-12 11:46 ` Linus Walleij 2015-05-28 0:50 ` Paul Gortmaker 2015-06-02 9:19 ` Linus Walleij 2015-06-03 14:07 ` Paul Gortmaker 2015-06-10 7:35 ` Linus Walleij 2015-05-10 19:49 ` [PATCH 2/7] drivers/platform: Convert non-modular pdev_bus to use builtin_driver_register Paul Gortmaker 2015-05-10 19:49 ` [PATCH 3/7] drivers/cpuidle: Convert non-modular drivers " Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-11 17:13 ` Daniel Lezcano 2015-05-11 17:13 ` Daniel Lezcano 2015-05-10 19:49 ` [PATCH 4/7] drivers/cpufreq: " Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-12 7:04 ` Viresh Kumar 2015-05-12 7:04 ` Viresh Kumar 2015-05-13 3:17 ` Paul Gortmaker [this message] 2015-05-13 3:17 ` Paul Gortmaker 2015-05-13 3:17 ` Paul Gortmaker 2015-06-03 20:59 ` Paul Gortmaker 2015-06-03 20:59 ` Paul Gortmaker 2015-06-03 20:59 ` Paul Gortmaker 2015-06-03 21:12 ` [PATCH v2] drivers/cpufreq: Convert non-modular s5pv210-cpufreq.c to use builtin_platform_driver Paul Gortmaker 2015-06-03 21:12 ` Paul Gortmaker 2015-06-03 21:12 ` Paul Gortmaker 2015-06-04 2:28 ` Viresh Kumar 2015-06-04 2:28 ` Viresh Kumar 2015-06-15 23:50 ` Rafael J. Wysocki 2015-06-15 23:50 ` Rafael J. Wysocki 2015-06-16 15:37 ` Paul Gortmaker 2015-06-16 15:37 ` Paul Gortmaker 2015-06-16 15:37 ` Paul Gortmaker 2015-05-10 19:49 ` [PATCH 5/7] drivers/soc: Convert non-modular tegra/pmc to use builtin_driver_register Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-10 19:49 ` [PATCH 6/7] drivers/soc: Convert non-modular soc-realview " Paul Gortmaker 2015-05-12 11:39 ` Linus Walleij 2015-05-10 19:49 ` [PATCH 7/7] drivers/power: Convert non-modular syscon-reboot " Paul Gortmaker 2015-05-10 19:49 ` Paul Gortmaker 2015-05-23 17:55 ` Sebastian Reichel 2015-06-03 19:09 ` [PATCH] drivers/clk: convert sunxi/clk-mod0.c to use builtin_platform_driver Paul Gortmaker 2015-06-03 19:09 ` Paul Gortmaker 2015-06-04 16:21 ` Maxime Ripard 2015-06-04 16:21 ` Maxime Ripard 2015-06-04 22:50 ` Stephen Boyd 2015-06-04 22:50 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAP=VYLqNnn1w8ss9to+NGOhwmq8O8wYY9scMg1vQ1+mQmf=Gyw@mail.gmail.com' \ --to=paul.gortmaker@windriver.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.