All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kasan: fix doc warning in init.c
@ 2021-06-03 14:07 Yu Kuai
  2021-06-03 14:16   ` Andrey Ryabinin
  2021-06-05 20:15   ` Andrey Konovalov
  0 siblings, 2 replies; 5+ messages in thread
From: Yu Kuai @ 2021-06-03 14:07 UTC (permalink / raw)
  To: ryabinin.a.a, akpm; +Cc: kasan-dev, linux-mm, linux-kernel, yukuai3, yi.zhang

Fix gcc W=1 warning:

mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 mm/kasan/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/kasan/init.c b/mm/kasan/init.c
index c4605ac9837b..348f31d15a97 100644
--- a/mm/kasan/init.c
+++ b/mm/kasan/init.c
@@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
 /**
  * kasan_populate_early_shadow - populate shadow memory region with
  *                               kasan_early_shadow_page
- * @shadow_start - start of the memory range to populate
- * @shadow_end   - end of the memory range to populate
+ * @shadow_start: start of the memory range to populate
+ * @shadow_end: end of the memory range to populate
  */
 int __ref kasan_populate_early_shadow(const void *shadow_start,
 					const void *shadow_end)
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kasan: fix doc warning in init.c
  2021-06-03 14:07 [PATCH] kasan: fix doc warning in init.c Yu Kuai
@ 2021-06-03 14:16   ` Andrey Ryabinin
  2021-06-05 20:15   ` Andrey Konovalov
  1 sibling, 0 replies; 5+ messages in thread
From: Andrey Ryabinin @ 2021-06-03 14:16 UTC (permalink / raw)
  To: Yu Kuai; +Cc: Andrew Morton, kasan-dev, Linux-MM, LKML, yi.zhang

On Thu, Jun 3, 2021 at 4:57 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Acked-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kasan: fix doc warning in init.c
@ 2021-06-03 14:16   ` Andrey Ryabinin
  0 siblings, 0 replies; 5+ messages in thread
From: Andrey Ryabinin @ 2021-06-03 14:16 UTC (permalink / raw)
  To: Yu Kuai; +Cc: Andrew Morton, kasan-dev, Linux-MM, LKML, yi.zhang

On Thu, Jun 3, 2021 at 4:57 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Acked-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kasan: fix doc warning in init.c
  2021-06-03 14:07 [PATCH] kasan: fix doc warning in init.c Yu Kuai
@ 2021-06-05 20:15   ` Andrey Konovalov
  2021-06-05 20:15   ` Andrey Konovalov
  1 sibling, 0 replies; 5+ messages in thread
From: Andrey Konovalov @ 2021-06-05 20:15 UTC (permalink / raw)
  To: Yu Kuai
  Cc: Andrey Ryabinin, Andrew Morton, kasan-dev,
	Linux Memory Management List, LKML, yi.zhang

On Thu, Jun 3, 2021 at 4:58 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  mm/kasan/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index c4605ac9837b..348f31d15a97 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
>  /**
>   * kasan_populate_early_shadow - populate shadow memory region with
>   *                               kasan_early_shadow_page
> - * @shadow_start - start of the memory range to populate
> - * @shadow_end   - end of the memory range to populate
> + * @shadow_start: start of the memory range to populate
> + * @shadow_end: end of the memory range to populate
>   */
>  int __ref kasan_populate_early_shadow(const void *shadow_start,
>                                         const void *shadow_end)
> --
> 2.31.1

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kasan: fix doc warning in init.c
@ 2021-06-05 20:15   ` Andrey Konovalov
  0 siblings, 0 replies; 5+ messages in thread
From: Andrey Konovalov @ 2021-06-05 20:15 UTC (permalink / raw)
  To: Yu Kuai
  Cc: Andrey Ryabinin, Andrew Morton, kasan-dev,
	Linux Memory Management List, LKML, yi.zhang

On Thu, Jun 3, 2021 at 4:58 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  mm/kasan/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index c4605ac9837b..348f31d15a97 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
>  /**
>   * kasan_populate_early_shadow - populate shadow memory region with
>   *                               kasan_early_shadow_page
> - * @shadow_start - start of the memory range to populate
> - * @shadow_end   - end of the memory range to populate
> + * @shadow_start: start of the memory range to populate
> + * @shadow_end: end of the memory range to populate
>   */
>  int __ref kasan_populate_early_shadow(const void *shadow_start,
>                                         const void *shadow_end)
> --
> 2.31.1

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-05 20:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 14:07 [PATCH] kasan: fix doc warning in init.c Yu Kuai
2021-06-03 14:16 ` Andrey Ryabinin
2021-06-03 14:16   ` Andrey Ryabinin
2021-06-05 20:15 ` Andrey Konovalov
2021-06-05 20:15   ` Andrey Konovalov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.