From: Alexandre Courbot <acourbot@chromium.org> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Tiffany Lin <tiffany.lin@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Yunfei Dong <yunfei.dong@mediatek.com>, Maoguang Meng <maoguang.meng@mediatek.com>, linux-media <linux-media@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 07/16] media: mtk-vcodec: venc: specify supported formats per-chip Date: Mon, 27 Jul 2020 18:06:42 +0900 [thread overview] Message-ID: <CAPBb6MUsSzrZAZdeH+at+9pf5sVa0ghE982ktnPW8rB91pYt6Q@mail.gmail.com> (raw) In-Reply-To: <CAAEAJfA4Po9R25CzBxiFAV=7-7rPujLc79zLnXyXWk7xNbBtYA@mail.gmail.com> On Sun, Jul 26, 2020 at 11:29 PM Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > > Hi Alexandre, > > Last review on my side, this series looks mostly good. Thanks for taking the time to look at it! I know it's not the best looking code out there. ^_^; > > On Mon, 13 Jul 2020 at 03:09, Alexandre Courbot <acourbot@chromium.org> wrote: > > > > Different chips have different supported bitrate ranges. Move the list > > s/bitrate ranges/formats Ack. > > > of supported formats to the platform data, and split the output and > > capture formats into two lists to make it easier to find the default > > format for each queue. > > > > Signed-off-by: Alexandre Courbot <acourbot@chromium.org> > > Acked-by: Tiffany Lin <tiffany.lin@mediatek.com> > > --- > > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++ > > .../platform/mtk-vcodec/mtk_vcodec_enc.c | 122 +++++++----------- > > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 40 ++++++ > > 3 files changed, 95 insertions(+), 75 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index b8f913de8d80..59b4b750666b 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -313,6 +313,10 @@ enum mtk_chip { > > * @has_lt_irq: whether the encoder uses the LT irq > > * @min_birate: minimum supported encoding bitrate > > * @max_bitrate: maximum supported encoding bitrate > > + * @capture_formats: array of supported capture formats > > + * @num_capture_formats: number of entries in capture_formats > > + * @output_formats: array of supported output formats > > + * @num_output_formats: number of entries in output_formats > > */ > > struct mtk_vcodec_enc_pdata { > > enum mtk_chip chip; > > @@ -321,6 +325,10 @@ struct mtk_vcodec_enc_pdata { > > bool has_lt_irq; > > unsigned long min_bitrate; > > unsigned long max_bitrate; > > + const struct mtk_video_fmt *capture_formats; > > + size_t num_capture_formats; > > + const struct mtk_video_fmt *output_formats; > > + size_t num_output_formats; > > }; > > > > /** > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > index 50ba9da59153..05743a745a11 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > @@ -23,47 +23,9 @@ > > #define DFT_CFG_WIDTH MTK_VENC_MIN_W > > #define DFT_CFG_HEIGHT MTK_VENC_MIN_H > > #define MTK_MAX_CTRLS_HINT 20 > > -#define OUT_FMT_IDX 0 > > -#define CAP_FMT_IDX 4 > > - > > > > static void mtk_venc_worker(struct work_struct *work); > > > > -static const struct mtk_video_fmt mtk_video_formats[] = { > > - { > > - .fourcc = V4L2_PIX_FMT_NV12M, > > - .type = MTK_FMT_FRAME, > > - .num_planes = 2, > > Again, not an issue with your patch, so feel free to ignore this. > > You may avoid keeping track of num_planes (or any other > property of the pixel format) and use v4l2_fill_pixfmt_mp > to get all the information you need. That's a good idea. Let's see if I can come with an extra patch in a way that does not prevent the already acked patches from being merged. :)
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@chromium.org> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Maoguang Meng <maoguang.meng@mediatek.com>, devicetree <devicetree@vger.kernel.org>, Yunfei Dong <yunfei.dong@mediatek.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Tiffany Lin <tiffany.lin@mediatek.com>, linux-media <linux-media@vger.kernel.org> Subject: Re: [PATCH v3 07/16] media: mtk-vcodec: venc: specify supported formats per-chip Date: Mon, 27 Jul 2020 18:06:42 +0900 [thread overview] Message-ID: <CAPBb6MUsSzrZAZdeH+at+9pf5sVa0ghE982ktnPW8rB91pYt6Q@mail.gmail.com> (raw) In-Reply-To: <CAAEAJfA4Po9R25CzBxiFAV=7-7rPujLc79zLnXyXWk7xNbBtYA@mail.gmail.com> On Sun, Jul 26, 2020 at 11:29 PM Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > > Hi Alexandre, > > Last review on my side, this series looks mostly good. Thanks for taking the time to look at it! I know it's not the best looking code out there. ^_^; > > On Mon, 13 Jul 2020 at 03:09, Alexandre Courbot <acourbot@chromium.org> wrote: > > > > Different chips have different supported bitrate ranges. Move the list > > s/bitrate ranges/formats Ack. > > > of supported formats to the platform data, and split the output and > > capture formats into two lists to make it easier to find the default > > format for each queue. > > > > Signed-off-by: Alexandre Courbot <acourbot@chromium.org> > > Acked-by: Tiffany Lin <tiffany.lin@mediatek.com> > > --- > > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++ > > .../platform/mtk-vcodec/mtk_vcodec_enc.c | 122 +++++++----------- > > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 40 ++++++ > > 3 files changed, 95 insertions(+), 75 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index b8f913de8d80..59b4b750666b 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -313,6 +313,10 @@ enum mtk_chip { > > * @has_lt_irq: whether the encoder uses the LT irq > > * @min_birate: minimum supported encoding bitrate > > * @max_bitrate: maximum supported encoding bitrate > > + * @capture_formats: array of supported capture formats > > + * @num_capture_formats: number of entries in capture_formats > > + * @output_formats: array of supported output formats > > + * @num_output_formats: number of entries in output_formats > > */ > > struct mtk_vcodec_enc_pdata { > > enum mtk_chip chip; > > @@ -321,6 +325,10 @@ struct mtk_vcodec_enc_pdata { > > bool has_lt_irq; > > unsigned long min_bitrate; > > unsigned long max_bitrate; > > + const struct mtk_video_fmt *capture_formats; > > + size_t num_capture_formats; > > + const struct mtk_video_fmt *output_formats; > > + size_t num_output_formats; > > }; > > > > /** > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > index 50ba9da59153..05743a745a11 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > @@ -23,47 +23,9 @@ > > #define DFT_CFG_WIDTH MTK_VENC_MIN_W > > #define DFT_CFG_HEIGHT MTK_VENC_MIN_H > > #define MTK_MAX_CTRLS_HINT 20 > > -#define OUT_FMT_IDX 0 > > -#define CAP_FMT_IDX 4 > > - > > > > static void mtk_venc_worker(struct work_struct *work); > > > > -static const struct mtk_video_fmt mtk_video_formats[] = { > > - { > > - .fourcc = V4L2_PIX_FMT_NV12M, > > - .type = MTK_FMT_FRAME, > > - .num_planes = 2, > > Again, not an issue with your patch, so feel free to ignore this. > > You may avoid keeping track of num_planes (or any other > property of the pixel format) and use v4l2_fill_pixfmt_mp > to get all the information you need. That's a good idea. Let's see if I can come with an extra patch in a way that does not prevent the already acked patches from being merged. :) _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-07-27 9:07 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-13 6:08 [PATCH v3 00/16] mtk-vcodec: venc: support for MT8183 and v4l2-compliance fixes Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 01/16] media: mtk-vcodec: abstract firmware interface Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-22 21:23 ` Ezequiel Garcia 2020-07-22 21:23 ` Ezequiel Garcia 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 14:24 ` Ezequiel Garcia 2020-07-27 14:24 ` Ezequiel Garcia 2020-07-27 14:25 ` Ezequiel Garcia 2020-07-27 14:25 ` Ezequiel Garcia 2020-08-21 10:35 ` Alexandre Courbot 2020-08-21 10:35 ` Alexandre Courbot 2020-08-21 10:34 ` Alexandre Courbot 2020-08-21 10:34 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 02/16] dt-bindings: media: mtk-vcodec: document SCP node Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:20 ` Chen-Yu Tsai 2020-07-13 6:20 ` Chen-Yu Tsai 2020-08-21 10:35 ` Alexandre Courbot 2020-08-21 10:35 ` Alexandre Courbot 2020-07-22 21:37 ` Ezequiel Garcia 2020-07-22 21:37 ` Ezequiel Garcia 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 14:12 ` Ezequiel Garcia 2020-07-27 14:12 ` Ezequiel Garcia 2020-07-13 6:08 ` [PATCH v3 03/16] media: mtk-vcodec: add SCP firmware ops Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-22 21:39 ` Ezequiel Garcia 2020-07-22 21:39 ` Ezequiel Garcia 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 14:09 ` Ezequiel Garcia 2020-07-27 14:09 ` Ezequiel Garcia 2020-08-21 10:35 ` Alexandre Courbot 2020-08-21 10:35 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 04/16] media: mtk-vcodec: venc: support SCP firmware Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-24 21:13 ` Ezequiel Garcia 2020-07-24 21:13 ` Ezequiel Garcia 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 9:06 ` Alexandre Courbot 2020-07-27 14:07 ` Ezequiel Garcia 2020-07-27 14:07 ` Ezequiel Garcia 2020-08-21 10:35 ` Alexandre Courbot 2020-08-21 10:35 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 05/16] media: mtk-vcodec: venc: handle firmware version field Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 06/16] media: mtk-vcodec: venc: specify bitrate range per-chip Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 07/16] media: mtk-vcodec: venc: specify supported formats per-chip Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-26 14:29 ` Ezequiel Garcia 2020-07-26 14:29 ` Ezequiel Garcia 2020-07-27 9:06 ` Alexandre Courbot [this message] 2020-07-27 9:06 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 08/16] dt-bindings: media: document mediatek,mt8183-vcodec-enc Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 08/16] dt-bindings: media: document mediatek, mt8183-vcodec-enc Alexandre Courbot 2020-07-13 23:34 ` [PATCH v3 08/16] dt-bindings: media: document mediatek,mt8183-vcodec-enc Rob Herring 2020-07-13 23:34 ` Rob Herring 2020-07-13 6:08 ` [PATCH v3 09/16] media: mtk-vcodec: add support for MT8183 encoder Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 10/16] Revert "media: mtk-vcodec: Remove extra area allocation in an input buffer on encoding" Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 11/16] media: mtk-vcodec: venc support MIN_OUTPUT_BUFFERS control Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 12/16] media: mtk-vcodec: venc: set OUTPUT buffers field to V4L2_FIELD_NONE Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 13/16] media: mtk-vcodec: venc: use platform data for ENUM_FRAMESIZES Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 14/16] media: mtk-vcodec: venc: support ENUM_FRAMESIZES on OUTPUT formats Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 15/16] media: mtk-vcodec: venc: set default time per frame Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot 2020-07-13 6:08 ` [PATCH v3 16/16] media: mtk-vcodec: venc: fix invalid time per frame in S_PARM Alexandre Courbot 2020-07-13 6:08 ` Alexandre Courbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPBb6MUsSzrZAZdeH+at+9pf5sVa0ghE982ktnPW8rB91pYt6Q@mail.gmail.com \ --to=acourbot@chromium.org \ --cc=andrew-ct.chen@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel@vanguardiasur.com.ar \ --cc=hverkuil-cisco@xs4all.nl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=maoguang.meng@mediatek.com \ --cc=tiffany.lin@mediatek.com \ --cc=yunfei.dong@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.