[Buildroot] [PATCH] package/links: enable building graphics mode with only fb driver

[Buildroot] [PATCH] package/links: enable building graphics mode with only fb driver

[Urja Rannikko]

The "fb" framebuffer driver needs GPM (mouse support) to compile,
but not DirectFB or Xorg.

Also added a Kconfig comment for easier discovery of the GPM
requirement.

Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
 package/links/Config.in | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/package/links/Config.in b/package/links/Config.in
index 713f53da4e..cc2389c9f1 100644
--- a/package/links/Config.in
+++ b/package/links/Config.in
@@ -10,11 +10,15 @@ if BR2_PACKAGE_LINKS
 
 config BR2_PACKAGE_LINKS_GRAPHICS
 	bool "use graphics"
-	depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
+	depends on BR2_PACKAGE_GPM || BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXT if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_LIBPNG
 	help
-	  Enable graphics output for DirectFB or X11.
+	  Enable graphics output for framebuffer, DirectFB or X11.
+	  Framebuffer output requires GPM (console mouse).
 	  Otherwise links will be text-mode only.
 
+comment "links graphics needs GPM, DirectFB or X11"
+	depends on !BR2_PACKAGE_GPM && !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
+
 endif
-- 
2.31.1

[Buildroot] [PATCH] package/links: enable building graphics mode with only fb driver

[Arnout Vandecappelle]

 Hi Urja,

On 27/04/2021 11:13, Urja Rannikko wrote:
> The "fb" framebuffer driver needs GPM (mouse support) to compile,
> but not DirectFB or Xorg.
> 
> Also added a Kconfig comment for easier discovery of the GPM
> requirement.
> 
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> ---
>  package/links/Config.in | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/links/Config.in b/package/links/Config.in
> index 713f53da4e..cc2389c9f1 100644
> --- a/package/links/Config.in
> +++ b/package/links/Config.in
> @@ -10,11 +10,15 @@ if BR2_PACKAGE_LINKS
>  
>  config BR2_PACKAGE_LINKS_GRAPHICS
>  	bool "use graphics"
> -	depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
> +	depends on BR2_PACKAGE_GPM || BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7

 Still not good enough, I'm afraid :-) You also need to depend on gpm in the .mk
file.

 Also, I'm thinking: maybe we can turn this around and automatically select gpm?

	select BR2_PACKAGE_GPM if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7

 That way you don't need the comment either. Well, you still do because gpm
depends on static:

	depends on !BR2_STATIC_LIBS if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7 # gpm

so the comment would become:

comment "links graphics needs dynamic libs, DirectFB or X11"
	depends on BR2_STATIC_LIBS && !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7

 Regards,
 Arnout

>  	select BR2_PACKAGE_XLIB_LIBXT if BR2_PACKAGE_XORG7
>  	select BR2_PACKAGE_LIBPNG
>  	help
> -	  Enable graphics output for DirectFB or X11.
> +	  Enable graphics output for framebuffer, DirectFB or X11.
> +	  Framebuffer output requires GPM (console mouse).
>  	  Otherwise links will be text-mode only.
>  
> +comment "links graphics needs GPM, DirectFB or X11"
> +	depends on !BR2_PACKAGE_GPM && !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
> +
>  endif
> 

[Buildroot] [PATCH] package/links: enable building graphics mode with only fb driver

[Urja Rannikko]

Hi,

On Wed, May 5, 2021 at 11:08 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>  Still not good enough, I'm afraid :-) You also need to depend on gpm in the .mk
> file.
>
It already does, atleast that's how i read this fragment in links.mk:

ifeq ($(BR2_PACKAGE_GPM),y)
LINKS_CONF_OPTS += --with-gpm
LINKS_DEPENDENCIES += gpm
else
LINKS_CONF_OPTS += --without-gpm
endif

And yes links can use GPM in textmode-only build too, so that seems
correct as-is.

>  Also, I'm thinking: maybe we can turn this around and automatically select gpm?
>
>         select BR2_PACKAGE_GPM if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
>
>  That way you don't need the comment either. Well, you still do because gpm
> depends on static:
>
>         depends on !BR2_STATIC_LIBS if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7 # gpm
>
> so the comment would become:
>
> comment "links graphics needs dynamic libs, DirectFB or X11"
>         depends on BR2_STATIC_LIBS && !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
>

I have no hard opinion on this, except that I do dislike possibly
non-obvious use of select
(and it has the dependency trouble you listed), which would leave GPM
selected if one
toggled links graphics on and off while using menuconfig.

-- 
Urja Rannikko

[Buildroot] [PATCH] package/links: enable building graphics mode with only fb driver

[Arnout Vandecappelle]

On 14/05/2021 11:26, Urja Rannikko wrote:
> Hi,
> 
> On Wed, May 5, 2021 at 11:08 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>
>>  Still not good enough, I'm afraid :-) You also need to depend on gpm in the .mk
>> file.
>>
> It already does, atleast that's how i read this fragment in links.mk:
> 
> ifeq ($(BR2_PACKAGE_GPM),y)
> LINKS_CONF_OPTS += --with-gpm
> LINKS_DEPENDENCIES += gpm
> else
> LINKS_CONF_OPTS += --without-gpm
> endif
> 
> And yes links can use GPM in textmode-only build too, so that seems
> correct as-is.

 Oops, you're right, my bad.

 Applied to next, thanks!

 Regards,
 Arnout

> 
>>  Also, I'm thinking: maybe we can turn this around and automatically select gpm?
>>
>>         select BR2_PACKAGE_GPM if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
>>
>>  That way you don't need the comment either. Well, you still do because gpm
>> depends on static:
>>
>>         depends on !BR2_STATIC_LIBS if !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7 # gpm
>>
>> so the comment would become:
>>
>> comment "links graphics needs dynamic libs, DirectFB or X11"
>>         depends on BR2_STATIC_LIBS && !BR2_PACKAGE_DIRECTFB && !BR2_PACKAGE_XORG7
>>
> 
> I have no hard opinion on this, except that I do dislike possibly
> non-obvious use of select
> (and it has the dependency trouble you listed), which would leave GPM
> selected if one
> toggled links graphics on and off while using menuconfig.
>