All of lore.kernel.org
 help / color / mirror / Atom feed
From: Urja Rannikko <urjaman@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/links: graphics mode does not depend on DirectFB or X11
Date: Tue, 27 Apr 2021 11:47:17 +0300	[thread overview]
Message-ID: <CAPCnQJm9Ng0C_Ve0Bm8GDpYYrMM9eYMBhBEouEEELBnTeSia1Q@mail.gmail.com> (raw)
In-Reply-To: <20210426223253.424b4fcb@windsurf>

Hi,

On Mon, Apr 26, 2021 at 11:32 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Urja,
>
> On Fri, 23 Apr 2021 14:21:18 +0300
> Urja Rannikko <urjaman@gmail.com> wrote:
>
> > The "fb" framebuffer driver does not have any special dependencies.
> >
> > Signed-off-by: Urja Rannikko <urjaman@gmail.com>
>
> Thanks a lot for your contribution, but unfortunately, with the patch
> you posted, links doesn't build anymore:
>
> configure: error: No graphics drivers found.
> make: *** [package/pkg-generic.mk:240: /home/thomas/projets/buildroot/output/build/links-2.21/.stamp_configured] Error 1
>
> Tested configuration:
>
> BR2_arm=y
> BR2_cortex_a9=y
> BR2_ARM_ENABLE_VFP=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> BR2_INIT_NONE=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_LINKS=y
> BR2_PACKAGE_LINKS_GRAPHICS=y
> # BR2_TARGET_ROOTFS_TAR is not set
>
> Could you have a look ?
Ah, you're right and my patch is wrong :)

The missing dependency that links wants for framebuffer is GPM (console mouse).
You can verify that by adding this to the config, it should build:
BR2_PACKAGE_GPM=y

I'll send a new patch with dependency on one of GPM, DirectFB or XORG.
This one is kinda funny to me tho... Have mouse? get graphics...
I missed it because I wanted mouse support on the linux console to begin with,
should've built as minimal as possible to test, sigh...

      reply	other threads:[~2021-04-27  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 11:21 [Buildroot] [PATCH] package/links: graphics mode does not depend on DirectFB or X11 Urja Rannikko
2021-04-26 20:32 ` Thomas Petazzoni
2021-04-27  8:47   ` Urja Rannikko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPCnQJm9Ng0C_Ve0Bm8GDpYYrMM9eYMBhBEouEEELBnTeSia1Q@mail.gmail.com \
    --to=urjaman@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.