[Buildroot] [PATCH] package/links: graphics mode does not depend on DirectFB or X11

[Buildroot] [PATCH] package/links: graphics mode does not depend on DirectFB or X11

[Urja Rannikko]

The "fb" framebuffer driver does not have any special dependencies.

Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
 package/links/Config.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/links/Config.in b/package/links/Config.in
index 713f53da4e..64683ac772 100644
--- a/package/links/Config.in
+++ b/package/links/Config.in
@@ -10,11 +10,10 @@ if BR2_PACKAGE_LINKS
 
 config BR2_PACKAGE_LINKS_GRAPHICS
 	bool "use graphics"
-	depends on BR2_PACKAGE_DIRECTFB || BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXT if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_LIBPNG
 	help
-	  Enable graphics output for DirectFB or X11.
+	  Enable graphics output for framebuffer, DirectFB or X11.
 	  Otherwise links will be text-mode only.
 
 endif
-- 
2.31.1

[Buildroot] [PATCH] package/links: graphics mode does not depend on DirectFB or X11

[Thomas Petazzoni]

Hello Urja,

On Fri, 23 Apr 2021 14:21:18 +0300
Urja Rannikko <urjaman@gmail.com> wrote:

> The "fb" framebuffer driver does not have any special dependencies.
> 
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>

Thanks a lot for your contribution, but unfortunately, with the patch
you posted, links doesn't build anymore:

configure: error: No graphics drivers found.
make: *** [package/pkg-generic.mk:240: /home/thomas/projets/buildroot/output/build/links-2.21/.stamp_configured] Error 1

Tested configuration:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_LINKS=y
BR2_PACKAGE_LINKS_GRAPHICS=y
# BR2_TARGET_ROOTFS_TAR is not set

Could you have a look ?

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/links: graphics mode does not depend on DirectFB or X11

[Urja Rannikko]

Hi,

On Mon, Apr 26, 2021 at 11:32 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Urja,
>
> On Fri, 23 Apr 2021 14:21:18 +0300
> Urja Rannikko <urjaman@gmail.com> wrote:
>
> > The "fb" framebuffer driver does not have any special dependencies.
> >
> > Signed-off-by: Urja Rannikko <urjaman@gmail.com>
>
> Thanks a lot for your contribution, but unfortunately, with the patch
> you posted, links doesn't build anymore:
>
> configure: error: No graphics drivers found.
> make: *** [package/pkg-generic.mk:240: /home/thomas/projets/buildroot/output/build/links-2.21/.stamp_configured] Error 1
>
> Tested configuration:
>
> BR2_arm=y
> BR2_cortex_a9=y
> BR2_ARM_ENABLE_VFP=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> BR2_INIT_NONE=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_LINKS=y
> BR2_PACKAGE_LINKS_GRAPHICS=y
> # BR2_TARGET_ROOTFS_TAR is not set
>
> Could you have a look ?
Ah, you're right and my patch is wrong :)

The missing dependency that links wants for framebuffer is GPM (console mouse).
You can verify that by adding this to the config, it should build:
BR2_PACKAGE_GPM=y

I'll send a new patch with dependency on one of GPM, DirectFB or XORG.
This one is kinda funny to me tho... Have mouse? get graphics...
I missed it because I wanted mouse support on the linux console to begin with,
should've built as minimal as possible to test, sigh...