All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Krause <xerofoify@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: balbi@ti.com, Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg
Date: Mon, 7 Jul 2014 13:40:40 -0400	[thread overview]
Message-ID: <CAPDOMVjpqWL-BVUPKig+2d7921105A03c1BX6164RkC=vuXBGQ@mail.gmail.com> (raw)
In-Reply-To: <20140707081456.GH28884@atomide.com>

Hey Tony,
This seems to be a false positive then.Please reply if it is so I can remove the
Fix me message.
Cheers Nick

On Mon, Jul 7, 2014 at 4:14 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
>> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
>> that the cpu is a omap16xx and the nwires are not equal to 3.
>
> This is most likely unsafe to do as the pin is probably
> shared with some other device and we have to rely for
> the bootloader to do the right thing for the board.
>
> Regards,
>
> Tony
>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  arch/arm/mach-omap1/usb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
>> index 4118db5..17e3139 100644
>> --- a/arch/arm/mach-omap1/usb.c
>> +++ b/arch/arm/mach-omap1/usb.c
>> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>>               omap_cfg_reg(W9_USB2_TXEN);
>>               omap_cfg_reg(W5_USB2_SE0);
>>               if (nwires != 3)
>> -                     omap_cfg_reg(Y5_USB2_RCV);
>> -             // FIXME omap_cfg_reg(USB2_SPEED);
>> +                     omap_cfg_reg(USB2_SPEED)
>>       } else {
>>               pr_debug("usb%d cpu unrecognized\n", 1);
>>               return 0;
>> --
>> 1.9.1
>>

WARNING: multiple messages have this Message-ID (diff)
From: xerofoify@gmail.com (Nick Krause)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-omap1: Fix call to omap_cfg_reg
Date: Mon, 7 Jul 2014 13:40:40 -0400	[thread overview]
Message-ID: <CAPDOMVjpqWL-BVUPKig+2d7921105A03c1BX6164RkC=vuXBGQ@mail.gmail.com> (raw)
In-Reply-To: <20140707081456.GH28884@atomide.com>

Hey Tony,
This seems to be a false positive then.Please reply if it is so I can remove the
Fix me message.
Cheers Nick

On Mon, Jul 7, 2014 at 4:14 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Nicholas Krause <xerofoify@gmail.com> [140704 10:03]:
>> This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
>> that the cpu is a omap16xx and the nwires are not equal to 3.
>
> This is most likely unsafe to do as the pin is probably
> shared with some other device and we have to rely for
> the bootloader to do the right thing for the board.
>
> Regards,
>
> Tony
>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  arch/arm/mach-omap1/usb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
>> index 4118db5..17e3139 100644
>> --- a/arch/arm/mach-omap1/usb.c
>> +++ b/arch/arm/mach-omap1/usb.c
>> @@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
>>               omap_cfg_reg(W9_USB2_TXEN);
>>               omap_cfg_reg(W5_USB2_SE0);
>>               if (nwires != 3)
>> -                     omap_cfg_reg(Y5_USB2_RCV);
>> -             // FIXME omap_cfg_reg(USB2_SPEED);
>> +                     omap_cfg_reg(USB2_SPEED)
>>       } else {
>>               pr_debug("usb%d cpu unrecognized\n", 1);
>>               return 0;
>> --
>> 1.9.1
>>

  reply	other threads:[~2014-07-07 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 17:02 [PATCH] mach-omap1: Fix call to omap_cfg_reg Nicholas Krause
2014-07-04 17:02 ` Nicholas Krause
2014-07-07  8:14 ` Tony Lindgren
2014-07-07  8:14   ` Tony Lindgren
2014-07-07  8:14   ` Tony Lindgren
2014-07-07 17:40   ` Nick Krause [this message]
2014-07-07 17:40     ` Nick Krause
2014-07-08  8:10     ` Tony Lindgren
2014-07-08  8:10       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDOMVjpqWL-BVUPKig+2d7921105A03c1BX6164RkC=vuXBGQ@mail.gmail.com' \
    --to=xerofoify@gmail.com \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.