From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Adrian Hunter <adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-tegra <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties Date: Tue, 19 May 2020 09:28:43 +0200 [thread overview] Message-ID: <CAPDyKFo_Xp-zipqE26iMv4CFwUoMCQZy3Zr63Cp=uzePgWX7BA@mail.gmail.com> (raw) In-Reply-To: <20200516154314.14769-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On Sat, 16 May 2020 at 17:44, Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > Several people asked me about the MMC warnings in the KMSG log and > I had to tell to ignore them because these warning are irrelevant to > pre-Tegra210 SoCs. Why are the warnings irrelevant? > It should be up to a board's device-tree writer to > properly describe all the necessary properties. Secondly, eventually all > device-tree bindings will be converted to YAML, which allows to validate > board DT files, giving a warning about missing properties. Hence let's > remove the noisy warnings to stop the confusion. Yep, makes sense. However, perhaps we should do this conversion then, rather than first drop the warnings? Kind regards Uffe > > Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > drivers/mmc/host/sdhci-tegra.c | 28 ++++------------------------ > 1 file changed, 4 insertions(+), 24 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 3e2c5101291d..83867629013d 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -607,46 +607,26 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-3v3-timeout", > &autocal->pull_up_3v3_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_3v3) && > - (tegra_host->pinctrl_state_3v3_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_up_3v3_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-3v3-timeout", > &autocal->pull_down_3v3_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_3v3) && > - (tegra_host->pinctrl_state_3v3_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_down_3v3_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-1v8-timeout", > &autocal->pull_up_1v8_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_1v8) && > - (tegra_host->pinctrl_state_1v8_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_up_1v8_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-1v8-timeout", > &autocal->pull_down_1v8_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_1v8) && > - (tegra_host->pinctrl_state_1v8_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_down_1v8_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-sdr104", > -- > 2.26.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org> To: Dmitry Osipenko <digetx@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Adrian Hunter <adrian.hunter@intel.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, linux-tegra <linux-tegra@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties Date: Tue, 19 May 2020 09:28:43 +0200 [thread overview] Message-ID: <CAPDyKFo_Xp-zipqE26iMv4CFwUoMCQZy3Zr63Cp=uzePgWX7BA@mail.gmail.com> (raw) In-Reply-To: <20200516154314.14769-1-digetx@gmail.com> On Sat, 16 May 2020 at 17:44, Dmitry Osipenko <digetx@gmail.com> wrote: > > Several people asked me about the MMC warnings in the KMSG log and > I had to tell to ignore them because these warning are irrelevant to > pre-Tegra210 SoCs. Why are the warnings irrelevant? > It should be up to a board's device-tree writer to > properly describe all the necessary properties. Secondly, eventually all > device-tree bindings will be converted to YAML, which allows to validate > board DT files, giving a warning about missing properties. Hence let's > remove the noisy warnings to stop the confusion. Yep, makes sense. However, perhaps we should do this conversion then, rather than first drop the warnings? Kind regards Uffe > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/mmc/host/sdhci-tegra.c | 28 ++++------------------------ > 1 file changed, 4 insertions(+), 24 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 3e2c5101291d..83867629013d 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -607,46 +607,26 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-3v3-timeout", > &autocal->pull_up_3v3_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_3v3) && > - (tegra_host->pinctrl_state_3v3_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_up_3v3_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-3v3-timeout", > &autocal->pull_down_3v3_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_3v3) && > - (tegra_host->pinctrl_state_3v3_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_down_3v3_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-1v8-timeout", > &autocal->pull_up_1v8_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_1v8) && > - (tegra_host->pinctrl_state_1v8_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_up_1v8_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-1v8-timeout", > &autocal->pull_down_1v8_timeout); > - if (err) { > - if (!IS_ERR(tegra_host->pinctrl_state_1v8) && > - (tegra_host->pinctrl_state_1v8_drv == NULL)) > - pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n", > - mmc_hostname(host->mmc)); > + if (err) > autocal->pull_down_1v8_timeout = 0; > - } > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-sdr104", > -- > 2.26.0 >
next prev parent reply other threads:[~2020-05-19 7:28 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-16 15:43 [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties Dmitry Osipenko 2020-05-16 15:43 ` Dmitry Osipenko [not found] ` <20200516154314.14769-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-05-19 7:28 ` Ulf Hansson [this message] 2020-05-19 7:28 ` Ulf Hansson 2020-05-19 14:05 ` Dmitry Osipenko 2020-05-19 15:29 ` Ulf Hansson [not found] ` <b634e7a5-9a30-3bd1-126d-be62e4dd73e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-05-19 16:24 ` Thierry Reding 2020-05-19 16:24 ` Thierry Reding 2020-05-19 16:33 ` Dmitry Osipenko [not found] ` <b4eb368e-adc2-7b77-3ae9-fefdcfddaf3d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-05-19 18:34 ` Sowjanya Komatineni 2020-05-19 18:34 ` Sowjanya Komatineni [not found] ` <11c93dac-f5ba-2193-6f44-63af27fdce09-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-05-19 18:41 ` Sowjanya Komatineni 2020-05-19 18:41 ` Sowjanya Komatineni 2020-05-19 19:07 ` Sowjanya Komatineni [not found] ` <c7469c16-f6f1-f9c0-566f-3b1d3774f130-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-05-19 20:44 ` Sowjanya Komatineni 2020-05-19 20:44 ` Sowjanya Komatineni 2020-05-20 2:00 ` Dmitry Osipenko [not found] ` <d2c71267-e696-c459-fbd6-dbb5fd312ed3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-05-20 11:26 ` Ulf Hansson 2020-05-20 11:26 ` Ulf Hansson [not found] ` <CAPDyKFqdeGyQpXpM+xynd_rWbi0S6hCeQS1Dyiy6Hd2E_yfHpg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2020-05-20 16:09 ` Sowjanya Komatineni 2020-05-20 16:09 ` Sowjanya Komatineni [not found] ` <96f917a3-d822-1c36-d088-3e4a322c1761-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-05-22 12:13 ` Thierry Reding 2020-05-22 12:13 ` Thierry Reding 2020-05-22 12:18 ` Dmitry Osipenko 2020-05-22 12:18 ` Dmitry Osipenko [not found] ` <2fa9db46-e310-dbbc-e1f7-f7058435a688-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-05-22 12:34 ` Thierry Reding 2020-05-22 12:34 ` Thierry Reding 2020-05-22 15:22 ` Sowjanya Komatineni 2020-05-22 15:26 ` Thierry Reding 2020-05-22 15:57 ` Sowjanya Komatineni 2020-05-25 8:47 ` Ulf Hansson 2020-05-25 8:47 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPDyKFo_Xp-zipqE26iMv4CFwUoMCQZy3Zr63Cp=uzePgWX7BA@mail.gmail.com' \ --to=ulf.hansson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \ --cc=adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.