From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-mmc <linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org Subject: Re: [PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels Date: Thu, 28 May 2015 09:23:25 +0200 [thread overview] Message-ID: <CAPDyKFocEvZnV=BpPB8L3+XvS4YrMB9OJUW4_x=7H43mDww45Q@mail.gmail.com> (raw) In-Reply-To: <1432646768-12532-6-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org> On 26 May 2015 at 15:26, Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> wrote: > Switch to use ma_request_slave_channel_compat_reason() to request the DMA I guess it should be dma_request_slave_... huh, that was a long name. :-) > channels. In case of error, return the error code we received including > -EPROBE_DEFER > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> > CC: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> With the minor change above. Acked-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Kind regards Uffe > --- > drivers/mmc/host/omap_hsmmc.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 57bb85930f81..d252478391ee 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -2088,23 +2088,21 @@ static int omap_hsmmc_probe(struct platform_device *pdev) > dma_cap_zero(mask); > dma_cap_set(DMA_SLAVE, mask); > > - host->rx_chan = > - dma_request_slave_channel_compat(mask, omap_dma_filter_fn, > - &rx_req, &pdev->dev, "rx"); > + host->rx_chan = dma_request_slave_channel_compat_reason(mask, > + omap_dma_filter_fn, &rx_req, &pdev->dev, "rx"); > > - if (!host->rx_chan) { > + if (IS_ERR(host->rx_chan)) { > dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", rx_req); > - ret = -ENXIO; > + ret = PTR_ERR(host->rx_chan); > goto err_irq; > } > > - host->tx_chan = > - dma_request_slave_channel_compat(mask, omap_dma_filter_fn, > - &tx_req, &pdev->dev, "tx"); > + host->tx_chan = dma_request_slave_channel_compat_reason(mask, > + omap_dma_filter_fn, &tx_req, &pdev->dev, "tx"); > > - if (!host->tx_chan) { > + if (IS_ERR(host->tx_chan)) { > dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", tx_req); > - ret = -ENXIO; > + ret = PTR_ERR(host->tx_chan); > goto err_irq; > } > > @@ -2166,9 +2164,9 @@ err_slot_name: > if (host->use_reg) > omap_hsmmc_reg_put(host); > err_irq: > - if (host->tx_chan) > + if (!IS_ERR_OR_NULL(host->tx_chan)) > dma_release_channel(host->tx_chan); > - if (host->rx_chan) > + if (!IS_ERR_OR_NULL(host->rx_chan)) > dma_release_channel(host->rx_chan); > pm_runtime_put_sync(host->dev); > pm_runtime_disable(host->dev); > -- > 2.3.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org> To: Peter Ujfalusi <peter.ujfalusi@ti.com> Cc: Vinod Koul <vinod.koul@intel.com>, Tony Lindgren <tony@atomide.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org, linux-serial@vger.kernel.org, linux-omap <linux-omap@vger.kernel.org>, linux-mmc <linux-mmc@vger.kernel.org>, linux-crypto@vger.kernel.org, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, linux-media@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels Date: Thu, 28 May 2015 09:23:25 +0200 [thread overview] Message-ID: <CAPDyKFocEvZnV=BpPB8L3+XvS4YrMB9OJUW4_x=7H43mDww45Q@mail.gmail.com> (raw) In-Reply-To: <1432646768-12532-6-git-send-email-peter.ujfalusi@ti.com> On 26 May 2015 at 15:26, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > Switch to use ma_request_slave_channel_compat_reason() to request the DMA I guess it should be dma_request_slave_... huh, that was a long name. :-) > channels. In case of error, return the error code we received including > -EPROBE_DEFER > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > CC: Ulf Hansson <ulf.hansson@linaro.org> With the minor change above. Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > drivers/mmc/host/omap_hsmmc.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 57bb85930f81..d252478391ee 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -2088,23 +2088,21 @@ static int omap_hsmmc_probe(struct platform_device *pdev) > dma_cap_zero(mask); > dma_cap_set(DMA_SLAVE, mask); > > - host->rx_chan = > - dma_request_slave_channel_compat(mask, omap_dma_filter_fn, > - &rx_req, &pdev->dev, "rx"); > + host->rx_chan = dma_request_slave_channel_compat_reason(mask, > + omap_dma_filter_fn, &rx_req, &pdev->dev, "rx"); > > - if (!host->rx_chan) { > + if (IS_ERR(host->rx_chan)) { > dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", rx_req); > - ret = -ENXIO; > + ret = PTR_ERR(host->rx_chan); > goto err_irq; > } > > - host->tx_chan = > - dma_request_slave_channel_compat(mask, omap_dma_filter_fn, > - &tx_req, &pdev->dev, "tx"); > + host->tx_chan = dma_request_slave_channel_compat_reason(mask, > + omap_dma_filter_fn, &tx_req, &pdev->dev, "tx"); > > - if (!host->tx_chan) { > + if (IS_ERR(host->tx_chan)) { > dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", tx_req); > - ret = -ENXIO; > + ret = PTR_ERR(host->tx_chan); > goto err_irq; > } > > @@ -2166,9 +2164,9 @@ err_slot_name: > if (host->use_reg) > omap_hsmmc_reg_put(host); > err_irq: > - if (host->tx_chan) > + if (!IS_ERR_OR_NULL(host->tx_chan)) > dma_release_channel(host->tx_chan); > - if (host->rx_chan) > + if (!IS_ERR_OR_NULL(host->rx_chan)) > dma_release_channel(host->rx_chan); > pm_runtime_put_sync(host->dev); > pm_runtime_disable(host->dev); > -- > 2.3.5 >
next prev parent reply other threads:[~2015-05-28 7:23 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-26 13:25 [PATCH 00/13] dmaengine + omap drivers: support fro deferred probing Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` [PATCH 01/13] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-29 9:33 ` Vinod Koul 2015-05-29 9:42 ` Geert Uytterhoeven 2015-05-29 9:42 ` Geert Uytterhoeven 2015-05-29 10:18 ` Vinod Koul 2015-05-29 14:32 ` Peter Ujfalusi 2015-05-29 14:32 ` Peter Ujfalusi 2015-06-02 12:55 ` Vinod Koul 2015-06-04 15:58 ` Peter Ujfalusi 2015-06-04 15:58 ` Peter Ujfalusi 2015-06-12 12:58 ` Vinod Koul 2015-06-22 11:31 ` Peter Ujfalusi 2015-06-22 11:31 ` Peter Ujfalusi 2015-06-22 11:31 ` Peter Ujfalusi 2015-06-24 16:24 ` Vinod Koul 2015-06-25 11:15 ` Arnd Bergmann 2015-11-18 14:21 ` Peter Ujfalusi 2015-11-18 14:21 ` Peter Ujfalusi 2015-11-18 14:21 ` Peter Ujfalusi 2015-11-18 14:29 ` Arnd Bergmann 2015-11-18 14:41 ` Peter Ujfalusi 2015-11-18 14:41 ` Peter Ujfalusi 2015-11-18 14:41 ` Peter Ujfalusi 2015-11-18 15:07 ` Arnd Bergmann 2015-11-18 15:43 ` Andy Shevchenko 2015-11-18 15:43 ` Andy Shevchenko [not found] ` <CAHp75VeZFXp9i_zz7CBkVQVPGQxuzYk9AbWbbbn33r8YX3LCdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-11-18 15:51 ` Arnd Bergmann 2015-11-18 15:51 ` Arnd Bergmann 2015-11-18 16:00 ` Andy Shevchenko 2015-11-18 16:06 ` Vinod Koul 2015-11-18 16:06 ` Vinod Koul 2015-11-19 10:34 ` Peter Ujfalusi 2015-11-19 10:34 ` Peter Ujfalusi 2015-11-19 11:25 ` Arnd Bergmann 2015-11-20 10:25 ` Peter Ujfalusi 2015-11-20 10:25 ` Peter Ujfalusi 2015-11-20 10:58 ` Arnd Bergmann 2015-11-20 10:58 ` Arnd Bergmann 2015-11-20 12:24 ` Andy Shevchenko 2015-11-20 12:24 ` Andy Shevchenko [not found] ` <CAHp75VdoHqPMNGFfz4mPhX+Lw+vxgiyqFS8j5+kQ9Z9CHt=OTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-11-20 12:30 ` Peter Ujfalusi 2015-11-20 12:30 ` Peter Ujfalusi [not found] ` <564F1253.4000800-l0cyMroinI0@public.gmane.org> 2015-11-20 14:08 ` Andy Shevchenko 2015-11-20 14:08 ` Andy Shevchenko 2015-11-20 12:52 ` Peter Ujfalusi 2015-11-20 12:52 ` Peter Ujfalusi 2015-11-20 12:52 ` Peter Ujfalusi [not found] ` <564F1773.9030006-l0cyMroinI0@public.gmane.org> 2015-11-20 13:48 ` Arnd Bergmann 2015-11-20 13:48 ` Arnd Bergmann 2015-11-18 15:46 ` Andy Shevchenko 2015-11-19 10:36 ` Peter Ujfalusi 2015-11-19 10:36 ` Peter Ujfalusi 2015-05-26 13:25 ` [PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel validity at module remove Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-28 7:20 ` Ulf Hansson 2015-05-26 13:26 ` [PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi [not found] ` <1432646768-12532-6-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org> 2015-05-28 7:23 ` Ulf Hansson [this message] 2015-05-28 7:23 ` Ulf Hansson 2015-05-26 13:26 ` [PATCH 06/13] mmc: omap: " Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` [PATCH 07/13] mmc: davinci_mmc: " Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-28 7:31 ` Ulf Hansson 2015-05-26 13:26 ` [PATCH 08/13] crypto: omap-aes - " Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` [PATCH 10/13] crypto: omap-sham - Support for deferred probing when requesting DMA channel Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` [PATCH 11/13] spi: omap2-mcspi: Support for deferred probing when requesting DMA channels Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 15:27 ` Mark Brown 2015-05-27 11:15 ` Peter Ujfalusi 2015-05-27 11:15 ` Peter Ujfalusi [not found] ` <5565A740.2020707-l0cyMroinI0@public.gmane.org> 2015-05-27 17:48 ` Mark Brown 2015-05-27 17:48 ` Mark Brown 2015-05-27 17:48 ` Mark Brown 2015-05-26 13:26 ` [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-11-09 19:50 ` Laurent Pinchart 2015-11-10 7:56 ` Peter Ujfalusi 2015-11-10 7:56 ` Peter Ujfalusi 2015-11-10 7:56 ` Peter Ujfalusi [not found] ` <1432646768-12532-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org> 2015-05-26 13:25 ` [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi 2015-05-26 13:25 ` Peter Ujfalusi [not found] ` <1432646768-12532-4-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org> 2015-05-26 14:44 ` Greg Kroah-Hartman 2015-05-26 14:44 ` Greg Kroah-Hartman 2015-05-27 10:41 ` Peter Ujfalusi 2015-05-27 10:41 ` Peter Ujfalusi 2015-05-27 10:41 ` Peter Ujfalusi 2015-05-27 10:41 ` Peter Ujfalusi 2015-05-26 15:08 ` Tony Lindgren 2015-05-26 15:08 ` Tony Lindgren 2015-05-27 10:58 ` Peter Ujfalusi 2015-05-27 10:58 ` Peter Ujfalusi 2015-05-26 13:26 ` [PATCH 09/13] crypto: omap-des - " Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` [PATCH 13/13] ASoC: omap-pcm: Switch to use dma_request_slave_channel_compat_reason() Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-26 13:26 ` Peter Ujfalusi 2015-05-27 17:48 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPDyKFocEvZnV=BpPB8L3+XvS4YrMB9OJUW4_x=7H43mDww45Q@mail.gmail.com' \ --to=ulf.hansson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \ --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \ --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \ --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \ --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.