[patch] PM / Domains: Fix a warning message

[patch] PM / Domains: Fix a warning message

[Dan Carpenter]

The first argument of WARN() is the condition, followed by the message.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 661737c..7b4d41f 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
 	 * powered on/off in that context.
 	 */
 	if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
-		WARN("Parent %s of subdomain %s must be IRQ safe\n",
+		WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
 				genpd->name, subdomain->name);
 		return -EINVAL;
 	}

[patch] PM / Domains: Fix a warning message

[Dan Carpenter]

The first argument of WARN() is the condition, followed by the message.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 661737c..7b4d41f 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
 	 * powered on/off in that context.
 	 */
 	if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
-		WARN("Parent %s of subdomain %s must be IRQ safe\n",
+		WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
 				genpd->name, subdomain->name);
 		return -EINVAL;
 	}

Re: [patch] PM / Domains: Fix a warning message

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Thu 2016-11-10 15:52:15, Dan Carpenter wrote:
> The first argument of WARN() is the condition, followed by the message.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [patch] PM / Domains: Fix a warning message

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Thu 2016-11-10 15:52:15, Dan Carpenter wrote:
> The first argument of WARN() is the condition, followed by the message.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [patch] PM / Domains: Fix a warning message

[Ulf Hansson]

On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The first argument of WARN() is the condition, followed by the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 661737c..7b4d41f 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
>          * powered on/off in that context.
>          */
>         if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
> -               WARN("Parent %s of subdomain %s must be IRQ safe\n",
> +               WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
>                                 genpd->name, subdomain->name);
>                 return -EINVAL;
>         }

Re: [patch] PM / Domains: Fix a warning message

[Ulf Hansson]

On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The first argument of WARN() is the condition, followed by the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 661737c..7b4d41f 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
>          * powered on/off in that context.
>          */
>         if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
> -               WARN("Parent %s of subdomain %s must be IRQ safe\n",
> +               WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
>                                 genpd->name, subdomain->name);
>                 return -EINVAL;
>         }

Re: [patch] PM / Domains: Fix a warning message

[Rafael J. Wysocki]

On Thursday, November 10, 2016 08:25:36 PM Ulf Hansson wrote:
> On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The first argument of WARN() is the condition, followed by the message.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Applied.

Thanks,
Rafael

Re: [patch] PM / Domains: Fix a warning message

[Rafael J. Wysocki]

On Thursday, November 10, 2016 08:25:36 PM Ulf Hansson wrote:
> On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The first argument of WARN() is the condition, followed by the message.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Applied.

Thanks,
Rafael