From: Ulf Hansson <ulf.hansson@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC 0/5] ARM: shmobile: rcar-gen2: Add CPG Clock Domain
Date: Fri, 20 Mar 2015 08:54:33 +0000 [thread overview]
Message-ID: <CAPDyKFox=MoUX5tzxyVjLh+d61AFNsPR+LY0sP-VF+68Gs_rKw@mail.gmail.com> (raw)
In-Reply-To: <1426708017-28885-1-git-send-email-geert+renesas@glider.be>
On 18 March 2015 at 20:46, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Hi,
>
> This RFC patch series adds Clock Domain support to the R-Car Gen2 Clock
> Pulse Generator (CPG) driver using the generic PM Domain. This allows
> to power-manage the module clocks of SoC devices that are part of the
> CPG Clock Domain using Runtime PM, or for system suspend/resume.
>
> SoC devices that are part of the CPG Clock Domain and can be
> power-managed through their primary clock are tagged in DT with a proper
> "power-domains" property. Drivers for devices with multiple clocks
> (notably du and rcar-sound) still have to manage their (multiple module)
> clocks themselves.
>
> Finally, the legacy default PM domain hack in drivers/sh/pm_runtime.c is
> disabled when running on an R-Car Gen2 SoC with genpd support.
>
> Compared to the legacy default PM domain hack, the CPG Clock Domain has
> several advantages:
> - It only affects on-SoC devices, not all platform devices,
> - It only affects the on-SoC devices we want, as specified in DT,
> - Allmost all module clocks of all on-SoC devices (barring devices
> needed for wake-up[*]) are now gated during s2ram, saving more
> power.
>
> Here's a list of all devices in the CPG Clock Domain on r8a7791:
>
> root@koelsch:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> cpg_clocks on
> /devices/platform/e61c0000.interrupt-controller active
> /devices/platform/e60b0000.i2c suspended
> /devices/platform/ffca0000.timer suspended
> /devices/platform/e6050000.gpio active
> /devices/platform/e6051000.gpio active
> /devices/platform/e6052000.gpio active
> /devices/platform/e6053000.gpio active
> /devices/platform/e6054000.gpio active
> /devices/platform/e6055000.gpio active
> /devices/platform/e6055400.gpio active
> /devices/platform/e6055800.gpio active
> /devices/platform/ee090000.pci active
> /devices/platform/ee0d0000.pci active
> /devices/platform/fe000000.pcie unsupported
> /devices/platform/e6700000.dma-controller active
> /devices/platform/e6720000.dma-controller active
> /devices/platform/ec700000.dma-controller active
> /devices/platform/ec720000.dma-controller suspended
> /devices/platform/e6e60000.serial active
> /devices/platform/e6e68000.serial active
> /devices/platform/ee300000.sata unsupported
> /devices/platform/e6b10000.spi suspended
> /devices/platform/e6e20000.spi suspended
> /devices/platform/ee700000.ethernet active
> /devices/platform/e6530000.i2c suspended
> /devices/platform/e6ef1000.video suspended
> /devices/platform/e61f0000.thermal active
> /devices/platform/ee100000.sd active
> /devices/platform/ee140000.sd active
> /devices/platform/ee160000.sd active
> root@koelsch:~#
>
> Logically, the CPG Clock Domain operates on the SoC CPG/MSTP block.
> As there's no single device node in DT representing this block (there
> are separate device nodes for the CPG and for the individual MSTP
> clocks), I bound the logic to the CPG device node.
> Perhaps this is something we should change for future SoCs?
>
> As usual when involving clocks and/or PM Domains, the DTS changes depend
> stricly on the driver change. The final patch must be applied last.
>
> The DTS changes also depend on the series "[PATCH 0/5] ARM: shmobile:
> Add INTC-SYS clock to device tree" I've just sent.
>
> This was tested on r8a7791/koelsch.
>
> Thanks for your comments!
>
> [*] GPIO wake-up requires "[PATCH 0/3] gpio: rcar: Fix wake up using
> gpio-keys with PM domain").
>
> Geert Uytterhoeven (5):
> [RFC] clk: shmobile: rcar-gen2: Add CPG Clock Domain support
> [RFC] ARM: shmobile: r8a7790 dtsi: Add CPG Clock Domain
> [RFC] ARM: shmobile: r8a7791 dtsi: Add CPG Clock Domain
> [RFC] ARM: shmobile: r8a7794 dtsi: Add CPG Clock Domain
> drivers: sh: Disable PM runtime for multi-platform R-Car Gen2 with
> genpd
>
> .../clock/renesas,rcar-gen2-cpg-clocks.txt | 26 ++++++-
> arch/arm/boot/dts/r8a7790.dtsi | 77 +++++++++++++++++++--
> arch/arm/boot/dts/r8a7791.dtsi | 80 ++++++++++++++++++++--
> arch/arm/boot/dts/r8a7794.dtsi | 29 ++++++++
> arch/arm/mach-shmobile/Kconfig | 1 +
> drivers/clk/shmobile/clk-rcar-gen2.c | 63 +++++++++++++++++
> drivers/sh/pm_runtime.c | 10 +--
> 7 files changed, 268 insertions(+), 18 deletions(-)
For the complete patchset.
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
> --
> 1.9.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH/RFC 0/5] ARM: shmobile: rcar-gen2: Add CPG Clock Domain
Date: Fri, 20 Mar 2015 09:54:33 +0100 [thread overview]
Message-ID: <CAPDyKFox=MoUX5tzxyVjLh+d61AFNsPR+LY0sP-VF+68Gs_rKw@mail.gmail.com> (raw)
In-Reply-To: <1426708017-28885-1-git-send-email-geert+renesas@glider.be>
On 18 March 2015 at 20:46, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Hi,
>
> This RFC patch series adds Clock Domain support to the R-Car Gen2 Clock
> Pulse Generator (CPG) driver using the generic PM Domain. This allows
> to power-manage the module clocks of SoC devices that are part of the
> CPG Clock Domain using Runtime PM, or for system suspend/resume.
>
> SoC devices that are part of the CPG Clock Domain and can be
> power-managed through their primary clock are tagged in DT with a proper
> "power-domains" property. Drivers for devices with multiple clocks
> (notably du and rcar-sound) still have to manage their (multiple module)
> clocks themselves.
>
> Finally, the legacy default PM domain hack in drivers/sh/pm_runtime.c is
> disabled when running on an R-Car Gen2 SoC with genpd support.
>
> Compared to the legacy default PM domain hack, the CPG Clock Domain has
> several advantages:
> - It only affects on-SoC devices, not all platform devices,
> - It only affects the on-SoC devices we want, as specified in DT,
> - Allmost all module clocks of all on-SoC devices (barring devices
> needed for wake-up[*]) are now gated during s2ram, saving more
> power.
>
> Here's a list of all devices in the CPG Clock Domain on r8a7791:
>
> root@koelsch:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> cpg_clocks on
> /devices/platform/e61c0000.interrupt-controller active
> /devices/platform/e60b0000.i2c suspended
> /devices/platform/ffca0000.timer suspended
> /devices/platform/e6050000.gpio active
> /devices/platform/e6051000.gpio active
> /devices/platform/e6052000.gpio active
> /devices/platform/e6053000.gpio active
> /devices/platform/e6054000.gpio active
> /devices/platform/e6055000.gpio active
> /devices/platform/e6055400.gpio active
> /devices/platform/e6055800.gpio active
> /devices/platform/ee090000.pci active
> /devices/platform/ee0d0000.pci active
> /devices/platform/fe000000.pcie unsupported
> /devices/platform/e6700000.dma-controller active
> /devices/platform/e6720000.dma-controller active
> /devices/platform/ec700000.dma-controller active
> /devices/platform/ec720000.dma-controller suspended
> /devices/platform/e6e60000.serial active
> /devices/platform/e6e68000.serial active
> /devices/platform/ee300000.sata unsupported
> /devices/platform/e6b10000.spi suspended
> /devices/platform/e6e20000.spi suspended
> /devices/platform/ee700000.ethernet active
> /devices/platform/e6530000.i2c suspended
> /devices/platform/e6ef1000.video suspended
> /devices/platform/e61f0000.thermal active
> /devices/platform/ee100000.sd active
> /devices/platform/ee140000.sd active
> /devices/platform/ee160000.sd active
> root@koelsch:~#
>
> Logically, the CPG Clock Domain operates on the SoC CPG/MSTP block.
> As there's no single device node in DT representing this block (there
> are separate device nodes for the CPG and for the individual MSTP
> clocks), I bound the logic to the CPG device node.
> Perhaps this is something we should change for future SoCs?
>
> As usual when involving clocks and/or PM Domains, the DTS changes depend
> stricly on the driver change. The final patch must be applied last.
>
> The DTS changes also depend on the series "[PATCH 0/5] ARM: shmobile:
> Add INTC-SYS clock to device tree" I've just sent.
>
> This was tested on r8a7791/koelsch.
>
> Thanks for your comments!
>
> [*] GPIO wake-up requires "[PATCH 0/3] gpio: rcar: Fix wake up using
> gpio-keys with PM domain").
>
> Geert Uytterhoeven (5):
> [RFC] clk: shmobile: rcar-gen2: Add CPG Clock Domain support
> [RFC] ARM: shmobile: r8a7790 dtsi: Add CPG Clock Domain
> [RFC] ARM: shmobile: r8a7791 dtsi: Add CPG Clock Domain
> [RFC] ARM: shmobile: r8a7794 dtsi: Add CPG Clock Domain
> drivers: sh: Disable PM runtime for multi-platform R-Car Gen2 with
> genpd
>
> .../clock/renesas,rcar-gen2-cpg-clocks.txt | 26 ++++++-
> arch/arm/boot/dts/r8a7790.dtsi | 77 +++++++++++++++++++--
> arch/arm/boot/dts/r8a7791.dtsi | 80 ++++++++++++++++++++--
> arch/arm/boot/dts/r8a7794.dtsi | 29 ++++++++
> arch/arm/mach-shmobile/Kconfig | 1 +
> drivers/clk/shmobile/clk-rcar-gen2.c | 63 +++++++++++++++++
> drivers/sh/pm_runtime.c | 10 +--
> 7 files changed, 268 insertions(+), 18 deletions(-)
For the complete patchset.
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
> --
> 1.9.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC 0/5] ARM: shmobile: rcar-gen2: Add CPG Clock Domain
Date: Fri, 20 Mar 2015 09:54:33 +0100 [thread overview]
Message-ID: <CAPDyKFox=MoUX5tzxyVjLh+d61AFNsPR+LY0sP-VF+68Gs_rKw@mail.gmail.com> (raw)
In-Reply-To: <1426708017-28885-1-git-send-email-geert+renesas@glider.be>
On 18 March 2015 at 20:46, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Hi,
>
> This RFC patch series adds Clock Domain support to the R-Car Gen2 Clock
> Pulse Generator (CPG) driver using the generic PM Domain. This allows
> to power-manage the module clocks of SoC devices that are part of the
> CPG Clock Domain using Runtime PM, or for system suspend/resume.
>
> SoC devices that are part of the CPG Clock Domain and can be
> power-managed through their primary clock are tagged in DT with a proper
> "power-domains" property. Drivers for devices with multiple clocks
> (notably du and rcar-sound) still have to manage their (multiple module)
> clocks themselves.
>
> Finally, the legacy default PM domain hack in drivers/sh/pm_runtime.c is
> disabled when running on an R-Car Gen2 SoC with genpd support.
>
> Compared to the legacy default PM domain hack, the CPG Clock Domain has
> several advantages:
> - It only affects on-SoC devices, not all platform devices,
> - It only affects the on-SoC devices we want, as specified in DT,
> - Allmost all module clocks of all on-SoC devices (barring devices
> needed for wake-up[*]) are now gated during s2ram, saving more
> power.
>
> Here's a list of all devices in the CPG Clock Domain on r8a7791:
>
> root at koelsch:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status slaves
> /device runtime status
> ----------------------------------------------------------------------
> cpg_clocks on
> /devices/platform/e61c0000.interrupt-controller active
> /devices/platform/e60b0000.i2c suspended
> /devices/platform/ffca0000.timer suspended
> /devices/platform/e6050000.gpio active
> /devices/platform/e6051000.gpio active
> /devices/platform/e6052000.gpio active
> /devices/platform/e6053000.gpio active
> /devices/platform/e6054000.gpio active
> /devices/platform/e6055000.gpio active
> /devices/platform/e6055400.gpio active
> /devices/platform/e6055800.gpio active
> /devices/platform/ee090000.pci active
> /devices/platform/ee0d0000.pci active
> /devices/platform/fe000000.pcie unsupported
> /devices/platform/e6700000.dma-controller active
> /devices/platform/e6720000.dma-controller active
> /devices/platform/ec700000.dma-controller active
> /devices/platform/ec720000.dma-controller suspended
> /devices/platform/e6e60000.serial active
> /devices/platform/e6e68000.serial active
> /devices/platform/ee300000.sata unsupported
> /devices/platform/e6b10000.spi suspended
> /devices/platform/e6e20000.spi suspended
> /devices/platform/ee700000.ethernet active
> /devices/platform/e6530000.i2c suspended
> /devices/platform/e6ef1000.video suspended
> /devices/platform/e61f0000.thermal active
> /devices/platform/ee100000.sd active
> /devices/platform/ee140000.sd active
> /devices/platform/ee160000.sd active
> root at koelsch:~#
>
> Logically, the CPG Clock Domain operates on the SoC CPG/MSTP block.
> As there's no single device node in DT representing this block (there
> are separate device nodes for the CPG and for the individual MSTP
> clocks), I bound the logic to the CPG device node.
> Perhaps this is something we should change for future SoCs?
>
> As usual when involving clocks and/or PM Domains, the DTS changes depend
> stricly on the driver change. The final patch must be applied last.
>
> The DTS changes also depend on the series "[PATCH 0/5] ARM: shmobile:
> Add INTC-SYS clock to device tree" I've just sent.
>
> This was tested on r8a7791/koelsch.
>
> Thanks for your comments!
>
> [*] GPIO wake-up requires "[PATCH 0/3] gpio: rcar: Fix wake up using
> gpio-keys with PM domain").
>
> Geert Uytterhoeven (5):
> [RFC] clk: shmobile: rcar-gen2: Add CPG Clock Domain support
> [RFC] ARM: shmobile: r8a7790 dtsi: Add CPG Clock Domain
> [RFC] ARM: shmobile: r8a7791 dtsi: Add CPG Clock Domain
> [RFC] ARM: shmobile: r8a7794 dtsi: Add CPG Clock Domain
> drivers: sh: Disable PM runtime for multi-platform R-Car Gen2 with
> genpd
>
> .../clock/renesas,rcar-gen2-cpg-clocks.txt | 26 ++++++-
> arch/arm/boot/dts/r8a7790.dtsi | 77 +++++++++++++++++++--
> arch/arm/boot/dts/r8a7791.dtsi | 80 ++++++++++++++++++++--
> arch/arm/boot/dts/r8a7794.dtsi | 29 ++++++++
> arch/arm/mach-shmobile/Kconfig | 1 +
> drivers/clk/shmobile/clk-rcar-gen2.c | 63 +++++++++++++++++
> drivers/sh/pm_runtime.c | 10 +--
> 7 files changed, 268 insertions(+), 18 deletions(-)
For the complete patchset.
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
> --
> 1.9.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2015-03-20 8:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:46 [PATCH/RFC 0/5] ARM: shmobile: rcar-gen2: Add CPG Clock Domain Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` [PATCH/RFC 1/5] clk: shmobile: rcar-gen2: Add CPG Clock Domain support Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-24 23:00 ` Michael Turquette
2015-03-24 23:00 ` Michael Turquette
2015-03-24 23:00 ` Michael Turquette
2015-03-25 1:04 ` Simon Horman
2015-03-25 1:04 ` Simon Horman
2015-03-25 1:04 ` Simon Horman
2015-03-30 9:58 ` Geert Uytterhoeven
2015-03-30 9:58 ` Geert Uytterhoeven
2015-03-30 9:58 ` Geert Uytterhoeven
2015-03-31 0:16 ` Simon Horman
2015-03-31 0:16 ` Simon Horman
2015-03-31 0:16 ` Simon Horman
2015-03-30 23:53 ` Laurent Pinchart
2015-03-30 23:53 ` Laurent Pinchart
2015-03-30 23:53 ` Laurent Pinchart
2015-04-01 12:13 ` Geert Uytterhoeven
2015-04-01 12:13 ` Geert Uytterhoeven
2015-04-01 12:13 ` Geert Uytterhoeven
2015-04-01 13:45 ` Laurent Pinchart
2015-04-01 13:45 ` Laurent Pinchart
2015-04-01 13:45 ` Laurent Pinchart
2015-03-31 22:25 ` Kevin Hilman
2015-03-31 22:25 ` Kevin Hilman
2015-03-31 22:25 ` Kevin Hilman
2015-03-18 19:46 ` [PATCH/RFC 2/5] ARM: shmobile: r8a7790 dtsi: Add CPG Clock Domain Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` [PATCH/RFC 3/5] ARM: shmobile: r8a7791 " Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` [PATCH/RFC 4/5] ARM: shmobile: r8a7794 " Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` [PATCH/RFC 5/5] drivers: sh: Disable PM runtime for multi-platform R-Car Gen2 with genpd Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-18 19:46 ` Geert Uytterhoeven
2015-03-20 8:54 ` Ulf Hansson [this message]
2015-03-20 8:54 ` [PATCH/RFC 0/5] ARM: shmobile: rcar-gen2: Add CPG Clock Domain Ulf Hansson
2015-03-20 8:54 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFox=MoUX5tzxyVjLh+d61AFNsPR+LY0sP-VF+68Gs_rKw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.