* [PATCH] mmc: pwrseq_sd8787: Allow being built-in irrespective of dependencies
@ 2023-01-16 11:14 Lukas Wunner
2023-01-16 12:16 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wunner @ 2023-01-16 11:14 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc, Matt Ranostay, Lubomir Rintel, Claudiu Beznea
pwrseq_sd8787 is forced to be built as a module if its dependencies are.
That's unnecessary, it's perfectly fine for it to be built-in even
though the wireless drivers that need it are modules.
Relax the depends definition in Kconfig accordingly.
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: Matt Ranostay <matt@ranostay.consulting>
Cc: Lubomir Rintel <lkundrak@v3.sk>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/mmc/core/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig
index 6f25c34e4fec..e9e9d31b39b4 100644
--- a/drivers/mmc/core/Kconfig
+++ b/drivers/mmc/core/Kconfig
@@ -15,7 +15,7 @@ config PWRSEQ_EMMC
config PWRSEQ_SD8787
tristate "HW reset support for SD8787 BT + Wifi module"
- depends on OF && (MWIFIEX || BT_MRVL_SDIO || LIBERTAS_SDIO || WILC1000_SDIO)
+ depends on OF && (MWIFIEX != n || BT_MRVL_SDIO != n || LIBERTAS_SDIO != n || WILC1000_SDIO != n)
help
This selects hardware reset support for the SD8787 BT + Wifi
module. By default this option is set to n.
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: pwrseq_sd8787: Allow being built-in irrespective of dependencies
2023-01-16 11:14 [PATCH] mmc: pwrseq_sd8787: Allow being built-in irrespective of dependencies Lukas Wunner
@ 2023-01-16 12:16 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2023-01-16 12:16 UTC (permalink / raw)
To: Lukas Wunner; +Cc: linux-mmc, Matt Ranostay, Lubomir Rintel, Claudiu Beznea
On Mon, 16 Jan 2023 at 12:15, Lukas Wunner <lukas@wunner.de> wrote:
>
> pwrseq_sd8787 is forced to be built as a module if its dependencies are.
>
> That's unnecessary, it's perfectly fine for it to be built-in even
> though the wireless drivers that need it are modules.
>
> Relax the depends definition in Kconfig accordingly.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Matt Ranostay <matt@ranostay.consulting>
> Cc: Lubomir Rintel <lkundrak@v3.sk>
> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/core/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig
> index 6f25c34e4fec..e9e9d31b39b4 100644
> --- a/drivers/mmc/core/Kconfig
> +++ b/drivers/mmc/core/Kconfig
> @@ -15,7 +15,7 @@ config PWRSEQ_EMMC
>
> config PWRSEQ_SD8787
> tristate "HW reset support for SD8787 BT + Wifi module"
> - depends on OF && (MWIFIEX || BT_MRVL_SDIO || LIBERTAS_SDIO || WILC1000_SDIO)
> + depends on OF && (MWIFIEX != n || BT_MRVL_SDIO != n || LIBERTAS_SDIO != n || WILC1000_SDIO != n)
> help
> This selects hardware reset support for the SD8787 BT + Wifi
> module. By default this option is set to n.
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-16 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-16 11:14 [PATCH] mmc: pwrseq_sd8787: Allow being built-in irrespective of dependencies Lukas Wunner
2023-01-16 12:16 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.