All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Chris Ball <chris@printf.net>, Andy Green <andy.green@linaro.org>,
	Patch Tracking <patches@linaro.org>,
	Jaswinder Singh <jaswinder.singh@linaro.org>,
	Vincent Yang <Vincent.Yang@tw.fujitsu.com>,
	Tetsuya Takinishi <t.takinishi@jp.fujitsu.com>
Subject: Re: [PATCH v3 4/4] mmc: sdhci: host: add new f_sdh30
Date: Fri, 16 Jan 2015 09:36:56 +0100	[thread overview]
Message-ID: <CAPDyKFp+sF5J2geen0K1SmU67O9vNDc_w8q92vq+ywZhv9snuw@mail.gmail.com> (raw)
In-Reply-To: <CAOEd-H3eU=OJQp5+-yzP02ccpzZdoBJ1BUeFoZiu-DhLYDhGWA@mail.gmail.com>

[...]

>>> +       pm_runtime_set_active(&pdev->dev);
>>> +       pm_runtime_enable(&pdev->dev);
>>> +       ret = pm_runtime_get_sync(&pdev->dev);
>>> +       if (ret < 0)
>>> +               dev_err(dev, "Failed to pm_runtime_get_sync: %d\n", ret);
>>
>> As I stated earlier I think this is a strange behaviour of how to
>> implement runtime PM support. Could you elaborate one more time why
>> this actually is needed?
>
> Thanks for pointing out this.
> We studied again and realized that this runtime PM support was only there for
> powerdomain management, but we have not yet upstreamed the powerdomain
> support. Thus we would like to remove it in next version.

I am fine with you removing the runtime PM support in the next
version. I also hope you to upstream the power domain support later
on, that would be nice.

A small note:
>From a driver perspective, you shall be able to implement runtime PM
support even if you haven't upstreamed the power domain support yet.
But, let's then deal with that as a separate patch later on.

Kind regards
Uffe

WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] mmc: sdhci: host: add new f_sdh30
Date: Fri, 16 Jan 2015 09:36:56 +0100	[thread overview]
Message-ID: <CAPDyKFp+sF5J2geen0K1SmU67O9vNDc_w8q92vq+ywZhv9snuw@mail.gmail.com> (raw)
In-Reply-To: <CAOEd-H3eU=OJQp5+-yzP02ccpzZdoBJ1BUeFoZiu-DhLYDhGWA@mail.gmail.com>

[...]

>>> +       pm_runtime_set_active(&pdev->dev);
>>> +       pm_runtime_enable(&pdev->dev);
>>> +       ret = pm_runtime_get_sync(&pdev->dev);
>>> +       if (ret < 0)
>>> +               dev_err(dev, "Failed to pm_runtime_get_sync: %d\n", ret);
>>
>> As I stated earlier I think this is a strange behaviour of how to
>> implement runtime PM support. Could you elaborate one more time why
>> this actually is needed?
>
> Thanks for pointing out this.
> We studied again and realized that this runtime PM support was only there for
> powerdomain management, but we have not yet upstreamed the powerdomain
> support. Thus we would like to remove it in next version.

I am fine with you removing the runtime PM support in the next
version. I also hope you to upstream the power domain support later
on, that would be nice.

A small note:
>From a driver perspective, you shall be able to implement runtime PM
support even if you haven't upstreamed the power domain support yet.
But, let's then deal with that as a separate patch later on.

Kind regards
Uffe

  reply	other threads:[~2015-01-16  8:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 11:41 [PATCH v3 0/4] mmc: sdhci: adding support for a new Fujitsu sdhci IP Vincent Yang
2015-01-09 11:41 ` Vincent Yang
2015-01-09 11:41 ` [PATCH v3 1/4] mmc: sdhci: add a voltage switch callback function Vincent Yang
2015-01-09 11:41   ` Vincent Yang
2015-01-09 11:41 ` [PATCH v3 2/4] mmc: sdhci: add a quirk for tuning work around Vincent Yang
2015-01-09 11:41   ` Vincent Yang
2015-01-09 11:41 ` [PATCH v3 3/4] mmc: sdhci: add a quirk for single block transactions Vincent Yang
2015-01-09 11:41   ` Vincent Yang
2015-01-09 11:41 ` [PATCH v3 4/4] mmc: sdhci: host: add new f_sdh30 Vincent Yang
2015-01-09 11:41   ` Vincent Yang
2015-01-13 12:19   ` Ulf Hansson
2015-01-13 12:19     ` Ulf Hansson
2015-01-16  3:33     ` Vincent Yang
2015-01-16  3:33       ` Vincent Yang
2015-01-16  8:36       ` Ulf Hansson [this message]
2015-01-16  8:36         ` Ulf Hansson
2015-01-16 17:09         ` Vincent Yang
2015-01-16 17:09           ` Vincent Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFp+sF5J2geen0K1SmU67O9vNDc_w8q92vq+ywZhv9snuw@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=Vincent.Yang@tw.fujitsu.com \
    --cc=andy.green@linaro.org \
    --cc=chris@printf.net \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=patches@linaro.org \
    --cc=t.takinishi@jp.fujitsu.com \
    --cc=vincent.yang.fujitsu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.