From: Ulf Hansson <ulf.hansson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Rui Feng <rui_feng@realsil.com.cn>,
linux-nvme@lists.infradead.org,
linux-pci <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mmc: core: Initial support for SD express card/host
Date: Fri, 24 Jul 2020 12:06:15 +0200 [thread overview]
Message-ID: <CAPDyKFp3D8xZCSGNMm2ZOpa5f5wMwderCuAA5yLMXdjoKFoxQw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1+rwY5uFpUMijgET_W78Tj+tqqKDevgqstjUmmhxdKuA@mail.gmail.com>
On Thu, 16 Jul 2020 at 20:23, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jul 16, 2020 at 4:16 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> > + /* Continue with the SD express init, if the card supports it. */
> > + resp &= 0x3000;
> > + if (pcie_bits && resp) {
> > + if (resp == 0x3000)
> > + host->ios.timing = MMC_TIMING_SD_EXP_1_2V;
> > + else
> > + host->ios.timing = MMC_TIMING_SD_EXP;
> > +
> > + /*
> > + * According to the spec the clock shall also be gated, but
> > + * let's leave this to the host driver for more flexibility.
> > + */
> > + return host->ops->init_sd_express(host, &host->ios);
> > + }
> > +
> > return 0;
> > }
>
> Does this need an additional handshake or timeout to see if the
> device was successfully probed by the nvme driver?
>
> It looks like the card would just disappear here if e.g. the nvme driver
> is not loaded or runs into a runtime error.
You are correct! In principle, the card would not be detected (it
doesn't disappear as it never gets registered). Instead, it's left in
"half-initialized" state, waiting for the nvme driver to take over.
I simply didn't want to go that far, to introduce synchronizations
steps between the nvme driver and mmc driver, but rather started
simple. Perhaps we can discuss these things as improvements on top
instead?
What do you think?
Kind regards
Uffe
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rui Feng <rui_feng@realsil.com.cn>,
linux-pci <linux-pci@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] mmc: core: Initial support for SD express card/host
Date: Fri, 24 Jul 2020 12:06:15 +0200 [thread overview]
Message-ID: <CAPDyKFp3D8xZCSGNMm2ZOpa5f5wMwderCuAA5yLMXdjoKFoxQw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1+rwY5uFpUMijgET_W78Tj+tqqKDevgqstjUmmhxdKuA@mail.gmail.com>
On Thu, 16 Jul 2020 at 20:23, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jul 16, 2020 at 4:16 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> > + /* Continue with the SD express init, if the card supports it. */
> > + resp &= 0x3000;
> > + if (pcie_bits && resp) {
> > + if (resp == 0x3000)
> > + host->ios.timing = MMC_TIMING_SD_EXP_1_2V;
> > + else
> > + host->ios.timing = MMC_TIMING_SD_EXP;
> > +
> > + /*
> > + * According to the spec the clock shall also be gated, but
> > + * let's leave this to the host driver for more flexibility.
> > + */
> > + return host->ops->init_sd_express(host, &host->ios);
> > + }
> > +
> > return 0;
> > }
>
> Does this need an additional handshake or timeout to see if the
> device was successfully probed by the nvme driver?
>
> It looks like the card would just disappear here if e.g. the nvme driver
> is not loaded or runs into a runtime error.
You are correct! In principle, the card would not be detected (it
doesn't disappear as it never gets registered). Instead, it's left in
"half-initialized" state, waiting for the nvme driver to take over.
I simply didn't want to go that far, to introduce synchronizations
steps between the nvme driver and mmc driver, but rather started
simple. Perhaps we can discuss these things as improvements on top
instead?
What do you think?
Kind regards
Uffe
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-07-24 10:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:15 [PATCH] mmc: core: Initial support for SD express card/host Ulf Hansson
2020-07-16 14:15 ` Ulf Hansson
2020-07-16 16:13 ` Greg Kroah-Hartman
2020-07-16 16:13 ` Greg Kroah-Hartman
2020-07-16 17:04 ` Ulf Hansson
2020-07-16 17:04 ` Ulf Hansson
2020-07-16 17:21 ` Greg Kroah-Hartman
2020-07-16 17:21 ` Greg Kroah-Hartman
2020-07-16 18:22 ` Arnd Bergmann
2020-07-16 18:22 ` Arnd Bergmann
2020-07-24 10:06 ` Ulf Hansson [this message]
2020-07-24 10:06 ` Ulf Hansson
2020-07-24 13:35 ` Arnd Bergmann
2020-07-24 13:35 ` Arnd Bergmann
2020-07-24 13:44 ` Christoph Hellwig
2020-07-24 13:44 ` Christoph Hellwig
2020-08-21 12:40 ` Ulf Hansson
2020-08-21 12:40 ` Ulf Hansson
2020-08-24 1:04 ` 答复: " 冯锐
2020-08-24 1:04 ` 冯锐
2020-08-24 6:33 ` Ulf Hansson
2020-08-24 6:33 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFp3D8xZCSGNMm2ZOpa5f5wMwderCuAA5yLMXdjoKFoxQw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=rui_feng@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.