* [PATCH] mmc: renesas_sdhi: use plain numbers for end_flags
@ 2022-11-22 8:05 Wolfram Sang
2022-11-22 15:44 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2022-11-22 8:05 UTC (permalink / raw)
To: linux-mmc
Cc: linux-renesas-soc, Wolfram Sang, kernel test robot, Dan Carpenter
Linux *_bit accessors take plain bit numbers, no need for BIT().
Fixes: 8d901e2ba566 ("mmc: renesas_sdhi: take DMA end interrupts into account")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
index ea2a85174a09..68da3da9e2e5 100644
--- a/drivers/mmc/host/renesas_sdhi.h
+++ b/drivers/mmc/host/renesas_sdhi.h
@@ -57,8 +57,8 @@ struct renesas_sdhi_of_data_with_quirks {
};
/* We want both end_flags to be set before we mark DMA as finished */
-#define SDHI_DMA_END_FLAG_DMA BIT(0)
-#define SDHI_DMA_END_FLAG_ACCESS BIT(1)
+#define SDHI_DMA_END_FLAG_DMA 0
+#define SDHI_DMA_END_FLAG_ACCESS 1
struct renesas_sdhi_dma {
unsigned long end_flags;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: use plain numbers for end_flags
2022-11-22 8:05 [PATCH] mmc: renesas_sdhi: use plain numbers for end_flags Wolfram Sang
@ 2022-11-22 15:44 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2022-11-22 15:44 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-mmc, linux-renesas-soc, kernel test robot, Dan Carpenter
On Tue, 22 Nov 2022 at 09:06, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Linux *_bit accessors take plain bit numbers, no need for BIT().
>
> Fixes: 8d901e2ba566 ("mmc: renesas_sdhi: take DMA end interrupts into account")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index ea2a85174a09..68da3da9e2e5 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -57,8 +57,8 @@ struct renesas_sdhi_of_data_with_quirks {
> };
>
> /* We want both end_flags to be set before we mark DMA as finished */
> -#define SDHI_DMA_END_FLAG_DMA BIT(0)
> -#define SDHI_DMA_END_FLAG_ACCESS BIT(1)
> +#define SDHI_DMA_END_FLAG_DMA 0
> +#define SDHI_DMA_END_FLAG_ACCESS 1
>
> struct renesas_sdhi_dma {
> unsigned long end_flags;
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-22 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 8:05 [PATCH] mmc: renesas_sdhi: use plain numbers for end_flags Wolfram Sang
2022-11-22 15:44 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.