From: Ulf Hansson <ulf.hansson@linaro.org>
To: Michal Simek <michal.simek@xilinx.com>,
Manish Narani <manish.narani@xilinx.com>,
Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Cc: rashmi.a@intel.com,
linux-drivers-review-request@eclists.intel.com,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kishon <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-phy@lists.infradead.org,
Mark Gross <mgross@linux.intel.com>,
kris.pan@linux.intel.com, furong.zhou@intel.com,
mallikarjunappa.sangannavar@intel.com,
Adrian Hunter <adrian.hunter@intel.com>,
mahesh.r.vaidya@intel.com, nandhini.srikandan@intel.com,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>
Subject: Re: [“PATCH” 1/2] mmc: sdhci-of-arasan: Use clock-frequency property to update clk_xin
Date: Thu, 17 Jun 2021 12:04:17 +0200 [thread overview]
Message-ID: <CAPDyKFpTf8DvauD17JR+jMH1TypgPiNs86k3YtaD4g10fRp65Q@mail.gmail.com> (raw)
In-Reply-To: <397dc803-f4ea-e8d3-9956-de8b3f537e2f@xilinx.com>
On Fri, 4 Jun 2021 at 08:13, Michal Simek <michal.simek@xilinx.com> wrote:
>
>
>
> On 6/3/21 8:22 PM, rashmi.a@intel.com wrote:
> > From: Rashmi A <rashmi.a@intel.com>
> >
> > If clock-frequency property is set and it is not the same as the current
> > clock rate of clk_xin(base clock frequency), set clk_xin to use the
> > provided clock rate.
> >
> > Signed-off-by: Rashmi A <rashmi.a@intel.com>
> > Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> > ---
> > drivers/mmc/host/sdhci-of-arasan.c | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> > index 839965f7c717..0e7c07ed9690 100644
> > --- a/drivers/mmc/host/sdhci-of-arasan.c
> > +++ b/drivers/mmc/host/sdhci-of-arasan.c
> > @@ -1542,6 +1542,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> > }
> > }
> >
> > + sdhci_get_of_property(pdev);
> > +
> > sdhci_arasan->clk_ahb = devm_clk_get(dev, "clk_ahb");
> > if (IS_ERR(sdhci_arasan->clk_ahb)) {
> > ret = dev_err_probe(dev, PTR_ERR(sdhci_arasan->clk_ahb),
> > @@ -1561,14 +1563,22 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> > goto err_pltfm_free;
> > }
> >
> > + /* If clock-frequency property is set, use the provided value */
> > + if (pltfm_host->clock &&
> > + pltfm_host->clock != clk_get_rate(clk_xin)) {
> > + ret = clk_set_rate(clk_xin, pltfm_host->clock);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Failed to set SD clock rate\n");
> > + goto clk_dis_ahb;
> > + }
> > + }
> > +
> > ret = clk_prepare_enable(clk_xin);
> > if (ret) {
> > dev_err(dev, "Unable to enable SD clock.\n");
> > goto clk_dis_ahb;
> > }
> >
> > - sdhci_get_of_property(pdev);
> > -
> > if (of_property_read_bool(np, "xlnx,fails-without-test-cd"))
> > sdhci_arasan->quirks |= SDHCI_ARASAN_QUIRK_FORCE_CDTEST;
> >
> >
>
> Manish/Sai: Please retest this on Xilinx SOC.
>
> Thanks,
> Michal
I am about to queue this patch, but it would be nice to get your
confirmation and tested-by tags before doing so. Would that be
possible within the next couple of days?
Kind regards
Uffe
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Michal Simek <michal.simek@xilinx.com>,
Manish Narani <manish.narani@xilinx.com>,
Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Cc: rashmi.a@intel.com,
linux-drivers-review-request@eclists.intel.com,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kishon <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-phy@lists.infradead.org,
Mark Gross <mgross@linux.intel.com>,
kris.pan@linux.intel.com, furong.zhou@intel.com,
mallikarjunappa.sangannavar@intel.com,
Adrian Hunter <adrian.hunter@intel.com>,
mahesh.r.vaidya@intel.com, nandhini.srikandan@intel.com,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>
Subject: Re: [“PATCH” 1/2] mmc: sdhci-of-arasan: Use clock-frequency property to update clk_xin
Date: Thu, 17 Jun 2021 12:04:17 +0200 [thread overview]
Message-ID: <CAPDyKFpTf8DvauD17JR+jMH1TypgPiNs86k3YtaD4g10fRp65Q@mail.gmail.com> (raw)
In-Reply-To: <397dc803-f4ea-e8d3-9956-de8b3f537e2f@xilinx.com>
On Fri, 4 Jun 2021 at 08:13, Michal Simek <michal.simek@xilinx.com> wrote:
>
>
>
> On 6/3/21 8:22 PM, rashmi.a@intel.com wrote:
> > From: Rashmi A <rashmi.a@intel.com>
> >
> > If clock-frequency property is set and it is not the same as the current
> > clock rate of clk_xin(base clock frequency), set clk_xin to use the
> > provided clock rate.
> >
> > Signed-off-by: Rashmi A <rashmi.a@intel.com>
> > Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> > ---
> > drivers/mmc/host/sdhci-of-arasan.c | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> > index 839965f7c717..0e7c07ed9690 100644
> > --- a/drivers/mmc/host/sdhci-of-arasan.c
> > +++ b/drivers/mmc/host/sdhci-of-arasan.c
> > @@ -1542,6 +1542,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> > }
> > }
> >
> > + sdhci_get_of_property(pdev);
> > +
> > sdhci_arasan->clk_ahb = devm_clk_get(dev, "clk_ahb");
> > if (IS_ERR(sdhci_arasan->clk_ahb)) {
> > ret = dev_err_probe(dev, PTR_ERR(sdhci_arasan->clk_ahb),
> > @@ -1561,14 +1563,22 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> > goto err_pltfm_free;
> > }
> >
> > + /* If clock-frequency property is set, use the provided value */
> > + if (pltfm_host->clock &&
> > + pltfm_host->clock != clk_get_rate(clk_xin)) {
> > + ret = clk_set_rate(clk_xin, pltfm_host->clock);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Failed to set SD clock rate\n");
> > + goto clk_dis_ahb;
> > + }
> > + }
> > +
> > ret = clk_prepare_enable(clk_xin);
> > if (ret) {
> > dev_err(dev, "Unable to enable SD clock.\n");
> > goto clk_dis_ahb;
> > }
> >
> > - sdhci_get_of_property(pdev);
> > -
> > if (of_property_read_bool(np, "xlnx,fails-without-test-cd"))
> > sdhci_arasan->quirks |= SDHCI_ARASAN_QUIRK_FORCE_CDTEST;
> >
> >
>
> Manish/Sai: Please retest this on Xilinx SOC.
>
> Thanks,
> Michal
I am about to queue this patch, but it would be nice to get your
confirmation and tested-by tags before doing so. Would that be
possible within the next couple of days?
Kind regards
Uffe
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-06-17 10:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 18:22 [“PATCH” 0/2] [KMB] mmc clock-frequency property update and rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` [“PATCH” 1/2] mmc: sdhci-of-arasan: Use clock-frequency property to update clk_xin rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-04 6:13 ` Michal Simek
2021-06-04 6:13 ` Michal Simek
2021-06-04 6:13 ` Michal Simek
2021-06-17 10:04 ` Ulf Hansson [this message]
2021-06-17 10:04 ` Ulf Hansson
2021-06-17 10:18 ` Sai Krishna Potthuri
2021-06-17 10:18 ` Sai Krishna Potthuri
2021-06-17 10:18 ` Sai Krishna Potthuri
2021-06-03 18:22 ` [“PATCH” 2/2] phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-03 18:22 ` rashmi.a
2021-06-08 12:52 ` Ulf Hansson
2021-06-08 12:52 ` Ulf Hansson
2021-06-08 12:52 ` Ulf Hansson
2021-06-09 3:40 ` Vinod Koul
2021-06-09 3:40 ` Vinod Koul
2021-06-09 3:40 ` Vinod Koul
2021-06-29 15:08 ` [“PATCH” 0/2] [KMB] mmc clock-frequency property update and Ulf Hansson
2021-06-29 15:08 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpTf8DvauD17JR+jMH1TypgPiNs86k3YtaD4g10fRp65Q@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=furong.zhou@intel.com \
--cc=kishon@ti.com \
--cc=kris.pan@linux.intel.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-drivers-review-request@eclists.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mahesh.r.vaidya@intel.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=manish.narani@xilinx.com \
--cc=mgross@linux.intel.com \
--cc=michal.simek@xilinx.com \
--cc=nandhini.srikandan@intel.com \
--cc=rashmi.a@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.