* [PATCH] mmc: core: Use pm_runtime_resume_and_get() to replace open coding
@ 2021-05-20 12:21 Tian Tao
2021-05-24 14:10 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-05-20 12:21 UTC (permalink / raw)
To: ulf.hansson; +Cc: linux-mmc, Tian Tao
use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. this change is just to simplify the code, no
actual functional changes
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/mmc/core/sdio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 3eb94ac..68edf7a 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -937,11 +937,9 @@ static void mmc_sdio_detect(struct mmc_host *host)
/* Make sure card is powered before detecting it */
if (host->caps & MMC_CAP_POWER_OFF_CARD) {
- err = pm_runtime_get_sync(&host->card->dev);
- if (err < 0) {
- pm_runtime_put_noidle(&host->card->dev);
+ err = pm_runtime_resume_and_get(&host->card->dev);
+ if (err < 0)
goto out;
- }
}
mmc_claim_host(host);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: core: Use pm_runtime_resume_and_get() to replace open coding
2021-05-20 12:21 [PATCH] mmc: core: Use pm_runtime_resume_and_get() to replace open coding Tian Tao
@ 2021-05-24 14:10 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-05-24 14:10 UTC (permalink / raw)
To: Tian Tao; +Cc: linux-mmc
On Thu, 20 May 2021 at 14:21, Tian Tao <tiantao6@hisilicon.com> wrote:
>
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/core/sdio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index 3eb94ac..68edf7a 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -937,11 +937,9 @@ static void mmc_sdio_detect(struct mmc_host *host)
>
> /* Make sure card is powered before detecting it */
> if (host->caps & MMC_CAP_POWER_OFF_CARD) {
> - err = pm_runtime_get_sync(&host->card->dev);
> - if (err < 0) {
> - pm_runtime_put_noidle(&host->card->dev);
> + err = pm_runtime_resume_and_get(&host->card->dev);
> + if (err < 0)
> goto out;
> - }
> }
>
> mmc_claim_host(host);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-24 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 12:21 [PATCH] mmc: core: Use pm_runtime_resume_and_get() to replace open coding Tian Tao
2021-05-24 14:10 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.