From: Ulf Hansson <ulf.hansson@linaro.org>
To: "David Lanzendörfer" <david.lanzendoerfer@o2s.ch>
Cc: Chen-Yu Tsai <wens@csie.org>, Chris Ball <chris@printf.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] mmc: sunxi: Declare ERASE capability
Date: Wed, 20 Aug 2014 16:20:22 +0200 [thread overview]
Message-ID: <CAPDyKFq1yzdu19ReECRZzVynHZByN4803WdZ=vjgCnC9F0+MiA@mail.gmail.com> (raw)
In-Reply-To: <3728016.4j3Ljjy6eM@dizzy-6.o2s.ch>
On 20 August 2014 16:10, David Lanzendörfer <david.lanzendoerfer@o2s.ch> wrote:
> Hi
>> Declare ERASE capability so we can use filesystems with the discard
>> option and the fstrim tool.
> I totally agree with you that information about such capabilities should be
> exposed but maybe it would be wiser to use DT instead of hardcoding it?
Nope, this is pure software support. No HW config.
What we should do future wise, is to remove the MMC_CAP_ERASE
entirely. Due to current existing bugs, mainly in mmc core layer
regarding erase, we can't do it yet.
> I mean a WiFi device won't support erase functionality...
That's already covered by the mmc core layer. No worries.
Kind regards
Uffe
WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sunxi: Declare ERASE capability
Date: Wed, 20 Aug 2014 16:20:22 +0200 [thread overview]
Message-ID: <CAPDyKFq1yzdu19ReECRZzVynHZByN4803WdZ=vjgCnC9F0+MiA@mail.gmail.com> (raw)
In-Reply-To: <3728016.4j3Ljjy6eM@dizzy-6.o2s.ch>
On 20 August 2014 16:10, David Lanzend?rfer <david.lanzendoerfer@o2s.ch> wrote:
> Hi
>> Declare ERASE capability so we can use filesystems with the discard
>> option and the fstrim tool.
> I totally agree with you that information about such capabilities should be
> exposed but maybe it would be wiser to use DT instead of hardcoding it?
Nope, this is pure software support. No HW config.
What we should do future wise, is to remove the MMC_CAP_ERASE
entirely. Due to current existing bugs, mainly in mmc core layer
regarding erase, we can't do it yet.
> I mean a WiFi device won't support erase functionality...
That's already covered by the mmc core layer. No worries.
Kind regards
Uffe
next prev parent reply other threads:[~2014-08-20 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 13:39 [PATCH] mmc: sunxi: Declare ERASE capability Chen-Yu Tsai
2014-08-20 13:39 ` Chen-Yu Tsai
2014-08-20 14:10 ` David Lanzendörfer
2014-08-20 14:10 ` David Lanzendörfer
2014-08-20 14:20 ` Ulf Hansson [this message]
2014-08-20 14:20 ` Ulf Hansson
2014-08-29 23:16 ` David Lanzendörfer
2014-08-29 23:16 ` David Lanzendörfer
2014-08-23 14:11 ` Hans de Goede
2014-08-23 14:11 ` Hans de Goede
2014-08-29 11:10 ` Ulf Hansson
2014-08-29 11:10 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFq1yzdu19ReECRZzVynHZByN4803WdZ=vjgCnC9F0+MiA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=chris@printf.net \
--cc=david.lanzendoerfer@o2s.ch \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.