All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Ludovic Barre <ludovic.Barre@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH V2 1/6] mmc: mmci: add get_datactrl_cfg callback
Date: Thu, 21 Mar 2019 17:57:38 +0100	[thread overview]
Message-ID: <CAPDyKFq52dXPP+-peh82uCqTDFhmXvYWbTyncHDr_Oyo8Bd1VA@mail.gmail.com> (raw)
In-Reply-To: <1551976742-4358-2-git-send-email-ludovic.Barre@st.com>

On Thu, 7 Mar 2019 at 17:39, Ludovic Barre <ludovic.Barre@st.com> wrote:
>
> From: Ludovic Barre <ludovic.barre@st.com>
>
> This patch adds get_datactrl_cfg callback in mmci_host_ops
> to allow to get datactrl configuration specific at variant.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
>  drivers/mmc/host/mmci.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h
> index 6bde28c..a59049b 100644
> --- a/drivers/mmc/host/mmci.h
> +++ b/drivers/mmc/host/mmci.h
> @@ -362,6 +362,7 @@ struct mmci_host_ops {
>                          bool next);
>         void (*unprep_data)(struct mmci_host *host, struct mmc_data *data,
>                             int err);
> +       u32 (*get_datactrl_cfg)(struct mmci_host *host);
>         void (*get_next_data)(struct mmci_host *host, struct mmc_data *data);
>         int (*dma_setup)(struct mmci_host *host);
>         void (*dma_release)(struct mmci_host *host);
> --
> 2.7.4
>

Perhaps squash this change with patch2, they seems to belong to each
other as they are both the preparation that is needed for the
following changes on top.

Kind regards
Uffe

WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Ludovic Barre <ludovic.Barre@st.com>
Cc: DTML <devicetree@vger.kernel.org>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 1/6] mmc: mmci: add get_datactrl_cfg callback
Date: Thu, 21 Mar 2019 17:57:38 +0100	[thread overview]
Message-ID: <CAPDyKFq52dXPP+-peh82uCqTDFhmXvYWbTyncHDr_Oyo8Bd1VA@mail.gmail.com> (raw)
In-Reply-To: <1551976742-4358-2-git-send-email-ludovic.Barre@st.com>

On Thu, 7 Mar 2019 at 17:39, Ludovic Barre <ludovic.Barre@st.com> wrote:
>
> From: Ludovic Barre <ludovic.barre@st.com>
>
> This patch adds get_datactrl_cfg callback in mmci_host_ops
> to allow to get datactrl configuration specific at variant.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
>  drivers/mmc/host/mmci.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h
> index 6bde28c..a59049b 100644
> --- a/drivers/mmc/host/mmci.h
> +++ b/drivers/mmc/host/mmci.h
> @@ -362,6 +362,7 @@ struct mmci_host_ops {
>                          bool next);
>         void (*unprep_data)(struct mmci_host *host, struct mmc_data *data,
>                             int err);
> +       u32 (*get_datactrl_cfg)(struct mmci_host *host);
>         void (*get_next_data)(struct mmci_host *host, struct mmc_data *data);
>         int (*dma_setup)(struct mmci_host *host);
>         void (*dma_release)(struct mmci_host *host);
> --
> 2.7.4
>

Perhaps squash this change with patch2, they seems to belong to each
other as they are both the preparation that is needed for the
following changes on top.

Kind regards
Uffe

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-21 16:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 16:38 [PATCH V2 0/6] mmc: mmci: add get_datactrl_cfg callback Ludovic Barre
2019-03-07 16:38 ` Ludovic Barre
2019-03-07 16:38 ` Ludovic Barre
2019-03-07 16:38 ` [PATCH V2 1/6] " Ludovic Barre
2019-03-07 16:38   ` Ludovic Barre
2019-03-07 16:38   ` Ludovic Barre
2019-03-21 16:57   ` Ulf Hansson [this message]
2019-03-21 16:57     ` Ulf Hansson
2019-03-07 16:38 ` [PATCH V2 2/6] mmc: mmci: add helper functions to define datactrl value for variants Ludovic Barre
2019-03-07 16:38   ` Ludovic Barre
2019-03-07 16:38   ` Ludovic Barre
2019-03-21 16:43   ` Ulf Hansson
2019-03-21 16:43     ` Ulf Hansson
2019-03-07 16:38 ` [PATCH V2 3/6] mmc: mmci: define get_dctrl_cfg for legacy variant Ludovic Barre
2019-03-07 16:38   ` Ludovic Barre
2019-03-07 16:38   ` Ludovic Barre
2019-03-21 16:55   ` Ulf Hansson
2019-03-21 16:55     ` Ulf Hansson
2019-03-07 16:39 ` [PATCH V2 4/6] mmc: mmci: qcom: define get_dctrl_cfg Ludovic Barre
2019-03-07 16:39   ` Ludovic Barre
2019-03-07 16:39   ` Ludovic Barre
2019-03-07 16:39 ` [PATCH V2 5/6] mmc: mmci: stm32: " Ludovic Barre
2019-03-07 16:39   ` Ludovic Barre
2019-03-07 16:39   ` Ludovic Barre
2019-03-07 16:39 ` [PATCH V2 6/6] mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback Ludovic Barre
2019-03-07 16:39   ` Ludovic Barre
2019-03-07 16:39   ` Ludovic Barre
2019-03-07 16:46   ` Russell King - ARM Linux admin
2019-03-07 16:46     ` Russell King - ARM Linux admin
2019-03-08  8:44     ` Ludovic BARRE
2019-03-08  8:44       ` Ludovic BARRE
2019-03-08  8:44       ` Ludovic BARRE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFq52dXPP+-peh82uCqTDFhmXvYWbTyncHDr_Oyo8Bd1VA@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=alexandre.torgue@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=ludovic.Barre@st.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.