* [PATCH] mmc: sdhci-s3c: drop unneeded MODULE_ALIAS
@ 2021-09-16 17:05 ` Krzysztof Kozlowski
2021-09-17 8:47 ` Jaehoon Chung
2021-09-23 18:49 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 17:05 UTC (permalink / raw)
To: linux-kernel
Cc: Krzysztof Kozlowski, Ben Dooks, Jaehoon Chung, Adrian Hunter,
Ulf Hansson, linux-mmc
The MODULE_DEVICE_TABLE already creates proper alias for platform
driver. Having another MODULE_ALIAS causes the alias to be duplicated.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/mmc/host/sdhci-s3c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 862f033d235d..9085f3932443 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -791,4 +791,3 @@ module_platform_driver(sdhci_s3c_driver);
MODULE_DESCRIPTION("Samsung SDHCI (HSMMC) glue");
MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:s3c-sdhci");
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-s3c: drop unneeded MODULE_ALIAS
2021-09-16 17:05 ` [PATCH] mmc: sdhci-s3c: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2021-09-17 8:47 ` Jaehoon Chung
2021-09-23 18:49 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2021-09-17 8:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel
Cc: Ben Dooks, Adrian Hunter, Ulf Hansson, linux-mmc
On 9/17/21 2:05 AM, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsunhg.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/host/sdhci-s3c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 862f033d235d..9085f3932443 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -791,4 +791,3 @@ module_platform_driver(sdhci_s3c_driver);
> MODULE_DESCRIPTION("Samsung SDHCI (HSMMC) glue");
> MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>");
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform:s3c-sdhci");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-s3c: drop unneeded MODULE_ALIAS
2021-09-16 17:05 ` [PATCH] mmc: sdhci-s3c: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-17 8:47 ` Jaehoon Chung
@ 2021-09-23 18:49 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2021-09-23 18:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linux Kernel Mailing List, Ben Dooks, Jaehoon Chung,
Adrian Hunter, linux-mmc
On Thu, 16 Sept 2021 at 19:05, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-s3c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 862f033d235d..9085f3932443 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -791,4 +791,3 @@ module_platform_driver(sdhci_s3c_driver);
> MODULE_DESCRIPTION("Samsung SDHCI (HSMMC) glue");
> MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>");
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform:s3c-sdhci");
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-23 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210916172004epcas1p2319884c6fcc67551399a4d0e2ba19cee@epcas1p2.samsung.com>
2021-09-16 17:05 ` [PATCH] mmc: sdhci-s3c: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-17 8:47 ` Jaehoon Chung
2021-09-23 18:49 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.