* [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER
@ 2016-11-30 12:24 Geert Uytterhoeven
2016-11-30 12:41 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-11-30 12:24 UTC (permalink / raw)
To: Rafael J. Wysocki, Kevin Hilman, Ulf Hansson
Cc: Yoshihiro Shimoda, linux-pm, linux-renesas-soc, Geert Uytterhoeven
EPROBE_DEFER is not an error, hence printing an error message like
renesas_irqc e61c0000.interrupt-controller: failed to add to PM domain always-on: -517
may confuse the user.
Suppress the error message in case of EPROBE_DEFER to fix this.
Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/base/power/domain.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 64164aac6ae3990a..f22137b52dcb641b 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2032,8 +2032,9 @@ int genpd_dev_pm_attach(struct device *dev)
mutex_unlock(&gpd_list_lock);
if (ret < 0) {
- dev_err(dev, "failed to add to PM domain %s: %d",
- pd->name, ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "failed to add to PM domain %s: %d",
+ pd->name, ret);
goto out;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER
2016-11-30 12:24 [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER Geert Uytterhoeven
@ 2016-11-30 12:41 ` Simon Horman
2016-11-30 14:34 ` Ulf Hansson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2016-11-30 12:41 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rafael J. Wysocki, Kevin Hilman, Ulf Hansson, Yoshihiro Shimoda,
linux-pm, linux-renesas-soc
On Wed, Nov 30, 2016 at 01:24:56PM +0100, Geert Uytterhoeven wrote:
> EPROBE_DEFER is not an error, hence printing an error message like
>
> renesas_irqc e61c0000.interrupt-controller: failed to add to PM domain always-on: -517
>
> may confuse the user.
>
> Suppress the error message in case of EPROBE_DEFER to fix this.
>
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER
2016-11-30 12:24 [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER Geert Uytterhoeven
2016-11-30 12:41 ` Simon Horman
@ 2016-11-30 14:34 ` Ulf Hansson
2016-11-30 16:41 ` Kevin Hilman
2016-12-01 14:25 ` Rafael J. Wysocki
3 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2016-11-30 14:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rafael J. Wysocki, Kevin Hilman, Yoshihiro Shimoda, linux-pm,
Linux-Renesas
On 30 November 2016 at 13:24, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> EPROBE_DEFER is not an error, hence printing an error message like
>
> renesas_irqc e61c0000.interrupt-controller: failed to add to PM domain always-on: -517
>
> may confuse the user.
>
> Suppress the error message in case of EPROBE_DEFER to fix this.
>
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by; Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/base/power/domain.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 64164aac6ae3990a..f22137b52dcb641b 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2032,8 +2032,9 @@ int genpd_dev_pm_attach(struct device *dev)
> mutex_unlock(&gpd_list_lock);
>
> if (ret < 0) {
> - dev_err(dev, "failed to add to PM domain %s: %d",
> - pd->name, ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "failed to add to PM domain %s: %d",
> + pd->name, ret);
> goto out;
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER
2016-11-30 12:24 [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER Geert Uytterhoeven
2016-11-30 12:41 ` Simon Horman
2016-11-30 14:34 ` Ulf Hansson
@ 2016-11-30 16:41 ` Kevin Hilman
2016-12-01 14:25 ` Rafael J. Wysocki
3 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2016-11-30 16:41 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rafael J. Wysocki, Ulf Hansson, Yoshihiro Shimoda, linux-pm,
linux-renesas-soc
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> EPROBE_DEFER is not an error, hence printing an error message like
>
> renesas_irqc e61c0000.interrupt-controller: failed to add to PM domain always-on: -517
>
> may confuse the user.
>
> Suppress the error message in case of EPROBE_DEFER to fix this.
>
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Yes, I had noticed this too but not got around to fixing it.
Acked-by: Kevin Hilman <khilman@baylibre.com>
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER
2016-11-30 12:24 [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER Geert Uytterhoeven
` (2 preceding siblings ...)
2016-11-30 16:41 ` Kevin Hilman
@ 2016-12-01 14:25 ` Rafael J. Wysocki
3 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2016-12-01 14:25 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kevin Hilman, Ulf Hansson, Yoshihiro Shimoda, linux-pm,
linux-renesas-soc
On Wednesday, November 30, 2016 01:24:56 PM Geert Uytterhoeven wrote:
> EPROBE_DEFER is not an error, hence printing an error message like
>
> renesas_irqc e61c0000.interrupt-controller: failed to add to PM domain always-on: -517
>
> may confuse the user.
>
> Suppress the error message in case of EPROBE_DEFER to fix this.
>
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/base/power/domain.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 64164aac6ae3990a..f22137b52dcb641b 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2032,8 +2032,9 @@ int genpd_dev_pm_attach(struct device *dev)
> mutex_unlock(&gpd_list_lock);
>
> if (ret < 0) {
> - dev_err(dev, "failed to add to PM domain %s: %d",
> - pd->name, ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "failed to add to PM domain %s: %d",
> + pd->name, ret);
> goto out;
> }
>
>
Applied (with ACKs etc).
Thanks,
Rafael
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-01 14:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-30 12:24 [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER Geert Uytterhoeven
2016-11-30 12:41 ` Simon Horman
2016-11-30 14:34 ` Ulf Hansson
2016-11-30 16:41 ` Kevin Hilman
2016-12-01 14:25 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.