* [PATCH] mmc: au1xmmc: propagate errors from platform_get_irq()
@ 2021-12-23 18:45 Sergey Shtylyov
2021-12-24 14:27 ` Manuel Lauss
2021-12-28 16:57 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 18:45 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Manuel Lauss
The driver overrides the error codes returned by platform_get_irq() to
-ENODEV. Switch to propagating the error codes upstream.
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
This patch is against the 'next' branch of Ulf Hansson's 'mmc.git' repo.
drivers/mmc/host/au1xmmc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux/drivers/mmc/host/au1xmmc.c
===================================================================
--- linux.orig/drivers/mmc/host/au1xmmc.c
+++ linux/drivers/mmc/host/au1xmmc.c
@@ -969,8 +969,10 @@ static int au1xmmc_probe(struct platform
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq < 0)
+ if (host->irq < 0) {
+ ret = host->irq;
goto out3;
+ }
mmc->ops = &au1xmmc_ops;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: au1xmmc: propagate errors from platform_get_irq()
2021-12-23 18:45 [PATCH] mmc: au1xmmc: propagate errors from platform_get_irq() Sergey Shtylyov
@ 2021-12-24 14:27 ` Manuel Lauss
2021-12-28 16:57 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Manuel Lauss @ 2021-12-24 14:27 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: Ulf Hansson, linux-mmc
On Thu, Dec 23, 2021 at 7:45 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes returned by platform_get_irq() to
> -ENODEV. Switch to propagating the error codes upstream.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Sure, why not.
Tested-by: Manuel Lauss <manuel.lauss@gmail.com
Manuel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: au1xmmc: propagate errors from platform_get_irq()
2021-12-23 18:45 [PATCH] mmc: au1xmmc: propagate errors from platform_get_irq() Sergey Shtylyov
2021-12-24 14:27 ` Manuel Lauss
@ 2021-12-28 16:57 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2021-12-28 16:57 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: linux-mmc, Manuel Lauss
On Thu, 23 Dec 2021 at 19:45, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes returned by platform_get_irq() to
> -ENODEV. Switch to propagating the error codes upstream.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Applied for next, thanks!
Kind regards
Uffe
>
> ---
> This patch is against the 'next' branch of Ulf Hansson's 'mmc.git' repo.
>
> drivers/mmc/host/au1xmmc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux/drivers/mmc/host/au1xmmc.c
> ===================================================================
> --- linux.orig/drivers/mmc/host/au1xmmc.c
> +++ linux/drivers/mmc/host/au1xmmc.c
> @@ -969,8 +969,10 @@ static int au1xmmc_probe(struct platform
> }
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq < 0)
> + if (host->irq < 0) {
> + ret = host->irq;
> goto out3;
> + }
>
> mmc->ops = &au1xmmc_ops;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-28 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 18:45 [PATCH] mmc: au1xmmc: propagate errors from platform_get_irq() Sergey Shtylyov
2021-12-24 14:27 ` Manuel Lauss
2021-12-28 16:57 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.