* [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select
@ 2016-12-01 4:05 Masahiro Yamada
2016-12-02 6:41 ` Ludovic Desroches
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Masahiro Yamada @ 2016-12-01 4:05 UTC (permalink / raw)
To: linux-mmc
Cc: Masahiro Yamada, Adrian Hunter, linux-kernel, Stefan Wahren,
Al Cooper, Wolfram Sang, Andrei Pistirica, Simon Horman,
Geert Uytterhoeven, Ulf Hansson
I see no override of read/write callbacks in sdhci-of-at91.c.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
BTW, this config may not be so useful in recent multi-platforms.
Perhaps, is it better to remove this config entirely instead of
the AT91 fix only.
drivers/mmc/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 39f6f96..8ac1640 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -135,7 +135,6 @@ config MMC_SDHCI_OF_AT91
tristate "SDHCI OF support for the Atmel SDMMC controller"
depends on MMC_SDHCI_PLTFM
depends on OF
- select MMC_SDHCI_IO_ACCESSORS
help
This selects the Atmel SDMMC driver
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select
2016-12-01 4:05 [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select Masahiro Yamada
@ 2016-12-02 6:41 ` Ludovic Desroches
2016-12-02 14:03 ` Adrian Hunter
2016-12-05 13:18 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Ludovic Desroches @ 2016-12-02 6:41 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mmc, Adrian Hunter, linux-kernel, Stefan Wahren, Al Cooper,
Wolfram Sang, Andrei Pistirica, Simon Horman, Geert Uytterhoeven,
Ulf Hansson
On Thu, Dec 01, 2016 at 01:05:46PM +0900, Masahiro Yamada wrote:
> I see no override of read/write callbacks in sdhci-of-at91.c.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
> ---
>
> BTW, this config may not be so useful in recent multi-platforms.
> Perhaps, is it better to remove this config entirely instead of
> the AT91 fix only.
>
>
> drivers/mmc/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 39f6f96..8ac1640 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -135,7 +135,6 @@ config MMC_SDHCI_OF_AT91
> tristate "SDHCI OF support for the Atmel SDMMC controller"
> depends on MMC_SDHCI_PLTFM
> depends on OF
> - select MMC_SDHCI_IO_ACCESSORS
> help
> This selects the Atmel SDMMC driver
>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select
@ 2016-12-02 6:41 ` Ludovic Desroches
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Desroches @ 2016-12-02 6:41 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mmc, Adrian Hunter, linux-kernel, Stefan Wahren, Al Cooper,
Wolfram Sang, Andrei Pistirica, Simon Horman, Geert Uytterhoeven,
Ulf Hansson
On Thu, Dec 01, 2016 at 01:05:46PM +0900, Masahiro Yamada wrote:
> I see no override of read/write callbacks in sdhci-of-at91.c.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
> ---
>
> BTW, this config may not be so useful in recent multi-platforms.
> Perhaps, is it better to remove this config entirely instead of
> the AT91 fix only.
>
>
> drivers/mmc/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 39f6f96..8ac1640 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -135,7 +135,6 @@ config MMC_SDHCI_OF_AT91
> tristate "SDHCI OF support for the Atmel SDMMC controller"
> depends on MMC_SDHCI_PLTFM
> depends on OF
> - select MMC_SDHCI_IO_ACCESSORS
> help
> This selects the Atmel SDMMC driver
>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select
2016-12-01 4:05 [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select Masahiro Yamada
2016-12-02 6:41 ` Ludovic Desroches
@ 2016-12-02 14:03 ` Adrian Hunter
2016-12-05 13:18 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Adrian Hunter @ 2016-12-02 14:03 UTC (permalink / raw)
To: Masahiro Yamada, linux-mmc
Cc: linux-kernel, Stefan Wahren, Al Cooper, Wolfram Sang,
Andrei Pistirica, Simon Horman, Geert Uytterhoeven, Ulf Hansson
On 01/12/16 06:05, Masahiro Yamada wrote:
> I see no override of read/write callbacks in sdhci-of-at91.c.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> BTW, this config may not be so useful in recent multi-platforms.
> Perhaps, is it better to remove this config entirely instead of
> the AT91 fix only.
>
>
> drivers/mmc/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 39f6f96..8ac1640 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -135,7 +135,6 @@ config MMC_SDHCI_OF_AT91
> tristate "SDHCI OF support for the Atmel SDMMC controller"
> depends on MMC_SDHCI_PLTFM
> depends on OF
> - select MMC_SDHCI_IO_ACCESSORS
> help
> This selects the Atmel SDMMC driver
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select
2016-12-01 4:05 [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select Masahiro Yamada
2016-12-02 6:41 ` Ludovic Desroches
2016-12-02 14:03 ` Adrian Hunter
@ 2016-12-05 13:18 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2016-12-05 13:18 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mmc, Adrian Hunter, linux-kernel, Stefan Wahren, Al Cooper,
Wolfram Sang, Andrei Pistirica, Simon Horman, Geert Uytterhoeven
On 1 December 2016 at 05:05, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> I see no override of read/write callbacks in sdhci-of-at91.c.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
>
> BTW, this config may not be so useful in recent multi-platforms.
> Perhaps, is it better to remove this config entirely instead of
> the AT91 fix only.
>
>
> drivers/mmc/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 39f6f96..8ac1640 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -135,7 +135,6 @@ config MMC_SDHCI_OF_AT91
> tristate "SDHCI OF support for the Atmel SDMMC controller"
> depends on MMC_SDHCI_PLTFM
> depends on OF
> - select MMC_SDHCI_IO_ACCESSORS
> help
> This selects the Atmel SDMMC driver
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-05 13:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-01 4:05 [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select Masahiro Yamada
2016-12-02 6:41 ` Ludovic Desroches
2016-12-02 6:41 ` Ludovic Desroches
2016-12-02 14:03 ` Adrian Hunter
2016-12-05 13:18 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.