All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Viresh Kumar <vireshk@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Russell King <linux@armlinux.org.uk>,
	Carlo Caione <carlo@caione.org>,
	Kevin Hilman <khilman@baylibre.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq
Date: Fri, 15 Dec 2017 10:18:03 +0100	[thread overview]
Message-ID: <CAPDyKFrNsTr9=fpzz2K+aQSS04ziOnLs1KxV-K0StzN=Tb=4MQ@mail.gmail.com> (raw)
In-Reply-To: <6ad5c6077b96353a77ea30d1b64651c77d5622f6.1511066652.git.arvind.yadav.cs@gmail.com>

On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
> changes in v2 :
>               Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
>               return -EINVAL instead of host->irq.
>
>  drivers/mmc/host/sunxi-mmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index cc98355d..c926ac8 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
>                 goto error_assert_reset;
>
>         host->irq = platform_get_irq(pdev, 0);
> +       if (host->irq <= 0) {
> +               ret = -EINVAL;
> +               goto error_assert_reset;
> +       }
> +
>         return devm_request_threaded_irq(&pdev->dev, host->irq, sunxi_mmc_irq,
>                         sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
>
> --
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq
Date: Fri, 15 Dec 2017 10:18:03 +0100	[thread overview]
Message-ID: <CAPDyKFrNsTr9=fpzz2K+aQSS04ziOnLs1KxV-K0StzN=Tb=4MQ@mail.gmail.com> (raw)
In-Reply-To: <6ad5c6077b96353a77ea30d1b64651c77d5622f6.1511066652.git.arvind.yadav.cs@gmail.com>

On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
> changes in v2 :
>               Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
>               return -EINVAL instead of host->irq.
>
>  drivers/mmc/host/sunxi-mmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index cc98355d..c926ac8 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
>                 goto error_assert_reset;
>
>         host->irq = platform_get_irq(pdev, 0);
> +       if (host->irq <= 0) {
> +               ret = -EINVAL;
> +               goto error_assert_reset;
> +       }
> +
>         return devm_request_threaded_irq(&pdev->dev, host->irq, sunxi_mmc_irq,
>                         sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
>
> --
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 6/6 v3] mmc: sunxi-mmc: Handle return value of platform_get_irq
Date: Fri, 15 Dec 2017 10:18:03 +0100	[thread overview]
Message-ID: <CAPDyKFrNsTr9=fpzz2K+aQSS04ziOnLs1KxV-K0StzN=Tb=4MQ@mail.gmail.com> (raw)
In-Reply-To: <6ad5c6077b96353a77ea30d1b64651c77d5622f6.1511066652.git.arvind.yadav.cs@gmail.com>

On 19 November 2017 at 05:52, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
> changes in v2 :
>               Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v3 :
>               return -EINVAL instead of host->irq.
>
>  drivers/mmc/host/sunxi-mmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index cc98355d..c926ac8 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
>                 goto error_assert_reset;
>
>         host->irq = platform_get_irq(pdev, 0);
> +       if (host->irq <= 0) {
> +               ret = -EINVAL;
> +               goto error_assert_reset;
> +       }
> +
>         return devm_request_threaded_irq(&pdev->dev, host->irq, sunxi_mmc_irq,
>                         sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);
>
> --
> 2.7.4
>

  reply	other threads:[~2017-12-15  9:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-19  4:52 [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Arvind Yadav
2017-11-19  4:52 ` Arvind Yadav
2017-11-19  4:52 ` Arvind Yadav
2017-11-19  4:52 ` [PATCH 2/6 v3] mmc: s3cmci: " Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-12-15  9:17   ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-11-19  4:52 ` [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-11-22 12:02   ` Adrian Hunter
2017-11-22 12:02     ` Adrian Hunter
2017-11-22 12:02     ` Adrian Hunter
2017-12-15  9:17   ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-11-19  4:52 ` [PATCH 4/6 v3] mmc: sdhci-spear: " Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-11-20  6:45   ` Viresh Kumar
2017-11-20  6:45     ` Viresh Kumar
2017-11-20  6:45     ` Viresh Kumar
2017-12-15  9:17   ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-12-15  9:17     ` Ulf Hansson
2017-11-19  4:52 ` [PATCH 6/6 v3] mmc: sunxi-mmc: " Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-11-19  4:52   ` Arvind Yadav
2017-12-15  9:18   ` Ulf Hansson [this message]
2017-12-15  9:18     ` Ulf Hansson
2017-12-15  9:18     ` Ulf Hansson
2017-12-15  9:18     ` Ulf Hansson
2017-12-07  0:58 ` [PATCH 1/6 v3] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Kevin Hilman
2017-12-07  0:58   ` Kevin Hilman
2017-12-07  0:58   ` Kevin Hilman
2017-12-15  9:17 ` Ulf Hansson
2017-12-15  9:17   ` Ulf Hansson
2017-12-15  9:17   ` Ulf Hansson
2017-12-15  9:17   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFrNsTr9=fpzz2K+aQSS04ziOnLs1KxV-K0StzN=Tb=4MQ@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=carlo@caione.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.ripard@free-electrons.com \
    --cc=vireshk@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.