Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci

From: Ulf Hansson <ulf.hansson@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Lina Iyer <ilina@codeaurora.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Benjamin Gaignard <benjamin.gaignard@st.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
Date: Wed, 23 Sep 2020 15:44:53 +0200	[thread overview]
Message-ID: <CAPDyKFrPRjgqzN2TXCh8A8P3H8g7FFQKRo8WZeLuCnMbMsT3bA@mail.gmail.com> (raw)
In-Reply-To: <20200923081106.GA30942@e121166-lin.cambridge.arm.com>

On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > Extend the file pattern to also include cpuidle-psci.h and
> > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > particularly to help with the support for PM domains.
> > >
> > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Any objections from the original maintainers?
>
> The PSCI driver providing support for platform coordinated idle states
> (that this patch is targeting AFAICS) does not require more maintainers,
> that support is complete and Sudeep and I will take care of refactoring
> and fixes.
>
> If the OSI bits in it require a specific maintainer I would prefer those
> bits to be moved into a specific file and maintainership added
> _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for
genpd) is still being worked upon. The corresponding code deserves to
be looked after by someone. I offer my help with this.

I guess we can split up the code as you suggest, but perhaps another
way would be to explicitly state my part of the responsibility in
MAINTAINERS. Along the lines of this:

M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains

Would that be okay to you?

Kind regards
Uffe

>
> Thanks,
> Lorenzo
>
> > >  MAINTAINERS | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f9ae8ea54e27..66821197175e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > >  CPUIDLE DRIVER - ARM PSCI
> > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > >  L:     linux-pm@vger.kernel.org
> > >  L:     linux-arm-kernel@lists.infradead.org
> > >  S:     Supported
> > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > +F:     drivers/cpuidle/cpuidle-psci*
> > >
> > >  CRAMFS FILESYSTEM
> > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > --
> > > 2.25.1
> > >