[PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency

[PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency

[Krzysztof Kozlowski]

The meta-schema already defines dependency between clock-cells and
clock-output-names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
index 23abb7e8b9d8..dd70431df0b7 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
@@ -158,10 +158,6 @@ properties:
     description:
       The MIO bank number in which the command and data lines are configured.
 
-dependencies:
-  clock-output-names: [ '#clock-cells' ]
-  '#clock-cells': [ clock-output-names ]
-
 required:
   - compatible
   - reg
-- 
2.30.2

Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency

[Ulf Hansson]

On Tue, 28 Sept 2021 at 10:23, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The meta-schema already defines dependency between clock-cells and
> clock-output-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 23abb7e8b9d8..dd70431df0b7 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,10 +158,6 @@ properties:
>      description:
>        The MIO bank number in which the command and data lines are configured.
>
> -dependencies:
> -  clock-output-names: [ '#clock-cells' ]
> -  '#clock-cells': [ clock-output-names ]
> -
>  required:
>    - compatible
>    - reg
> --
> 2.30.2
>

Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency

[Rob Herring]

On Tue, Sep 28, 2021 at 10:23:46AM +0200, Krzysztof Kozlowski wrote:
> The meta-schema already defines dependency between clock-cells and

You mean the schema already does.

> clock-output-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 23abb7e8b9d8..dd70431df0b7 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,10 +158,6 @@ properties:
>      description:
>        The MIO bank number in which the command and data lines are configured.
>  
> -dependencies:
> -  clock-output-names: [ '#clock-cells' ]

The schema defines this.

> -  '#clock-cells': [ clock-output-names ]

But not this. That's because in the common case, clock-output-names is 
optional. But here it is required when '#clock-cells' is present.

Rob

Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency

[Krzysztof Kozlowski]

On 04/10/2021 16:56, Rob Herring wrote:
> On Tue, Sep 28, 2021 at 10:23:46AM +0200, Krzysztof Kozlowski wrote:
>> The meta-schema already defines dependency between clock-cells and
> 
> You mean the schema already does.

Yes.

> 
>> clock-output-names.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> index 23abb7e8b9d8..dd70431df0b7 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> @@ -158,10 +158,6 @@ properties:
>>      description:
>>        The MIO bank number in which the command and data lines are configured.
>>  
>> -dependencies:
>> -  clock-output-names: [ '#clock-cells' ]
> 
> The schema defines this.
> 
>> -  '#clock-cells': [ clock-output-names ]
> 
> But not this. That's because in the common case, clock-output-names is 
> optional. But here it is required when '#clock-cells' is present.

You are right, somehow I missed that part...


Best regards,
Krzysztof