* [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command()
@ 2018-07-25 8:46 Masahiro Yamada
2018-07-25 10:18 ` Wolfram Sang
2018-07-30 15:06 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-07-25 8:46 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, Masahiro Yamada, linux-kernel, Ulf Hansson
Pass TMIO_MASK_CMD to tmio_mmc_enable_mmc_irqs() directly,
and remove the variable, irq_mask.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/tmio_mmc_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 3080299..3cb554c 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -309,7 +309,6 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
{
struct mmc_data *data = host->data;
int c = cmd->opcode;
- u32 irq_mask = TMIO_MASK_CMD;
switch (mmc_resp_type(cmd)) {
case MMC_RSP_NONE: c |= RESP_NONE; break;
@@ -349,7 +348,7 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
c |= TRANSFER_READ;
}
- tmio_mmc_enable_mmc_irqs(host, irq_mask);
+ tmio_mmc_enable_mmc_irqs(host, TMIO_MASK_CMD);
/* Fire off the command */
sd_ctrl_write32_as_16_and_16(host, CTL_ARG_REG, cmd->arg);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command()
2018-07-25 8:46 [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command() Masahiro Yamada
@ 2018-07-25 10:18 ` Wolfram Sang
2018-07-30 15:06 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2018-07-25 10:18 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Wolfram Sang, linux-mmc, linux-kernel, Ulf Hansson
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
On Wed, Jul 25, 2018 at 05:46:14PM +0900, Masahiro Yamada wrote:
> Pass TMIO_MASK_CMD to tmio_mmc_enable_mmc_irqs() directly,
> and remove the variable, irq_mask.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command()
2018-07-25 8:46 [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command() Masahiro Yamada
2018-07-25 10:18 ` Wolfram Sang
@ 2018-07-30 15:06 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2018-07-30 15:06 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Wolfram Sang, linux-mmc, Linux Kernel Mailing List
On 25 July 2018 at 10:46, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Pass TMIO_MASK_CMD to tmio_mmc_enable_mmc_irqs() directly,
> and remove the variable, irq_mask.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/tmio_mmc_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 3080299..3cb554c 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -309,7 +309,6 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
> {
> struct mmc_data *data = host->data;
> int c = cmd->opcode;
> - u32 irq_mask = TMIO_MASK_CMD;
>
> switch (mmc_resp_type(cmd)) {
> case MMC_RSP_NONE: c |= RESP_NONE; break;
> @@ -349,7 +348,7 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
> c |= TRANSFER_READ;
> }
>
> - tmio_mmc_enable_mmc_irqs(host, irq_mask);
> + tmio_mmc_enable_mmc_irqs(host, TMIO_MASK_CMD);
>
> /* Fire off the command */
> sd_ctrl_write32_as_16_and_16(host, CTL_ARG_REG, cmd->arg);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-30 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 8:46 [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command() Masahiro Yamada
2018-07-25 10:18 ` Wolfram Sang
2018-07-30 15:06 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.