* [PATCH] mmc: tegra: don't enable UHS modes on Tegra210
@ 2015-12-30 15:49 Lucas Stach
[not found] ` <1451490549-21430-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2016-01-05 17:06 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Lucas Stach @ 2015-12-30 15:49 UTC (permalink / raw)
To: Ulf Hansson
Cc: Stephen Warren, Thierry Reding, Alexandre Courbot,
linux-mmc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Tegra210 needs a different tuning sequence than Tegra30+. Disable
UHS modes until support for this is properly added.
Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
---
Ulf,
this is a follow on patch to my Tegra UHS-I series. After reading the
Tegra210 TRM I realized that the currently implemented tuning sequence will
only work on Tegra30..Tegra124. If you don't keep your tree stable you
might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes,
otherwise please pick this up as a fix on top.
---
drivers/mmc/host/sdhci-tegra.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index b5abbe2..83c4bf7 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -353,9 +353,6 @@ static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
.pdata = &sdhci_tegra210_pdata,
- .nvquirks = NVQUIRK_ENABLE_SDR50 |
- NVQUIRK_ENABLE_DDR50 |
- NVQUIRK_ENABLE_SDR104,
};
static const struct of_device_id sdhci_tegra_dt_match[] = {
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: tegra: don't enable UHS modes on Tegra210
[not found] ` <1451490549-21430-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
@ 2016-01-04 7:51 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-01-04 7:51 UTC (permalink / raw)
To: Lucas Stach
Cc: Ulf Hansson, Stephen Warren, Alexandre Courbot,
linux-mmc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Wed, Dec 30, 2015 at 04:49:09PM +0100, Lucas Stach wrote:
> Tegra210 needs a different tuning sequence than Tegra30+. Disable
> UHS modes until support for this is properly added.
>
> Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
> ---
> Ulf,
> this is a follow on patch to my Tegra UHS-I series. After reading the
> Tegra210 TRM I realized that the currently implemented tuning sequence will
> only work on Tegra30..Tegra124. If you don't keep your tree stable you
> might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes,
> otherwise please pick this up as a fix on top.
> ---
> drivers/mmc/host/sdhci-tegra.c | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: tegra: don't enable UHS modes on Tegra210
2015-12-30 15:49 [PATCH] mmc: tegra: don't enable UHS modes on Tegra210 Lucas Stach
[not found] ` <1451490549-21430-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
@ 2016-01-05 17:06 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2016-01-05 17:06 UTC (permalink / raw)
To: Lucas Stach
Cc: Stephen Warren, Thierry Reding, Alexandre Courbot, linux-mmc,
linux-tegra
On 30 December 2015 at 16:49, Lucas Stach <dev@lynxeye.de> wrote:
> Tegra210 needs a different tuning sequence than Tegra30+. Disable
> UHS modes until support for this is properly added.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> Ulf,
> this is a follow on patch to my Tegra UHS-I series. After reading the
> Tegra210 TRM I realized that the currently implemented tuning sequence will
> only work on Tegra30..Tegra124. If you don't keep your tree stable you
> might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes,
> otherwise please pick this up as a fix on top.
Thanks, I have squashed the change into patch4.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b5abbe2..83c4bf7 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -353,9 +353,6 @@ static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
>
> static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
> .pdata = &sdhci_tegra210_pdata,
> - .nvquirks = NVQUIRK_ENABLE_SDR50 |
> - NVQUIRK_ENABLE_DDR50 |
> - NVQUIRK_ENABLE_SDR104,
> };
>
> static const struct of_device_id sdhci_tegra_dt_match[] = {
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-05 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-30 15:49 [PATCH] mmc: tegra: don't enable UHS modes on Tegra210 Lucas Stach
[not found] ` <1451490549-21430-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2016-01-04 7:51 ` Thierry Reding
2016-01-05 17:06 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.