* [PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-10-30 1:28 Tian Tao
2020-11-05 12:58 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-10-30 1:28 UTC (permalink / raw)
To: ulf.hansson, linux-mmc, linux-kernel
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/mmc/host/moxart-mmc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
index f25079b..89bff4e 100644
--- a/drivers/mmc/host/moxart-mmc.c
+++ b/drivers/mmc/host/moxart-mmc.c
@@ -465,9 +465,8 @@ static irqreturn_t moxart_irq(int irq, void *devid)
{
struct moxart_host *host = (struct moxart_host *)devid;
u32 status;
- unsigned long flags;
- spin_lock_irqsave(&host->lock, flags);
+ spin_lock(&host->lock);
status = readl(host->base + REG_STATUS);
if (status & CARD_CHANGE) {
@@ -484,7 +483,7 @@ static irqreturn_t moxart_irq(int irq, void *devid)
if (status & (FIFO_ORUN | FIFO_URUN) && host->mrq)
moxart_transfer_pio(host);
- spin_unlock_irqrestore(&host->lock, flags);
+ spin_unlock(&host->lock);
return IRQ_HANDLED;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-10-30 1:28 [PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
@ 2020-11-05 12:58 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2020-11-05 12:58 UTC (permalink / raw)
To: Tian Tao; +Cc: linux-mmc, Linux Kernel Mailing List
On Fri, 30 Oct 2020 at 02:28, Tian Tao <tiantao6@hisilicon.com> wrote:
>
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/moxart-mmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
> index f25079b..89bff4e 100644
> --- a/drivers/mmc/host/moxart-mmc.c
> +++ b/drivers/mmc/host/moxart-mmc.c
> @@ -465,9 +465,8 @@ static irqreturn_t moxart_irq(int irq, void *devid)
> {
> struct moxart_host *host = (struct moxart_host *)devid;
> u32 status;
> - unsigned long flags;
>
> - spin_lock_irqsave(&host->lock, flags);
> + spin_lock(&host->lock);
>
> status = readl(host->base + REG_STATUS);
> if (status & CARD_CHANGE) {
> @@ -484,7 +483,7 @@ static irqreturn_t moxart_irq(int irq, void *devid)
> if (status & (FIFO_ORUN | FIFO_URUN) && host->mrq)
> moxart_transfer_pio(host);
>
> - spin_unlock_irqrestore(&host->lock, flags);
> + spin_unlock(&host->lock);
>
> return IRQ_HANDLED;
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-05 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 1:28 [PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-11-05 12:58 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.