* Re: [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis
2021-09-05 9:02 [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis Krish Jain
@ 2021-09-05 22:39 ` Krish Jain
2021-09-06 7:57 ` Dan Carpenter
2021-09-06 7:55 ` Dan Carpenter
2021-09-06 9:38 ` Greg KH
2 siblings, 1 reply; 5+ messages in thread
From: Krish Jain @ 2021-09-05 22:39 UTC (permalink / raw)
To: Greg KH; +Cc: linux-staging
On Sat, Sep 4, 2021 at 10:48 PM Krish Jain <krishjain02939@gmail.com> wrote:
>
> From: Krish Jain <krishjain02939@gmail.com>
>
> This patch fixes the format of the code. It properly formats lines that
> should not end with a '(' as suggested by checkpath.pl.
>
> Signed-off-by: Krish Jain <krishjain02939@gmail.com>
> ---
> drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index b0ed935de7ac..89b72a802800 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
> struct mtk_hsdma_chan chan[1];
> };
>
> -static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
> - struct mtk_hsdma_chan *chan)
> +static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
> {
> return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
> ddev);
> @@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
> return container_of(c, struct mtk_hsdma_chan, vchan.chan);
> }
>
> -static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
> - struct virt_dma_desc *vdesc)
> +static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
> {
> return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
> }
> @@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> spin_unlock_bh(&chan->vchan.lock);
> }
>
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> - struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> - size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
> {
> struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
> struct mtk_hsdma_desc *desc;
> --
> 2.25.1
>
Hi, Greg, just to follow up on this, is this submission OK?
Best Regards,
Krish
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis
2021-09-05 22:39 ` Krish Jain
@ 2021-09-06 7:57 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-09-06 7:57 UTC (permalink / raw)
To: Krish Jain; +Cc: Greg KH, linux-staging
On Mon, Sep 06, 2021 at 12:39:07AM +0200, Krish Jain wrote:
> > -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> > - struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> > - size_t len, unsigned long flags)
> > +static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
> > {
> > struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
> > struct mtk_hsdma_desc *desc;
> > --
> > 2.25.1
> >
>
> Hi, Greg, just to follow up on this, is this submission OK?
Please, give us a minumum of two weeks to respond before asking for
feedback. We will get to it. There is no rush.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis
2021-09-05 9:02 [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis Krish Jain
2021-09-05 22:39 ` Krish Jain
@ 2021-09-06 7:55 ` Dan Carpenter
2021-09-06 9:38 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-09-06 7:55 UTC (permalink / raw)
To: Krish Jain; +Cc: gregkh, linux-staging
On Sun, Sep 05, 2021 at 11:02:01AM +0200, Krish Jain wrote:
> @@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> spin_unlock_bh(&chan->vchan.lock);
> }
>
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> - struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> - size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
This line is too long now.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis
2021-09-05 9:02 [PATCH v2] mt7621-dma: Properly format lines in "hsdma-mt7621.c" ending with an open parenthesis Krish Jain
2021-09-05 22:39 ` Krish Jain
2021-09-06 7:55 ` Dan Carpenter
@ 2021-09-06 9:38 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2021-09-06 9:38 UTC (permalink / raw)
To: Krish Jain; +Cc: linux-staging
On Sun, Sep 05, 2021 at 11:02:01AM +0200, Krish Jain wrote:
> From: Krish Jain <krishjain02939@gmail.com>
>
> This patch fixes the format of the code. It properly formats lines that
> should not end with a '(' as suggested by checkpath.pl.
>
> Signed-off-by: Krish Jain <krishjain02939@gmail.com>
> ---
> drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Any reason why you didn't match up other patches for this driver for the
subject line?
$ git log --oneline drivers/staging/mt7621-dma/ | head
1f92798cbe7f staging/mt7621-dma: mtk-hsdma.c->hsdma-mt7621.c
d887d6104ade staging: mt7621-dma: Fix a resource leak in an error handling path
773cfe0684a3 staging: mt7621-dma: fix alignment warnings
08446a45d194 staging: mt7621-dma: convert tasklets to use new tasklet_setup() API
5d6633b26bc3 staging: mt7621-dma: quoted string split across lines
e71903106721 staging: mt7621-dma: align to match open parenthesis
62a6e25ed677 staging: mt7621-dma: Remove unnecessary line continuations
390e4f967299 staging: mt7621-dma: use devm_platform_ioremap_resource() to simplify code
04d15d5cadb8 staging: Remove dev_err() usage after platform_get_irq()
4c1d2fc7d56c staging: mt7621-dma: sizeof via pointer dereference
Please always put 'staging' as the prefix here, so that our tools catch
things easily.
>
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index b0ed935de7ac..89b72a802800 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
> struct mtk_hsdma_chan chan[1];
> };
>
> -static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
> - struct mtk_hsdma_chan *chan)
> +static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
> {
> return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
> ddev);
> @@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
> return container_of(c, struct mtk_hsdma_chan, vchan.chan);
> }
>
> -static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
> - struct virt_dma_desc *vdesc)
> +static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
> {
> return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
> }
> @@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
> spin_unlock_bh(&chan->vchan.lock);
> }
>
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> - struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> - size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
> {
> struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
> struct mtk_hsdma_desc *desc;
> --
> 2.25.1
>
What happens when you run this patch through checkpatch.pl? Didn't you
just add new warnings with your attempt to fix them?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread