* [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style
@ 2016-09-25 23:00 Gonçalo Salazar
2016-09-26 0:53 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Gonçalo Salazar @ 2016-09-25 23:00 UTC (permalink / raw)
To: florian.c.schilhabel, Larry.Finger, gregkh, trivial, devel
Cc: linux-kernel, Gonçalo Salazar
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.
Resubmitted with updated subject.
Please let me know of any feedback you have.
Thanks,
Gonçalo Salazar
Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
---
drivers/staging/rtl8712/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 3fc65b2..897d462 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
*
* notes: drv_init() is called when the bus driver has located a card for us
* to support. We accept the new device by returning 0.
-*/
+ */
static int r871xu_drv_init(struct usb_interface *pusb_intf,
const struct usb_device_id *pdid)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style
2016-09-25 23:00 [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Gonçalo Salazar
@ 2016-09-26 0:53 ` Larry Finger
2016-09-26 11:20 ` Gonçalo Salazar
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2016-09-26 0:53 UTC (permalink / raw)
To: Gonçalo Salazar, florian.c.schilhabel, gregkh, trivial, devel
Cc: linux-kernel
On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
> Made this as a first commit.
> Resubmitted with updated subject.
>
> Please let me know of any feedback you have.
I missed this last time, but everything above the --- line goes into the
permanent record. Are you sure you want all this to be there? Any chatty remarks
and any description of what changed in subsequent submissions should be below
the ---. The maintainer will see them, but they are stripped before they get
merged into the repo.
Larry
>
> Thanks,
> Gonçalo Salazar
>
> Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
> ---
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 3fc65b2..897d462 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
> *
> * notes: drv_init() is called when the bus driver has located a card for us
> * to support. We accept the new device by returning 0.
> -*/
> + */
> static int r871xu_drv_init(struct usb_interface *pusb_intf,
> const struct usb_device_id *pdid)
> {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style
2016-09-26 0:53 ` Larry Finger
@ 2016-09-26 11:20 ` Gonçalo Salazar
2016-09-26 18:14 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Gonçalo Salazar @ 2016-09-26 11:20 UTC (permalink / raw)
To: Larry Finger; +Cc: Florian Schilhabel, gregkh, trivial, devel, linux-kernel
2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@lwfinger.net>:
> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>
>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>> Made this as a first commit.
>> Resubmitted with updated subject.
>>
>> Please let me know of any feedback you have.
>
>
> I missed this last time, but everything above the --- line goes into the
> permanent record. Are you sure you want all this to be there? Any chatty
> remarks and any description of what changed in subsequent submissions should
> be below the ---. The maintainer will see them, but they are stripped before
> they get merged into the repo.
>
> Larry
Made a mistake that should not be in the permanent record...
Should I resubmit the patch? or are you able to strip it from the submission?
Gonçalo
>
>
>>
>> Thanks,
>> Gonçalo Salazar
>>
>> Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
>> ---
>> drivers/staging/rtl8712/usb_intf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8712/usb_intf.c
>> b/drivers/staging/rtl8712/usb_intf.c
>> index 3fc65b2..897d462 100644
>> --- a/drivers/staging/rtl8712/usb_intf.c
>> +++ b/drivers/staging/rtl8712/usb_intf.c
>> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
>> *
>> * notes: drv_init() is called when the bus driver has located a card for
>> us
>> * to support. We accept the new device by returning 0.
>> -*/
>> + */
>> static int r871xu_drv_init(struct usb_interface *pusb_intf,
>> const struct usb_device_id *pdid)
>> {
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style
2016-09-26 11:20 ` Gonçalo Salazar
@ 2016-09-26 18:14 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2016-09-26 18:14 UTC (permalink / raw)
To: Gonçalo Salazar
Cc: Florian Schilhabel, gregkh, trivial, devel, linux-kernel
On 09/26/2016 06:20 AM, Gonçalo Salazar wrote:
> 2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@lwfinger.net>:
>> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>>
>>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>>> Made this as a first commit.
>>> Resubmitted with updated subject.
>>>
>>> Please let me know of any feedback you have.
>>
>>
>> I missed this last time, but everything above the --- line goes into the
>> permanent record. Are you sure you want all this to be there? Any chatty
>> remarks and any description of what changed in subsequent submissions should
>> be below the ---. The maintainer will see them, but they are stripped before
>> they get merged into the repo.
>>
>> Larry
>
> Made a mistake that should not be in the permanent record...
> Should I resubmit the patch? or are you able to strip it from the submission?
I am not the one that applies the patches; however, it would be unreasonable to
expect the maintainer to edit any patch. You need to submit V3.
Larry
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-26 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-25 23:00 [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Gonçalo Salazar
2016-09-26 0:53 ` Larry Finger
2016-09-26 11:20 ` Gonçalo Salazar
2016-09-26 18:14 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.