From: Sam Protsenko <semen.protsenko@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Alim Akhtar <alim.akhtar@samsung.com>, Chanho Park <chanho61.park@samsung.com>, David Virag <virag.david003@gmail.com>, Sumit Semwal <sumit.semwal@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer Date: Wed, 8 Feb 2023 00:08:18 -0600 [thread overview] Message-ID: <CAPLW+4mXJ8Gmb-OWabdN6EyaUrCUQuFAGyGh09TDgikmL5gjAg@mail.gmail.com> (raw) In-Reply-To: <59ff815b-baad-02c5-67df-e4d65f63afa3@linaro.org> On Fri, 3 Feb 2023 at 03:18, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/02/2023 07:09, Sam Protsenko wrote: > > Exynos5433 clock driver implements PM support internally, which might be > > also useful for other Exynos clock drivers. Extract all PM related code > > from clk-exynos5433 to common ARM64 functions. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > > > > > if (IS_ERR(parent_clk)) { > > pr_err("%s: could not find bus clock %s; err = %ld\n", > > @@ -91,6 +112,46 @@ static int __init exynos_arm64_enable_bus_clk(struct device *dev, > > return 0; > > } > > > > +static int __init exynos_arm64_cmu_prepare_pm(struct device *dev, > > + const struct samsung_cmu_info *cmu) > > Align the arguments. > The same issue here as in my previous answer, unfortunately: when I try to align the `cmu' argument to match the open parentheses, it doesn't fit 80 characters limit, which doesn't look nice to me. Do you mind if I leave it as is? > Rest looks good to me. > > Best regards, > Krzysztof >
WARNING: multiple messages have this Message-ID (diff)
From: Sam Protsenko <semen.protsenko@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Alim Akhtar <alim.akhtar@samsung.com>, Chanho Park <chanho61.park@samsung.com>, David Virag <virag.david003@gmail.com>, Sumit Semwal <sumit.semwal@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer Date: Wed, 8 Feb 2023 00:08:18 -0600 [thread overview] Message-ID: <CAPLW+4mXJ8Gmb-OWabdN6EyaUrCUQuFAGyGh09TDgikmL5gjAg@mail.gmail.com> (raw) In-Reply-To: <59ff815b-baad-02c5-67df-e4d65f63afa3@linaro.org> On Fri, 3 Feb 2023 at 03:18, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/02/2023 07:09, Sam Protsenko wrote: > > Exynos5433 clock driver implements PM support internally, which might be > > also useful for other Exynos clock drivers. Extract all PM related code > > from clk-exynos5433 to common ARM64 functions. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > > > > > if (IS_ERR(parent_clk)) { > > pr_err("%s: could not find bus clock %s; err = %ld\n", > > @@ -91,6 +112,46 @@ static int __init exynos_arm64_enable_bus_clk(struct device *dev, > > return 0; > > } > > > > +static int __init exynos_arm64_cmu_prepare_pm(struct device *dev, > > + const struct samsung_cmu_info *cmu) > > Align the arguments. > The same issue here as in my previous answer, unfortunately: when I try to align the `cmu' argument to match the open parentheses, it doesn't fit 80 characters limit, which doesn't look nice to me. Do you mind if I leave it as is? > Rest looks good to me. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-08 6:08 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230203060905eucas1p20dc8b2dbf93ec2b0c604bd461afbae94@eucas1p2.samsung.com> 2023-02-03 6:09 ` [PATCH 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 1/6] clk: samsung: Don't pass reg_base to samsung_clk_register_pll() Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 2/6] clk: samsung: Remove np argument from samsung_clk_init() Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 3/6] clk: samsung: Set dev in samsung_clk_init() Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 4/6] clk: samsung: Extract clocks registration to common function Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 5/6] clk: samsung: Extract parent clock enabling " Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 9:14 ` Krzysztof Kozlowski 2023-02-03 9:14 ` Krzysztof Kozlowski 2023-02-08 6:00 ` Sam Protsenko 2023-02-08 6:00 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 9:18 ` Krzysztof Kozlowski 2023-02-03 9:18 ` Krzysztof Kozlowski 2023-02-08 6:08 ` Sam Protsenko [this message] 2023-02-08 6:08 ` Sam Protsenko 2023-02-03 12:19 ` kernel test robot 2023-02-03 12:19 ` kernel test robot 2023-02-03 14:33 ` [PATCH 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Marek Szyprowski 2023-02-03 14:33 ` Marek Szyprowski 2023-02-08 6:05 ` Sam Protsenko 2023-02-08 6:05 ` Sam Protsenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPLW+4mXJ8Gmb-OWabdN6EyaUrCUQuFAGyGh09TDgikmL5gjAg@mail.gmail.com \ --to=semen.protsenko@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=chanho61.park@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=tomasz.figa@gmail.com \ --cc=virag.david003@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.