From: Sam Protsenko <semen.protsenko@linaro.org> To: Rob Herring <robh+dt@kernel.org> Cc: "Ryu Euiyoul" <ryu.real@samsung.com>, "Tom Gall" <tom.gall@linaro.org>, "Sumit Semwal" <sumit.semwal@linaro.org>, "John Stultz" <john.stultz@linaro.org>, "Amit Pundir" <amit.pundir@linaro.org>, devicetree <devicetree@vger.kernel.org>, "linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>, linux-clk <linux-clk@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>, "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>, "Chanwoo Choi" <cw00.choi@samsung.com>, "Tomasz Figa" <tomasz.figa@gmail.com>, "Stephen Boyd" <sboyd@kernel.org>, "Michael Turquette" <mturquette@baylibre.com>, "Sylwester Nawrocki" <snawrocki@kernel.org>, "Sylwester Nawrocki" <s.nawrocki@samsung.com> Subject: Re: [PATCH v3 4/5] dt-bindings: clock: Document Exynos850 CMU bindings Date: Tue, 12 Oct 2021 11:13:48 +0300 [thread overview] Message-ID: <CAPLW+4mXMLadAi6U3GiXqRHAGnLH79rZeK6w=EcbOccjqH4N9w@mail.gmail.com> (raw) In-Reply-To: <ef781890-76ca-3392-9a17-3856fa1834cf@samsung.com> Hi Rob, On Mon, 11 Oct 2021 at 13:42, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > On 11.10.2021 12:13, Sam Protsenko wrote: > > On Sat, 9 Oct 2021 at 23:41, Sylwester Nawrocki <snawrocki@kernel.org> wrote: > >> > >> On 08.10.2021 17:43, Sam Protsenko wrote: > >>> Provide dt-schema documentation for Exynos850 SoC clock controller. > >>> > >>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > [...] > >>> +++ b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml > >>> @@ -0,0 +1,185 @@ > [...] > >>> + > >>> +title: Samsung Exynos850 SoC clock controller > >>> + > >>> +maintainers: > >>> + - Sam Protsenko <semen.protsenko@linaro.org> > >>> + - Chanwoo Choi <cw00.choi@samsung.com> > >>> + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >>> + - Sylwester Nawrocki <s.nawrocki@samsung.com> > >>> + - Tomasz Figa <tomasz.figa@gmail.com> > >>> + > >>> +description: | > >>> + Exynos850 clock controller is comprised of several CMU units, generating > >>> + clocks for different domains. Those CMU units are modeled as separate device > >>> + tree nodes, and might depend on each other. Root clocks in that clock tree are > >>> + two external clocks:: OSCCLK (26 MHz) and RTCCLK (32768 Hz). Those external > >>> + clocks must be defined as fixed-rate clocks in dts. > >>> + > >>> + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and > >>> + dividers; all other leaf clocks (other CMUs) are usually derived from CMU_TOP. > >>> + > >>> + Each clock is assigned an identifier and client nodes can use this identifier > >>> + to specify the clock which they consume. All clocks that available for usage > >> > >> s/All clocks that available/All clocks available ? > >> No need to resend, I can amend it when applying. > >> > > > > Yeah, not a native speaker, I tend to do such mistakes sometimes :) > > Please fix when applying. > > > > Btw, I can see that you already applied 3 out of 5 patches from this > > patch series here: [1]. Can you please also apply the rest, or is > > there any outstanding comments that I missed? > > The patches look good to me, I just wanted to allow some for Rob to have > a look and provide an Ack. > Can you please review this one? Thanks! > Regards, > -- > Sylwester Nawrocki > Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Sam Protsenko <semen.protsenko@linaro.org> To: Rob Herring <robh+dt@kernel.org> Cc: "Ryu Euiyoul" <ryu.real@samsung.com>, "Tom Gall" <tom.gall@linaro.org>, "Sumit Semwal" <sumit.semwal@linaro.org>, "John Stultz" <john.stultz@linaro.org>, "Amit Pundir" <amit.pundir@linaro.org>, devicetree <devicetree@vger.kernel.org>, "linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>, linux-clk <linux-clk@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>, "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>, "Chanwoo Choi" <cw00.choi@samsung.com>, "Tomasz Figa" <tomasz.figa@gmail.com>, "Stephen Boyd" <sboyd@kernel.org>, "Michael Turquette" <mturquette@baylibre.com>, "Sylwester Nawrocki" <snawrocki@kernel.org>, "Sylwester Nawrocki" <s.nawrocki@samsung.com> Subject: Re: [PATCH v3 4/5] dt-bindings: clock: Document Exynos850 CMU bindings Date: Tue, 12 Oct 2021 11:13:48 +0300 [thread overview] Message-ID: <CAPLW+4mXMLadAi6U3GiXqRHAGnLH79rZeK6w=EcbOccjqH4N9w@mail.gmail.com> (raw) In-Reply-To: <ef781890-76ca-3392-9a17-3856fa1834cf@samsung.com> Hi Rob, On Mon, 11 Oct 2021 at 13:42, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > > On 11.10.2021 12:13, Sam Protsenko wrote: > > On Sat, 9 Oct 2021 at 23:41, Sylwester Nawrocki <snawrocki@kernel.org> wrote: > >> > >> On 08.10.2021 17:43, Sam Protsenko wrote: > >>> Provide dt-schema documentation for Exynos850 SoC clock controller. > >>> > >>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > [...] > >>> +++ b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml > >>> @@ -0,0 +1,185 @@ > [...] > >>> + > >>> +title: Samsung Exynos850 SoC clock controller > >>> + > >>> +maintainers: > >>> + - Sam Protsenko <semen.protsenko@linaro.org> > >>> + - Chanwoo Choi <cw00.choi@samsung.com> > >>> + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >>> + - Sylwester Nawrocki <s.nawrocki@samsung.com> > >>> + - Tomasz Figa <tomasz.figa@gmail.com> > >>> + > >>> +description: | > >>> + Exynos850 clock controller is comprised of several CMU units, generating > >>> + clocks for different domains. Those CMU units are modeled as separate device > >>> + tree nodes, and might depend on each other. Root clocks in that clock tree are > >>> + two external clocks:: OSCCLK (26 MHz) and RTCCLK (32768 Hz). Those external > >>> + clocks must be defined as fixed-rate clocks in dts. > >>> + > >>> + CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and > >>> + dividers; all other leaf clocks (other CMUs) are usually derived from CMU_TOP. > >>> + > >>> + Each clock is assigned an identifier and client nodes can use this identifier > >>> + to specify the clock which they consume. All clocks that available for usage > >> > >> s/All clocks that available/All clocks available ? > >> No need to resend, I can amend it when applying. > >> > > > > Yeah, not a native speaker, I tend to do such mistakes sometimes :) > > Please fix when applying. > > > > Btw, I can see that you already applied 3 out of 5 patches from this > > patch series here: [1]. Can you please also apply the rest, or is > > there any outstanding comments that I missed? > > The patches look good to me, I just wanted to allow some for Rob to have > a look and provide an Ack. > Can you please review this one? Thanks! > Regards, > -- > Sylwester Nawrocki > Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-12 8:14 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-08 15:43 [PATCH v3 0/5] clk: samsung: Introduce Exynos850 SoC clock driver Sam Protsenko 2021-10-08 15:43 ` Sam Protsenko 2021-10-08 15:43 ` [PATCH v3 1/5] clk: samsung: clk-pll: Implement pll0822x PLL type Sam Protsenko 2021-10-08 15:43 ` Sam Protsenko 2021-10-09 20:24 ` Sylwester Nawrocki 2021-10-09 20:24 ` Sylwester Nawrocki 2021-10-08 15:43 ` [PATCH v3 2/5] clk: samsung: clk-pll: Implement pll0831x " Sam Protsenko 2021-10-08 15:43 ` Sam Protsenko 2021-10-09 20:25 ` Sylwester Nawrocki 2021-10-09 20:25 ` Sylwester Nawrocki 2021-10-08 15:43 ` [PATCH v3 3/5] dt-bindings: clock: Add bindings definitions for Exynos850 CMU Sam Protsenko 2021-10-08 15:43 ` Sam Protsenko 2021-10-09 20:28 ` Sylwester Nawrocki 2021-10-09 20:28 ` Sylwester Nawrocki 2021-10-08 15:43 ` [PATCH v3 4/5] dt-bindings: clock: Document Exynos850 CMU bindings Sam Protsenko 2021-10-08 15:43 ` Sam Protsenko 2021-10-09 20:40 ` Sylwester Nawrocki 2021-10-09 20:40 ` Sylwester Nawrocki 2021-10-11 10:13 ` Sam Protsenko 2021-10-11 10:13 ` Sam Protsenko 2021-10-11 10:42 ` Sylwester Nawrocki 2021-10-11 10:42 ` Sylwester Nawrocki 2021-10-12 8:13 ` Sam Protsenko [this message] 2021-10-12 8:13 ` Sam Protsenko 2021-10-15 13:46 ` Sylwester Nawrocki 2021-10-15 13:46 ` Sylwester Nawrocki 2021-10-08 15:43 ` [PATCH v3 5/5] clk: samsung: Introduce Exynos850 clock driver Sam Protsenko 2021-10-08 15:43 ` Sam Protsenko 2021-10-12 8:14 ` Sam Protsenko 2021-10-12 8:14 ` Sam Protsenko 2021-10-15 13:30 ` Sylwester Nawrocki 2021-10-15 13:30 ` Sylwester Nawrocki 2021-10-15 14:35 ` Sam Protsenko 2021-10-15 14:35 ` Sam Protsenko 2021-10-15 1:17 ` Chanwoo Choi 2021-10-15 1:17 ` Chanwoo Choi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPLW+4mXMLadAi6U3GiXqRHAGnLH79rZeK6w=EcbOccjqH4N9w@mail.gmail.com' \ --to=semen.protsenko@linaro.org \ --cc=amit.pundir@linaro.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=john.stultz@linaro.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=pawel.mikolaj.chmiel@gmail.com \ --cc=robh+dt@kernel.org \ --cc=ryu.real@samsung.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=snawrocki@kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=tom.gall@linaro.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.