All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Protsenko <semen.protsenko@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: "Ryu Euiyoul" <ryu.real@samsung.com>,
	"Tom Gall" <tom.gall@linaro.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Amit Pundir" <amit.pundir@linaro.org>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Tomasz Figa" <tomasz.figa@gmail.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH 6/6] clk: samsung: Introduce Exynos850 clock driver
Date: Tue, 5 Oct 2021 14:36:11 +0300	[thread overview]
Message-ID: <CAPLW+4n0DX3gn=Ntat39EUO-L2t=SR_=Nr3LtznN4XsNrc=OWA@mail.gmail.com> (raw)
In-Reply-To: <1d884e38-ac8c-6f0c-ad27-243c5c4b9b9b@samsung.com>

On Wed, 15 Sept 2021 at 16:07, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
>
> On 14.09.2021 17:56, Sam Protsenko wrote:
> > +static void __init exynos850_cmu_top_init(struct device_node *np)
> > +{
> > +     exynos850_init_clocks(np, top_clk_regs, ARRAY_SIZE(top_clk_regs));
> > +     samsung_cmu_register_one(np, &top_cmu_info);
> > +}
> > +
> > +CLK_OF_DECLARE(exynos850_cmu_top, "samsung,exynos850-cmu-top",
> > +            exynos850_cmu_top_init);
>
> Was there anything preventing you from making it a platform driver instead?
>

Can you please elaborate on benefits of adding platform driver? I
don't implement PM ops for now, and I can see that clk-exynos7.c does
not add platform driver as well... clk-exynos5433.c seems to use
platform_driver for PM ops only.

> --
> Regards,
> Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: Sam Protsenko <semen.protsenko@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: "Ryu Euiyoul" <ryu.real@samsung.com>,
	"Tom Gall" <tom.gall@linaro.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"John Stultz" <john.stultz@linaro.org>,
	"Amit Pundir" <amit.pundir@linaro.org>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Tomasz Figa" <tomasz.figa@gmail.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH 6/6] clk: samsung: Introduce Exynos850 clock driver
Date: Tue, 5 Oct 2021 14:36:11 +0300	[thread overview]
Message-ID: <CAPLW+4n0DX3gn=Ntat39EUO-L2t=SR_=Nr3LtznN4XsNrc=OWA@mail.gmail.com> (raw)
In-Reply-To: <1d884e38-ac8c-6f0c-ad27-243c5c4b9b9b@samsung.com>

On Wed, 15 Sept 2021 at 16:07, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
>
> On 14.09.2021 17:56, Sam Protsenko wrote:
> > +static void __init exynos850_cmu_top_init(struct device_node *np)
> > +{
> > +     exynos850_init_clocks(np, top_clk_regs, ARRAY_SIZE(top_clk_regs));
> > +     samsung_cmu_register_one(np, &top_cmu_info);
> > +}
> > +
> > +CLK_OF_DECLARE(exynos850_cmu_top, "samsung,exynos850-cmu-top",
> > +            exynos850_cmu_top_init);
>
> Was there anything preventing you from making it a platform driver instead?
>

Can you please elaborate on benefits of adding platform driver? I
don't implement PM ops for now, and I can see that clk-exynos7.c does
not add platform driver as well... clk-exynos5433.c seems to use
platform_driver for PM ops only.

> --
> Regards,
> Sylwester

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-05 11:36 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 15:56 [PATCH 0/6] clk: samsung: Introduce Exynos850 SoC clock driver Sam Protsenko
2021-09-14 15:56 ` Sam Protsenko
2021-09-14 15:56 ` [PATCH 1/6] clk: samsung: Enable bus clock on init Sam Protsenko
2021-09-14 15:56   ` Sam Protsenko
2021-09-15  8:21   ` Krzysztof Kozlowski
2021-09-15  8:21     ` Krzysztof Kozlowski
2021-10-06 10:46     ` Sam Protsenko
2021-10-06 10:46       ` Sam Protsenko
2021-10-06 12:38       ` Krzysztof Kozlowski
2021-10-06 12:38         ` Krzysztof Kozlowski
2021-10-06 13:29         ` Sam Protsenko
2021-10-06 13:29           ` Sam Protsenko
2021-10-08  6:50           ` Krzysztof Kozlowski
2021-10-08  6:50             ` Krzysztof Kozlowski
2021-09-15 12:51   ` Sylwester Nawrocki
2021-09-15 12:51     ` Sylwester Nawrocki
2021-10-06 11:18     ` Sam Protsenko
2021-10-06 11:18       ` Sam Protsenko
2021-10-06 12:45       ` Krzysztof Kozlowski
2021-10-06 12:45         ` Krzysztof Kozlowski
2021-10-09 18:49       ` Sylwester Nawrocki
2021-10-09 18:49         ` Sylwester Nawrocki
2021-09-14 15:56 ` [PATCH 2/6] clk: samsung: clk-pll: Implement pll0822x PLL type Sam Protsenko
2021-09-14 15:56   ` Sam Protsenko
2021-09-15  8:24   ` Krzysztof Kozlowski
2021-09-15  8:24     ` Krzysztof Kozlowski
2021-09-15 15:59   ` Chanwoo Choi
2021-09-15 15:59     ` Chanwoo Choi
2021-09-14 15:56 ` [PATCH 3/6] clk: samsung: clk-pll: Implement pll0831x " Sam Protsenko
2021-09-14 15:56   ` Sam Protsenko
2021-09-15  8:26   ` Krzysztof Kozlowski
2021-09-15  8:26     ` Krzysztof Kozlowski
2021-09-15 16:11   ` Chanwoo Choi
2021-09-15 16:11     ` Chanwoo Choi
2021-09-14 15:56 ` [PATCH 4/6] dt-bindings: clock: Add bindings definitions for Exynos850 CMU Sam Protsenko
2021-09-14 15:56   ` Sam Protsenko
2021-09-15  8:27   ` Krzysztof Kozlowski
2021-09-15  8:27     ` Krzysztof Kozlowski
2021-09-15 16:37   ` Chanwoo Choi
2021-09-15 16:37     ` Chanwoo Choi
2021-10-05 10:28     ` Sam Protsenko
2021-10-05 10:28       ` Sam Protsenko
2021-10-06 10:49       ` Krzysztof Kozlowski
2021-10-06 10:49         ` Krzysztof Kozlowski
2021-10-06 13:31         ` Sam Protsenko
2021-10-06 13:31           ` Sam Protsenko
2021-09-21 21:10   ` Rob Herring
2021-09-21 21:10     ` Rob Herring
2021-09-14 15:56 ` [PATCH 5/6] dt-bindings: clock: Document Exynos850 CMU bindings Sam Protsenko
2021-09-14 15:56   ` Sam Protsenko
2021-09-14 21:35   ` Rob Herring
2021-09-14 21:35     ` Rob Herring
2021-09-15  8:28   ` Krzysztof Kozlowski
2021-09-15  8:28     ` Krzysztof Kozlowski
2021-10-05 11:48     ` Sam Protsenko
2021-10-05 11:48       ` Sam Protsenko
2021-09-15 16:47   ` Chanwoo Choi
2021-09-15 16:47     ` Chanwoo Choi
2021-09-14 15:56 ` [PATCH 6/6] clk: samsung: Introduce Exynos850 clock driver Sam Protsenko
2021-09-14 15:56   ` Sam Protsenko
2021-09-15  8:59   ` Krzysztof Kozlowski
2021-09-15  8:59     ` Krzysztof Kozlowski
2021-10-05 11:29     ` Sam Protsenko
2021-10-05 11:29       ` Sam Protsenko
2021-10-06 12:50       ` Krzysztof Kozlowski
2021-10-06 12:50         ` Krzysztof Kozlowski
2021-09-15 13:07   ` Sylwester Nawrocki
2021-09-15 13:07     ` Sylwester Nawrocki
2021-10-05 11:36     ` Sam Protsenko [this message]
2021-10-05 11:36       ` Sam Protsenko
2021-10-06 12:46       ` Krzysztof Kozlowski
2021-10-06 12:46         ` Krzysztof Kozlowski
2021-09-15 18:04   ` Chanwoo Choi
2021-09-15 18:04     ` Chanwoo Choi
2021-09-15 22:00     ` Sam Protsenko
2021-09-15 22:00       ` Sam Protsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPLW+4n0DX3gn=Ntat39EUO-L2t=SR_=Nr3LtznN4XsNrc=OWA@mail.gmail.com' \
    --to=semen.protsenko@linaro.org \
    --cc=amit.pundir@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=john.stultz@linaro.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pawel.mikolaj.chmiel@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=ryu.real@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tom.gall@linaro.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.