[PATCH] tools: fix python version checking issue

[PATCH] tools: fix python version checking issue

[Ren, Yongjie]

Even if python version is 2.4.3 which is newer than the required version 2.3, the configure script still raises a version issue.
I tested my patch with python 2.6.6 and 2.4.3. It will fix a syntax error like the following.
checking for python version >= 2.3 ... Traceback (most recent call last):
  File "<string>", line 1, in ?
TypeError: 'str' object is not callable
no
configure: error: Python 2.4.3 is too old, minimum required version is 2.3

Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
--

tools/m4/python_version.m4 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -r a4d93d0e0df2 tools/m4/python_version.m4
--- a/tools/m4/python_version.m4        Wed Feb 22 14:33:24 2012 +0000
+++ b/tools/m4/python_version.m4        Fri Feb 24 22:08:53 2012 -0500
@@ -1,6 +1,6 @@
 AC_DEFUN([AX_CHECK_PYTHON_VERSION],
 [AC_MSG_CHECKING([for python version >= $1.$2 ])
-`$PYTHON -c 'import sys; exit(eval("sys.version_info < ($1, $2)"))'`
+`$PYTHON -c 'import sys; sys.exit(eval("sys.version_info < ($1, $2)"))'`
 if test "$?" != "0"
 then
     python_version=`$PYTHON -V 2>&1`


Best Regards,
     Yongjie Ren  (Jay)

Re: [PATCH] tools: fix python version checking issue

[Roger Pau Monné]

2012/2/25 Ren, Yongjie <yongjie.ren@intel.com>:
> Even if python version is 2.4.3 which is newer than the required version 2.3, the configure script still raises a version issue.
> I tested my patch with python 2.6.6 and 2.4.3. It will fix a syntax error like the following.
> checking for python version >= 2.3 ... Traceback (most recent call last):
>  File "<string>", line 1, in ?
> TypeError: 'str' object is not callable
> no
> configure: error: Python 2.4.3 is too old, minimum required version is 2.3
>
> Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>

Acked-by: Roger Pau Monne <roger.pau@entel.upc.edu>

Provided that the following is applied after, output from autoconf:

8<--------------------------------------------

autoconf: rerun autoconf

Rerun autoconf to generate new configure script with python version
checking fix.

Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>

diff -r 8916d782ba27 tools/configure
--- a/tools/configure	Tue Feb 21 22:28:03 2012 +0100
+++ b/tools/configure	Tue Feb 21 22:30:03 2012 +0100
@@ -6293,7 +6293,7 @@ then
 fi
     { $as_echo "$as_me:${as_lineno-$LINENO}: checking for python
version >= 2.3 " >&5
 $as_echo_n "checking for python version >= 2.3 ... " >&6; }
-`$PYTHON -c 'import sys; exit(eval("sys.version_info < (2, 3)"))'`
+`$PYTHON -c 'import sys; sys.exit(eval("sys.version_info < (2, 3)"))'`
 if test "$?" != "0"
 then
     python_version=`$PYTHON -V 2>&1`

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] tools: fix python version checking issue

[Ian Jackson]

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools: fix python version checking issue"):
> 2012/2/25 Ren, Yongjie <yongjie.ren@intel.com>:
> > Even if python version is 2.4.3 which is newer than the required version 2.3, the configure script still raises a version issue.
> > I tested my patch with python 2.6.6 and 2.4.3. It will fix a syntax error like the following.
> > checking for python version >= 2.3 ... Traceback (most recent call last):
> >  File "<string>", line 1, in ?
> > TypeError: 'str' object is not callable
> > no
> > configure: error: Python 2.4.3 is too old, minimum required version is 2.3
> >
> > Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
> 
> Acked-by: Roger Pau Monne <roger.pau@entel.upc.edu>

Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks.

> Provided that the following is applied after, output from autoconf:

Thanks, I reran autogen.sh.

Ian.