* [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()
@ 2013-05-30 9:04 Kamalesh Babulal
2013-05-30 9:20 ` Frederic Weisbecker
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kamalesh Babulal @ 2013-05-30 9:04 UTC (permalink / raw)
To: linux-kernel; +Cc: fweisbec, peterz, mingo
78becc2709 "sched: Use an accessor to read the rq clock"
introduces rq_clock(), which obsoletes use of "rq" in
expire_cfs_rq_runtime() and triggers build warning:
kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
kernel/sched/fair.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3ee1c2e..143dcdb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2156,7 +2156,6 @@ static int assign_cfs_rq_runtime(struct cfs_rq *cfs_rq)
static void expire_cfs_rq_runtime(struct cfs_rq *cfs_rq)
{
struct cfs_bandwidth *cfs_b = tg_cfs_bandwidth(cfs_rq->tg);
- struct rq *rq = rq_of(cfs_rq);
/* if the deadline is ahead of our clock, nothing to do */
if (likely((s64)(rq_clock(rq_of(cfs_rq)) - cfs_rq->runtime_expires) < 0))
--
1.7.11.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()
2013-05-30 9:04 [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime() Kamalesh Babulal
@ 2013-05-30 9:20 ` Frederic Weisbecker
2013-05-30 14:01 ` Paul Turner
2013-05-31 12:44 ` [tip:sched/core] " tip-bot for Kamalesh Babulal
2013-05-31 15:58 ` [PATCH -tip] " Peter Zijlstra
2 siblings, 1 reply; 5+ messages in thread
From: Frederic Weisbecker @ 2013-05-30 9:20 UTC (permalink / raw)
To: Kamalesh Babulal; +Cc: linux-kernel, peterz, mingo
2013/5/30 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>:
> 78becc2709 "sched: Use an accessor to read the rq clock"
> introduces rq_clock(), which obsoletes use of "rq" in
> expire_cfs_rq_runtime() and triggers build warning:
>
> kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
> kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Thanks!
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()
2013-05-30 9:20 ` Frederic Weisbecker
@ 2013-05-30 14:01 ` Paul Turner
0 siblings, 0 replies; 5+ messages in thread
From: Paul Turner @ 2013-05-30 14:01 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Kamalesh Babulal, LKML, Peter Zijlstra, Ingo Molnar
Looks good
On Thu, May 30, 2013 at 2:20 AM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 2013/5/30 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>:
>> 78becc2709 "sched: Use an accessor to read the rq clock"
>> introduces rq_clock(), which obsoletes use of "rq" in
>> expire_cfs_rq_runtime() and triggers build warning:
>>
>> kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
>> kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
>>
>> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>
> Thanks!
>
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:sched/core] sched/fair: Remove unused variable from expire_cfs_rq_runtime()
2013-05-30 9:04 [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime() Kamalesh Babulal
2013-05-30 9:20 ` Frederic Weisbecker
@ 2013-05-31 12:44 ` tip-bot for Kamalesh Babulal
2013-05-31 15:58 ` [PATCH -tip] " Peter Zijlstra
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Kamalesh Babulal @ 2013-05-31 12:44 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, fweisbec, kamalesh, pjt, tglx
Commit-ID: 0de358f1c2642710d41190b73fbc295e675c4ab8
Gitweb: http://git.kernel.org/tip/0de358f1c2642710d41190b73fbc295e675c4ab8
Author: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
AuthorDate: Thu, 30 May 2013 14:34:20 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 31 May 2013 13:02:29 +0200
sched/fair: Remove unused variable from expire_cfs_rq_runtime()
Commit 78becc2709 ("sched: Use an accessor to read the rq clock")
introduces rq_clock(), which obsoletes the use of the "rq" variable
in expire_cfs_rq_runtime() and triggers this build warning:
kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Paul Turner <pjt@google.com>
Cc: peterz@infradead.org
Link: http://lkml.kernel.org/r/1369904660-14169-1-git-send-email-kamalesh@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3ee1c2e..143dcdb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2156,7 +2156,6 @@ static int assign_cfs_rq_runtime(struct cfs_rq *cfs_rq)
static void expire_cfs_rq_runtime(struct cfs_rq *cfs_rq)
{
struct cfs_bandwidth *cfs_b = tg_cfs_bandwidth(cfs_rq->tg);
- struct rq *rq = rq_of(cfs_rq);
/* if the deadline is ahead of our clock, nothing to do */
if (likely((s64)(rq_clock(rq_of(cfs_rq)) - cfs_rq->runtime_expires) < 0))
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()
2013-05-30 9:04 [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime() Kamalesh Babulal
2013-05-30 9:20 ` Frederic Weisbecker
2013-05-31 12:44 ` [tip:sched/core] " tip-bot for Kamalesh Babulal
@ 2013-05-31 15:58 ` Peter Zijlstra
2 siblings, 0 replies; 5+ messages in thread
From: Peter Zijlstra @ 2013-05-31 15:58 UTC (permalink / raw)
To: Kamalesh Babulal; +Cc: linux-kernel, fweisbec, mingo
On Thu, May 30, 2013 at 02:34:20PM +0530, Kamalesh Babulal wrote:
> 78becc2709 "sched: Use an accessor to read the rq clock"
> introduces rq_clock(), which obsoletes use of "rq" in
> expire_cfs_rq_runtime() and triggers build warning:
>
> kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
> kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-31 15:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-30 9:04 [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime() Kamalesh Babulal
2013-05-30 9:20 ` Frederic Weisbecker
2013-05-30 14:01 ` Paul Turner
2013-05-31 12:44 ` [tip:sched/core] " tip-bot for Kamalesh Babulal
2013-05-31 15:58 ` [PATCH -tip] " Peter Zijlstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.